)]}'
{"id":"openstack%2Fpython-ironicclient~424402","triplet_id":"openstack%2Fpython-ironicclient~master~I5fd5e41983c052717474dc33571abf0856ecca28","project":"openstack/python-ironicclient","branch":"master","topic":"bug/1526226","hashtags":[],"change_id":"I5fd5e41983c052717474dc33571abf0856ecca28","subject":"Follow up nits in the patch \"ironic node-inject-nmi\"","status":"MERGED","created":"2017-01-24 01:47:57.000000000","updated":"2017-01-24 12:10:54.000000000","submitted":"2017-01-24 12:10:54.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0949d1f12b9912d8b593f7a7cc592d74c34cb0a2","_number":424402,"virtual_id_number":424402,"owner":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-01-24 12:10:54.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-01-24 01:50:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":1,"date":"2017-01-24 02:30:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},{"value":2,"date":"2017-01-24 11:42:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},{"value":1,"date":"2017-01-24 11:42:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-01-24 01:50:08.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2017-01-24 02:30:26.000000000","updated_by":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"reviewer":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"state":"REVIEWER"},{"updated":"2017-01-24 11:42:09.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2017-01-24 12:10:54.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a694c28b93960b32953b11b9f08b69195e98f05f","author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"date":"2017-01-24 01:47:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d46ef38d474567d97a09c3c9ad693d813deb9cae","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2017-01-24 01:50:08.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3f826029aa8b9151a8ed26695bcef641a7de2c26","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-24 02:16:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python35 http://logs.openstack.org/02/424402/1/check/gate-python-ironicclient-python35/d421abb/ : SUCCESS in 4m 33s\n- gate-python-ironicclient-docs-ubuntu-xenial http://docs-draft.openstack.org/02/424402/1/check/gate-python-ironicclient-docs-ubuntu-xenial/f0af9ae//doc/build/html/ : SUCCESS in 3m 46s\n- gate-python-ironicclient-pep8-ubuntu-xenial http://logs.openstack.org/02/424402/1/check/gate-python-ironicclient-pep8-ubuntu-xenial/43ca6d8/ : SUCCESS in 2m 53s\n- gate-python-ironicclient-python27-ubuntu-xenial http://logs.openstack.org/02/424402/1/check/gate-python-ironicclient-python27-ubuntu-xenial/07dddfb/ : SUCCESS in 2m 17s\n- gate-python-ironicclient-pypy http://logs.openstack.org/02/424402/1/check/gate-python-ironicclient-pypy/3fdef95/ : SUCCESS in 2m 49s (non-voting)\n- gate-python-ironicclient-releasenotes http://docs-draft.openstack.org/02/424402/1/check/gate-python-ironicclient-releasenotes/09777e7//releasenotes/build/html/ : SUCCESS in 3m 33s\n- check-osc-plugins http://logs.openstack.org/02/424402/1/check/check-osc-plugins/9f1f959/ : FAILURE in 3m 36s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial http://logs.openstack.org/02/424402/1/check/gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial/63d0cff/ : SUCCESS in 27m 23s\n- gate-ironicclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/02/424402/1/check/gate-ironicclient-dsvm-functional-ubuntu-xenial/1e77ea0/ : SUCCESS in 9m 59s\n- python-ironicclient-coverage-ubuntu-xenial http://logs.openstack.org/02/424402/1/check/python-ironicclient-coverage-ubuntu-xenial/7ac175d/ : SUCCESS in 2m 09s","accounts_in_message":[],"_revision_number":1},{"id":"a2178bd91c15644c8cb3b7df9072e637844dee9c","author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"date":"2017-01-24 02:30:26.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"b92ef07f84779724a15df6fc061600d4e8b5deb1","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-01-24 11:42:09.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"0c1ab4145339c12e67c22a8a14e777415ba2ccf8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-24 11:42:22.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"86be22e1af9d3e59bae0569e39073add12afa779","date":"2017-01-24 12:10:54.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"d435593d1a4de79f44191792b1840893b3ebe546","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-24 12:10:54.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-ironicclient-python35 http://logs.openstack.org/02/424402/1/gate/gate-python-ironicclient-python35/edb6b7c/ : SUCCESS in 3m 47s\n- gate-python-ironicclient-docs-ubuntu-xenial http://docs-draft.openstack.org/02/424402/1/gate/gate-python-ironicclient-docs-ubuntu-xenial/d604e67//doc/build/html/ : SUCCESS in 4m 23s\n- gate-python-ironicclient-pep8-ubuntu-xenial http://logs.openstack.org/02/424402/1/gate/gate-python-ironicclient-pep8-ubuntu-xenial/85d41a6/ : SUCCESS in 3m 18s\n- gate-python-ironicclient-python27-ubuntu-xenial http://logs.openstack.org/02/424402/1/gate/gate-python-ironicclient-python27-ubuntu-xenial/ffa1a3d/ : SUCCESS in 2m 41s\n- gate-python-ironicclient-releasenotes http://docs-draft.openstack.org/02/424402/1/gate/gate-python-ironicclient-releasenotes/9082c96//releasenotes/build/html/ : SUCCESS in 2m 14s\n- gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial http://logs.openstack.org/02/424402/1/gate/gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial/31910c4/ : SUCCESS in 26m 41s\n- gate-ironicclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/02/424402/1/gate/gate-ironicclient-dsvm-functional-ubuntu-xenial/cc51219/ : SUCCESS in 9m 07s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"daf6db7530b5053fd3f52f366bc9a0d66a589172","revisions":{"daf6db7530b5053fd3f52f366bc9a0d66a589172":{"kind":"REWORK","_number":1,"created":"2017-01-24 01:47:57.000000000","uploader":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"ref":"refs/changes/02/424402/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/02/424402/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/02/424402/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/02/424402/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/02/424402/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/02/424402/1"}}},"commit":{"parents":[{"commit":"8a1d09e8985f916630412f13158d1577c23235c7","subject":"Merge \"Add a new command \"ironic node-inject-nmi\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/8a1d09e8985f916630412f13158d1577c23235c7"}]}],"author":{"name":"Naohiro Tamura","email":"naohirot@jp.fujitsu.com","date":"2017-01-24 01:38:14.000000000","tz":540},"committer":{"name":"Naohiro Tamura","email":"naohirot@jp.fujitsu.com","date":"2017-01-24 01:38:14.000000000","tz":540},"subject":"Follow up nits in the patch \"ironic node-inject-nmi\"","message":"Follow up nits in the patch \"ironic node-inject-nmi\"\n\nThis is a follow-up patch for \u0027Add a new command \"ironic\nnode-inject-nmi\"\u0027 [1] to fix nits, docstring and release note.\n\n [1] Ib19e020685d46051ddf3086adde57ed229b22797\n\nChange-Id: I5fd5e41983c052717474dc33571abf0856ecca28\nPartial-Bug: #1526226\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/daf6db7530b5053fd3f52f366bc9a0d66a589172"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/daf6db7530b5053fd3f52f366bc9a0d66a589172"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}