)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"14c759c9d08f29647323f9b09c83e9f28b6f08f2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     SofiiaAndriichenko \u003csandriichenko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-24 09:49:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed bug, resources aren\u0027t deleted after openstack CLI functional tests had finished"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I45593a49c67b3143215c83a6f729920f789e0e5a"},{"line_number":10,"context_line":"Closes-Bug: #1658942"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a3905b3_188248c8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":85},"updated":"2017-01-24 11:50:39.000000000","message":"Start the line with \"Fix\", \"Add\", \"Change\" instead of \"Fixed\", \"Added\", \"Changed\".\nGit commit messages should start with a short 50 character or less summary in a single paragraph. \nThe following paragraph(s) should explain the change in more detail.","commit_id":"c238d9d3afc865c332972bf35a9d43cc3697664a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c2627f5c1e233572c33860ab4a27a99b4e993416","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     SofiiaAndriichenko \u003csandriichenko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-24 09:49:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed bug, resources aren\u0027t deleted after openstack CLI functional tests had finished"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I45593a49c67b3143215c83a6f729920f789e0e5a"},{"line_number":10,"context_line":"Closes-Bug: #1658942"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a3905b3_211fb60a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":85},"in_reply_to":"5a3905b3_188248c8","updated":"2017-01-24 18:36:00.000000000","message":"++ Apart from that, it seems you\u0027ve confused the two messages, this one handles ironic CLI, the other patch - OSC.","commit_id":"c238d9d3afc865c332972bf35a9d43cc3697664a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a64b6b637a669fe8319e41c10b6b8c1e9b0d988c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix cleanup of resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed bug, resources aren\u0027t deleted after OSC functional tests"},{"line_number":10,"context_line":"had finished"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I45593a49c67b3143215c83a6f729920f789e0e5a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_e5978337","line":9,"range":{"start_line":9,"start_character":42,"end_line":9,"end_character":45},"updated":"2017-02-01 10:53:59.000000000","message":"still an issue here, this is not osc tests, but \u0027ironic\u0027 command tests","commit_id":"3955a68c8c8fe94a9b5f7106fab12e234a6513b0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"654f4c7cc43e227f0c8ba0a3a265a04b2b0ee9a6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     SofiiaAndriichenko \u003csandriichenko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-01 13:36:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix cleanup of resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed bug, resources aren\u0027t deleted after ironic command tests"},{"line_number":10,"context_line":"had finished"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a461143_f767fce7","line":7,"updated":"2017-02-02 16:21:44.000000000","message":".. in functional tests","commit_id":"141bb4335b4dce66f0715a7a5ea149228218256f"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"df7c30945e875a6e353e7eb1a8d1adabc675fd15","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     SofiiaAndriichenko \u003csandriichenko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-01 13:36:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix cleanup of resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed bug, resources aren\u0027t deleted after ironic command tests"},{"line_number":10,"context_line":"had finished"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a461143_c9a988e1","line":7,"in_reply_to":"3a461143_f767fce7","updated":"2017-02-02 16:47:33.000000000","message":"Done","commit_id":"141bb4335b4dce66f0715a7a5ea149228218256f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"654f4c7cc43e227f0c8ba0a3a265a04b2b0ee9a6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix cleanup of resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed bug, resources aren\u0027t deleted after ironic command tests"},{"line_number":10,"context_line":"had finished"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I45593a49c67b3143215c83a6f729920f789e0e5a"},{"line_number":13,"context_line":"Closes-Bug: #1658942"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a461143_176568e0","line":10,"updated":"2017-02-02 16:21:44.000000000","message":"nit: maybe worth mentioning the exact test","commit_id":"141bb4335b4dce66f0715a7a5ea149228218256f"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"df7c30945e875a6e353e7eb1a8d1adabc675fd15","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix cleanup of resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed bug, resources aren\u0027t deleted after ironic command tests"},{"line_number":10,"context_line":"had finished"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I45593a49c67b3143215c83a6f729920f789e0e5a"},{"line_number":13,"context_line":"Closes-Bug: #1658942"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a461143_893060a0","line":10,"in_reply_to":"3a461143_176568e0","updated":"2017-02-02 16:47:33.000000000","message":"Done","commit_id":"141bb4335b4dce66f0715a7a5ea149228218256f"}],"ironicclient/tests/functional/test_json_response.py":[{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"14c759c9d08f29647323f9b09c83e9f28b6f08f2","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        response \u003d self.ironic(\u0027node-create\u0027, flags\u003d\u0027--json\u0027,"},{"line_number":153,"context_line":"                               params\u003d\u0027-d fake\u0027, parse\u003dFalse)"},{"line_number":154,"context_line":"        self.assertTrue(_is_valid_json(response, schema))"},{"line_number":155,"context_line":"        node \u003d json.loads(response)"},{"line_number":156,"context_line":"        self.ironic(\u0027node-delete\u0027, params\u003dnode[\u0027uuid\u0027])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def test_node_update_json(self):"},{"line_number":159,"context_line":"        \"\"\"Test JSON response for node update.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_1b7b227c","line":156,"range":{"start_line":155,"start_character":8,"end_line":156,"end_character":55},"updated":"2017-01-24 11:50:39.000000000","message":"This code will not be reached if preceding assertion fails.\nYou should use `addCleanup()` method that will be invoked as teardown.","commit_id":"c238d9d3afc865c332972bf35a9d43cc3697664a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c2627f5c1e233572c33860ab4a27a99b4e993416","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        response \u003d self.ironic(\u0027node-create\u0027, flags\u003d\u0027--json\u0027,"},{"line_number":153,"context_line":"                               params\u003d\u0027-d fake\u0027, parse\u003dFalse)"},{"line_number":154,"context_line":"        self.assertTrue(_is_valid_json(response, schema))"},{"line_number":155,"context_line":"        node \u003d json.loads(response)"},{"line_number":156,"context_line":"        self.ironic(\u0027node-delete\u0027, params\u003dnode[\u0027uuid\u0027])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def test_node_update_json(self):"},{"line_number":159,"context_line":"        \"\"\"Test JSON response for node update.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_a1ce46b5","line":156,"range":{"start_line":155,"start_character":8,"end_line":156,"end_character":55},"in_reply_to":"5a3905b3_1b7b227c","updated":"2017-01-24 18:36:00.000000000","message":"I agree that addCleanp is more explicit, but we still need to do json.loads to deserialize the output and get uuid, it will fail if it is not valid json, and the node still won\u0027t be cleaned up. So not a big deal I think.","commit_id":"c238d9d3afc865c332972bf35a9d43cc3697664a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"654f4c7cc43e227f0c8ba0a3a265a04b2b0ee9a6","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                               params\u003d\u0027-d fake\u0027, parse\u003dFalse)"},{"line_number":154,"context_line":"        self.assertTrue(_is_valid_json(response, schema))"},{"line_number":155,"context_line":"        node \u003d json.loads(response)"},{"line_number":156,"context_line":"        self.addCleanup(self.delete_node, node[\u0027uuid\u0027])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def test_node_update_json(self):"},{"line_number":159,"context_line":"        \"\"\"Test JSON response for node update.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_376264d9","line":156,"updated":"2017-02-02 16:21:44.000000000","message":"this does not have to use addCleanup, it\u0027s the last thing in this test anyway :) just delete it here.\n\nif you want your test to also delete the node when assertTrue above fails, you should addCleanup before that assertions. You may probably use a pre-defined name.","commit_id":"141bb4335b4dce66f0715a7a5ea149228218256f"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"df7c30945e875a6e353e7eb1a8d1adabc675fd15","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                               params\u003d\u0027-d fake\u0027, parse\u003dFalse)"},{"line_number":154,"context_line":"        self.assertTrue(_is_valid_json(response, schema))"},{"line_number":155,"context_line":"        node \u003d json.loads(response)"},{"line_number":156,"context_line":"        self.addCleanup(self.delete_node, node[\u0027uuid\u0027])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def test_node_update_json(self):"},{"line_number":159,"context_line":"        \"\"\"Test JSON response for node update.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_77622c18","line":156,"in_reply_to":"3a461143_376264d9","updated":"2017-02-02 16:47:33.000000000","message":"Thanks, i\u0027d like to put addCleanup before assertion, and to use pre-defined name.","commit_id":"141bb4335b4dce66f0715a7a5ea149228218256f"}]}