)]}'
{"ironicclient/osc/v1/baremetal_node.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"62a483db6d2f5daa711a2805f539ec353dc6fe83","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        node.pop(\u0027portgroups\u0027, None)"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"        node.setdefault(\u0027chassis_uuid\u0027, \u0027\u0027)"},{"line_number":1117,"context_line":"        if fields and (\u0027chassis_uuid\u0027 not in fields):"},{"line_number":1118,"context_line":"            node.pop(\u0027chassis_uuid\u0027, None)"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"        return self.dict2columns(node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_224b015b","line":1117,"updated":"2017-02-02 17:42:10.000000000","message":"I\u0027d rather do \n\n if fields and (\u0027chassis_uuid\u0027 in fields):\n   node.setdefault(\u0027chassis_uuid\u0027, \u0027\u0027)\n\ninstead of popping it after addition.","commit_id":"dadc46514e0103ad6c9d4a50d5a87ef357d4f13c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"41be48f651d81a04501e3ee159b80a442363bc6c","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        node.pop(\u0027portgroups\u0027, None)"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"        node.setdefault(\u0027chassis_uuid\u0027, \u0027\u0027)"},{"line_number":1117,"context_line":"        if fields and (\u0027chassis_uuid\u0027 not in fields):"},{"line_number":1118,"context_line":"            node.pop(\u0027chassis_uuid\u0027, None)"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"        return self.dict2columns(node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_523f2025","line":1117,"in_reply_to":"3a461143_224b015b","updated":"2017-02-03 13:00:26.000000000","message":"Thank you!","commit_id":"dadc46514e0103ad6c9d4a50d5a87ef357d4f13c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"22a7db568a4650d4e833099f1ce36259c20eec18","unresolved":false,"context_lines":[{"line_number":1113,"context_line":"        node.pop(\"ports\", None)"},{"line_number":1114,"context_line":"        node.pop(\u0027portgroups\u0027, None)"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"        if fields and (\u0027chassis_uuid\u0027 in fields):"},{"line_number":1117,"context_line":"            node.setdefault(\u0027chassis_uuid\u0027, \u0027\u0027)"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"        return self.dict2columns(node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_092baeec","line":1116,"updated":"2017-02-03 13:57:05.000000000","message":"Sorry for confusion :( For some reason I did not grasp that if fields\u003dNone it means we want the whole representation. The correct way would be:\n\n if not fields or \u0027chassis_uuid\u0027 in fields:\n   node.setdefault(\u0027chassis_uuid\u0027, \u0027\u0027)","commit_id":"da1aea6ad1f79576e35416befd70b20b21890143"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"06c00ec68ad698bab1b3b2974541896cd9a367dd","unresolved":false,"context_lines":[{"line_number":1113,"context_line":"        node.pop(\"ports\", None)"},{"line_number":1114,"context_line":"        node.pop(\u0027portgroups\u0027, None)"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"        if fields and (\u0027chassis_uuid\u0027 in fields):"},{"line_number":1117,"context_line":"            node.setdefault(\u0027chassis_uuid\u0027, \u0027\u0027)"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"        return self.dict2columns(node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_758961ca","line":1116,"in_reply_to":"1a430d35_092baeec","updated":"2017-02-03 15:52:30.000000000","message":"Ok :)","commit_id":"da1aea6ad1f79576e35416befd70b20b21890143"}]}