)]}'
{"ironicclient/tests/functional/test_node_vif.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c4751462deb8b9d8a67a41a090082eb7d311bea6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        3) Check attached VIF data in port group internal_info."},{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        port \u003d self.show_port(self.port[\u0027uuid\u0027], flags\u003dself.vif_api_ver)"},{"line_number":48,"context_line":"        self.assertEqual(port[\u0027internal_info\u0027][self.tenant_vif_key],"},{"line_number":49,"context_line":"                         self.vif_id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        port_group \u003d self.show_portgroup(self.port_group[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_63042e7e","line":48,"updated":"2017-02-10 21:02:53.000000000","message":"So you expected that VIF is attached to portgroup, port shouldn\u0027t contain tenant_vif_port_id\n\nself.assertNotIn(self.tenant_vif_key, port[\u0027internal_info\u0027])","commit_id":"37b741c339ba8baf50e036fc505e8c95bcf3bcae"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"b35bb551e371fcc6dbdfd41cf03598c2a8ec5f99","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        3) Check attached VIF data in port group internal_info."},{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        port \u003d self.show_port(self.port[\u0027uuid\u0027], flags\u003dself.vif_api_ver)"},{"line_number":48,"context_line":"        self.assertEqual(port[\u0027internal_info\u0027][self.tenant_vif_key],"},{"line_number":49,"context_line":"                         self.vif_id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        port_group \u003d self.show_portgroup(self.port_group[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_89ed8e27","line":48,"in_reply_to":"fa31d9ce_63042e7e","updated":"2017-02-13 13:33:49.000000000","message":"Done","commit_id":"37b741c339ba8baf50e036fc505e8c95bcf3bcae"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c4751462deb8b9d8a67a41a090082eb7d311bea6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.assertEqual(port[\u0027internal_info\u0027][self.tenant_vif_key],"},{"line_number":49,"context_line":"                         self.vif_id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        port_group \u003d self.show_portgroup(self.port_group[\u0027uuid\u0027],"},{"line_number":52,"context_line":"                                         flags\u003dself.vif_api_ver)"},{"line_number":53,"context_line":"        self.assertEqual(port_group[\u0027internal_info\u0027][self.tenant_vif_key],"},{"line_number":54,"context_line":"                         self.vif_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_ce87c10d","line":51,"updated":"2017-02-10 21:02:53.000000000","message":"show_portgroup returns the following:\n\n{\u0027internal_info\u0027: u\"{u\u0027tenant_vif_port_id\u0027: u\u0027128f0912-da2f-47e0-a9da-c1b671e6cf6a\u0027}\", \u0027node_uuid\u0027: u\u0027060dfc80-6d5c-438a-af10-5df5d6649876\u0027, \u0027standalone_ports_supported\u0027: u\u0027True\u0027, \u0027uuid\u0027: u\u00276586ffb5-aac8-4dd0-89e3-b0a78b19f01f\u0027, \u0027address\u0027: u\u0027None\u0027, \u0027mode\u0027: u\u0027active-backup\u0027, \u0027updated_at\u0027: u\u00272017-02-10T20:30:18+00:00\u0027, \u0027name\u0027: u\u0027None\u0027, \u0027properties\u0027: u\u0027{}\u0027, \u0027extra\u0027: u\u0027{}\u0027, \u0027created_at\u0027: u\u00272017-02-10T20:30:15+00:00\u0027}\n\ninternal_info is not converted to dict it is a string, \n\nget_dict_from_output doesn\u0027t convert nested data\nhttps://github.com/openstack/python-ironicclient/blob/master/ironicclient/tests/functional/utils.py#L18","commit_id":"37b741c339ba8baf50e036fc505e8c95bcf3bcae"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"b35bb551e371fcc6dbdfd41cf03598c2a8ec5f99","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.assertEqual(port[\u0027internal_info\u0027][self.tenant_vif_key],"},{"line_number":49,"context_line":"                         self.vif_id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        port_group \u003d self.show_portgroup(self.port_group[\u0027uuid\u0027],"},{"line_number":52,"context_line":"                                         flags\u003dself.vif_api_ver)"},{"line_number":53,"context_line":"        self.assertEqual(port_group[\u0027internal_info\u0027][self.tenant_vif_key],"},{"line_number":54,"context_line":"                         self.vif_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_e9de0a6c","line":51,"in_reply_to":"fa31d9ce_ce87c10d","updated":"2017-02-13 13:33:49.000000000","message":"Thanks!","commit_id":"37b741c339ba8baf50e036fc505e8c95bcf3bcae"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c4751462deb8b9d8a67a41a090082eb7d311bea6","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        2) Check that no more VIF data in port internal_info."},{"line_number":72,"context_line":"        3) Check that no more VIF data in port group internal_info."},{"line_number":73,"context_line":"        \"\"\""},{"line_number":74,"context_line":"        self.node_vif_detach(self.node[\u0027uuid\u0027], self.vif_id)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        port \u003d self.show_port(self.port[\u0027uuid\u0027], flags\u003dself.vif_api_ver)"},{"line_number":77,"context_line":"        self.assertNotIn(self.tenant_vif_key, port[\u0027internal_info\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_23e87610","line":74,"updated":"2017-02-10 21:02:53.000000000","message":"test are launched concurrently, you can\u0027t use the same vif here, as other tests use it also.","commit_id":"37b741c339ba8baf50e036fc505e8c95bcf3bcae"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6a4ad30aaac70e22f11603c3a2e6bbe5d6f7db37","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            params\u003d\u0027--portgroup {0}\u0027.format(self.port_group[\u0027uuid\u0027]))"},{"line_number":36,"context_line":"        self.node_vif_attach(self.node[\u0027uuid\u0027], self.vif_id)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_node_vif_attach_with_portgroup(self):"},{"line_number":39,"context_line":"        \"\"\"Attach VIF to the node with port group."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        Test steps:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba2be162_fc68c3bc","line":38,"updated":"2017-03-01 12:37:18.000000000","message":"I\u0027m sure this shouldn\u0027t be a part of ironicclient functional tests, as it test Ironic API functionality please move it to ironic instead.\nHere should be simple tests vif-attach/vif-detach/vif-list.","commit_id":"e406092b93c28c72e87121e8524ae2d340e1fecb"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"3fd5b648b996b68c76ed2b815d18da17d65b87f5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            params\u003d\u0027--portgroup {0}\u0027.format(self.port_group[\u0027uuid\u0027]))"},{"line_number":36,"context_line":"        self.node_vif_attach(self.node[\u0027uuid\u0027], self.vif_id)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_node_vif_attach_with_portgroup(self):"},{"line_number":39,"context_line":"        \"\"\"Attach VIF to the node with port group."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        Test steps:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba2be162_6b1fe4b6","line":38,"in_reply_to":"ba2be162_fc68c3bc","updated":"2017-03-06 14:23:41.000000000","message":"Ok, i minimize this set of tests.","commit_id":"e406092b93c28c72e87121e8524ae2d340e1fecb"}]}