)]}'
{"ironicclient/osc/v1/baremetal_node.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ac0cd0cddef659fb323040ce100a5396455a81b9","unresolved":false,"context_lines":[{"line_number":1113,"context_line":"        node.pop(\"links\", None)"},{"line_number":1114,"context_line":"        node.pop(\"ports\", None)"},{"line_number":1115,"context_line":"        node.pop(\u0027portgroups\u0027, None)"},{"line_number":1116,"context_line":"        node.pop(\u0027states\u0027, None)"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":"        if not fields or \u0027chassis_uuid\u0027 in fields:"},{"line_number":1119,"context_line":"            node.setdefault(\u0027chassis_uuid\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_0baa6b70","line":1116,"updated":"2017-02-13 15:59:29.000000000","message":"I also wonder if it is possible to reuse NODE_DETAILED_RESOURCE here and in the other place to avoid adding these pops all the time?","commit_id":"4971891f9e3c207b38fcc0b801268a80897f2c90"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"a263843283808b972b99ac5380a9e6f8062d1fb2","unresolved":false,"context_lines":[{"line_number":1113,"context_line":"        node.pop(\"links\", None)"},{"line_number":1114,"context_line":"        node.pop(\"ports\", None)"},{"line_number":1115,"context_line":"        node.pop(\u0027portgroups\u0027, None)"},{"line_number":1116,"context_line":"        node.pop(\u0027states\u0027, None)"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":"        if not fields or \u0027chassis_uuid\u0027 in fields:"},{"line_number":1119,"context_line":"            node.setdefault(\u0027chassis_uuid\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_889d5abe","line":1116,"in_reply_to":"fa31d9ce_0baa6b70","updated":"2017-02-14 10:33:50.000000000","message":"I suppose that we should add list of non-CLI resource fields for that reason.","commit_id":"4971891f9e3c207b38fcc0b801268a80897f2c90"}],"releasenotes/notes/remove-states-field-0242960d121a09a7.yaml":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c601747e1d496d10d01fb5c0e5bc3f495870f1b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Hide \u0027states\u0027 field in \u0027node create\u0027 and \u0027node show\u0027"},{"line_number":4,"context_line":"    OSC subcommands output because this field is not meant"},{"line_number":5,"context_line":"    for CLI users."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa31d9ce_50982b1c","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"updated":"2017-02-15 14:25:22.000000000","message":"not sure if it suits the upgrade section...","commit_id":"d7dc96dc6567a387118faee385cca4ebc63b8fe4"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"adb965d2789767e9418f1596eb0b60d6d41684b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Hide \u0027states\u0027 field in \u0027node create\u0027 and \u0027node show\u0027"},{"line_number":4,"context_line":"    OSC subcommands output because this field is not meant"},{"line_number":5,"context_line":"    for CLI users."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa31d9ce_2671bd44","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"fa31d9ce_50982b1c","updated":"2017-02-15 14:59:51.000000000","message":"In previous similar patches it was said that i should mark it as upgrade: https://review.openstack.org/#/c/366703/\nhttps://review.openstack.org/#/c/366731/","commit_id":"d7dc96dc6567a387118faee385cca4ebc63b8fe4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c601747e1d496d10d01fb5c0e5bc3f495870f1b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Hide \u0027states\u0027 field in \u0027node create\u0027 and \u0027node show\u0027"},{"line_number":4,"context_line":"    OSC subcommands output because this field is not meant"},{"line_number":5,"context_line":"    for CLI users."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa31d9ce_f0d91ff4","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":8},"updated":"2017-02-15 14:25:22.000000000","message":"Hides","commit_id":"d7dc96dc6567a387118faee385cca4ebc63b8fe4"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"adb965d2789767e9418f1596eb0b60d6d41684b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Hide \u0027states\u0027 field in \u0027node create\u0027 and \u0027node show\u0027"},{"line_number":4,"context_line":"    OSC subcommands output because this field is not meant"},{"line_number":5,"context_line":"    for CLI users."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa31d9ce_66957531","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":8},"in_reply_to":"fa31d9ce_f0d91ff4","updated":"2017-02-15 14:59:51.000000000","message":"Done","commit_id":"d7dc96dc6567a387118faee385cca4ebc63b8fe4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c601747e1d496d10d01fb5c0e5bc3f495870f1b4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Hide \u0027states\u0027 field in \u0027node create\u0027 and \u0027node show\u0027"},{"line_number":4,"context_line":"    OSC subcommands output because this field is not meant"},{"line_number":5,"context_line":"    for CLI users."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa31d9ce_b0a16748","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":17},"updated":"2017-02-15 14:25:22.000000000","message":"not meant to be present in the output.","commit_id":"d7dc96dc6567a387118faee385cca4ebc63b8fe4"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"adb965d2789767e9418f1596eb0b60d6d41684b7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Hide \u0027states\u0027 field in \u0027node create\u0027 and \u0027node show\u0027"},{"line_number":4,"context_line":"    OSC subcommands output because this field is not meant"},{"line_number":5,"context_line":"    for CLI users."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa31d9ce_c6a621ad","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":17},"in_reply_to":"fa31d9ce_b0a16748","updated":"2017-02-15 14:59:51.000000000","message":"thanks!","commit_id":"d7dc96dc6567a387118faee385cca4ebc63b8fe4"}]}