)]}'
{"id":"openstack%2Fpython-ironicclient~458871","triplet_id":"openstack%2Fpython-ironicclient~master~I769d63869858b03d80b8a85370a5e24f13a22ab4","project":"openstack/python-ironicclient","branch":"master","topic":"ksa-requests","hashtags":[],"change_id":"I769d63869858b03d80b8a85370a5e24f13a22ab4","subject":"Remove direct dependency on requests","status":"ABANDONED","created":"2017-04-21 15:05:39.000000000","updated":"2021-05-03 13:50:00.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"110f9956184f3aa181465322977a34f9a4f962a8","_number":458871,"virtual_id_number":458871,"owner":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"actions":{},"labels":{"Verified":{"all":[{"date":"2017-04-24 11:49:56.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":-1,"date":"2017-04-23 16:56:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-04-23 16:56:47.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"}],"messages":[{"id":"3d607eb40da70145f4b3c044533db555c7020959","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2017-04-21 15:05:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fafedb958cd1cdc11c123a2300bf7d8ba79086f9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-21 15:42:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python35 http://logs.openstack.org/71/458871/1/check/gate-python-ironicclient-python35/cc46922/ : SUCCESS in 2m 30s\n- gate-python-ironicclient-docs-ubuntu-xenial http://docs-draft.openstack.org/71/458871/1/check/gate-python-ironicclient-docs-ubuntu-xenial/a34fa38//doc/build/html/ : SUCCESS in 3m 33s\n- gate-python-ironicclient-pep8-ubuntu-xenial http://logs.openstack.org/71/458871/1/check/gate-python-ironicclient-pep8-ubuntu-xenial/9bbe590/ : SUCCESS in 3m 29s\n- gate-python-ironicclient-python27-ubuntu-xenial http://logs.openstack.org/71/458871/1/check/gate-python-ironicclient-python27-ubuntu-xenial/22bc976/ : SUCCESS in 2m 25s\n- gate-python-ironicclient-requirements http://logs.openstack.org/71/458871/1/check/gate-python-ironicclient-requirements/5c8e7ed/ : SUCCESS in 1m 45s\n- gate-python-ironicclient-pypy http://logs.openstack.org/71/458871/1/check/gate-python-ironicclient-pypy/0f53f0d/ : SUCCESS in 3m 36s (non-voting)\n- gate-python-ironicclient-releasenotes http://docs-draft.openstack.org/71/458871/1/check/gate-python-ironicclient-releasenotes/4f765aa//releasenotes/build/html/ : SUCCESS in 3m 03s\n- check-osc-plugins http://logs.openstack.org/71/458871/1/check/check-osc-plugins/a51e7e8/ : SUCCESS in 3m 53s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial http://logs.openstack.org/71/458871/1/check/gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial/ba1da46/ : SUCCESS in 34m 59s\n- gate-ironicclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/458871/1/check/gate-ironicclient-dsvm-functional-ubuntu-xenial/9e96565/ : SUCCESS in 14m 28s\n- python-ironicclient-coverage-ubuntu-xenial http://logs.openstack.org/71/458871/1/check/python-ironicclient-coverage-ubuntu-xenial/e5fed7f/ : SUCCESS in 2m 35s","accounts_in_message":[],"_revision_number":1},{"id":"a278a1c796ca4e29e2876d4f3644d39c1d669774","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-04-23 16:56:47.000000000","message":"Patch Set 1: Code-Review-1\n\nWe\u0027re importing requests directly in ironicclient.common.http and unit tests, so I think it has to stay.","accounts_in_message":[],"_revision_number":1},{"id":"180a3a13a1f7cfeb4f59c583a26d0d4d199d12e0","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2017-04-24 11:49:56.000000000","message":"Patch Set 1:\n\nkeystoneauth has a dependency on requests, which means that ironicclient will get requests installed. The reason for removing it here is to minimize the number of places the version string is declared in a potentially conflicting manner.","accounts_in_message":[],"_revision_number":1},{"id":"ade5fbad4335bcf00a2a41b62ef97ac27857cb5d","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-04-24 11:53:52.000000000","message":"Patch Set 1:\n\nI understand. Still, we use it directly, and AFAIU have to declare its dependency explicitly as well. Or we should reimport it from keystoneauth somehow.","accounts_in_message":[],"_revision_number":1},{"id":"ba2a4ba728a8bb765485b4f7f41b05bc8d770bc6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-13 01:04:10.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"1bea294e3dce7e8a3d804b28eb91ec8347321880","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-12-18 03:15:41.000000000","message":"Removed reviewer Jenkins with the following votes:\n\n* Verified-1 by Jenkins (3)\n","accounts_in_message":[],"_revision_number":1},{"id":"110f9956184f3aa181465322977a34f9a4f962a8","tag":"autogenerated:gerrit:abandon","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-05-03 13:50:00.000000000","message":"Abandoned\n\nAbandoning because of inactivity","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4347bc7851fcc03cf0e43aabdeef8bced4ad4012","revisions":{"4347bc7851fcc03cf0e43aabdeef8bced4ad4012":{"kind":"REWORK","_number":1,"created":"2017-04-21 15:05:39.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/71/458871/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/71/458871/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/71/458871/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/71/458871/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/71/458871/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/71/458871/1"}}},"commit":{"parents":[{"commit":"850f6513fe0d8952e5d87022b67bf03a3ff9fbf3","subject":"Merge \"Update OSC baremetal node set/unset supporting dynamic drivers\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/850f6513fe0d8952e5d87022b67bf03a3ff9fbf3"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2017-04-21 15:05:27.000000000","tz":-300},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2017-04-21 15:05:27.000000000","tz":-300},"subject":"Remove direct dependency on requests","message":"Remove direct dependency on requests\n\nkeystoneauth is the library that pulls in requests. If we have client\nlibraries also depend directly on requests, we can get into situations\nfor end users in installations where, because of sequencing of client\nlibrary releases there are conflicting versions of requests needed and\npkg_resources/entrypoints break.\n\nRemove the direct depend and let keystoneauth pull it in for us.\n\nChange-Id: I769d63869858b03d80b8a85370a5e24f13a22ab4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/4347bc7851fcc03cf0e43aabdeef8bced4ad4012"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/4347bc7851fcc03cf0e43aabdeef8bced4ad4012"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}