)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"52f66ce86ad644e4ac585bb2dfefd12214733535","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ia0437529bcb1a3e8dd20bde55eb57e0443290028"},{"line_number":24,"context_line":"Partial-Bug: #1526231"},{"line_number":25,"context_line":"Depends-On: I2c74f386291e588a25612f73de08e8367795acff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_c81d5474","line":25,"updated":"2017-07-02 11:21:32.000000000","message":"if you want the driver commands to support the new fields, you need to make this change depend on a change that actually does it, i.e. updates https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/driver.py#L85-L105. I\u0027m not sure such change even exists. Let\u0027s limit this patch to only node operations until then.","commit_id":"c43a2407eeb8388be583ba0196e06222341c01d1"}],"ironicclient/osc/v1/baremetal_node.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"20a37f58f0cdd6f7e510843fc7a8477f1d13134d","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        parser.add_argument("},{"line_number":393,"context_line":"            \u0027--storage-interface\u0027,"},{"line_number":394,"context_line":"            metavar\u003d\u0027\u003cstorage_interface\u003e\u0027,"},{"line_number":395,"context_line":"            help\u003d_(\u0027Storage interface used by the node\\\u0027s driver. This is \u0027"},{"line_number":396,"context_line":"                   \u0027only applicable when the specified --driver is a \u0027"},{"line_number":397,"context_line":"                   \u0027hardware type.\u0027))"},{"line_number":398,"context_line":"        parser.add_argument("},{"line_number":399,"context_line":"            \u0027--vendor-interface\u0027,"},{"line_number":400,"context_line":"            metavar\u003d\u0027\u003cvendor_interface\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_c94f8c32","line":397,"range":{"start_line":395,"start_character":65,"end_line":397,"end_character":35},"updated":"2017-07-03 08:41:57.000000000","message":"storage_interface can be set to classical drivers[1].\n\n[1] https://github.com/openstack/ironic/blob/5777f4ab8c21eb93d720f57a980a594bdda0a8fd/ironic/common/driver_factory.py#L249","commit_id":"c43a2407eeb8388be583ba0196e06222341c01d1"}],"ironicclient/v1/node_shell.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b6e1beb7f6a446b864d7c50d9bdc5878367f647","unresolved":false,"context_lines":[{"line_number":262,"context_line":"@cliutils.arg("},{"line_number":263,"context_line":"    \u0027--storage-interface\u0027,"},{"line_number":264,"context_line":"    metavar\u003d\u0027\u003cstorage-interface\u003e\u0027,"},{"line_number":265,"context_line":"    help\u003d\u0027Storage interface used by the node\\\u0027s driver. This is \u0027"},{"line_number":266,"context_line":"         \u0027only applicable when the specified --driver is a \u0027"},{"line_number":267,"context_line":"         \u0027hardware type.\u0027)"},{"line_number":268,"context_line":"@cliutils.arg("},{"line_number":269,"context_line":"    \u0027--vendor-interface\u0027,"},{"line_number":270,"context_line":"    metavar\u003d\u0027\u003cvendor-interface\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_83c80122","line":267,"range":{"start_line":265,"start_character":55,"end_line":267,"end_character":24},"updated":"2017-07-05 14:47:30.000000000","message":"Storage interfaces should work just fine with classic drivers.","commit_id":"8d5a60867e70cd73c81f9a1c32c68ce143c57089"}],"releasenotes/notes/node-driver-support-storage-interface-e93fc8d4de5d24d6.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b6e1beb7f6a446b864d7c50d9bdc5878367f647","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for storage_interface for the below commands."},{"line_number":5,"context_line":"    They are available starting with ironic API microversion 1.33."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ironic node-create"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f1d235d_4338a9ec","line":4,"range":{"start_line":4,"start_character":47,"end_line":4,"end_character":61},"updated":"2017-07-05 14:47:30.000000000","message":"nit: commands below","commit_id":"8d5a60867e70cd73c81f9a1c32c68ce143c57089"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"19e7627a11d1c5bd9e87e2411e1b9ec37da38191","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for storage_interface for the below commands."},{"line_number":5,"context_line":"    They are available starting with ironic API microversion 1.33."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ironic node-create"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f1d235d_d2d8da53","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":61},"updated":"2017-07-06 12:04:23.000000000","message":"nit: Perhaps \"commands listed below.\" might fit better.","commit_id":"185d5518fa251877ba9d3cfaa25b871c6be7b6f8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3f4c5a03087898a806f80010e197e7085d30b824","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    * openstack baremetal node set"},{"line_number":15,"context_line":"    * openstack baremetal node unset"},{"line_number":16,"context_line":"    * openstack baremetal driver list"},{"line_number":17,"context_line":"    * openstack baremetal driver show"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f1d235d_ee012eb1","line":17,"updated":"2017-07-11 13:39:57.000000000","message":"nit, if you do another revision. We want to emphasize the openstack baremetal commands, since we want to remove the ironic ones in the future, so it would be better to put the openstack commands first, before the ironic ones.","commit_id":"e442a1c06d3b3fd10b054c21f86446016ff80a6f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7ce428d9fe6478292b8a4a8ba957ea5e15ebea57","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds support for storage_interface for the commands below."},{"line_number":5,"context_line":"    They are available starting with ironic API microversion 1.33."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ironic node-create"},{"line_number":8,"context_line":"    * ironic node-show"},{"line_number":9,"context_line":"    * ironic node-update"},{"line_number":10,"context_line":"    * ironic driver-list"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_1bf3780c","line":7,"updated":"2017-07-11 22:00:00.000000000","message":"Can a follow-up be done so they are in the format:\n\n * ``ironic node-create``\n\nWith the double back-quotes.","commit_id":"525f60912cd214088ddc4cf6dacdb06b95e2b3a5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"511f18b321eddc4857bf3d7212b4820a5aa9401a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds support for storage_interface for the commands below."},{"line_number":5,"context_line":"    They are available starting with ironic API microversion 1.33."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ironic node-create"},{"line_number":8,"context_line":"    * ironic node-show"},{"line_number":9,"context_line":"    * ironic node-update"},{"line_number":10,"context_line":"    * ironic driver-list"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_3b8d1431","line":7,"in_reply_to":"3f1d235d_1bf3780c","updated":"2017-07-11 22:05:32.000000000","message":"Well, there\u0027s no consistency unless someone wants to try to enforce it, see our past/existing release notes, eg [1]. Maybe this is something to do at the end before a release is done, or we should just agree first...\n\n[1] https://docs.openstack.org/releasenotes/python-ironicclient/unreleased.html","commit_id":"525f60912cd214088ddc4cf6dacdb06b95e2b3a5"}]}