)]}'
{"ironicclient/tests/unit/v1/test_volume_connector_shell.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2a3ab75c3715c7b822c315d7fba88ba7381e0e7a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Hitachi Data Systems"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_82450673","line":1,"updated":"2017-07-10 22:05:45.000000000","message":"should we change to 2017 too?","commit_id":"7f57080cf6880e1a1fe77934516a660c23e5e576"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"237bab584c5637b36442c513ac876ca3179b2ee5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Hitachi Data Systems"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_32a1b2aa","line":1,"in_reply_to":"3f1d235d_82450673","updated":"2017-07-12 02:46:50.000000000","message":"Done","commit_id":"7f57080cf6880e1a1fe77934516a660c23e5e576"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2a3ab75c3715c7b822c315d7fba88ba7381e0e7a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def test_do_volume_connector_show(self):"},{"line_number":40,"context_line":"        client_mock \u003d mock.MagicMock()"},{"line_number":41,"context_line":"        args \u003d mock.MagicMock()"},{"line_number":42,"context_line":"        args.volume_connector \u003d \u0027volume_connector_uuid\u0027"},{"line_number":43,"context_line":"        args.fields \u003d None"},{"line_number":44,"context_line":"        args.json \u003d False"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_4276ceda","line":42,"updated":"2017-07-10 22:05:45.000000000","message":"i don\u0027t know why we do this; seems like we should use some fake uuid but i guess it is ok.","commit_id":"7f57080cf6880e1a1fe77934516a660c23e5e576"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"237bab584c5637b36442c513ac876ca3179b2ee5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def test_do_volume_connector_show(self):"},{"line_number":40,"context_line":"        client_mock \u003d mock.MagicMock()"},{"line_number":41,"context_line":"        args \u003d mock.MagicMock()"},{"line_number":42,"context_line":"        args.volume_connector \u003d \u0027volume_connector_uuid\u0027"},{"line_number":43,"context_line":"        args.fields \u003d None"},{"line_number":44,"context_line":"        args.json \u003d False"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_b555ac52","line":42,"in_reply_to":"3f1d235d_4276ceda","updated":"2017-07-12 02:46:50.000000000","message":"Just imitating other tests though fake UUIDs might be better.","commit_id":"7f57080cf6880e1a1fe77934516a660c23e5e576"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"ddaff6d9d98cdb11554fdb0b77a6150b451f49ca","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import ironicclient.v1.volume_connector_shell as vc_shell"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class Volume_ConnectorShellTest(utils.BaseTestCase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_volume_connector_show(self):"},{"line_number":29,"context_line":"        actual \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_99313bf0","line":26,"range":{"start_line":26,"start_character":12,"end_line":26,"end_character":13},"updated":"2017-07-12 13:07:59.000000000","message":"nit: s/_// in case you have a new revision.","commit_id":"911b8cc0bb3fade170cee082d04cba3e07b8d58b"}],"ironicclient/v1/volume_connector_shell.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e5571755440a0b796fdb9ce02bc180f794f64389","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Hitachi Data Systems"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_0b584a53","line":1,"updated":"2017-07-07 00:46:29.000000000","message":"? Didn\u0027t you submit this patch in July 2017?","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"df075b0ff8f15543ce8e353e0eacf1929fd72bae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Hitachi Data Systems"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_97b6898a","line":1,"in_reply_to":"3f1d235d_0b584a53","updated":"2017-07-10 05:23:22.000000000","message":"It was caused since this code was split from another patch submitted a few years ago.","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e5571755440a0b796fdb9ce02bc180f794f64389","unresolved":false,"context_lines":[{"line_number":60,"context_line":"@cliutils.arg("},{"line_number":61,"context_line":"    \u0027--node\u0027,"},{"line_number":62,"context_line":"    metavar\u003d\u0027\u003cnode\u003e\u0027,"},{"line_number":63,"context_line":"    help\u003d_(\u0027Only show information for the volume connector with this node.\u0027))"},{"line_number":64,"context_line":"@cliutils.arg("},{"line_number":65,"context_line":"    \u0027--limit\u0027,"},{"line_number":66,"context_line":"    metavar\u003d\u0027\u003climit\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_06627fd8","line":63,"updated":"2017-07-07 00:46:29.000000000","message":"how about \u0027Only list volume connectors of this node (name or UUID).\u0027","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"df075b0ff8f15543ce8e353e0eacf1929fd72bae","unresolved":false,"context_lines":[{"line_number":60,"context_line":"@cliutils.arg("},{"line_number":61,"context_line":"    \u0027--node\u0027,"},{"line_number":62,"context_line":"    metavar\u003d\u0027\u003cnode\u003e\u0027,"},{"line_number":63,"context_line":"    help\u003d_(\u0027Only show information for the volume connector with this node.\u0027))"},{"line_number":64,"context_line":"@cliutils.arg("},{"line_number":65,"context_line":"    \u0027--limit\u0027,"},{"line_number":66,"context_line":"    metavar\u003d\u0027\u003climit\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_57b0f18b","line":63,"in_reply_to":"3f1d235d_06627fd8","updated":"2017-07-10 05:23:22.000000000","message":"Done","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e5571755440a0b796fdb9ce02bc180f794f64389","unresolved":false,"context_lines":[{"line_number":71,"context_line":"@cliutils.arg("},{"line_number":72,"context_line":"    \u0027--marker\u0027,"},{"line_number":73,"context_line":"    metavar\u003d\u0027\u003cvolume connector\u003e\u0027,"},{"line_number":74,"context_line":"    help\u003d_(\u0027Volume connector UUID (for example, of the last volume_connector \u0027"},{"line_number":75,"context_line":"           \u0027in the list from a previous request). Returns the list of volume \u0027"},{"line_number":76,"context_line":"           \u0027connectors after this UUID.\u0027))"},{"line_number":77,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_46b19746","line":74,"updated":"2017-07-07 00:46:29.000000000","message":"s/volume_connector/volume connector/","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"df075b0ff8f15543ce8e353e0eacf1929fd72bae","unresolved":false,"context_lines":[{"line_number":71,"context_line":"@cliutils.arg("},{"line_number":72,"context_line":"    \u0027--marker\u0027,"},{"line_number":73,"context_line":"    metavar\u003d\u0027\u003cvolume connector\u003e\u0027,"},{"line_number":74,"context_line":"    help\u003d_(\u0027Volume connector UUID (for example, of the last volume_connector \u0027"},{"line_number":75,"context_line":"           \u0027in the list from a previous request). Returns the list of volume \u0027"},{"line_number":76,"context_line":"           \u0027connectors after this UUID.\u0027))"},{"line_number":77,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_37ad7531","line":74,"in_reply_to":"3f1d235d_46b19746","updated":"2017-07-10 05:23:22.000000000","message":"Done","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e5571755440a0b796fdb9ce02bc180f794f64389","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    volume_connector \u003d cc.volume_connector.list(**params)"},{"line_number":126,"context_line":"    cliutils.print_list(volume_connector, fields,"},{"line_number":127,"context_line":"                        field_labels\u003dfield_labels,"},{"line_number":128,"context_line":"                        sortby_index\u003dNone)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_66f493f1","line":128,"updated":"2017-07-07 00:46:29.000000000","message":"we should probably add \u0027json_flag\u003dargs.json\u0027 too.","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"df075b0ff8f15543ce8e353e0eacf1929fd72bae","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    volume_connector \u003d cc.volume_connector.list(**params)"},{"line_number":126,"context_line":"    cliutils.print_list(volume_connector, fields,"},{"line_number":127,"context_line":"                        field_labels\u003dfield_labels,"},{"line_number":128,"context_line":"                        sortby_index\u003dNone)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_d74ac181","line":128,"in_reply_to":"3f1d235d_66f493f1","updated":"2017-07-10 05:23:22.000000000","message":"Done","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e5571755440a0b796fdb9ce02bc180f794f64389","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    \u0027-t\u0027, \u0027--type\u0027,"},{"line_number":145,"context_line":"    metavar\u003d\"\u003ctype\u003e\","},{"line_number":146,"context_line":"    help\u003d_(\"Type of the volume connector. Can be \u0027iqn\u0027, \u0027ip\u0027, \u0027mac\u0027, \u0027wwnn\u0027, \""},{"line_number":147,"context_line":"           \"\u0027wwpn\u0027.\"))"},{"line_number":148,"context_line":"@cliutils.arg("},{"line_number":149,"context_line":"    \u0027-v\u0027, \u0027--connector_id\u0027,"},{"line_number":150,"context_line":"    metavar\u003d\"\u003cconnector id\u003e\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_66293335","line":147,"updated":"2017-07-07 00:46:29.000000000","message":"isn\u0027t this required?","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"df075b0ff8f15543ce8e353e0eacf1929fd72bae","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    \u0027-t\u0027, \u0027--type\u0027,"},{"line_number":145,"context_line":"    metavar\u003d\"\u003ctype\u003e\","},{"line_number":146,"context_line":"    help\u003d_(\"Type of the volume connector. Can be \u0027iqn\u0027, \u0027ip\u0027, \u0027mac\u0027, \u0027wwnn\u0027, \""},{"line_number":147,"context_line":"           \"\u0027wwpn\u0027.\"))"},{"line_number":148,"context_line":"@cliutils.arg("},{"line_number":149,"context_line":"    \u0027-v\u0027, \u0027--connector_id\u0027,"},{"line_number":150,"context_line":"    metavar\u003d\"\u003cconnector id\u003e\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_97444976","line":147,"in_reply_to":"3f1d235d_66293335","updated":"2017-07-10 05:23:22.000000000","message":"Done","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e5571755440a0b796fdb9ce02bc180f794f64389","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    help\u003d_(\"Type of the volume connector. Can be \u0027iqn\u0027, \u0027ip\u0027, \u0027mac\u0027, \u0027wwnn\u0027, \""},{"line_number":147,"context_line":"           \"\u0027wwpn\u0027.\"))"},{"line_number":148,"context_line":"@cliutils.arg("},{"line_number":149,"context_line":"    \u0027-v\u0027, \u0027--connector_id\u0027,"},{"line_number":150,"context_line":"    metavar\u003d\"\u003cconnector id\u003e\","},{"line_number":151,"context_line":"    help\u003d_(\"ID of the Volume connector in the specified type.\"))"},{"line_number":152,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_46fbd7bf","line":149,"updated":"2017-07-07 00:46:29.000000000","message":"-v is already used for verbose output. What about -c (for Connector). or -i for id?\n\nI mean, it\u0027ll still work, just wondering if it might be confusing: \u0027ironic -v volume_connector_create -v id ...\u0027.\n\nI see that you used -i for volume_id (when creating volume target) so maybe use -i for consistency here?","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"df075b0ff8f15543ce8e353e0eacf1929fd72bae","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    help\u003d_(\"Type of the volume connector. Can be \u0027iqn\u0027, \u0027ip\u0027, \u0027mac\u0027, \u0027wwnn\u0027, \""},{"line_number":147,"context_line":"           \"\u0027wwpn\u0027.\"))"},{"line_number":148,"context_line":"@cliutils.arg("},{"line_number":149,"context_line":"    \u0027-v\u0027, \u0027--connector_id\u0027,"},{"line_number":150,"context_line":"    metavar\u003d\"\u003cconnector id\u003e\","},{"line_number":151,"context_line":"    help\u003d_(\"ID of the Volume connector in the specified type.\"))"},{"line_number":152,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_7749ad89","line":149,"in_reply_to":"3f1d235d_46fbd7bf","updated":"2017-07-10 05:23:22.000000000","message":"Done","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e5571755440a0b796fdb9ce02bc180f794f64389","unresolved":false,"context_lines":[{"line_number":148,"context_line":"@cliutils.arg("},{"line_number":149,"context_line":"    \u0027-v\u0027, \u0027--connector_id\u0027,"},{"line_number":150,"context_line":"    metavar\u003d\"\u003cconnector id\u003e\","},{"line_number":151,"context_line":"    help\u003d_(\"ID of the Volume connector in the specified type.\"))"},{"line_number":152,"context_line":"@cliutils.arg("},{"line_number":153,"context_line":"    \u0027-u\u0027, \u0027--uuid\u0027,"},{"line_number":154,"context_line":"    metavar\u003d\u0027\u003cuuid\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_c63007a2","line":151,"updated":"2017-07-07 00:46:29.000000000","message":"isn\u0027t this required?","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"df075b0ff8f15543ce8e353e0eacf1929fd72bae","unresolved":false,"context_lines":[{"line_number":148,"context_line":"@cliutils.arg("},{"line_number":149,"context_line":"    \u0027-v\u0027, \u0027--connector_id\u0027,"},{"line_number":150,"context_line":"    metavar\u003d\"\u003cconnector id\u003e\","},{"line_number":151,"context_line":"    help\u003d_(\"ID of the Volume connector in the specified type.\"))"},{"line_number":152,"context_line":"@cliutils.arg("},{"line_number":153,"context_line":"    \u0027-u\u0027, \u0027--uuid\u0027,"},{"line_number":154,"context_line":"    metavar\u003d\u0027\u003cuuid\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_575eb145","line":151,"in_reply_to":"3f1d235d_c63007a2","updated":"2017-07-10 05:23:22.000000000","message":"Done","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e5571755440a0b796fdb9ce02bc180f794f64389","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    volume_connector \u003d cc.volume_connector.create(**fields)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    data \u003d dict([(f, getattr(volume_connector, f, \u0027\u0027)) for f in field_list])"},{"line_number":165,"context_line":"    cliutils.print_dict(data, wrap\u003d72)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"@cliutils.arg(\u0027volume_connector\u0027, metavar\u003d\u0027\u003cvolume connector\u003e\u0027, nargs\u003d\u0027+\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_26cd7b84","line":165,"updated":"2017-07-07 00:46:29.000000000","message":"add \u0027json_flag\u003dargs.json\u0027","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"df075b0ff8f15543ce8e353e0eacf1929fd72bae","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    volume_connector \u003d cc.volume_connector.create(**fields)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    data \u003d dict([(f, getattr(volume_connector, f, \u0027\u0027)) for f in field_list])"},{"line_number":165,"context_line":"    cliutils.print_dict(data, wrap\u003d72)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"@cliutils.arg(\u0027volume_connector\u0027, metavar\u003d\u0027\u003cvolume connector\u003e\u0027, nargs\u003d\u0027+\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_17583954","line":165,"in_reply_to":"3f1d235d_26cd7b84","updated":"2017-07-10 05:23:22.000000000","message":"Done","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e5571755440a0b796fdb9ce02bc180f794f64389","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    \"\"\"Delete a volume connector.\"\"\""},{"line_number":172,"context_line":"    for p in args.volume_connector:"},{"line_number":173,"context_line":"        cc.volume_connector.delete(p)"},{"line_number":174,"context_line":"        print(_(\u0027Deleted volume connector %s\u0027) % p)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"@cliutils.arg(\u0027volume_connector\u0027, metavar\u003d\u0027\u003cvolume connector\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_e6978344","line":174,"updated":"2017-07-07 00:46:29.000000000","message":"take a look at eg portgroup_shell.py to copy/paste; this can be one or more volume connectors, so we should keep track of any that failed to be deleted.","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"df075b0ff8f15543ce8e353e0eacf1929fd72bae","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    \"\"\"Delete a volume connector.\"\"\""},{"line_number":172,"context_line":"    for p in args.volume_connector:"},{"line_number":173,"context_line":"        cc.volume_connector.delete(p)"},{"line_number":174,"context_line":"        print(_(\u0027Deleted volume connector %s\u0027) % p)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"@cliutils.arg(\u0027volume_connector\u0027, metavar\u003d\u0027\u003cvolume connector\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_f7293d9b","line":174,"in_reply_to":"3f1d235d_e6978344","updated":"2017-07-10 05:23:22.000000000","message":"Done","commit_id":"79eb113221ae2a339f935c92ef6491b3ff94bd50"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2a3ab75c3715c7b822c315d7fba88ba7381e0e7a","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            cc.volume_connector.delete(vc)"},{"line_number":180,"context_line":"            print(_(\u0027Deleted volume connector %s\u0027) % vc)"},{"line_number":181,"context_line":"        except exceptions.ClientException as e:"},{"line_number":182,"context_line":"            failures.append(_(\"Failed to delete volume_connector %(vc)s: \""},{"line_number":183,"context_line":"                              \"%(error)s\")"},{"line_number":184,"context_line":"                            % {\u0027vc\u0027: vc, \u0027error\u0027: e})"},{"line_number":185,"context_line":"    if failures:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_2239923e","line":182,"updated":"2017-07-10 22:05:45.000000000","message":"nit s/volume_connector/volume connector/","commit_id":"7f57080cf6880e1a1fe77934516a660c23e5e576"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"237bab584c5637b36442c513ac876ca3179b2ee5","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            cc.volume_connector.delete(vc)"},{"line_number":180,"context_line":"            print(_(\u0027Deleted volume connector %s\u0027) % vc)"},{"line_number":181,"context_line":"        except exceptions.ClientException as e:"},{"line_number":182,"context_line":"            failures.append(_(\"Failed to delete volume_connector %(vc)s: \""},{"line_number":183,"context_line":"                              \"%(error)s\")"},{"line_number":184,"context_line":"                            % {\u0027vc\u0027: vc, \u0027error\u0027: e})"},{"line_number":185,"context_line":"    if failures:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_12d6b628","line":182,"in_reply_to":"3f1d235d_2239923e","updated":"2017-07-12 02:46:50.000000000","message":"Done","commit_id":"7f57080cf6880e1a1fe77934516a660c23e5e576"}],"releasenotes/notes/add-volume-connector-support-873090474d5e41b8.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2a3ab75c3715c7b822c315d7fba88ba7381e0e7a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * ``client.volume_connector.update`` for updating a volume connector"},{"line_number":11,"context_line":"    * ``client.volume_connector.delete``  for deleting a volume connector"},{"line_number":12,"context_line":"    * ``client.node.list_volume_connectors`` for getting volume connectors"},{"line_number":13,"context_line":"      associated with a node"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    Also adds these OpenStackClient commands for volume connector resources:"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f1d235d_029216f7","line":13,"updated":"2017-07-10 22:05:45.000000000","message":"Julia is planning on doing a client release with the above sometime this week. I don\u0027t think the rest will get in. So leave that alone in a separate reno.","commit_id":"7f57080cf6880e1a1fe77934516a660c23e5e576"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"237bab584c5637b36442c513ac876ca3179b2ee5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * ``client.volume_connector.update`` for updating a volume connector"},{"line_number":11,"context_line":"    * ``client.volume_connector.delete``  for deleting a volume connector"},{"line_number":12,"context_line":"    * ``client.node.list_volume_connectors`` for getting volume connectors"},{"line_number":13,"context_line":"      associated with a node"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    Also adds these OpenStackClient commands for volume connector resources:"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f1d235d_52baee09","line":13,"in_reply_to":"3f1d235d_029216f7","updated":"2017-07-12 02:46:50.000000000","message":"Done","commit_id":"7f57080cf6880e1a1fe77934516a660c23e5e576"}]}