)]}'
{"ironicclient/tests/unit/v1/test_volume_target_shell.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8cce4c74e002c9dfa9574eb62a6f80ff097859be","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import ironicclient.v1.volume_target_shell as vt_shell"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class Volume_TargetShellTest(utils.BaseTestCase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_volume_target_show(self):"},{"line_number":29,"context_line":"        actual \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_f2d45dbf","line":26,"range":{"start_line":26,"start_character":12,"end_line":26,"end_character":13},"updated":"2017-07-14 20:22:21.000000000","message":"Nit: I\u0027m also going to nit the underscore in the class name.  Please remove if you push another revision.","commit_id":"1a5a04102ee3494555db39e12ff27ef6a4b79f0b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cd0ce29b729311bcc622139037c1f02184f54d55","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import ironicclient.v1.volume_target_shell as vt_shell"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class Volume_TargetShellTest(utils.BaseTestCase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_volume_target_show(self):"},{"line_number":29,"context_line":"        actual \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_dee822e3","line":26,"range":{"start_line":26,"start_character":12,"end_line":26,"end_character":13},"in_reply_to":"1f1a1f67_f2d45dbf","updated":"2017-07-17 15:04:02.000000000","message":"This is a funny one. \u0027Volume_Target\u0027 is consistent with the name of the file and all the internal names that refer to \u0027volume_target\u0027 so I\u0027m good either way :)\n\nbut I think I\u0027ve seen two people mention it as a nit.","commit_id":"1a5a04102ee3494555db39e12ff27ef6a4b79f0b"}],"ironicclient/v1/node_shell.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fa358958dd897082e3609f32d801b4c5cc2e8a83","unresolved":false,"context_lines":[{"line_number":478,"context_line":"    help\u003d_(\"One or more volume target fields. Only these fields will be \""},{"line_number":479,"context_line":"           \"fetched from the server. Can not be used when \u0027--detail\u0027 is \""},{"line_number":480,"context_line":"           \"specified.\"))"},{"line_number":481,"context_line":"def do_node_volume_target_list(cc, args):"},{"line_number":482,"context_line":"    \"\"\"List the volume targets associated with a node.\"\"\""},{"line_number":483,"context_line":"    if args.detail:"},{"line_number":484,"context_line":"        fields \u003d res_fields.VOLUME_TARGET_DETAILED_RESOURCE.fields"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_cb4b50ae","line":481,"updated":"2017-07-12 14:29:06.000000000","message":"OH. I just looked at the spec and it mentions this. However, we didn\u0027t add a do_node_volume_connector_list().\n\nGiven that the plan is to deprecate the ironic commands in Queens, and I see we don\u0027t have a do_node_portgroup_list() either, I would prefer not to include this. What do others think?","commit_id":"a8639b8fb0f5d6c77d21ed3f0370ffa7dc28a14d"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"820abe16e2be0371762222a7b0892dead0366e68","unresolved":false,"context_lines":[{"line_number":478,"context_line":"    help\u003d_(\"One or more volume target fields. Only these fields will be \""},{"line_number":479,"context_line":"           \"fetched from the server. Can not be used when \u0027--detail\u0027 is \""},{"line_number":480,"context_line":"           \"specified.\"))"},{"line_number":481,"context_line":"def do_node_volume_target_list(cc, args):"},{"line_number":482,"context_line":"    \"\"\"List the volume targets associated with a node.\"\"\""},{"line_number":483,"context_line":"    if args.detail:"},{"line_number":484,"context_line":"        fields \u003d res_fields.VOLUME_TARGET_DETAILED_RESOURCE.fields"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_e1e148fe","line":481,"in_reply_to":"1f1a1f67_cb4b50ae","updated":"2017-07-14 05:03:59.000000000","message":"I agree that we don\u0027t have do_node_volume_target_list.\nThough I removed do_node_volume_connector_list initially implemented, I\u0027m afraid I forgot to remove from volume target.\n\nThank you for pointing it out.","commit_id":"a8639b8fb0f5d6c77d21ed3f0370ffa7dc28a14d"}],"ironicclient/v1/volume_target_shell.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fa358958dd897082e3609f32d801b4c5cc2e8a83","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    \u0027-p\u0027, \u0027--properties\u0027,"},{"line_number":148,"context_line":"    metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":149,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":150,"context_line":"    help\u003d_(\"Properties of the Volume target in the specified type.\"))"},{"line_number":151,"context_line":"@cliutils.arg("},{"line_number":152,"context_line":"    \u0027-b\u0027, \u0027--boot_index\u0027,"},{"line_number":153,"context_line":"    metavar\u003d\"\u003cboot_index\u003e\","}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_ab4b7485","line":150,"updated":"2017-07-12 14:29:06.000000000","message":"nit s/Volume/volume/\n\nActually, we should probably make this more consistent with the other commands that have --properties. eg\n\nKey/value property related to the type of this volume target. Can be specified multiple times.","commit_id":"a8639b8fb0f5d6c77d21ed3f0370ffa7dc28a14d"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"820abe16e2be0371762222a7b0892dead0366e68","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    \u0027-p\u0027, \u0027--properties\u0027,"},{"line_number":148,"context_line":"    metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":149,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":150,"context_line":"    help\u003d_(\"Properties of the Volume target in the specified type.\"))"},{"line_number":151,"context_line":"@cliutils.arg("},{"line_number":152,"context_line":"    \u0027-b\u0027, \u0027--boot_index\u0027,"},{"line_number":153,"context_line":"    metavar\u003d\"\u003cboot_index\u003e\","}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_9679b8fd","line":150,"in_reply_to":"1f1a1f67_ab4b7485","updated":"2017-07-14 05:03:59.000000000","message":"Done","commit_id":"a8639b8fb0f5d6c77d21ed3f0370ffa7dc28a14d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fa358958dd897082e3609f32d801b4c5cc2e8a83","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    \u0027-i\u0027, \u0027--volume_id\u0027,"},{"line_number":158,"context_line":"    metavar\u003d\"\u003cvolume_id\u003e\","},{"line_number":159,"context_line":"    required\u003dTrue,"},{"line_number":160,"context_line":"    help\u003d_(\"ID of the Volume associated with this target.\"))"},{"line_number":161,"context_line":"@cliutils.arg("},{"line_number":162,"context_line":"    \u0027-u\u0027, \u0027--uuid\u0027,"},{"line_number":163,"context_line":"    metavar\u003d\u0027\u003cuuid\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_cb55901f","line":160,"updated":"2017-07-12 14:29:06.000000000","message":"nit s/Volume/volume/","commit_id":"a8639b8fb0f5d6c77d21ed3f0370ffa7dc28a14d"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"820abe16e2be0371762222a7b0892dead0366e68","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    \u0027-i\u0027, \u0027--volume_id\u0027,"},{"line_number":158,"context_line":"    metavar\u003d\"\u003cvolume_id\u003e\","},{"line_number":159,"context_line":"    required\u003dTrue,"},{"line_number":160,"context_line":"    help\u003d_(\"ID of the Volume associated with this target.\"))"},{"line_number":161,"context_line":"@cliutils.arg("},{"line_number":162,"context_line":"    \u0027-u\u0027, \u0027--uuid\u0027,"},{"line_number":163,"context_line":"    metavar\u003d\u0027\u003cuuid\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_b61cb4c1","line":160,"in_reply_to":"1f1a1f67_cb55901f","updated":"2017-07-14 05:03:59.000000000","message":"Done","commit_id":"a8639b8fb0f5d6c77d21ed3f0370ffa7dc28a14d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cd0ce29b729311bcc622139037c1f02184f54d55","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    help\u003d_(\u0027UUID of the node that this volume target belongs to.\u0027))"},{"line_number":141,"context_line":"@cliutils.arg("},{"line_number":142,"context_line":"    \u0027-t\u0027, \u0027--type\u0027,"},{"line_number":143,"context_line":"    metavar\u003d\"\u003cvolume type\u003e\","},{"line_number":144,"context_line":"    required\u003dTrue,"},{"line_number":145,"context_line":"    help\u003d_(\"Type of the volume target, e.g. \u0027iscsi\u0027, \u0027fibre_channel\u0027, \u0027rbd\u0027.\"))"},{"line_number":146,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_5e8c1235","line":143,"updated":"2017-07-17 15:04:02.000000000","message":"nit. hmm, since you changed it to --type, I wonder if it would be better as s/volume type/type/","commit_id":"1a5a04102ee3494555db39e12ff27ef6a4b79f0b"}],"releasenotes/notes/add-volume-target-cli-e062303f4b3b40ef.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fa358958dd897082e3609f32d801b4c5cc2e8a83","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds these Ironic CLI commands for volume taraget resources:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * ``ironic volume-taraget-create``"},{"line_number":7,"context_line":"    * ``ironic volume-taraget-list``"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f1a1f67_d003fd0e","line":4,"updated":"2017-07-12 14:29:06.000000000","message":"oops, s/taraget/target/\n\nsame thing for all the lines below :-(","commit_id":"a8639b8fb0f5d6c77d21ed3f0370ffa7dc28a14d"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"820abe16e2be0371762222a7b0892dead0366e68","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds these Ironic CLI commands for volume taraget resources:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * ``ironic volume-taraget-create``"},{"line_number":7,"context_line":"    * ``ironic volume-taraget-list``"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f1a1f67_56b680fc","line":4,"in_reply_to":"1f1a1f67_d003fd0e","updated":"2017-07-14 05:03:59.000000000","message":"sorry,,,","commit_id":"a8639b8fb0f5d6c77d21ed3f0370ffa7dc28a14d"}]}