)]}'
{"id":"openstack%2Fpython-ironicclient~481839","triplet_id":"openstack%2Fpython-ironicclient~master~Icb2f8d10161ba3658deb065332cb9567a1f91e11","project":"openstack/python-ironicclient","branch":"master","topic":"bug/1526231","hashtags":[],"change_id":"Icb2f8d10161ba3658deb065332cb9567a1f91e11","subject":"Fix unit tests for volume connector and target","status":"MERGED","created":"2017-07-08 16:11:40.000000000","updated":"2017-07-10 16:21:15.000000000","submitted":"2017-07-10 16:21:15.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8b9e18d68142f911970c825fed9a52c37feb1432","_number":481839,"virtual_id_number":481839,"owner":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-07-10 16:21:15.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-07-10 07:28:18.000000000","_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":2,"date":"2017-07-10 15:17:27.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":1,"date":"2017-07-10 15:17:27.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-07-10 07:28:18.000000000","updated_by":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"reviewer":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"state":"REVIEWER"},{"updated":"2017-07-10 15:17:27.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2017-07-10 16:21:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8376d95baed62f83e713e783bc0145123b7453c6","author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"date":"2017-07-08 16:11:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8adea347287b77dabe76841c1f368b74c0eec0fb","author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"date":"2017-07-08 16:21:55.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a9c493979c835ef12522f6ca11d79024e4a8cbbd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-08 16:47:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python35 http://logs.openstack.org/39/481839/2/check/gate-python-ironicclient-python35/6c46319/ : SUCCESS in 3m 25s\n- gate-python-ironicclient-docs-ubuntu-xenial http://docs-draft.openstack.org/39/481839/2/check/gate-python-ironicclient-docs-ubuntu-xenial/74e6b99//doc/build/html/ : SUCCESS in 2m 38s\n- gate-python-ironicclient-pep8-ubuntu-xenial http://logs.openstack.org/39/481839/2/check/gate-python-ironicclient-pep8-ubuntu-xenial/99955bf/ : SUCCESS in 2m 44s\n- gate-python-ironicclient-python27-ubuntu-xenial http://logs.openstack.org/39/481839/2/check/gate-python-ironicclient-python27-ubuntu-xenial/6515c1f/ : SUCCESS in 3m 52s\n- gate-python-ironicclient-pypy http://logs.openstack.org/39/481839/2/check/gate-python-ironicclient-pypy/5812029/ : FAILURE in 3m 06s (non-voting)\n- check-osc-plugins http://logs.openstack.org/39/481839/2/check/check-osc-plugins/13d092d/ : SUCCESS in 3m 11s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial http://logs.openstack.org/39/481839/2/check/gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial/230dd73/ : SUCCESS in 25m 01s\n- gate-ironicclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/39/481839/2/check/gate-ironicclient-dsvm-functional-ubuntu-xenial/83c5bdb/ : SUCCESS in 19m 53s\n- python-ironicclient-coverage-ubuntu-xenial http://logs.openstack.org/39/481839/2/check/python-ironicclient-coverage-ubuntu-xenial/f8227d2/ : SUCCESS in 3m 35s","accounts_in_message":[],"_revision_number":2},{"id":"c780a5a1f26468437a1dcf90bca3d59b90a751a2","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2017-07-10 07:28:18.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks Hironori!","accounts_in_message":[],"_revision_number":2},{"id":"ee915375c693d982e612f8a896d880eee1a87805","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2017-07-10 15:17:27.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nThanks.","accounts_in_message":[],"_revision_number":2},{"id":"de0e05101541ea6894296d27057611dd468d1917","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-10 15:28:43.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"2c4a594ee2d8edf6d0491eaed324e36f4146d8f7","date":"2017-07-10 16:21:15.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"81974d18a53fc75a60f6b2034b60ec07ad985a61","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-10 16:21:15.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-ironicclient-python35 http://logs.openstack.org/39/481839/2/gate/gate-python-ironicclient-python35/83b7661/ : SUCCESS in 2m 48s\n- gate-python-ironicclient-docs-ubuntu-xenial http://docs-draft.openstack.org/39/481839/2/gate/gate-python-ironicclient-docs-ubuntu-xenial/523f801//doc/build/html/ : SUCCESS in 5m 46s\n- gate-python-ironicclient-pep8-ubuntu-xenial http://logs.openstack.org/39/481839/2/gate/gate-python-ironicclient-pep8-ubuntu-xenial/2915b92/ : SUCCESS in 3m 10s\n- gate-python-ironicclient-python27-ubuntu-xenial http://logs.openstack.org/39/481839/2/gate/gate-python-ironicclient-python27-ubuntu-xenial/3c1478f/ : SUCCESS in 3m 31s\n- gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial http://logs.openstack.org/39/481839/2/gate/gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial/03b7ad6/ : SUCCESS in 45m 08s\n- gate-ironicclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/39/481839/2/gate/gate-ironicclient-dsvm-functional-ubuntu-xenial/d3300e0/ : SUCCESS in 12m 04s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d6c12241a40a4c8da9d1b111aebd7e96acb5f57c","revisions":{"dabdd277341f4171f46c694f912b35ae835b090c":{"kind":"REWORK","_number":1,"created":"2017-07-08 16:11:40.000000000","uploader":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"ref":"refs/changes/39/481839/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/39/481839/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/39/481839/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/39/481839/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/39/481839/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/39/481839/1"}}},"commit":{"parents":[{"commit":"7fe3ad1f11ee40124b631a3108a2e639c13acd3d","subject":"Merge \"Add volume target support to Python API\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/7fe3ad1f11ee40124b631a3108a2e639c13acd3d"}]}],"author":{"name":"Hironori Shiina","email":"shiina.hironori@jp.fujitsu.com","date":"2017-07-08 16:04:19.000000000","tz":540},"committer":{"name":"Hironori Shiina","email":"shiina.hironori@jp.fujitsu.com","date":"2017-07-08 16:04:19.000000000","tz":540},"subject":"Fix unit tests for volume connector and target","message":"Fix unit tests for volume connector and target\n\nThis patch fixes a few issues in unit tests for volume connector and\ntarget as follow-up for these pathces:\n  - I485595b081b2c1c9f9bdf55382d06dd275784fad\n  - I2347d0893abc2b1ccdea1ad6e794217b168a54c5\n\nThis patch incudes:\n  - fix overindent in _validate_obj() method in each test\n  - fix pagination tests\n  - split a test class based on fake response\n\nChange-Id: Icb2f8d10161ba3658deb065332cb9567a1f91e11\nPartial-Bug: 1526231\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/dabdd277341f4171f46c694f912b35ae835b090c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/dabdd277341f4171f46c694f912b35ae835b090c"}]},"branch":"refs/heads/master"},"d6c12241a40a4c8da9d1b111aebd7e96acb5f57c":{"kind":"REWORK","_number":2,"created":"2017-07-08 16:21:55.000000000","uploader":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"ref":"refs/changes/39/481839/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/39/481839/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/39/481839/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/39/481839/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/39/481839/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/39/481839/2"}}},"commit":{"parents":[{"commit":"7fe3ad1f11ee40124b631a3108a2e639c13acd3d","subject":"Merge \"Add volume target support to Python API\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/7fe3ad1f11ee40124b631a3108a2e639c13acd3d"}]}],"author":{"name":"Hironori Shiina","email":"shiina.hironori@jp.fujitsu.com","date":"2017-07-08 16:04:19.000000000","tz":540},"committer":{"name":"Hironori Shiina","email":"shiina.hironori@jp.fujitsu.com","date":"2017-07-08 16:21:34.000000000","tz":540},"subject":"Fix unit tests for volume connector and target","message":"Fix unit tests for volume connector and target\n\nThis patch fixes a few issues in unit tests for volume connector and\ntarget as follow-up for these pathces:\n  - I485595b081b2c1c9f9bdf55382d06dd275784fad\n  - I2347d0893abc2b1ccdea1ad6e794217b168a54c5\n\nThis patch incudes:\n  - fix overindent in _validate_obj() method in each test\n  - fix pagination tests\n  - split a test class based on fake response\n\nChange-Id: Icb2f8d10161ba3658deb065332cb9567a1f91e11\nPartial-Bug: 1526231\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/d6c12241a40a4c8da9d1b111aebd7e96acb5f57c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/d6c12241a40a4c8da9d1b111aebd7e96acb5f57c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}