)]}'
{"ironicclient/shell.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"250b80859007116573828a7a99c0ff839b43e394","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from ironicclient import exc"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":42,"context_line":"LATEST_API_VERSION \u003d (\u00271\u0027, \u0027latest\u0027)"},{"line_number":43,"context_line":"MISSING_VERSION_WARNING \u003d ("},{"line_number":44,"context_line":"    \"You are using the default API version of the \u0027ironic\u0027 command \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_7cac36ec","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":3},"updated":"2017-07-19 05:53:51.000000000","message":"The logging has to be configured before use, otherwise it will complain about\n\n    No handlers could be found for logger \"ironicclient.shell\"\n\nand the message does not output to terminal","commit_id":"0b1de6c2fb19dddc12d96d8eee5ad19964cd7dd5"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"250b80859007116573828a7a99c0ff839b43e394","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    def _check_version(self, api_version):"},{"line_number":302,"context_line":"        if api_version \u003d\u003d \u0027latest\u0027:"},{"line_number":303,"context_line":"            return LATEST_API_VERSION"},{"line_number":304,"context_line":"        else:"},{"line_number":305,"context_line":"            if api_version is None:"},{"line_number":306,"context_line":"                LOG.warning(MISSING_VERSION_WARNING, http.DEFAULT_VER)"},{"line_number":307,"context_line":"                api_version \u003d \u00271\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_c936ee51","line":304,"range":{"start_line":304,"start_character":8,"end_line":304,"end_character":13},"updated":"2017-07-19 05:53:51.000000000","message":"the code would be looking better if we can remove this else.","commit_id":"0b1de6c2fb19dddc12d96d8eee5ad19964cd7dd5"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"8bcaeba84d51f7d174da1267f1a0ae5b0033db80","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            return LATEST_API_VERSION"},{"line_number":303,"context_line":"        else:"},{"line_number":304,"context_line":"            if api_version is None:"},{"line_number":305,"context_line":"                print(MISSING_VERSION_WARNING % http.DEFAULT_VER,"},{"line_number":306,"context_line":"                      file\u003dsys.stderr)"},{"line_number":307,"context_line":"                api_version \u003d \u00271\u0027"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_b2abc073","line":306,"range":{"start_line":305,"start_character":16,"end_line":306,"end_character":38},"updated":"2017-07-21 08:42:34.000000000","message":"it\u0027s not compatible with python27, but the gate job passed, weird.","commit_id":"c39dace27982bc30ba27bc6c2beefa2b698b4d11"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4d9ea84bfc4dfbda6bdab85e4c5e72be25c329fc","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            return LATEST_API_VERSION"},{"line_number":303,"context_line":"        else:"},{"line_number":304,"context_line":"            if api_version is None:"},{"line_number":305,"context_line":"                print(MISSING_VERSION_WARNING % http.DEFAULT_VER,"},{"line_number":306,"context_line":"                      file\u003dsys.stderr)"},{"line_number":307,"context_line":"                api_version \u003d \u00271\u0027"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_d2207cb3","line":306,"range":{"start_line":305,"start_character":16,"end_line":306,"end_character":38},"in_reply_to":"1f1a1f67_b2abc073","updated":"2017-07-21 08:49:02.000000000","message":"We use from __future__ import print_function in this file, so it is compatible","commit_id":"c39dace27982bc30ba27bc6c2beefa2b698b4d11"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b80667c6b6d2ce6bc24072f8d8bbd6e3c919fe2c","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"LATEST_API_VERSION \u003d (\u00271\u0027, \u0027latest\u0027)"},{"line_number":42,"context_line":"MISSING_VERSION_WARNING \u003d ("},{"line_number":43,"context_line":"    \"You are using the default API version of the \u0027ironic\u0027 command \""},{"line_number":44,"context_line":"    \"This is currently API version %s. In the future, the default will be \""},{"line_number":45,"context_line":"    \"the latest API version understood by both API and CLI. You can preserve \""},{"line_number":46,"context_line":"    \"the current behavior by passing the --ironic-api-version argument with \""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_bcaee72b","line":43,"updated":"2017-07-24 15:48:11.000000000","message":"s/command/command./","commit_id":"cdae0fb0450850c9996c2e1fee784832f4507fe7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b80667c6b6d2ce6bc24072f8d8bbd6e3c919fe2c","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                                 default\u003dNone),"},{"line_number":165,"context_line":"                            help\u003d_(\u0027Accepts 1.x (where \"x\" is microversion) \u0027"},{"line_number":166,"context_line":"                                   \u0027or \"latest\", Defaults to \u0027"},{"line_number":167,"context_line":"                                   \u0027env[IRONIC_API_VERSION] or 1\u0027))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        parser.add_argument(\u0027--ironic_api_version\u0027,"},{"line_number":170,"context_line":"                            help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_1c46137e","line":167,"updated":"2017-07-24 15:48:11.000000000","message":"nit. we want them to specify this, right? Probably not worth changing now, but it seems to me that it would be more accurate to say \u0027Defaults to env[..] or 1.9 (which will change in Queens to be latest version...).","commit_id":"cdae0fb0450850c9996c2e1fee784832f4507fe7"}],"ironicclient/tests/functional/test_help_msg.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"8bcaeba84d51f7d174da1267f1a0ae5b0033db80","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        result \u003d self._ironic(\u0027help\u0027, merge_stderr\u003dTrue)"},{"line_number":73,"context_line":"        self.assertIn(\u0027You are using the default API version\u0027, result)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        result \u003d self._ironic(\u0027help\u0027, params\u003d\u0027--ironic-api-version 1.9\u0027,"},{"line_number":76,"context_line":"                              merge_stderr\u003dTrue)"},{"line_number":77,"context_line":"        self.assertNotIn(\u0027You are using the default API version\u0027, result)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_727888f7","line":75,"range":{"start_line":75,"start_character":38,"end_line":75,"end_character":71},"updated":"2017-07-21 08:42:34.000000000","message":"this param will be placed after subcommand, so that is why dvsm gate job fails","commit_id":"c39dace27982bc30ba27bc6c2beefa2b698b4d11"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4d9ea84bfc4dfbda6bdab85e4c5e72be25c329fc","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        result \u003d self._ironic(\u0027help\u0027, merge_stderr\u003dTrue)"},{"line_number":73,"context_line":"        self.assertIn(\u0027You are using the default API version\u0027, result)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        result \u003d self._ironic(\u0027help\u0027, params\u003d\u0027--ironic-api-version 1.9\u0027,"},{"line_number":76,"context_line":"                              merge_stderr\u003dTrue)"},{"line_number":77,"context_line":"        self.assertNotIn(\u0027You are using the default API version\u0027, result)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_32133069","line":75,"range":{"start_line":75,"start_character":38,"end_line":75,"end_character":71},"in_reply_to":"1f1a1f67_727888f7","updated":"2017-07-21 08:49:02.000000000","message":"right, I suspect I should use flags","commit_id":"c39dace27982bc30ba27bc6c2beefa2b698b4d11"}]}