)]}'
{"ironicclient/osc/v1/baremetal_create.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"69c447bb2e6e9e011fcb58f2000bf7189852740e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        parser \u003d super(CreateBaremetal, self).get_parser(prog_name)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        parser.add_argument("},{"line_number":37,"context_line":"            \"resource_files\", metavar\u003d\"\u003cfile\u003e\", default\u003d[], nargs\u003d\"*\","},{"line_number":38,"context_line":"            help\u003d_(\"File (.yaml or .json) containing descriptions of the \""},{"line_number":39,"context_line":"                   \"resources to create. Can be specified multiple times. If \""},{"line_number":40,"context_line":"                   \"you want to create resources, only specify the files. Do \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_8515824b","line":37,"updated":"2017-09-08 09:37:21.000000000","message":"let\u0027s remove default now","commit_id":"3b579443ca2b813c2caebec48800c0868780f4a0"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0ef86d4ed879c663abcda2b460261d4f24ce039a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        parser \u003d super(CreateBaremetal, self).get_parser(prog_name)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        parser.add_argument("},{"line_number":37,"context_line":"            \"resource_files\", metavar\u003d\"\u003cfile\u003e\", default\u003d[], nargs\u003d\"*\","},{"line_number":38,"context_line":"            help\u003d_(\"File (.yaml or .json) containing descriptions of the \""},{"line_number":39,"context_line":"                   \"resources to create. Can be specified multiple times. If \""},{"line_number":40,"context_line":"                   \"you want to create resources, only specify the files. Do \""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_bb4baaae","line":37,"in_reply_to":"7f287b81_8515824b","updated":"2017-09-09 06:53:58.000000000","message":"Done","commit_id":"3b579443ca2b813c2caebec48800c0868780f4a0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"69c447bb2e6e9e011fcb58f2000bf7189852740e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if not parsed_args.resource_files:"},{"line_number":46,"context_line":"            raise exc.ValidationError(_(\"One or more .json or .yaml files \""},{"line_number":47,"context_line":"                                        \"are required to create ironic \""},{"line_number":48,"context_line":"                                        \"resources.\"))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        create_resources.create_resources(self.app.client_manager.baremetal,"},{"line_number":51,"context_line":"                                          parsed_args.resource_files)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_650e163c","line":48,"updated":"2017-09-08 09:37:21.000000000","message":"this is not needed, I think, if we remove the default","commit_id":"3b579443ca2b813c2caebec48800c0868780f4a0"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0ef86d4ed879c663abcda2b460261d4f24ce039a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if not parsed_args.resource_files:"},{"line_number":46,"context_line":"            raise exc.ValidationError(_(\"One or more .json or .yaml files \""},{"line_number":47,"context_line":"                                        \"are required to create ironic \""},{"line_number":48,"context_line":"                                        \"resources.\"))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        create_resources.create_resources(self.app.client_manager.baremetal,"},{"line_number":51,"context_line":"                                          parsed_args.resource_files)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_9befce86","line":48,"in_reply_to":"7f287b81_650e163c","updated":"2017-09-09 06:53:58.000000000","message":"Actually, remove default\u003d[] from L37 does not change default value, because we used nargs\u003d\u0027*\u0027, the default result is an empty list if nothing is given.\nI\u0027d like to make sure if we want remove this assertion, because users will not get any output if he does not provide filenames, create_resources silently do nothing for an empty list. I prefer to keep it, wdyt?","commit_id":"3b579443ca2b813c2caebec48800c0868780f4a0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3b275dda7c61fd1804a40df00bc6b3ca8b0d3411","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        parser \u003d super(CreateBaremetal, self).get_parser(prog_name)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        parser.add_argument("},{"line_number":37,"context_line":"            \"resource_files\", metavar\u003d\"\u003cfile\u003e\", nargs\u003d\"*\","},{"line_number":38,"context_line":"            help\u003d_(\"File (.yaml or .json) containing descriptions of the \""},{"line_number":39,"context_line":"                   \"resources to create. Can be specified multiple times. If \""},{"line_number":40,"context_line":"                   \"you want to create resources, only specify the files. Do \""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_3b97b993","line":37,"updated":"2017-09-09 07:57:38.000000000","message":"Good point about the default. Then just change nargs\u003d\"*\" to nargs\u003d\"+\", and at least one file will be required. An explicit check still should not be needed.","commit_id":"4562fd382f05f3de9170f2568eb4d986723332b6"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"37b325141d3c437f5acc5ac75a43484918f74f9d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        parser \u003d super(CreateBaremetal, self).get_parser(prog_name)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        parser.add_argument("},{"line_number":37,"context_line":"            \"resource_files\", metavar\u003d\"\u003cfile\u003e\", nargs\u003d\"*\","},{"line_number":38,"context_line":"            help\u003d_(\"File (.yaml or .json) containing descriptions of the \""},{"line_number":39,"context_line":"                   \"resources to create. Can be specified multiple times. If \""},{"line_number":40,"context_line":"                   \"you want to create resources, only specify the files. Do \""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_9b3b4d9b","line":37,"in_reply_to":"5f2577a7_3b97b993","updated":"2017-09-09 08:09:35.000000000","message":"Done","commit_id":"4562fd382f05f3de9170f2568eb4d986723332b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8d5d5ef35e992a40319def033925c565bbd1e1e5","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class CreateBaremetal(command.Command):"},{"line_number":22,"context_line":"    \"\"\"Create resources from files."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Create resources from files (by only specifying the files)."},{"line_number":25,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_9d7e6669","line":22,"updated":"2017-09-12 21:25:44.000000000","message":"Just delete the lines after this, and change this to (note, no period at the end since that seems to be what we\u0027ve done for most of the other classes):\n\n\"\"\"Create resources from files\"\"\"","commit_id":"fbd3fa902d7b1b324990a30017842a440c6f01d9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"18c514f95a1b0467b7dd546f5d727b596eb8d802","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class CreateBaremetal(command.Command):"},{"line_number":22,"context_line":"    \"\"\"Create resources from files."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Create resources from files (by only specifying the files)."},{"line_number":25,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_c86e6195","line":22,"in_reply_to":"5f2577a7_9d7e6669","updated":"2017-09-13 01:16:22.000000000","message":"Done","commit_id":"fbd3fa902d7b1b324990a30017842a440c6f01d9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a19bd63f81f6bf26451f047769cca13cbffec3ce","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class CreateBaremetal(command.Command):"},{"line_number":22,"context_line":"    \"\"\"Create resources from files."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Create resources from files (by only specifying the files)."},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateBaremetal\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_a20fbfdf","line":24,"updated":"2017-09-12 21:16:44.000000000","message":"the \u0027(by only specifying the files)\u0027 was there to distinguish it from the other use of this command. We should delete it.","commit_id":"fbd3fa902d7b1b324990a30017842a440c6f01d9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"18c514f95a1b0467b7dd546f5d727b596eb8d802","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class CreateBaremetal(command.Command):"},{"line_number":22,"context_line":"    \"\"\"Create resources from files."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Create resources from files (by only specifying the files)."},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateBaremetal\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_280f25e2","line":24,"in_reply_to":"5f2577a7_a20fbfdf","updated":"2017-09-13 01:16:22.000000000","message":"Done","commit_id":"fbd3fa902d7b1b324990a30017842a440c6f01d9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a19bd63f81f6bf26451f047769cca13cbffec3ce","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateBaremetal\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def get_description(self):"},{"line_number":30,"context_line":"        return _(\"Create resources from files (by only specifying the files)\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_parser(self, prog_name):"},{"line_number":33,"context_line":"        parser \u003d super(CreateBaremetal, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_221cef10","line":30,"updated":"2017-09-12 21:16:44.000000000","message":"ditto. The \u0027resource_files\u0027 argument below will be mentioned in the help, so no need to have it mentioned here.","commit_id":"fbd3fa902d7b1b324990a30017842a440c6f01d9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8d5d5ef35e992a40319def033925c565bbd1e1e5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateBaremetal\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def get_description(self):"},{"line_number":30,"context_line":"        return _(\"Create resources from files (by only specifying the files)\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_parser(self, prog_name):"},{"line_number":33,"context_line":"        parser \u003d super(CreateBaremetal, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_9da54607","line":30,"in_reply_to":"5f2577a7_221cef10","updated":"2017-09-12 21:25:44.000000000","message":"Actually we can delete this entire method. The default (if this isn\u0027t here), is to use the first line of the docstring (ie, L22).","commit_id":"fbd3fa902d7b1b324990a30017842a440c6f01d9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"18c514f95a1b0467b7dd546f5d727b596eb8d802","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateBaremetal\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def get_description(self):"},{"line_number":30,"context_line":"        return _(\"Create resources from files (by only specifying the files)\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_parser(self, prog_name):"},{"line_number":33,"context_line":"        parser \u003d super(CreateBaremetal, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_a84f95bb","line":30,"in_reply_to":"5f2577a7_221cef10","updated":"2017-09-13 01:16:22.000000000","message":"Done","commit_id":"fbd3fa902d7b1b324990a30017842a440c6f01d9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"18c514f95a1b0467b7dd546f5d727b596eb8d802","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateBaremetal\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def get_description(self):"},{"line_number":30,"context_line":"        return _(\"Create resources from files (by only specifying the files)\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_parser(self, prog_name):"},{"line_number":33,"context_line":"        parser \u003d super(CreateBaremetal, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_884a99a9","line":30,"in_reply_to":"5f2577a7_9da54607","updated":"2017-09-13 01:16:22.000000000","message":"Done","commit_id":"fbd3fa902d7b1b324990a30017842a440c6f01d9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a19bd63f81f6bf26451f047769cca13cbffec3ce","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        parser.add_argument("},{"line_number":36,"context_line":"            \"resource_files\", metavar\u003d\"\u003cfile\u003e\", nargs\u003d\"+\","},{"line_number":37,"context_line":"            help\u003d_(\"File (.yaml or .json) containing descriptions of the \""},{"line_number":38,"context_line":"                   \"resources to create. Can be specified multiple times. If \""},{"line_number":39,"context_line":"                   \"you want to create resources, only specify the files. Do \""},{"line_number":40,"context_line":"                   \"not specify any of the optional arguments.\"))"},{"line_number":41,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_e28a6719","line":38,"updated":"2017-09-12 21:16:44.000000000","message":"Everything from \u0027If you want to create resources,...\u0027 should be deleted. That was there to distinguish the use of this cmd for creating resources vs a node.","commit_id":"fbd3fa902d7b1b324990a30017842a440c6f01d9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"18c514f95a1b0467b7dd546f5d727b596eb8d802","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        parser.add_argument("},{"line_number":36,"context_line":"            \"resource_files\", metavar\u003d\"\u003cfile\u003e\", nargs\u003d\"+\","},{"line_number":37,"context_line":"            help\u003d_(\"File (.yaml or .json) containing descriptions of the \""},{"line_number":38,"context_line":"                   \"resources to create. Can be specified multiple times. If \""},{"line_number":39,"context_line":"                   \"you want to create resources, only specify the files. Do \""},{"line_number":40,"context_line":"                   \"not specify any of the optional arguments.\"))"},{"line_number":41,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_48f39174","line":38,"in_reply_to":"5f2577a7_e28a6719","updated":"2017-09-13 01:16:22.000000000","message":"Done","commit_id":"fbd3fa902d7b1b324990a30017842a440c6f01d9"}],"releasenotes/notes/remove-deprecated-osc-cmd-6dc980299d2fbde4.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"69c447bb2e6e9e011fcb58f2000bf7189852740e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed following openstack baremetal commands due to ends of deprecation"},{"line_number":5,"context_line":"    cycle:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ``openstack baremetal delete``"},{"line_number":8,"context_line":"    * ``openstack baremetal list``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f287b81_450b1a29","line":5,"updated":"2017-09-08 09:37:21.000000000","message":"\"The following previously deprecated commands were removed:\"","commit_id":"3b579443ca2b813c2caebec48800c0868780f4a0"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0ef86d4ed879c663abcda2b460261d4f24ce039a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed following openstack baremetal commands due to ends of deprecation"},{"line_number":5,"context_line":"    cycle:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ``openstack baremetal delete``"},{"line_number":8,"context_line":"    * ``openstack baremetal list``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_bb44cab8","line":5,"in_reply_to":"7f287b81_450b1a29","updated":"2017-09-09 06:53:58.000000000","message":"Done","commit_id":"3b579443ca2b813c2caebec48800c0868780f4a0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"69c447bb2e6e9e011fcb58f2000bf7189852740e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * ``openstack baremetal set``"},{"line_number":11,"context_line":"    * ``openstack baremetal unset``"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    Equivalent commands are:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    * ``openstack baremetal node delete``"},{"line_number":16,"context_line":"    * ``openstack baremetal node list``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f287b81_25048e17","line":13,"updated":"2017-09-08 09:37:21.000000000","message":"nit: \"The equivalent\"","commit_id":"3b579443ca2b813c2caebec48800c0868780f4a0"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0ef86d4ed879c663abcda2b460261d4f24ce039a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * ``openstack baremetal set``"},{"line_number":11,"context_line":"    * ``openstack baremetal unset``"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    Equivalent commands are:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    * ``openstack baremetal node delete``"},{"line_number":16,"context_line":"    * ``openstack baremetal node list``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_7b18a2d2","line":13,"in_reply_to":"7f287b81_25048e17","updated":"2017-09-09 06:53:58.000000000","message":"Done","commit_id":"3b579443ca2b813c2caebec48800c0868780f4a0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"69c447bb2e6e9e011fcb58f2000bf7189852740e","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    The support of creating a single node by ``openstack baremetal create``"},{"line_number":22,"context_line":"    is removed, the equivalent command is ``openstack baremetal node create``."},{"line_number":23,"context_line":"    The only valid usage of ``openstack baremetal create`` is to create"},{"line_number":24,"context_line":"    various resources (chassis, node, port, portgroup, etc.) from resource"},{"line_number":25,"context_line":"    file(s)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f287b81_05019206","line":23,"updated":"2017-09-08 09:37:21.000000000","message":"nit: s/is/now is/","commit_id":"3b579443ca2b813c2caebec48800c0868780f4a0"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0ef86d4ed879c663abcda2b460261d4f24ce039a","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    The support of creating a single node by ``openstack baremetal create``"},{"line_number":22,"context_line":"    is removed, the equivalent command is ``openstack baremetal node create``."},{"line_number":23,"context_line":"    The only valid usage of ``openstack baremetal create`` is to create"},{"line_number":24,"context_line":"    various resources (chassis, node, port, portgroup, etc.) from resource"},{"line_number":25,"context_line":"    file(s)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_3b121ab3","line":23,"in_reply_to":"7f287b81_05019206","updated":"2017-09-09 06:53:58.000000000","message":"Done","commit_id":"3b579443ca2b813c2caebec48800c0868780f4a0"}]}