)]}'
{"ironicclient/common/http.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"665f8d99357f44b3766fc6c2a894f6ed0332ac8b","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        if (not self.endpoint_trimmed.endswith(\u0027/\u0027) and"},{"line_number":296,"context_line":"                not url.startswith(\u0027/\u0027)):"},{"line_number":297,"context_line":"            url \u003d \u0027/\u0027 + url"},{"line_number":298,"context_line":"        return self.endpoint_trimmed + url"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def _parse_version_headers(self, resp):"},{"line_number":301,"context_line":"        return self._generic_parse_version_headers(resp.headers.get)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_d6ab9e1b","line":298,"updated":"2017-10-05 21:02:39.000000000","message":"so what if self.endpoint_trimmed.endswith(\u0027/\u0027) and url.startswith(\u0027/\u0027). Are we ok with two \u0027//\u0027 ?\n\nIf we had (more) unit tests for this, with diff values of .endpoint_trimmed \u0026 url, it would help I think.","commit_id":"17ad376288940841fcb37588cd91d9a346906e42"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"8108de8b19b87386fa13bc1d80ff0e04610eeb85","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        if (not self.endpoint_trimmed.endswith(\u0027/\u0027) and"},{"line_number":296,"context_line":"                not url.startswith(\u0027/\u0027)):"},{"line_number":297,"context_line":"            url \u003d \u0027/\u0027 + url"},{"line_number":298,"context_line":"        return self.endpoint_trimmed + url"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def _parse_version_headers(self, resp):"},{"line_number":301,"context_line":"        return self._generic_parse_version_headers(resp.headers.get)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_b264a4e6","line":298,"in_reply_to":"7f515b1d_d6ab9e1b","updated":"2017-10-06 06:26:17.000000000","message":"usually double slash is no problem for servers, however to be on a safe side I\u0027ll trim the trailing / in the endpoint_trimmed right when it is created.","commit_id":"17ad376288940841fcb37588cd91d9a346906e42"}]}