)]}'
{"ironicclient/shell.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cb00ae4c6cdc03dd6e4d81c9a77f32c3a8ec558c","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        commands.remove(\u0027bash-completion\u0027)"},{"line_number":292,"context_line":"        print(\u0027 \u0027.join(commands | options))"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def _check_version(self, api_version):"},{"line_number":295,"context_line":"        if api_version in (\u00271\u0027, \u0027latest\u0027):"},{"line_number":296,"context_line":"            return (1, LATEST_VERSION)"},{"line_number":297,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_0fde2dd9","line":294,"updated":"2017-10-26 17:51:17.000000000","message":"Maybe a doc string on what we expect the return format to be would be good.","commit_id":"995599ceb3ceacb7297016efccda37860cca7a93"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"731448536669cf79659ad7f080a6b07515ee7d27","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        commands.remove(\u0027bash-completion\u0027)"},{"line_number":292,"context_line":"        print(\u0027 \u0027.join(commands | options))"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def _check_version(self, api_version):"},{"line_number":295,"context_line":"        if api_version in (\u00271\u0027, \u0027latest\u0027):"},{"line_number":296,"context_line":"            return (1, LATEST_VERSION)"},{"line_number":297,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_fa87c30e","line":294,"in_reply_to":"3f4b6375_0fde2dd9","updated":"2017-10-30 17:46:41.000000000","message":"Done","commit_id":"995599ceb3ceacb7297016efccda37860cca7a93"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cb00ae4c6cdc03dd6e4d81c9a77f32c3a8ec558c","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def _check_version(self, api_version):"},{"line_number":295,"context_line":"        if api_version in (\u00271\u0027, \u0027latest\u0027):"},{"line_number":296,"context_line":"            return (1, LATEST_VERSION)"},{"line_number":297,"context_line":"        else:"},{"line_number":298,"context_line":"            try:"},{"line_number":299,"context_line":"                versions \u003d tuple(int(i) for i in api_version.split(\u0027.\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_afcf1927","line":296,"range":{"start_line":296,"start_character":20,"end_line":296,"end_character":21},"updated":"2017-10-26 17:51:17.000000000","message":"Should the \u00271\u0027 in (1, LATEST_VERSION) be \u0027api_major_version\u0027 like on line 317?","commit_id":"995599ceb3ceacb7297016efccda37860cca7a93"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"555a292b1663c75da5791af68e6867a531fab293","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def _check_version(self, api_version):"},{"line_number":295,"context_line":"        if api_version in (\u00271\u0027, \u0027latest\u0027):"},{"line_number":296,"context_line":"            return (1, LATEST_VERSION)"},{"line_number":297,"context_line":"        else:"},{"line_number":298,"context_line":"            try:"},{"line_number":299,"context_line":"                versions \u003d tuple(int(i) for i in api_version.split(\u0027.\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_cf1935d7","line":296,"updated":"2017-10-26 17:38:45.000000000","message":"That looks like it will return:\n\n (1, \"1.34\")\n\nWhich doesn\u0027t seem right to me. Am I missing something?","commit_id":"995599ceb3ceacb7297016efccda37860cca7a93"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"916d026ca30edd159312cdcc370362cbaeb98ecd","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def _check_version(self, api_version):"},{"line_number":295,"context_line":"        if api_version in (\u00271\u0027, \u0027latest\u0027):"},{"line_number":296,"context_line":"            return (1, LATEST_VERSION)"},{"line_number":297,"context_line":"        else:"},{"line_number":298,"context_line":"            try:"},{"line_number":299,"context_line":"                versions \u003d tuple(int(i) for i in api_version.split(\u0027.\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_da68d1f5","line":296,"range":{"start_line":296,"start_character":20,"end_line":296,"end_character":21},"in_reply_to":"3f4b6375_afcf1927","updated":"2017-10-26 18:33:10.000000000","message":"Yep, (1, \"1.34\") is what it should return. previously it returned (1, \"latest\")","commit_id":"995599ceb3ceacb7297016efccda37860cca7a93"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c687d4b3c09ec30517bb879dbb6a548a924f9622","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def _check_version(self, api_version):"},{"line_number":295,"context_line":"        if api_version in (\u00271\u0027, \u0027latest\u0027):"},{"line_number":296,"context_line":"            return (1, LATEST_VERSION)"},{"line_number":297,"context_line":"        else:"},{"line_number":298,"context_line":"            try:"},{"line_number":299,"context_line":"                versions \u003d tuple(int(i) for i in api_version.split(\u0027.\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_b5b406f3","line":296,"range":{"start_line":296,"start_character":20,"end_line":296,"end_character":21},"in_reply_to":"3f4b6375_da68d1f5","updated":"2017-10-26 18:56:36.000000000","message":"Okay. Yeah, I looked at the caller. Just seems weird.\n\n/me has thoughts of a namedtuple, but then remembers we are deprecating this code.\n\nAnd never mind about api_major_version comment. I see that comes from below.","commit_id":"995599ceb3ceacb7297016efccda37860cca7a93"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cb00ae4c6cdc03dd6e4d81c9a77f32c3a8ec558c","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            if not versions or len(versions) \u003e 2:"},{"line_number":304,"context_line":"                msg \u003d _(\"The requested API version %(ver)s is an unexpected \""},{"line_number":305,"context_line":"                        \"format. Acceptable formats are \u0027X\u0027, \u0027X.Y\u0027, or the \""},{"line_number":306,"context_line":"                        \"literal string \u0027%(latest)s\u0027.\""},{"line_number":307,"context_line":"                        ) % {\u0027ver\u0027: api_version, \u0027latest\u0027: \u0027latest\u0027}"},{"line_number":308,"context_line":"                raise exc.CommandError(msg)"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_ef9751eb","line":306,"range":{"start_line":306,"start_character":41,"end_line":306,"end_character":53},"updated":"2017-10-26 17:51:17.000000000","message":"not your code, but strange that we use a variable to put in a hard-coded value. Not sure why they didn\u0027t just put in \u0027latest\u0027 here","commit_id":"995599ceb3ceacb7297016efccda37860cca7a93"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"731448536669cf79659ad7f080a6b07515ee7d27","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            if not versions or len(versions) \u003e 2:"},{"line_number":304,"context_line":"                msg \u003d _(\"The requested API version %(ver)s is an unexpected \""},{"line_number":305,"context_line":"                        \"format. Acceptable formats are \u0027X\u0027, \u0027X.Y\u0027, or the \""},{"line_number":306,"context_line":"                        \"literal string \u0027%(latest)s\u0027.\""},{"line_number":307,"context_line":"                        ) % {\u0027ver\u0027: api_version, \u0027latest\u0027: \u0027latest\u0027}"},{"line_number":308,"context_line":"                raise exc.CommandError(msg)"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_daa1a797","line":306,"range":{"start_line":306,"start_character":41,"end_line":306,"end_character":53},"in_reply_to":"3f4b6375_3a7fe5ab","updated":"2017-10-30 17:46:41.000000000","message":"Done","commit_id":"995599ceb3ceacb7297016efccda37860cca7a93"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"916d026ca30edd159312cdcc370362cbaeb98ecd","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            if not versions or len(versions) \u003e 2:"},{"line_number":304,"context_line":"                msg \u003d _(\"The requested API version %(ver)s is an unexpected \""},{"line_number":305,"context_line":"                        \"format. Acceptable formats are \u0027X\u0027, \u0027X.Y\u0027, or the \""},{"line_number":306,"context_line":"                        \"literal string \u0027%(latest)s\u0027.\""},{"line_number":307,"context_line":"                        ) % {\u0027ver\u0027: api_version, \u0027latest\u0027: \u0027latest\u0027}"},{"line_number":308,"context_line":"                raise exc.CommandError(msg)"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_3a7fe5ab","line":306,"range":{"start_line":306,"start_character":41,"end_line":306,"end_character":53},"in_reply_to":"3f4b6375_ef9751eb","updated":"2017-10-26 18:33:10.000000000","message":"lol","commit_id":"995599ceb3ceacb7297016efccda37860cca7a93"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cb00ae4c6cdc03dd6e4d81c9a77f32c3a8ec558c","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                raise exc.CommandError(msg)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"            # In the case of \u00271.0\u0027"},{"line_number":311,"context_line":"            if versions[1] \u003d\u003d 0:"},{"line_number":312,"context_line":"                os_ironic_api_version \u003d None"},{"line_number":313,"context_line":"            else:"},{"line_number":314,"context_line":"                os_ironic_api_version \u003d api_version"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_4f22e5ba","line":311,"updated":"2017-10-26 17:51:17.000000000","message":"Doesn\u0027t this fail if they pass in \u00271\u0027?  Index out of bounds or something.","commit_id":"995599ceb3ceacb7297016efccda37860cca7a93"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"916d026ca30edd159312cdcc370362cbaeb98ecd","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                raise exc.CommandError(msg)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"            # In the case of \u00271.0\u0027"},{"line_number":311,"context_line":"            if versions[1] \u003d\u003d 0:"},{"line_number":312,"context_line":"                os_ironic_api_version \u003d None"},{"line_number":313,"context_line":"            else:"},{"line_number":314,"context_line":"                os_ironic_api_version \u003d api_version"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_7a62fd0b","line":311,"in_reply_to":"3f4b6375_4f22e5ba","updated":"2017-10-26 18:33:10.000000000","message":"\"1\" was filtered out on line 295, but I need to check something like \"2\"","commit_id":"995599ceb3ceacb7297016efccda37860cca7a93"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c687d4b3c09ec30517bb879dbb6a548a924f9622","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                raise exc.CommandError(msg)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"            # In the case of \u00271.0\u0027"},{"line_number":311,"context_line":"            if versions[1] \u003d\u003d 0:"},{"line_number":312,"context_line":"                os_ironic_api_version \u003d None"},{"line_number":313,"context_line":"            else:"},{"line_number":314,"context_line":"                os_ironic_api_version \u003d api_version"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_95b7caf5","line":311,"in_reply_to":"3f4b6375_7a62fd0b","updated":"2017-10-26 18:56:36.000000000","message":"Ah okay. I\u0027ll leave the -1 for this then :)","commit_id":"995599ceb3ceacb7297016efccda37860cca7a93"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"731448536669cf79659ad7f080a6b07515ee7d27","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                raise exc.CommandError(msg)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"            # In the case of \u00271.0\u0027"},{"line_number":311,"context_line":"            if versions[1] \u003d\u003d 0:"},{"line_number":312,"context_line":"                os_ironic_api_version \u003d None"},{"line_number":313,"context_line":"            else:"},{"line_number":314,"context_line":"                os_ironic_api_version \u003d api_version"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_dacf6755","line":311,"in_reply_to":"3f4b6375_95b7caf5","updated":"2017-10-30 17:46:41.000000000","message":"Done","commit_id":"995599ceb3ceacb7297016efccda37860cca7a93"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cb00ae4c6cdc03dd6e4d81c9a77f32c3a8ec558c","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        kwargs[\u0027os_ironic_api_version\u0027] \u003d os_ironic_api_version"},{"line_number":408,"context_line":"        client \u003d ironicclient.client.get_client(api_major_version, **kwargs)"},{"line_number":409,"context_line":"        if options.ironic_api_version in (\u00271\u0027, \u0027latest\u0027):"},{"line_number":410,"context_line":"            # Allow negotiate a lower version, if the latest version supported"},{"line_number":411,"context_line":"            # by the client is higher than the latest version supported by the"},{"line_number":412,"context_line":"            # server."},{"line_number":413,"context_line":"            client.http_client.api_version_select_state \u003d \u0027default\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_8fa0dd43","line":410,"range":{"start_line":410,"start_character":20,"end_line":410,"end_character":29},"updated":"2017-10-26 17:51:17.000000000","message":"s/negotiate/negotiating/","commit_id":"995599ceb3ceacb7297016efccda37860cca7a93"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"731448536669cf79659ad7f080a6b07515ee7d27","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        kwargs[\u0027os_ironic_api_version\u0027] \u003d os_ironic_api_version"},{"line_number":408,"context_line":"        client \u003d ironicclient.client.get_client(api_major_version, **kwargs)"},{"line_number":409,"context_line":"        if options.ironic_api_version in (\u00271\u0027, \u0027latest\u0027):"},{"line_number":410,"context_line":"            # Allow negotiate a lower version, if the latest version supported"},{"line_number":411,"context_line":"            # by the client is higher than the latest version supported by the"},{"line_number":412,"context_line":"            # server."},{"line_number":413,"context_line":"            client.http_client.api_version_select_state \u003d \u0027default\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_9ad9ef23","line":410,"range":{"start_line":410,"start_character":20,"end_line":410,"end_character":29},"in_reply_to":"3f4b6375_8fa0dd43","updated":"2017-10-30 17:46:41.000000000","message":"Done","commit_id":"995599ceb3ceacb7297016efccda37860cca7a93"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8a5d5989a08845e0623ba31e8df800db842a047f","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        \"\"\"Validate the supplied API (micro)version."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        :param api_version: API version as a string (\"1\", \"1.x\" or \"latest\")"},{"line_number":298,"context_line":"        :returns: tuple (major version, version string)"},{"line_number":299,"context_line":"        \"\"\""},{"line_number":300,"context_line":"        if api_version in (\u00271\u0027, \u0027latest\u0027):"},{"line_number":301,"context_line":"            return (1, LATEST_VERSION)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_c45c817e","line":298,"updated":"2017-11-06 20:24:39.000000000","message":"that\u0027s not quite true, or maybe it depends on how you interpret \u0027version string\u0027, but it isn\u0027t worth trying to clarify I don\u0027t think.","commit_id":"28560398fad39a4fb65289d8458340c7d517fd79"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8a5d5989a08845e0623ba31e8df800db842a047f","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                raise exc.CommandError(msg)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"            if versions \u003d\u003d (1, 0):"},{"line_number":316,"context_line":"                os_ironic_api_version \u003d None"},{"line_number":317,"context_line":"            else:"},{"line_number":318,"context_line":"                os_ironic_api_version \u003d api_version"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_84520966","line":316,"updated":"2017-11-06 20:24:39.000000000","message":"Ugh, did we really do this? If you specify 1.1, we request 1.1. But if you specify 1.0, we request 1.9.\n\nGood thing we don\u0027t care.","commit_id":"28560398fad39a4fb65289d8458340c7d517fd79"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"978080be803bf21cf6250d122c6d6f1a46068eff","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                raise exc.CommandError(msg)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"            if versions \u003d\u003d (1, 0):"},{"line_number":316,"context_line":"                os_ironic_api_version \u003d None"},{"line_number":317,"context_line":"            else:"},{"line_number":318,"context_line":"                os_ironic_api_version \u003d api_version"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_d6d42522","line":316,"in_reply_to":"3f4b6375_84520966","updated":"2017-11-07 12:27:08.000000000","message":"Yeah.. I was surprised as well, but decided to just leave it alone.","commit_id":"28560398fad39a4fb65289d8458340c7d517fd79"}],"ironicclient/tests/functional/base.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e4d40c251099a0fb7fd52057d7ec74faf0da51ac","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        if utils.get_object(node_list, node_id):"},{"line_number":218,"context_line":"            node_show \u003d self.show_node(node_id)"},{"line_number":219,"context_line":"            if node_show[\u0027provision_state\u0027] not in (\u0027available\u0027,"},{"line_number":220,"context_line":"                                                    \u0027manageable\u0027,"},{"line_number":221,"context_line":"                                                    \u0027enroll\u0027):"},{"line_number":222,"context_line":"                self.ironic(\u0027node-set-provision-state\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_8c55f652","line":219,"updated":"2017-11-01 21:11:59.000000000","message":"This change seems unrelated to the commit.\n\nIf it is related can the commit message be expanded to explain this.","commit_id":"7d72de480cc36c2b884f204c5c417a9512ac8b18"}],"ironicclient/tests/functional/test_json_response.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"777ae7a553d4bbb72c55007fc7ac11070d40011d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            \"uuid\": {\"type\": \"string\"},"},{"line_number":49,"context_line":"            \"console_enabled\": {\"type\": \"boolean\"},"},{"line_number":50,"context_line":"            \"target_provision_state\": {\"type\": [\"string\", \"null\"]},"},{"line_number":51,"context_line":"            \"raid_config\": {\"type\": \"string\"},"},{"line_number":52,"context_line":"            \"provision_updated_at\": {\"type\": [\"string\", \"null\"]},"},{"line_number":53,"context_line":"            \"maintenance\": {\"type\": \"boolean\"},"},{"line_number":54,"context_line":"            \"target_raid_config\": {\"type\": \"string\"},"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_47c0257d","line":51,"range":{"start_line":51,"start_character":36,"end_line":51,"end_character":44},"updated":"2017-10-31 13:36:59.000000000","message":"It seems necessary to change it to \"object\" for the functional test.","commit_id":"ff7299e5e96df22f2b9471fac7aacacc5539fead"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"777ae7a553d4bbb72c55007fc7ac11070d40011d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            \"raid_config\": {\"type\": \"string\"},"},{"line_number":52,"context_line":"            \"provision_updated_at\": {\"type\": [\"string\", \"null\"]},"},{"line_number":53,"context_line":"            \"maintenance\": {\"type\": \"boolean\"},"},{"line_number":54,"context_line":"            \"target_raid_config\": {\"type\": \"string\"},"},{"line_number":55,"context_line":"            \"inspection_started_at\": {\"type\": [\"string\", \"null\"]},"},{"line_number":56,"context_line":"            \"inspection_finished_at\": {\"type\": [\"string\", \"null\"]},"},{"line_number":57,"context_line":"            \"power_state\": {\"type\": [\"string\", \"null\"]},"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_a740f908","line":54,"range":{"start_line":54,"start_character":43,"end_line":54,"end_character":51},"updated":"2017-10-31 13:36:59.000000000","message":"ditto","commit_id":"ff7299e5e96df22f2b9471fac7aacacc5539fead"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8a5d5989a08845e0623ba31e8df800db842a047f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            \"uuid\": {\"type\": \"string\"},"},{"line_number":49,"context_line":"            \"console_enabled\": {\"type\": \"boolean\"},"},{"line_number":50,"context_line":"            \"target_provision_state\": {\"type\": [\"string\", \"null\"]},"},{"line_number":51,"context_line":"            \"raid_config\": {\"type\": \"object\"},"},{"line_number":52,"context_line":"            \"provision_updated_at\": {\"type\": [\"string\", \"null\"]},"},{"line_number":53,"context_line":"            \"maintenance\": {\"type\": \"boolean\"},"},{"line_number":54,"context_line":"            \"target_raid_config\": {\"type\": \"object\"},"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_840a0923","line":51,"updated":"2017-11-06 20:24:39.000000000","message":"The reason this changed from string to object is because in API versions \u003c 1.12, the ironic response will not include this field. So the client code will spit this out, with an empty-string value.\n\nIn API version \u003e 1.12 (which is what happens when we use \u0027latest\u0027), the ironic response will include this field, with the value {} -- so the client response will have this value too.","commit_id":"28560398fad39a4fb65289d8458340c7d517fd79"}],"ironicclient/tests/functional/test_node.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e4d40c251099a0fb7fd52057d7ec74faf0da51ac","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        self.assertEqual(\u0027enroll\u0027, node_show[\u0027provision_state\u0027])"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        for verb, target in [(\u0027manage\u0027, \u0027manageable\u0027),"},{"line_number":173,"context_line":"                             (\u0027provide\u0027, \u0027available\u0027),"},{"line_number":174,"context_line":"                             (\u0027active\u0027, \u0027active\u0027),"},{"line_number":175,"context_line":"                             (\u0027deleted\u0027, \u0027available\u0027)]:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_8c6cd636","line":172,"updated":"2017-11-01 21:11:59.000000000","message":"This change seems unrelated to the commit.\n\nIf it is related can the commit message be expanded to explain this.","commit_id":"7d72de480cc36c2b884f204c5c417a9512ac8b18"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8a5d5989a08845e0623ba31e8df800db842a047f","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        self.assertEqual(\u0027power off\u0027, node_show[\u0027power_state\u0027])"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def test_node_set_provision_state(self):"},{"line_number":161,"context_line":"        \"\"\"Test steps:"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        1) create node"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_2430f59e","line":160,"updated":"2017-11-06 20:24:39.000000000","message":"seems like we might want both tests, and explicitly specify the API version for the original. but we are deprecating the ironic CLI so...","commit_id":"28560398fad39a4fb65289d8458340c7d517fd79"}],"ironicclient/tests/unit/test_shell.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8df525848bbe7585418cd72ac4014889bfbc0126","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            \u0027max_retries\u0027: http.DEFAULT_MAX_RETRIES,"},{"line_number":176,"context_line":"            \u0027retry_interval\u0027: http.DEFAULT_RETRY_INTERVAL,"},{"line_number":177,"context_line":"            \u0027os_ironic_api_version\u0027: ironic_shell.LATEST_VERSION,"},{"line_number":178,"context_line":"            \u0027timeout\u0027: 600, \u0027insecure\u0027: False"},{"line_number":179,"context_line":"        }"},{"line_number":180,"context_line":"        mock_client.assert_called_once_with(1, **expected_kwargs)"},{"line_number":181,"context_line":"        # Make sure we are actually prompted."}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_7a192f78","line":178,"updated":"2017-11-07 20:45:29.000000000","message":"nit: add trailing comma","commit_id":"28560398fad39a4fb65289d8458340c7d517fd79"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8df525848bbe7585418cd72ac4014889bfbc0126","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            \u0027os_key\u0027: None, \u0027max_retries\u0027: http.DEFAULT_MAX_RETRIES,"},{"line_number":206,"context_line":"            \u0027retry_interval\u0027: http.DEFAULT_RETRY_INTERVAL,"},{"line_number":207,"context_line":"            \u0027os_ironic_api_version\u0027: ironic_shell.LATEST_VERSION,"},{"line_number":208,"context_line":"            \u0027timeout\u0027: 600, \u0027insecure\u0027: False"},{"line_number":209,"context_line":"        }"},{"line_number":210,"context_line":"        mock_client.assert_called_once_with(1, **expected_kwargs)"},{"line_number":211,"context_line":"        self.assertFalse(mock_getpass.called)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_9a106b50","line":208,"updated":"2017-11-07 20:45:29.000000000","message":"nit: add trailing comma","commit_id":"28560398fad39a4fb65289d8458340c7d517fd79"}],"releasenotes/notes/ironic-cli-version-a5cdec73d585444d.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8a5d5989a08845e0623ba31e8df800db842a047f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3f4b6375_04c3b9ee","line":26,"updated":"2017-11-06 20:24:39.000000000","message":"What do you think about combining this release note with latest-default-41fdcc49701c4d70.yaml?","commit_id":"28560398fad39a4fb65289d8458340c7d517fd79"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"978080be803bf21cf6250d122c6d6f1a46068eff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3f4b6375_36e37907","line":26,"in_reply_to":"3f4b6375_04c3b9ee","updated":"2017-11-07 12:27:08.000000000","message":"I don\u0027t see a big point, to be honest. They\u0027re anyway combined in the final output.","commit_id":"28560398fad39a4fb65289d8458340c7d517fd79"}]}