)]}'
{"ironicclient/osc/plugin.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b3703a13fbfa200ccc2bc8130be4a01577f18410","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    for i in range(1, LAST_KNOWN_API_VERSION + 1)"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":"API_VERSIONS[\u00271\u0027] \u003d CLIENT_CLASS"},{"line_number":36,"context_line":"# NOTE(dtantsur): flag to indicate that the requested version was \"latest\"."},{"line_number":37,"context_line":"# Due to how OSC works we cannot just add \"latest\" to the list of supported"},{"line_number":38,"context_line":"# versions - it breaks the major version detection."},{"line_number":39,"context_line":"OS_BAREMETAL_API_LATEST \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_17094ddc","line":36,"updated":"2017-10-31 00:09:24.000000000","message":"This isn\u0027t true any more. The requested version was latest or 1.","commit_id":"17c1ee31290ccc2b77df72cea98b8ace8e6c86c9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c5528e77e218be1e4717bc1806958127f19f057a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    for i in range(1, LAST_KNOWN_API_VERSION + 1)"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":"API_VERSIONS[\u00271\u0027] \u003d CLIENT_CLASS"},{"line_number":36,"context_line":"# NOTE(dtantsur): flag to indicate that the requested version was \"latest\"."},{"line_number":37,"context_line":"# Due to how OSC works we cannot just add \"latest\" to the list of supported"},{"line_number":38,"context_line":"# versions - it breaks the major version detection."},{"line_number":39,"context_line":"OS_BAREMETAL_API_LATEST \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_c1587e57","line":36,"in_reply_to":"3f4b6375_17094ddc","updated":"2017-10-31 17:05:05.000000000","message":"I will update this comment","commit_id":"17c1ee31290ccc2b77df72cea98b8ace8e6c86c9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dbc848dda7d8797cdd7bb2d5c31a2ad47bc70caf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        requested_api_version,"},{"line_number":49,"context_line":"        API_VERSIONS)"},{"line_number":50,"context_line":"    LOG.debug(\u0027Instantiating baremetal client: %s\u0027, baremetal_client_class)"},{"line_number":51,"context_line":"    LOG.debug(\u0027Baremetal API version: %s\u0027,"},{"line_number":52,"context_line":"              requested_api_version if not OS_BAREMETAL_API_LATEST"},{"line_number":53,"context_line":"              else \"latest\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    client \u003d baremetal_client_class("},{"line_number":56,"context_line":"        os_ironic_api_version\u003drequested_api_version,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_6386eabb","line":53,"range":{"start_line":51,"start_character":4,"end_line":53,"end_character":28},"updated":"2017-10-26 09:38:47.000000000","message":"now you need to correct this, ideally..","commit_id":"17c1ee31290ccc2b77df72cea98b8ace8e6c86c9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c86cd264447838cdef75b1b3e27de185eea4effe","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        requested_api_version,"},{"line_number":49,"context_line":"        API_VERSIONS)"},{"line_number":50,"context_line":"    LOG.debug(\u0027Instantiating baremetal client: %s\u0027, baremetal_client_class)"},{"line_number":51,"context_line":"    LOG.debug(\u0027Baremetal API version: %s\u0027,"},{"line_number":52,"context_line":"              requested_api_version if not OS_BAREMETAL_API_LATEST"},{"line_number":53,"context_line":"              else \"latest\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    client \u003d baremetal_client_class("},{"line_number":56,"context_line":"        os_ironic_api_version\u003drequested_api_version,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_a920399c","line":53,"range":{"start_line":51,"start_character":4,"end_line":53,"end_character":28},"in_reply_to":"3f4b6375_3f7a3eb9","updated":"2017-10-26 15:56:34.000000000","message":"Okay. Thanks!","commit_id":"17c1ee31290ccc2b77df72cea98b8ace8e6c86c9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"16966bf4d9bc7c228df035f796923dd3ce3d2087","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        requested_api_version,"},{"line_number":49,"context_line":"        API_VERSIONS)"},{"line_number":50,"context_line":"    LOG.debug(\u0027Instantiating baremetal client: %s\u0027, baremetal_client_class)"},{"line_number":51,"context_line":"    LOG.debug(\u0027Baremetal API version: %s\u0027,"},{"line_number":52,"context_line":"              requested_api_version if not OS_BAREMETAL_API_LATEST"},{"line_number":53,"context_line":"              else \"latest\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    client \u003d baremetal_client_class("},{"line_number":56,"context_line":"        os_ironic_api_version\u003drequested_api_version,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_7c3b8bc7","line":53,"range":{"start_line":51,"start_character":4,"end_line":53,"end_character":28},"in_reply_to":"3f4b6375_41136e67","updated":"2017-11-01 19:01:35.000000000","message":"Hmm. Seems like information overload. Who is debugging this...my impression of this log line is that it is logging what the user specified, and if they didn\u0027t, it shows the default.\n\nSo I don\u0027t think we need 1 \u0026 2, if the user specifies 2, it overrides 1. that should be clear. If you want to log the env. variable, that should be done at the place where the code looks at the env variable.\n\nIf the user doesn\u0027t specify 1 or 2, then it is \u0027latest\u0027.\n\nIf you want to log how we intepret \u00271\u0027 or \u0027latest\u0027, maybe that goes in the \u0027ReplaceLatestVersion\u0027 class?","commit_id":"17c1ee31290ccc2b77df72cea98b8ace8e6c86c9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"fbd869a56b7f2527a3a27ade2821c9d8a7e6afca","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        requested_api_version,"},{"line_number":49,"context_line":"        API_VERSIONS)"},{"line_number":50,"context_line":"    LOG.debug(\u0027Instantiating baremetal client: %s\u0027, baremetal_client_class)"},{"line_number":51,"context_line":"    LOG.debug(\u0027Baremetal API version: %s\u0027,"},{"line_number":52,"context_line":"              requested_api_version if not OS_BAREMETAL_API_LATEST"},{"line_number":53,"context_line":"              else \"latest\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    client \u003d baremetal_client_class("},{"line_number":56,"context_line":"        os_ironic_api_version\u003drequested_api_version,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_9f8b72c1","line":53,"range":{"start_line":51,"start_character":4,"end_line":53,"end_character":28},"in_reply_to":"3f4b6375_6386eabb","updated":"2017-10-26 13:41:39.000000000","message":"I\u0027m not sure what you mean. Should it just always be the actual version?","commit_id":"17c1ee31290ccc2b77df72cea98b8ace8e6c86c9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c5528e77e218be1e4717bc1806958127f19f057a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        requested_api_version,"},{"line_number":49,"context_line":"        API_VERSIONS)"},{"line_number":50,"context_line":"    LOG.debug(\u0027Instantiating baremetal client: %s\u0027, baremetal_client_class)"},{"line_number":51,"context_line":"    LOG.debug(\u0027Baremetal API version: %s\u0027,"},{"line_number":52,"context_line":"              requested_api_version if not OS_BAREMETAL_API_LATEST"},{"line_number":53,"context_line":"              else \"latest\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    client \u003d baremetal_client_class("},{"line_number":56,"context_line":"        os_ironic_api_version\u003drequested_api_version,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_41136e67","line":53,"range":{"start_line":51,"start_character":4,"end_line":53,"end_character":28},"in_reply_to":"3f4b6375_77e52138","updated":"2017-10-31 17:05:05.000000000","message":"I was wondering if it would be overkill to log:\n\n 1) The requested environment variable version, if specified\n 2) The requested command line version, if specified\n 3) The actual version we are going to try\n 4) And indicate if it is the latest version or not. And maybe indicate we will do negotiation for a latest version type.\n\nWhat do you think?","commit_id":"17c1ee31290ccc2b77df72cea98b8ace8e6c86c9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"5baeb83b1b9d01e0a9b0f3c1c7f2b38f22f45856","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        requested_api_version,"},{"line_number":49,"context_line":"        API_VERSIONS)"},{"line_number":50,"context_line":"    LOG.debug(\u0027Instantiating baremetal client: %s\u0027, baremetal_client_class)"},{"line_number":51,"context_line":"    LOG.debug(\u0027Baremetal API version: %s\u0027,"},{"line_number":52,"context_line":"              requested_api_version if not OS_BAREMETAL_API_LATEST"},{"line_number":53,"context_line":"              else \"latest\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    client \u003d baremetal_client_class("},{"line_number":56,"context_line":"        os_ironic_api_version\u003drequested_api_version,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_4cc93e76","line":53,"range":{"start_line":51,"start_character":4,"end_line":53,"end_character":28},"in_reply_to":"3f4b6375_7c3b8bc7","updated":"2017-11-01 21:01:44.000000000","message":"Okay. I have updated it to print the version and add latest.\n\nSo if a latest version was requested. It will print:\n\n Baremetal API version: 1.34 (latest)","commit_id":"17c1ee31290ccc2b77df72cea98b8ace8e6c86c9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2008438cbceb93765d2de6f712132dac0f276d67","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        requested_api_version,"},{"line_number":49,"context_line":"        API_VERSIONS)"},{"line_number":50,"context_line":"    LOG.debug(\u0027Instantiating baremetal client: %s\u0027, baremetal_client_class)"},{"line_number":51,"context_line":"    LOG.debug(\u0027Baremetal API version: %s\u0027,"},{"line_number":52,"context_line":"              requested_api_version if not OS_BAREMETAL_API_LATEST"},{"line_number":53,"context_line":"              else \"latest\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    client \u003d baremetal_client_class("},{"line_number":56,"context_line":"        os_ironic_api_version\u003drequested_api_version,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_3f7a3eb9","line":53,"range":{"start_line":51,"start_character":4,"end_line":53,"end_character":28},"in_reply_to":"3f4b6375_9f8b72c1","updated":"2017-10-26 13:44:10.000000000","message":"I think it\u0027s fine to leave it as it is. Just pointing out that it will report \"latest\" for \"1\"","commit_id":"17c1ee31290ccc2b77df72cea98b8ace8e6c86c9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b3703a13fbfa200ccc2bc8130be4a01577f18410","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        requested_api_version,"},{"line_number":49,"context_line":"        API_VERSIONS)"},{"line_number":50,"context_line":"    LOG.debug(\u0027Instantiating baremetal client: %s\u0027, baremetal_client_class)"},{"line_number":51,"context_line":"    LOG.debug(\u0027Baremetal API version: %s\u0027,"},{"line_number":52,"context_line":"              requested_api_version if not OS_BAREMETAL_API_LATEST"},{"line_number":53,"context_line":"              else \"latest\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    client \u003d baremetal_client_class("},{"line_number":56,"context_line":"        os_ironic_api_version\u003drequested_api_version,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_77e52138","line":53,"range":{"start_line":51,"start_character":4,"end_line":53,"end_character":28},"in_reply_to":"3f4b6375_a920399c","updated":"2017-10-31 00:09:24.000000000","message":"Why is it fine that it logs \u0027latest\u0027, when it should log \u00271\u0027 ? Seems like that would be confusing if you were actually trying to debug...","commit_id":"17c1ee31290ccc2b77df72cea98b8ace8e6c86c9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"16966bf4d9bc7c228df035f796923dd3ce3d2087","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    return parser"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def _determine_default_version():"},{"line_number":90,"context_line":"    \"\"\"Determine the default API version."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    We need to figure out what the default API version should be. If the user"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_dca4bf0a","line":89,"updated":"2017-11-01 19:01:35.000000000","message":"Now that I think a bit more about this, I liked the original name, or something related to \u0027environment\u0027. Because the default version is \u0027latest\u0027. But that gets overridden if the user specifies it, either via the env var or via the --openstack-baremetal-api-version option.","commit_id":"17c1ee31290ccc2b77df72cea98b8ace8e6c86c9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"5baeb83b1b9d01e0a9b0f3c1c7f2b38f22f45856","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    return parser"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def _determine_default_version():"},{"line_number":90,"context_line":"    \"\"\"Determine the default API version."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    We need to figure out what the default API version should be. If the user"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_6ce19afc","line":89,"in_reply_to":"3f4b6375_dca4bf0a","updated":"2017-11-01 21:01:44.000000000","message":"I have updated the name to indicate it is for the the argparse \u0027default\u0027 value.","commit_id":"17c1ee31290ccc2b77df72cea98b8ace8e6c86c9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b3703a13fbfa200ccc2bc8130be4a01577f18410","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    We need to figure out what the default API version should be. If the user"},{"line_number":93,"context_line":"    has set the environment variable OS_BAREMETAL_API_VERSION, then use that"},{"line_number":94,"context_line":"    value as the default. This is so it can be overridden later if a a command"},{"line_number":95,"context_line":"    line argument is used. If the environment variable OS_BAREMETAL_API_VERSION"},{"line_number":96,"context_line":"    is \u0027latest\u0027 or \u00271\u0027, then set it to actual LATEST_VERSION."},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_b7c4b993","line":94,"updated":"2017-10-31 00:09:24.000000000","message":"nit s/a a/a/","commit_id":"17c1ee31290ccc2b77df72cea98b8ace8e6c86c9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"16966bf4d9bc7c228df035f796923dd3ce3d2087","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"class ReplaceLatestVersion(argparse.Action):"},{"line_number":116,"context_line":"    \"\"\"Replaces `latest` or \u00271\u0027 keyword by last known version."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    OSC cannot accept the literal \"latest\" as a supported API version as it"},{"line_number":119,"context_line":"    breaks the major version detection (OSC tries to load configuration options"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_1ce93719","line":116,"updated":"2017-11-01 19:01:35.000000000","message":"I guess this bothers me, because when/if we ever have a \u00272\u0027 keyword, this will be wrong. I can see what we can change \u00271\u0027 to \u00272\u0027 here, but then, where would \u00271\u0027 be handled?","commit_id":"17c1ee31290ccc2b77df72cea98b8ace8e6c86c9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"5baeb83b1b9d01e0a9b0f3c1c7f2b38f22f45856","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"class ReplaceLatestVersion(argparse.Action):"},{"line_number":116,"context_line":"    \"\"\"Replaces `latest` or \u00271\u0027 keyword by last known version."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    OSC cannot accept the literal \"latest\" as a supported API version as it"},{"line_number":119,"context_line":"    breaks the major version detection (OSC tries to load configuration options"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_2ceba2dc","line":116,"in_reply_to":"3f4b6375_1ce93719","updated":"2017-11-01 21:01:44.000000000","message":"Updated comment.","commit_id":"17c1ee31290ccc2b77df72cea98b8ace8e6c86c9"}]}