)]}'
{"ironicclient/osc/v1/baremetal_node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"162e023e680d40a133d3fe2fc0df7dbc52d99a1c","unresolved":false,"context_lines":[{"line_number":908,"context_line":"            help\u003d_(\"A gzipped, base64-encoded configuration drive string OR \""},{"line_number":909,"context_line":"                   \"the path to the configuration drive file OR the path to a \""},{"line_number":910,"context_line":"                   \"directory containing the config drive files. In case it\u0027s \""},{"line_number":911,"context_line":"                   \"a directory, a config drive will be generated from it. \"))"},{"line_number":912,"context_line":"        return parser"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_d330f058","line":911,"updated":"2017-11-03 15:38:12.000000000","message":"nit: I wonder if we should make this string a top-level constant to avoid copy-pasting..","commit_id":"b1a2d762e70a74ee748205b417f402e45bfda870"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"c5bad27e2f79028d58dc3b745d89dfab99ec7b4b","unresolved":false,"context_lines":[{"line_number":908,"context_line":"            help\u003d_(\"A gzipped, base64-encoded configuration drive string OR \""},{"line_number":909,"context_line":"                   \"the path to the configuration drive file OR the path to a \""},{"line_number":910,"context_line":"                   \"directory containing the config drive files. In case it\u0027s \""},{"line_number":911,"context_line":"                   \"a directory, a config drive will be generated from it. \"))"},{"line_number":912,"context_line":"        return parser"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_da9c580f","line":911,"in_reply_to":"3f4b6375_999bb915","updated":"2017-11-06 22:39:53.000000000","message":"Done","commit_id":"b1a2d762e70a74ee748205b417f402e45bfda870"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"715dd1e966387cc1c807e2c33d52e92f8bfc7822","unresolved":false,"context_lines":[{"line_number":908,"context_line":"            help\u003d_(\"A gzipped, base64-encoded configuration drive string OR \""},{"line_number":909,"context_line":"                   \"the path to the configuration drive file OR the path to a \""},{"line_number":910,"context_line":"                   \"directory containing the config drive files. In case it\u0027s \""},{"line_number":911,"context_line":"                   \"a directory, a config drive will be generated from it. \"))"},{"line_number":912,"context_line":"        return parser"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_1fa302b4","line":911,"in_reply_to":"3f4b6375_999bb915","updated":"2017-11-06 21:07:27.000000000","message":"top of the file works. Name is good.\n\nI was wondering why it had a blank space at the end of the string :)","commit_id":"b1a2d762e70a74ee748205b417f402e45bfda870"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"a4ca301630d2b92cdca61def822d452391e9ce19","unresolved":false,"context_lines":[{"line_number":908,"context_line":"            help\u003d_(\"A gzipped, base64-encoded configuration drive string OR \""},{"line_number":909,"context_line":"                   \"the path to the configuration drive file OR the path to a \""},{"line_number":910,"context_line":"                   \"directory containing the config drive files. In case it\u0027s \""},{"line_number":911,"context_line":"                   \"a directory, a config drive will be generated from it. \"))"},{"line_number":912,"context_line":"        return parser"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_999bb915","line":911,"in_reply_to":"3f4b6375_d330f058","updated":"2017-11-03 17:07:12.000000000","message":"I think it\u0027s a good idea. I couldn\u0027t find a previous pattern. Should I add the constant at top of this file and use it here? Any suggestion for the name? CONFIG_DRIVE_HELP, CONFIG_DRIVE_ARG_HELP? Or anything else?","commit_id":"b1a2d762e70a74ee748205b417f402e45bfda870"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"615f7bd3ff78caf52e1d66cef9207399ba68901c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from ironicclient.v1 import resource_fields as res_fields"},{"line_number":28,"context_line":"from ironicclient.v1 import utils as v1_utils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONFIG_DRIVE_ARG_HELP \u003d ("},{"line_number":31,"context_line":"    \"A gzipped, base64-encoded configuration drive string OR \""},{"line_number":32,"context_line":"    \"the path to the configuration drive file OR the path to a \""},{"line_number":33,"context_line":"    \"directory containing the config drive files. In case it\u0027s \""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_e0008603","line":30,"updated":"2017-11-06 22:52:57.000000000","message":"let\u0027s play it safe cuz I\u0027m not sure, and do CONFIG_DRIVE_ARG_HELP \u003d _(...).","commit_id":"0529fd0eb3bded79bc8316dbcb363c660fabdea3"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"0f4af839c7dae876a936d3bc0dc34ea972368c68","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from ironicclient.v1 import resource_fields as res_fields"},{"line_number":28,"context_line":"from ironicclient.v1 import utils as v1_utils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONFIG_DRIVE_ARG_HELP \u003d ("},{"line_number":31,"context_line":"    \"A gzipped, base64-encoded configuration drive string OR \""},{"line_number":32,"context_line":"    \"the path to the configuration drive file OR the path to a \""},{"line_number":33,"context_line":"    \"directory containing the config drive files. In case it\u0027s \""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_20333ef8","line":30,"in_reply_to":"3f4b6375_e0008603","updated":"2017-11-06 22:59:51.000000000","message":"Done","commit_id":"0529fd0eb3bded79bc8316dbcb363c660fabdea3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"615f7bd3ff78caf52e1d66cef9207399ba68901c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"A gzipped, base64-encoded configuration drive string OR \""},{"line_number":32,"context_line":"    \"the path to the configuration drive file OR the path to a \""},{"line_number":33,"context_line":"    \"directory containing the config drive files. In case it\u0027s \""},{"line_number":34,"context_line":"    \"a directory, a config drive will be generated from it. \")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class ProvisionStateBaremetalNode(command.Command):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_1a1c3076","line":34,"updated":"2017-11-06 22:52:57.000000000","message":"nit, if you feel like it. s/it. /it./","commit_id":"0529fd0eb3bded79bc8316dbcb363c660fabdea3"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"0f4af839c7dae876a936d3bc0dc34ea972368c68","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"A gzipped, base64-encoded configuration drive string OR \""},{"line_number":32,"context_line":"    \"the path to the configuration drive file OR the path to a \""},{"line_number":33,"context_line":"    \"directory containing the config drive files. In case it\u0027s \""},{"line_number":34,"context_line":"    \"a directory, a config drive will be generated from it. \")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class ProvisionStateBaremetalNode(command.Command):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_002e028b","line":34,"in_reply_to":"3f4b6375_1a1c3076","updated":"2017-11-06 22:59:51.000000000","message":"Done","commit_id":"0529fd0eb3bded79bc8316dbcb363c660fabdea3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"615f7bd3ff78caf52e1d66cef9207399ba68901c","unresolved":false,"context_lines":[{"line_number":489,"context_line":"            \u0027--config-drive\u0027,"},{"line_number":490,"context_line":"            metavar\u003d\u0027\u003cconfig-drive\u003e\u0027,"},{"line_number":491,"context_line":"            default\u003dNone,"},{"line_number":492,"context_line":"            help\u003d_(CONFIG_DRIVE_ARG_HELP))"},{"line_number":493,"context_line":"        return parser"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_9a0f0036","line":492,"updated":"2017-11-06 22:52:57.000000000","message":"OH. Hmm. I\u0027m not sure this will work for i18n. I think that they need to see the actual string, but I don\u0027t know for sure.\n\nLet\u0027s change it above, and just do help \u003d CONFIG_DRIVE_ARG_HELP here.","commit_id":"0529fd0eb3bded79bc8316dbcb363c660fabdea3"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"0f4af839c7dae876a936d3bc0dc34ea972368c68","unresolved":false,"context_lines":[{"line_number":489,"context_line":"            \u0027--config-drive\u0027,"},{"line_number":490,"context_line":"            metavar\u003d\u0027\u003cconfig-drive\u003e\u0027,"},{"line_number":491,"context_line":"            default\u003dNone,"},{"line_number":492,"context_line":"            help\u003d_(CONFIG_DRIVE_ARG_HELP))"},{"line_number":493,"context_line":"        return parser"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_e04e466d","line":492,"in_reply_to":"3f4b6375_9a0f0036","updated":"2017-11-06 22:59:51.000000000","message":"Done","commit_id":"0529fd0eb3bded79bc8316dbcb363c660fabdea3"}],"ironicclient/tests/unit/osc/v1/test_baremetal_node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"162e023e680d40a133d3fe2fc0df7dbc52d99a1c","unresolved":false,"context_lines":[{"line_number":1516,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":1517,"context_line":""},{"line_number":1518,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":1519,"context_line":""},{"line_number":1520,"context_line":"        self.baremetal_mock.node.wait_for_provision_state.assert_not_called()"},{"line_number":1521,"context_line":""},{"line_number":1522,"context_line":"    def test_rebuild_baremetal_provision_state_active_and_wait(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_b331f45b","line":1519,"updated":"2017-11-03 15:38:12.000000000","message":"please add an assertion here that configdrive\u003dNone is passed","commit_id":"b1a2d762e70a74ee748205b417f402e45bfda870"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"a4ca301630d2b92cdca61def822d452391e9ce19","unresolved":false,"context_lines":[{"line_number":1516,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":1517,"context_line":""},{"line_number":1518,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":1519,"context_line":""},{"line_number":1520,"context_line":"        self.baremetal_mock.node.wait_for_provision_state.assert_not_called()"},{"line_number":1521,"context_line":""},{"line_number":1522,"context_line":"    def test_rebuild_baremetal_provision_state_active_and_wait(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_19734918","line":1519,"in_reply_to":"3f4b6375_b331f45b","updated":"2017-11-03 17:07:12.000000000","message":"Done","commit_id":"b1a2d762e70a74ee748205b417f402e45bfda870"}],"releasenotes/notes/osc-node-rebuild-configdrive-8979d5b1373e8d5f.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"715dd1e966387cc1c807e2c33d52e92f8bfc7822","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds an option ``--config-drive`` to the"},{"line_number":5,"context_line":"    ``openstack baremetal node rebuild`` command which introduces"},{"line_number":6,"context_line":"    the ability to provide a configdrive."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_9f237256","line":6,"updated":"2017-11-06 21:07:27.000000000","message":"How about\n\nAdds the ability to specify a configuration drive when rebuilding a node, via the ``--config-drive`` option to the ``openstack baremetal node rebuild`` command. This is available starting with ironic API version 1.35.","commit_id":"6aad9a122cb5a76abc1a9b0b5c03c0b5b38dc80b"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"c5bad27e2f79028d58dc3b745d89dfab99ec7b4b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds an option ``--config-drive`` to the"},{"line_number":5,"context_line":"    ``openstack baremetal node rebuild`` command which introduces"},{"line_number":6,"context_line":"    the ability to provide a configdrive."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_9a8a60bc","line":6,"in_reply_to":"3f4b6375_9f237256","updated":"2017-11-06 22:39:53.000000000","message":"Done.","commit_id":"6aad9a122cb5a76abc1a9b0b5c03c0b5b38dc80b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"74f086cc799b2fb5532b4d027cd9452e030eb8ee","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds the ability to specify a configuration drive when"},{"line_number":5,"context_line":"    rebuilding a node, via the ``--config-drive`` option to the"},{"line_number":6,"context_line":"    ``openstack baremetal node rebuild`` command. This is available starting"},{"line_number":7,"context_line":"    with ironic API version 1.35."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f4b6375_b6f4095c","line":7,"updated":"2017-11-07 12:44:27.000000000","message":"nit: ideally we should say \"Bare Metal API\"","commit_id":"07290220762e023f1e197a7d854228d4d09fce7a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"37367c3ce0df959ae108fdcc5808e5576650ae1b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds the ability to specify a configuration drive when"},{"line_number":5,"context_line":"    rebuilding a node, via the ``--config-drive`` option to the"},{"line_number":6,"context_line":"    ``openstack baremetal node rebuild`` command. This is available starting"},{"line_number":7,"context_line":"    with ironic API version 1.35."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f4b6375_c689106f","line":7,"in_reply_to":"3f4b6375_b6f4095c","updated":"2017-11-07 18:08:59.000000000","message":"I wasn\u0027t sure if it was \u0027bare metal API\u0027 or \u0027Baremetal API\u0027 or .. I knew you had used that term before but I didn\u0027t find it and saw \u0027ironic API\u0027 so I used that.\n\nWe can switch to Bare Metal API when/if we clean up the release notes before releasing.","commit_id":"07290220762e023f1e197a7d854228d4d09fce7a"}]}