)]}'
{"id":"openstack%2Fpython-ironicclient~528606","triplet_id":"openstack%2Fpython-ironicclient~master~Ic36d855f30ca59c6ac8be01e49f8d21db7c9b052","project":"openstack/python-ironicclient","branch":"master","topic":"functional-node-validate-json","hashtags":[],"change_id":"Ic36d855f30ca59c6ac8be01e49f8d21db7c9b052","subject":"Accept None as a result of node validation in functional test","status":"MERGED","created":"2017-12-18 03:02:39.000000000","updated":"2017-12-21 18:09:07.000000000","submitted":"2017-12-21 18:09:07.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"528606-1513879747498-82a458cc","meta_rev_id":"9d3fd84b2a701af5277d10018b232ac68f83c1b7","_number":528606,"virtual_id_number":528606,"owner":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":2,"date":"2017-12-21 18:09:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":2,"date":"2017-12-18 15:28:26.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2017-12-21 17:47:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2017-12-21 17:47:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-12-18 15:28:26.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2017-12-21 17:47:37.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2017-12-21 18:09:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4f9b763ff361a1c1c220bdfb6f16551f4f2ccc6c","author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"date":"2017-12-18 03:02:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"86a41a67c521f2092423ed1e1265e3e5765449c2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-18 03:27:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-py35 http://logs.openstack.org/06/528606/1/check/openstack-tox-py35/e3cbe24/ : SUCCESS in 3m 48s\n- openstack-tox-pep8 http://logs.openstack.org/06/528606/1/check/openstack-tox-pep8/82669ce/ : SUCCESS in 3m 40s\n- openstack-tox-py27 http://logs.openstack.org/06/528606/1/check/openstack-tox-py27/e448838/ : SUCCESS in 4m 32s\n- build-openstack-sphinx-docs http://logs.openstack.org/06/528606/1/check/build-openstack-sphinx-docs/9e63505/html/ : SUCCESS in 4m 51s\n- openstackclient-check-plugins http://logs.openstack.org/06/528606/1/check/openstackclient-check-plugins/05db059/ : FAILURE in 3m 41s (non-voting)\n- openstack-tox-cover http://logs.openstack.org/06/528606/1/check/openstack-tox-cover/64bf422/cover/ : SUCCESS in 3m 54s\n- ironicclient-dsvm-functional http://logs.openstack.org/06/528606/1/check/ironicclient-dsvm-functional/116adf5/ : SUCCESS in 22m 21s","accounts_in_message":[],"_revision_number":1},{"id":"d430bdbd7d0e077e8303d1f55a30175ddecb86b5","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2017-12-18 15:28:26.000000000","message":"Patch Set 1: Code-Review+2\n\nGood catch. I see that for e.g. the \u0027inspect\u0027 interface of a classic driver. Thanks!\n\nMakes me wonder about how we\u0027re handling interfaces of hardware types, but that\u0027s a separate issue...","accounts_in_message":[],"_revision_number":1},{"id":"2b43c48db5474b0d159640bfe2a157ae448a6041","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-12-21 17:47:37.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2\n\nInterfaces of hardware types are never None, I think","accounts_in_message":[],"_revision_number":1},{"id":"234ff0ad10086adc6e098e195f9c7f885e501920","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-21 17:47:50.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9592f4f8fb787ad8737af11024eb75ecaff42786","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-21 18:09:07.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"3a809cff6f367d24276fa0a36271e5d4c93babd2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-21 18:09:07.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-py35 http://logs.openstack.org/06/528606/1/gate/openstack-tox-py35/4741d96/ : SUCCESS in 4m 28s\n- openstack-tox-pep8 http://logs.openstack.org/06/528606/1/gate/openstack-tox-pep8/07b1c0d/ : SUCCESS in 3m 41s\n- openstack-tox-py27 http://logs.openstack.org/06/528606/1/gate/openstack-tox-py27/e91cc3a/ : SUCCESS in 4m 13s\n- build-openstack-sphinx-docs http://logs.openstack.org/06/528606/1/gate/build-openstack-sphinx-docs/201165a/html/ : SUCCESS in 4m 46s\n- ironicclient-dsvm-functional http://logs.openstack.org/06/528606/1/gate/ironicclient-dsvm-functional/7a43514/ : SUCCESS in 15m 58s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7ba617b28836e0ab9b1adffce8248c817401b964","revisions":{"7ba617b28836e0ab9b1adffce8248c817401b964":{"kind":"REWORK","_number":1,"created":"2017-12-18 03:02:39.000000000","uploader":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"ref":"refs/changes/06/528606/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/06/528606/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/06/528606/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/06/528606/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/06/528606/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/06/528606/1"}}},"commit":{"parents":[{"commit":"58a0915416e52fe16a1987a6f7aa6d432479af8b","subject":"Use the tempest plugin from openstack/ironic-tempest-plugin","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/58a0915416e52fe16a1987a6f7aa6d432479af8b"}]}],"author":{"name":"Hironori Shiina","email":"shiina.hironori@jp.fujitsu.com","date":"2017-12-18 02:56:14.000000000","tz":540},"committer":{"name":"Hironori Shiina","email":"shiina.hironori@jp.fujitsu.com","date":"2017-12-18 02:56:14.000000000","tz":540},"subject":"Accept None as a result of node validation in functional test","message":"Accept None as a result of node validation in functional test\n\nA result of node validation can be None when a driver has no\nimplementation of an interface. This patch accepts None as a result\nof node validation in the JSON scehma test.\n\nChange-Id: Ic36d855f30ca59c6ac8be01e49f8d21db7c9b052\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/7ba617b28836e0ab9b1adffce8248c817401b964"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/7ba617b28836e0ab9b1adffce8248c817401b964"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}