)]}'
{"id":"openstack%2Fpython-ironicclient~54689","triplet_id":"openstack%2Fpython-ironicclient~master~Ia523b5741b579e1f237419524e78abc94878c50c","project":"openstack/python-ironicclient","branch":"master","topic":"bug/1240402","hashtags":[],"change_id":"Ia523b5741b579e1f237419524e78abc94878c50c","subject":"Fix i18N compliance","status":"ABANDONED","created":"2013-10-31 09:12:07.000000000","updated":"2013-11-01 02:45:36.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4e16a2c13bf5e0d7349a6a85079a75b313f447cb","_number":54689,"virtual_id_number":54689,"owner":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2013-10-31 09:32:27.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2013-10-31 23:01:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":-1,"date":"2013-10-31 22:50:53.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-10-31 09:27:05.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"date":"2013-10-31 22:50:53.000000000","_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-31 09:32:27.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2013-10-31 22:50:53.000000000","updated_by":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"reviewer":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"state":"REVIEWER"}],"messages":[{"id":"05c8aa71d67535f2453cb7a9e81efd5103b96321","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-31 09:17:33.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-ironicclient-pep8 http://logs.openstack.org/89/54689/1/check/gate-python-ironicclient-pep8/5b88ea5 : FAILURE in 2m 10s\n- gate-python-ironicclient-python26 http://logs.openstack.org/89/54689/1/check/gate-python-ironicclient-python26/fa26722 : FAILURE in 41s\n- gate-python-ironicclient-python27 http://logs.openstack.org/89/54689/1/check/gate-python-ironicclient-python27/aa04165 : FAILURE in 46s\n- gate-python-ironicclient-python33 http://logs.openstack.org/89/54689/1/check/gate-python-ironicclient-python33/6c86c4f : FAILURE in 5m 18s (non-voting)\n- gate-python-ironicclient-pypy http://logs.openstack.org/89/54689/1/check/gate-python-ironicclient-pypy/769b930 : FAILURE in 1m 35s\n","accounts_in_message":[],"_revision_number":1},{"id":"787a6947ccdd8dacc4a4350066091b780c092683","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2013-10-31 09:27:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b08cab7237ed8ea74f07e1f1376e7ff2988c9ed9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-31 09:32:27.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-ironicclient-pep8 http://logs.openstack.org/89/54689/2/check/gate-python-ironicclient-pep8/2c8c72c : SUCCESS in 1m 26s\n- gate-python-ironicclient-python26 http://logs.openstack.org/89/54689/2/check/gate-python-ironicclient-python26/5897d75 : FAILURE in 53s\n- gate-python-ironicclient-python27 http://logs.openstack.org/89/54689/2/check/gate-python-ironicclient-python27/0f10e95 : FAILURE in 2m 04s\n- gate-python-ironicclient-python33 http://logs.openstack.org/89/54689/2/check/gate-python-ironicclient-python33/b36a3e6 : FAILURE in 5m 19s (non-voting)\n- gate-python-ironicclient-pypy http://logs.openstack.org/89/54689/2/check/gate-python-ironicclient-pypy/52d0eff : FAILURE in 1m 36s\n","accounts_in_message":[],"_revision_number":2},{"id":"54ed49d3e1c150fa113470f29df5342a2a12de0d","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2013-10-31 09:39:30.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nLooks like the \u0027gettext\u0027 is not installed, will check existing code, and not sure if this is required.","accounts_in_message":[],"_revision_number":2},{"id":"bb986aed7550ddd9091413a5c0a67d2ac1745f3b","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2013-10-31 09:39:46.000000000","message":"Patch Set 2: No score\n\n","accounts_in_message":[],"_revision_number":2},{"id":"c206dfe720e7a086c3b20830deb43ad3c2d971a7","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2013-10-31 22:50:53.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nRight, python-ironicclient doesn\u0027t have the i18n deps such as Babel. You might need to dig around on the wiki for docs about the official setup for i18n in projects.","accounts_in_message":[],"_revision_number":2},{"id":"ac8ee95bac104a62c120d0a2982c8d43211b9ff9","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2013-10-31 23:00:51.000000000","message":"Patch Set 2:\n\nlifeless, ok will try to install \u0027gettext\u0027","accounts_in_message":[],"_revision_number":2},{"id":"4613fecd0ce13c147002f5311cd81cc8e8ff126a","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2013-10-31 23:01:00.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n","accounts_in_message":[],"_revision_number":2},{"id":"ca7627ad281438176662d4b3d33fd469212b744a","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2013-10-31 23:01:29.000000000","message":"Patch Set 2: Work In Progress\n\nWill try to find the i18n enablement document to install \u0027gettext\u0027","accounts_in_message":[],"_revision_number":2},{"id":"f68f7246b513f889529e70e3a18429d04da0fe2a","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2013-11-01 02:45:36.000000000","message":"Patch Set 2: Abandoned\n\nChecked other python-xxxclient, no i18n enablement is required for client, almost message string are defined and i18n enabled from API server code side already, so cancel this change.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"12407569dd362e58e153f923339bcb83f0010e60","revisions":{"e3307f43aed5059e502614fed14043ad14b24604":{"kind":"REWORK","_number":1,"created":"2013-10-31 09:12:07.000000000","uploader":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"ref":"refs/changes/89/54689/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/89/54689/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/89/54689/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/89/54689/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/89/54689/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/89/54689/1"}}},"commit":{"parents":[{"commit":"94e0fb78e4df8cff30ee2e376b3e64aa602a092c","subject":"Fixes Auth Token being sent as lambda function","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/94e0fb78e4df8cff30ee2e376b3e64aa602a092c"}]}],"author":{"name":"Haomeng, Wang","email":"whaom@cn.ibm.com","date":"2013-10-31 09:09:56.000000000","tz":480},"committer":{"name":"Haomeng, Wang","email":"whaom@cn.ibm.com","date":"2013-10-31 09:12:01.000000000","tz":480},"subject":"Fix i18N compliance","message":"Fix i18N compliance\n\nWe should use \u0027_(\"STRING ...\")\u0027 to enable i18n support\n\nChange-Id: Ia523b5741b579e1f237419524e78abc94878c50c\nCloses-Bug: #1240402\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e3307f43aed5059e502614fed14043ad14b24604"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e3307f43aed5059e502614fed14043ad14b24604"}]},"branch":"refs/heads/master"},"12407569dd362e58e153f923339bcb83f0010e60":{"kind":"REWORK","_number":2,"created":"2013-10-31 09:27:05.000000000","uploader":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"ref":"refs/changes/89/54689/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/89/54689/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/89/54689/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/89/54689/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/89/54689/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/89/54689/2"}}},"commit":{"parents":[{"commit":"94e0fb78e4df8cff30ee2e376b3e64aa602a092c","subject":"Fixes Auth Token being sent as lambda function","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/94e0fb78e4df8cff30ee2e376b3e64aa602a092c"}]}],"author":{"name":"Haomeng, Wang","email":"whaom@cn.ibm.com","date":"2013-10-31 09:09:56.000000000","tz":480},"committer":{"name":"Haomeng, Wang","email":"whaom@cn.ibm.com","date":"2013-10-31 09:26:49.000000000","tz":480},"subject":"Fix i18N compliance","message":"Fix i18N compliance\n\nWe should use \u0027_(\"STRING ...\")\u0027 to enable i18n support\n\nChange-Id: Ia523b5741b579e1f237419524e78abc94878c50c\nCloses-Bug: #1240402\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/12407569dd362e58e153f923339bcb83f0010e60"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/12407569dd362e58e153f923339bcb83f0010e60"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}