)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a7a48bff3cb37ad82d69b1890461e67ff1298d4a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds codes to support maintenance_type field exposed from ironic API."},{"line_number":10,"context_line":"Querying nodes with specified maintenance type is also supported as well."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I429df0ab5ea39140a2b988d5dfdacb24a67b955e"},{"line_number":13,"context_line":"Partial-Bug: #1596107"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_ae7225e2","line":12,"updated":"2018-03-28 09:58:46.000000000","message":"please add Depends-On to the API patch\n\nalso this change needs a release note","commit_id":"16e5afe0fbea88345b6f94db60aa61f1fce43248"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"1d1a8c208b30f1f158ca30311190bce85d06fa83","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds codes to support maintenance_type field exposed from ironic API."},{"line_number":10,"context_line":"Querying nodes with specified maintenance type is also supported as well."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I429df0ab5ea39140a2b988d5dfdacb24a67b955e"},{"line_number":13,"context_line":"Partial-Bug: #1596107"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_beceb62a","line":12,"in_reply_to":"bf659307_ae7225e2","updated":"2018-03-29 06:23:41.000000000","message":"Done","commit_id":"16e5afe0fbea88345b6f94db60aa61f1fce43248"}],"ironicclient/osc/v1/baremetal_node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a7a48bff3cb37ad82d69b1890461e67ff1298d4a","unresolved":false,"context_lines":[{"line_number":630,"context_line":"            params[\u0027associated\u0027] \u003d False"},{"line_number":631,"context_line":"        if parsed_args.maintenance is not None:"},{"line_number":632,"context_line":"            params[\u0027maintenance\u0027] \u003d parsed_args.maintenance"},{"line_number":633,"context_line":"        if parsed_args.maintenance_type is not None:"},{"line_number":634,"context_line":"            params[\u0027maintenance_type\u0027] \u003d parsed_args.maintenance_type"},{"line_number":635,"context_line":"        if parsed_args.provision_state:"},{"line_number":636,"context_line":"            params[\u0027provision_state\u0027] \u003d parsed_args.provision_state"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_6e7c0db5","line":633,"updated":"2018-03-28 09:58:46.000000000","message":"let\u0027s fail if maintenance_type is set, but maintenance is False","commit_id":"16e5afe0fbea88345b6f94db60aa61f1fce43248"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"1d1a8c208b30f1f158ca30311190bce85d06fa83","unresolved":false,"context_lines":[{"line_number":630,"context_line":"            params[\u0027associated\u0027] \u003d False"},{"line_number":631,"context_line":"        if parsed_args.maintenance is not None:"},{"line_number":632,"context_line":"            params[\u0027maintenance\u0027] \u003d parsed_args.maintenance"},{"line_number":633,"context_line":"        if parsed_args.maintenance_type is not None:"},{"line_number":634,"context_line":"            params[\u0027maintenance_type\u0027] \u003d parsed_args.maintenance_type"},{"line_number":635,"context_line":"        if parsed_args.provision_state:"},{"line_number":636,"context_line":"            params[\u0027provision_state\u0027] \u003d parsed_args.provision_state"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_fe7aeeee","line":633,"in_reply_to":"bf659307_6e7c0db5","updated":"2018-03-29 06:23:41.000000000","message":"Done","commit_id":"16e5afe0fbea88345b6f94db60aa61f1fce43248"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"03b2bba0d34544dc919e01ade1e7f54b275214b4","unresolved":false,"context_lines":[{"line_number":634,"context_line":"            if not parsed_args.maintenance:"},{"line_number":635,"context_line":"                raise exc.CommandError("},{"line_number":636,"context_line":"                    _(\"Currently --fault is only supported if \""},{"line_number":637,"context_line":"                      \"--maintenance is specified.\"))"},{"line_number":638,"context_line":"            params[\u0027fault\u0027] \u003d parsed_args.fault"},{"line_number":639,"context_line":"        if parsed_args.provision_state:"},{"line_number":640,"context_line":"            params[\u0027provision_state\u0027] \u003d parsed_args.provision_state"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_08603335","line":637,"updated":"2018-06-05 11:14:48.000000000","message":"This seems redundant to me, filtering by fault implies maintenance anyway.\n\nAlso in what patch was the filtering by faults introduced? I cannot see it in https://review.openstack.org/#/c/556015/ (see my comment there)","commit_id":"95ab4666453bf8ed255654752017180b8ebceb23"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b7132c2e8d9f2c08adedc81674b16e47425851c0","unresolved":false,"context_lines":[{"line_number":634,"context_line":"            if not parsed_args.maintenance:"},{"line_number":635,"context_line":"                raise exc.CommandError("},{"line_number":636,"context_line":"                    _(\"Currently --fault is only supported if \""},{"line_number":637,"context_line":"                      \"--maintenance is specified.\"))"},{"line_number":638,"context_line":"            params[\u0027fault\u0027] \u003d parsed_args.fault"},{"line_number":639,"context_line":"        if parsed_args.provision_state:"},{"line_number":640,"context_line":"            params[\u0027provision_state\u0027] \u003d parsed_args.provision_state"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_84aab416","line":637,"in_reply_to":"5f7c97a3_08603335","updated":"2018-06-07 12:09:47.000000000","message":"Done\num, you are the one who required this at PS1..","commit_id":"95ab4666453bf8ed255654752017180b8ebceb23"}],"ironicclient/v1/node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a7a48bff3cb37ad82d69b1890461e67ff1298d4a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                            \u0027vendor_interface\u0027, \u0027resource_class\u0027]"},{"line_number":56,"context_line":"    _resource_name \u003d \u0027nodes\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def list(self, associated\u003dNone, maintenance\u003dNone, maintenance_type\u003dNone,"},{"line_number":59,"context_line":"             marker\u003dNone, limit\u003dNone, detail\u003dFalse, sort_key\u003dNone,"},{"line_number":60,"context_line":"             sort_dir\u003dNone, fields\u003dNone, provision_state\u003dNone, driver\u003dNone,"},{"line_number":61,"context_line":"             resource_class\u003dNone, chassis\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_4e81098f","line":58,"updated":"2018-03-28 09:58:46.000000000","message":"let\u0027s add the new argument last to avoid breaking people who use positional arguments here (I hope nobody does, but still..)","commit_id":"16e5afe0fbea88345b6f94db60aa61f1fce43248"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"1d1a8c208b30f1f158ca30311190bce85d06fa83","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                            \u0027vendor_interface\u0027, \u0027resource_class\u0027]"},{"line_number":56,"context_line":"    _resource_name \u003d \u0027nodes\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def list(self, associated\u003dNone, maintenance\u003dNone, maintenance_type\u003dNone,"},{"line_number":59,"context_line":"             marker\u003dNone, limit\u003dNone, detail\u003dFalse, sort_key\u003dNone,"},{"line_number":60,"context_line":"             sort_dir\u003dNone, fields\u003dNone, provision_state\u003dNone, driver\u003dNone,"},{"line_number":61,"context_line":"             resource_class\u003dNone, chassis\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_7e6ede2f","line":58,"in_reply_to":"bf659307_4e81098f","updated":"2018-03-29 06:23:41.000000000","message":"Done","commit_id":"16e5afe0fbea88345b6f94db60aa61f1fce43248"}],"releasenotes/notes/node-fault-adbe74fd600063ee.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"03b2bba0d34544dc919e01ade1e7f54b275214b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support the ``fault`` field introduced in ironic Node, that"},{"line_number":5,"context_line":"    includes displaying or querying nodes by this field."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_6871a70c","line":4,"updated":"2018-06-05 11:14:48.000000000","message":"nit: \"Supports the node\u0027s ``fault`` field, introduced in the Bare Metal API version 1.42.\"","commit_id":"95ab4666453bf8ed255654752017180b8ebceb23"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b7132c2e8d9f2c08adedc81674b16e47425851c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support the ``fault`` field introduced in ironic Node, that"},{"line_number":5,"context_line":"    includes displaying or querying nodes by this field."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_47fede05","line":4,"in_reply_to":"5f7c97a3_6871a70c","updated":"2018-06-07 12:09:47.000000000","message":"Done","commit_id":"95ab4666453bf8ed255654752017180b8ebceb23"}]}