)]}'
{"id":"openstack%2Fpython-ironicclient~57087","triplet_id":"openstack%2Fpython-ironicclient~master~I9663662a1a1237cc356e17947aa86b0bf0954339","project":"openstack/python-ironicclient","branch":"master","hashtags":[],"change_id":"I9663662a1a1237cc356e17947aa86b0bf0954339","subject":"Shows \u0027last_error\u0027 property for a node","status":"MERGED","created":"2013-11-19 03:03:37.000000000","updated":"2013-11-22 00:19:08.000000000","submitted":"2013-11-21 23:35:08.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"711d42f4d73d6174666e1d961eba10c8d053dc00","_number":57087,"virtual_id_number":57087,"owner":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-11-21 23:35:08.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":0,"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-11-21 23:10:23.000000000","_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":-1,"date":"2013-11-20 05:54:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":1,"date":"2013-11-19 07:45:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},{"value":2,"date":"2013-11-19 18:30:57.000000000","_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-11-21 23:10:23.000000000","_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"date":"2013-11-20 05:52:02.000000000","_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":0,"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},{"value":0,"date":"2013-11-19 18:30:57.000000000","_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":0,"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-11-19 07:45:22.000000000","updated_by":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"reviewer":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"state":"REVIEWER"},{"updated":"2013-11-19 18:30:57.000000000","updated_by":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"reviewer":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"state":"REVIEWER"},{"updated":"2013-11-20 05:52:02.000000000","updated_by":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"reviewer":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"state":"REVIEWER"},{"updated":"2013-11-21 23:10:23.000000000","updated_by":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"reviewer":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"state":"REVIEWER"},{"updated":"2013-11-21 23:35:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"28d18ae7f62eb5f7677ead87406fd182a8034d95","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-19 03:22:22.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-ironicclient-pep8 http://logs.openstack.org/87/57087/1/check/gate-python-ironicclient-pep8/c6d247d : SUCCESS in 2m 00s\n- gate-python-ironicclient-python26 http://logs.openstack.org/87/57087/1/check/gate-python-ironicclient-python26/5956f1a : SUCCESS in 59s\n- gate-python-ironicclient-python27 http://logs.openstack.org/87/57087/1/check/gate-python-ironicclient-python27/c3e8302 : SUCCESS in 1m 54s\n- gate-python-ironicclient-python33 http://logs.openstack.org/87/57087/1/check/gate-python-ironicclient-python33/d745cc9 : FAILURE in 5m 31s (non-voting)\n- gate-python-ironicclient-pypy http://logs.openstack.org/87/57087/1/check/gate-python-ironicclient-pypy/96644ca : SUCCESS in 1m 39s\n","accounts_in_message":[],"_revision_number":1},{"id":"ce438853a5f56414da77087a420f27d385b18deb","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-11-19 07:45:22.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nlgtm","accounts_in_message":[],"_revision_number":1},{"id":"c3c06864720176f0b5fb38d4a9e21c561704ae12","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2013-11-19 18:30:57.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"22d8a89e382a9d101e8249a4980c44c2b2cb5423","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2013-11-20 05:54:48.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nRuby, I think the shell unittest is required to cover the new field to verify the result and display layout.","accounts_in_message":[],"_revision_number":1},{"id":"8e9d21876178a6b58c060271e23e8663b9c29e70","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2013-11-20 23:18:22.000000000","message":"Patch Set 1:\n\n@Ruby, FYI: I have a patch - \nhttps://review.openstack.org/#/c/53991/ which created our shell test files, you can add your case into these shell unittest files:\n\nironicclient/tests/v1/test_chassis_shell.py\nironicclient/tests/v1/test_port_shell.py\nironicclient/tests/v1/test_node_shell.py","accounts_in_message":[],"_revision_number":1},{"id":"8d4fc4e2982218e9d39ccd47ede14bddb0bd3d28","author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"date":"2013-11-21 23:10:23.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n@Ruby, thanks!\n\n@Haomeng, yes, I agree that this new field should be added to the tests you have created, but I would like this patch to land while we wait for further reviews on your patch. I will take a look in a moment, and I also want to allow Lucas and Max to have a chance to review again, since they both left feedback previously.","accounts_in_message":[],"_revision_number":1},{"id":"ffdcac26261b60bb8a457a3e2f86b022bb78cff9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-21 23:10:25.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"3d383086602a58206e2c3f6f08f9be58de73d7d4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-21 23:35:08.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- gate-python-ironicclient-pep8 http://logs.openstack.org/87/57087/1/gate/gate-python-ironicclient-pep8/32cf62c : SUCCESS in 2m 57s\n- gate-python-ironicclient-python26 http://logs.openstack.org/87/57087/1/gate/gate-python-ironicclient-python26/fcd92c0 : SUCCESS in 2m 06s\n- gate-python-ironicclient-python27 http://logs.openstack.org/87/57087/1/gate/gate-python-ironicclient-python27/ae43666 : SUCCESS in 1m 22s\n- gate-python-ironicclient-python33 http://logs.openstack.org/87/57087/1/gate/gate-python-ironicclient-python33/fbb34dd : FAILURE in 5m 23s (non-voting)\n- gate-python-ironicclient-pypy http://logs.openstack.org/87/57087/1/gate/gate-python-ironicclient-pypy/c2d1946 : SUCCESS in 1m 39s\n","accounts_in_message":[],"_revision_number":1},{"id":"1a74655fc1c79f5fb8e4d20118dc331f8d477f0a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-21 23:35:08.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"711d42f4d73d6174666e1d961eba10c8d053dc00","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2013-11-22 00:19:08.000000000","message":"Patch Set 1:\n\n@Devananda, ok that is fine for me, I will commit new patch to add these new shell unittest files.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"426072bb07c3c0cdc122f2ee22fc2fc971c21b0e","revisions":{"426072bb07c3c0cdc122f2ee22fc2fc971c21b0e":{"kind":"REWORK","_number":1,"created":"2013-11-19 03:03:37.000000000","uploader":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"ref":"refs/changes/87/57087/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/87/57087/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/87/57087/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/87/57087/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/87/57087/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/87/57087/1"}}},"commit":{"parents":[{"commit":"8c394d441b5ae4300376c2698673f051954defb6","subject":"Merge \"Comply with new hacking release\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/8c394d441b5ae4300376c2698673f051954defb6"}]}],"author":{"name":"Ruby Loo","email":"rloo@yahoo-inc.com","date":"2013-11-19 02:48:38.000000000","tz":0},"committer":{"name":"Ruby Loo","email":"rloo@yahoo-inc.com","date":"2013-11-19 02:48:38.000000000","tz":0},"subject":"Shows \u0027last_error\u0027 property for a node","message":"Shows \u0027last_error\u0027 property for a node\n\nhttps://review.openstack.org/#/c/54466/ introduced a \u0027last_error\u0027\nfield for a node. This string field is used to store the last error\nfrom any requested asynchronous operation (eg, whether that was to\nchange power state, or deploy a node, or anything else) that\nstarted but failed to finish. It is cleared when any new asynchronous\noperation is started.\n\nWith this change, an \u0027ironic node-show\u0027 command will also return the\n\u0027last_error\u0027 value (if any) for the specified node.\n\nChange-Id: I9663662a1a1237cc356e17947aa86b0bf0954339\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/426072bb07c3c0cdc122f2ee22fc2fc971c21b0e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/426072bb07c3c0cdc122f2ee22fc2fc971c21b0e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}