)]}'
{"ironicclient/osc/v1/baremetal_node.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a14541d44c7884c2b2d99b00279178a78bb91015","unresolved":false,"context_lines":[{"line_number":1416,"context_line":"            \"--conductor-group\","},{"line_number":1417,"context_line":"            action\u003d\"store_true\","},{"line_number":1418,"context_line":"            help\u003d_(\u0027Unset conductor group for this baremetal node (the \u0027"},{"line_number":1419,"context_line":"                   \u0027default group will be used)\u0027),"},{"line_number":1420,"context_line":"        )"},{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_d0fdf83c","line":1419,"updated":"2018-07-24 14:08:11.000000000","message":"I wonder if \u0027default group\u0027 will be confusing. As long as we document what that is, should be fine I think.","commit_id":"fb94fb825cccecd11c4a2f78beeff3b0b19956f3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a7789dcd5a220c77d770606e4765eddaad6748ee","unresolved":false,"context_lines":[{"line_number":1416,"context_line":"            \"--conductor-group\","},{"line_number":1417,"context_line":"            action\u003d\"store_true\","},{"line_number":1418,"context_line":"            help\u003d_(\u0027Unset conductor group for this baremetal node (the \u0027"},{"line_number":1419,"context_line":"                   \u0027default group will be used)\u0027),"},{"line_number":1420,"context_line":"        )"},{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_ff2f8a86","line":1419,"in_reply_to":"5f7c97a3_d0fdf83c","updated":"2018-07-25 08:55:26.000000000","message":"Yeah, all these help strings are quite short.","commit_id":"fb94fb825cccecd11c4a2f78beeff3b0b19956f3"}],"ironicclient/tests/unit/v1/test_node.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a14541d44c7884c2b2d99b00279178a78bb91015","unresolved":false,"context_lines":[{"line_number":42,"context_line":"         \u0027name\u0027: \u0027fake-node-1\u0027,"},{"line_number":43,"context_line":"         \u0027resource_class\u0027: \u0027foo\u0027,"},{"line_number":44,"context_line":"         \u0027extra\u0027: {},"},{"line_number":45,"context_line":"         \u0027conductor_group\u0027: \u0027in-the-closet-to-the-left\u0027}"},{"line_number":46,"context_line":"NODE2 \u003d {\u0027uuid\u0027: \u002766666666-7777-8888-9999-111111111111\u0027,"},{"line_number":47,"context_line":"         \u0027instance_uuid\u0027: \u002766666666-7777-8888-9999-222222222222\u0027,"},{"line_number":48,"context_line":"         \u0027chassis_uuid\u0027: \u0027aaaaaaaa-1111-bbbb-2222-cccccccccccc\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_502b289a","line":45,"updated":"2018-07-24 14:08:11.000000000","message":"shouldn\u0027t this be \u0027foo\u0027 ?","commit_id":"fb94fb825cccecd11c4a2f78beeff3b0b19956f3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a7789dcd5a220c77d770606e4765eddaad6748ee","unresolved":false,"context_lines":[{"line_number":42,"context_line":"         \u0027name\u0027: \u0027fake-node-1\u0027,"},{"line_number":43,"context_line":"         \u0027resource_class\u0027: \u0027foo\u0027,"},{"line_number":44,"context_line":"         \u0027extra\u0027: {},"},{"line_number":45,"context_line":"         \u0027conductor_group\u0027: \u0027in-the-closet-to-the-left\u0027}"},{"line_number":46,"context_line":"NODE2 \u003d {\u0027uuid\u0027: \u002766666666-7777-8888-9999-111111111111\u0027,"},{"line_number":47,"context_line":"         \u0027instance_uuid\u0027: \u002766666666-7777-8888-9999-222222222222\u0027,"},{"line_number":48,"context_line":"         \u0027chassis_uuid\u0027: \u0027aaaaaaaa-1111-bbbb-2222-cccccccccccc\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_bf47d252","line":45,"in_reply_to":"5f7c97a3_502b289a","updated":"2018-07-25 08:55:26.000000000","message":"It does not matter, this all is fake","commit_id":"fb94fb825cccecd11c4a2f78beeff3b0b19956f3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"84bcb9600da3669bbc7232fa3814644d4c395f83","unresolved":false,"context_lines":[{"line_number":42,"context_line":"         \u0027name\u0027: \u0027fake-node-1\u0027,"},{"line_number":43,"context_line":"         \u0027resource_class\u0027: \u0027foo\u0027,"},{"line_number":44,"context_line":"         \u0027extra\u0027: {},"},{"line_number":45,"context_line":"         \u0027conductor_group\u0027: \u0027in-the-closet-to-the-left\u0027}"},{"line_number":46,"context_line":"NODE2 \u003d {\u0027uuid\u0027: \u002766666666-7777-8888-9999-111111111111\u0027,"},{"line_number":47,"context_line":"         \u0027instance_uuid\u0027: \u002766666666-7777-8888-9999-222222222222\u0027,"},{"line_number":48,"context_line":"         \u0027chassis_uuid\u0027: \u0027aaaaaaaa-1111-bbbb-2222-cccccccccccc\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_eb4a6858","line":45,"in_reply_to":"5f7c97a3_bf47d252","updated":"2018-07-25 12:06:16.000000000","message":"I like it!  In the closet to the left that is.","commit_id":"fb94fb825cccecd11c4a2f78beeff3b0b19956f3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a14541d44c7884c2b2d99b00279178a78bb91015","unresolved":false,"context_lines":[{"line_number":791,"context_line":"    def test_node_list_conductor_group(self):"},{"line_number":792,"context_line":"        nodes \u003d self.mgr.list(conductor_group\u003d\u0027foo\u0027)"},{"line_number":793,"context_line":"        expect \u003d ["},{"line_number":794,"context_line":"            (\u0027GET\u0027, \u0027/v1/nodes/?conductor_group\u003dfoo\u0027, {}, None),"},{"line_number":795,"context_line":"        ]"},{"line_number":796,"context_line":"        self.assertEqual(expect, self.api.calls)"},{"line_number":797,"context_line":"        self.assertThat(nodes, HasLength(1))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_f004b41b","line":794,"updated":"2018-07-24 14:08:11.000000000","message":"hmm, maybe our tests are a sham. node1 has conductor_group \u003d \u0027in-the-closet-to-the-left\u0027. How does it match with this?\n\nOH, L204 is the shim.","commit_id":"fb94fb825cccecd11c4a2f78beeff3b0b19956f3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a7789dcd5a220c77d770606e4765eddaad6748ee","unresolved":false,"context_lines":[{"line_number":791,"context_line":"    def test_node_list_conductor_group(self):"},{"line_number":792,"context_line":"        nodes \u003d self.mgr.list(conductor_group\u003d\u0027foo\u0027)"},{"line_number":793,"context_line":"        expect \u003d ["},{"line_number":794,"context_line":"            (\u0027GET\u0027, \u0027/v1/nodes/?conductor_group\u003dfoo\u0027, {}, None),"},{"line_number":795,"context_line":"        ]"},{"line_number":796,"context_line":"        self.assertEqual(expect, self.api.calls)"},{"line_number":797,"context_line":"        self.assertThat(nodes, HasLength(1))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_7f513a0d","line":794,"in_reply_to":"5f7c97a3_f004b41b","updated":"2018-07-25 08:55:26.000000000","message":"right","commit_id":"fb94fb825cccecd11c4a2f78beeff3b0b19956f3"}],"ironicclient/v1/node.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"5927e6381d2ab1272c22232eab6cd4f9359f7cc1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def list(self, associated\u003dNone, maintenance\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":60,"context_line":"             detail\u003dFalse, sort_key\u003dNone, sort_dir\u003dNone, fields\u003dNone,"},{"line_number":61,"context_line":"             provision_state\u003dNone, driver\u003dNone, resource_class\u003dNone,"},{"line_number":62,"context_line":"             chassis\u003dNone, fault\u003dNone, os_ironic_api_version\u003dNone):"},{"line_number":63,"context_line":"        \"\"\"Retrieve a list of nodes."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        :param associated: Optional. Either a Boolean or a string"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d85c5b1c","line":62,"updated":"2018-07-23 15:12:22.000000000","message":"In my testing: \n\n$ openstack baremetal node list --conductor-group foo\nlist() got an unexpected keyword argument \u0027conductor_group\u0027\n\nNeed to add it here :)","commit_id":"a7f44c4a746e57bec3a2ab3b18a34eb1e1de8f63"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"be1b57afa175a31800d877559f4de60b76fa42af","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def list(self, associated\u003dNone, maintenance\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":60,"context_line":"             detail\u003dFalse, sort_key\u003dNone, sort_dir\u003dNone, fields\u003dNone,"},{"line_number":61,"context_line":"             provision_state\u003dNone, driver\u003dNone, resource_class\u003dNone,"},{"line_number":62,"context_line":"             chassis\u003dNone, fault\u003dNone, os_ironic_api_version\u003dNone):"},{"line_number":63,"context_line":"        \"\"\"Retrieve a list of nodes."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        :param associated: Optional. Either a Boolean or a string"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b8995fd0","line":62,"in_reply_to":"5f7c97a3_d85c5b1c","updated":"2018-07-23 15:13:06.000000000","message":"right","commit_id":"a7f44c4a746e57bec3a2ab3b18a34eb1e1de8f63"}],"releasenotes/notes/conductor-group-9cfab3756aa108e4.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a14541d44c7884c2b2d99b00279178a78bb91015","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for the ``--conductor-group`` argument to the following"},{"line_number":5,"context_line":"    CLI commands:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ``openstack baremetal node create``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_fb9ed5b5","line":4,"updated":"2018-07-24 14:08:11.000000000","message":"might be useful to elaborate on what conductor-group is useful for.","commit_id":"fb94fb825cccecd11c4a2f78beeff3b0b19956f3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a7789dcd5a220c77d770606e4765eddaad6748ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for the ``--conductor-group`` argument to the following"},{"line_number":5,"context_line":"    CLI commands:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ``openstack baremetal node create``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_3f3bc2c9","line":4,"in_reply_to":"5f7c97a3_fb9ed5b5","updated":"2018-07-25 08:55:26.000000000","message":"a link to the docs would be handy if we had them.. I can follow-up with a short explanation","commit_id":"fb94fb825cccecd11c4a2f78beeff3b0b19956f3"}]}