)]}'
{"ironicclient/tests/unit/osc/v1/test_baremetal_node.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"36fe4fa854f1dae23bfa8373bfcd6031afb56d89","unresolved":false,"context_lines":[{"line_number":603,"context_line":"            **kwargs"},{"line_number":604,"context_line":"        )"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        # NOTE(dtantsur): please keep this list sorted for sanity reasons"},{"line_number":607,"context_line":"        collist \u003d ["},{"line_number":608,"context_line":"            \u0027Automated Clean\u0027,"},{"line_number":609,"context_line":"            \u0027BIOS Interface\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6f8a8e1a","line":606,"range":{"start_line":606,"start_character":33,"end_line":606,"end_character":54},"updated":"2018-10-25 02:43:17.000000000","message":"if so, why we need L655?","commit_id":"9325743c0d66989c90e41fc0c365532cd86d5496"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"983a1afb55c90064f76aefbcd0b95c645ae48a68","unresolved":false,"context_lines":[{"line_number":603,"context_line":"            **kwargs"},{"line_number":604,"context_line":"        )"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        # NOTE(dtantsur): please keep this list sorted for sanity reasons"},{"line_number":607,"context_line":"        collist \u003d ["},{"line_number":608,"context_line":"            \u0027Automated Clean\u0027,"},{"line_number":609,"context_line":"            \u0027BIOS Interface\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_cdf8e619","line":606,"range":{"start_line":606,"start_character":33,"end_line":606,"end_character":54},"in_reply_to":"3f79a3b5_6f8a8e1a","updated":"2018-11-02 13:28:26.000000000","message":"This one is to make sure the list is easy to update. When it is sorted, you always know where to insert a new field. Line 655 is to enforce it in case we forget :)","commit_id":"9325743c0d66989c90e41fc0c365532cd86d5496"}],"ironicclient/v1/resource_fields.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"36fe4fa854f1dae23bfa8373bfcd6031afb56d89","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# Nodes"},{"line_number":202,"context_line":"# NOTE(dtantsur): the sorting of the list must follow the sorting for the"},{"line_number":203,"context_line":"# corresponding headings, so some items (like raid_config) may seem out of"},{"line_number":204,"context_line":"# order here."},{"line_number":205,"context_line":"NODE_DETAILED_RESOURCE \u003d Resource("},{"line_number":206,"context_line":"    [\u0027automated_clean\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0f1f5a0b","line":203,"range":{"start_line":203,"start_character":16,"end_line":203,"end_character":24},"updated":"2018-10-25 02:43:17.000000000","message":"Please forgive me, I was confused by this for a while, and figured out it was talking about field values. Since we used \"label\" at L24, I think this \"heading\" is a bit obscure, maybe we just follow the \"label\" term, or I personally would prefer some words like field description.","commit_id":"9325743c0d66989c90e41fc0c365532cd86d5496"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"983a1afb55c90064f76aefbcd0b95c645ae48a68","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# Nodes"},{"line_number":202,"context_line":"# NOTE(dtantsur): the sorting of the list must follow the sorting for the"},{"line_number":203,"context_line":"# corresponding headings, so some items (like raid_config) may seem out of"},{"line_number":204,"context_line":"# order here."},{"line_number":205,"context_line":"NODE_DETAILED_RESOURCE \u003d Resource("},{"line_number":206,"context_line":"    [\u0027automated_clean\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6d075217","line":203,"range":{"start_line":203,"start_character":16,"end_line":203,"end_character":24},"in_reply_to":"3f79a3b5_0f1f5a0b","updated":"2018-11-02 13:28:26.000000000","message":"I can follow-up with it.","commit_id":"9325743c0d66989c90e41fc0c365532cd86d5496"}]}