)]}'
{"id":"openstack%2Fpython-ironicclient~640491","triplet_id":"openstack%2Fpython-ironicclient~master~I610836e5038774621690aca88b2aee25670f0262","project":"openstack/python-ironicclient","branch":"master","topic":"story-2005118","hashtags":[],"change_id":"I610836e5038774621690aca88b2aee25670f0262","subject":"pass endpoint interface to http client","status":"MERGED","created":"2019-03-01 19:13:37.000000000","updated":"2019-03-07 06:00:38.000000000","submitted":"2019-03-06 20:28:00.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":29,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"640491-1551904080529-560e48ac","meta_rev_id":"fd40e27a0f0d5b862b83c8e0758479cac93a7494","_number":640491,"virtual_id_number":640491,"owner":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":2,"date":"2019-03-06 20:28:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-03-06 18:30:01.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2019-03-06 17:49:27.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2019-03-06 17:24:26.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":1,"date":"2019-03-06 17:49:27.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-01 21:22:32.000000000","updated_by":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"reviewer":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"state":"REVIEWER"},{"updated":"2019-03-05 11:50:42.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2019-03-06 17:15:11.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2019-03-06 17:19:23.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-03-06 17:24:26.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2019-03-06 17:49:27.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2019-03-06 20:28:00.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"762422d475ec998bcb0cd11a8c0316f7824ecc18","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-03-01 19:13:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f8e19d55cbb8f542fccea0a1fe26d9457ac63a37","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-01 20:14:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/91/640491/1/check/openstack-tox-cover/078a510/cover/ : SUCCESS in 5m 48s\n- openstack-tox-lower-constraints http://logs.openstack.org/91/640491/1/check/openstack-tox-lower-constraints/1d69661/ : SUCCESS in 8m 15s\n- openstack-tox-pep8 http://logs.openstack.org/91/640491/1/check/openstack-tox-pep8/4cfa4f4/ : SUCCESS in 5m 09s\n- openstack-tox-py27 http://logs.openstack.org/91/640491/1/check/openstack-tox-py27/a72c0b0/ : SUCCESS in 6m 35s\n- openstack-tox-py35 http://logs.openstack.org/91/640491/1/check/openstack-tox-py35/cb37503/ : SUCCESS in 7m 45s\n- openstack-tox-py36 http://logs.openstack.org/91/640491/1/check/openstack-tox-py36/612667a/ : SUCCESS in 7m 16s\n- openstack-tox-py37 http://logs.openstack.org/91/640491/1/check/openstack-tox-py37/56d949a/ : SUCCESS in 6m 36s\n- openstackclient-check-plugins http://logs.openstack.org/91/640491/1/check/openstackclient-check-plugins/a24e090/ : SUCCESS in 6m 21s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/91/640491/1/check/openstack-tox-docs/18a6e65/html/ : SUCCESS in 5m 03s\n- build-openstack-releasenotes http://logs.openstack.org/91/640491/1/check/build-openstack-releasenotes/791fbda/html/ : SUCCESS in 5m 28s\n- ironicclient-dsvm-functional http://logs.openstack.org/91/640491/1/check/ironicclient-dsvm-functional/3f75663/ : SUCCESS in 21m 55s\n- ironicclient-tempest-dsvm-src http://logs.openstack.org/91/640491/1/check/ironicclient-tempest-dsvm-src/3e1061a/ : SUCCESS in 41m 36s","accounts_in_message":[],"_revision_number":1},{"id":"7e660f9740ac44ad788eadfc393901cdb3d212a3","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-03-01 20:43:50.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c815985a1ea23be7cb97c7305e3756a7259c60d0","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-03-01 20:56:19.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5fd62d114f07d9c3e7db19f0b648f8b3bbf9881a","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-03-01 21:11:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0f61a799bdb25acf3b08538d34d9d396deb7ff66","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-03-01 21:22:32.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"85408ff34b2a6910ce8d6fc7d3751746b882c3f8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-01 22:06:35.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/91/640491/2/check/openstack-tox-cover/7325a95/cover/ : SUCCESS in 7m 36s\n- openstack-tox-lower-constraints http://logs.openstack.org/91/640491/2/check/openstack-tox-lower-constraints/4076c65/ : SUCCESS in 6m 50s\n- openstack-tox-pep8 http://logs.openstack.org/91/640491/2/check/openstack-tox-pep8/01f0d6b/ : SUCCESS in 5m 42s\n- openstack-tox-py27 http://logs.openstack.org/91/640491/2/check/openstack-tox-py27/3953a25/ : SUCCESS in 4m 37s\n- openstack-tox-py35 http://logs.openstack.org/91/640491/2/check/openstack-tox-py35/1613d27/ : SUCCESS in 5m 29s\n- openstack-tox-py36 http://logs.openstack.org/91/640491/2/check/openstack-tox-py36/1d6c77d/ : SUCCESS in 5m 21s\n- openstack-tox-py37 http://logs.openstack.org/91/640491/2/check/openstack-tox-py37/cc0a801/ : SUCCESS in 5m 16s\n- openstackclient-check-plugins http://logs.openstack.org/91/640491/2/check/openstackclient-check-plugins/7075167/ : SUCCESS in 6m 31s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/91/640491/2/check/openstack-tox-docs/ac2727d/html/ : SUCCESS in 4m 39s\n- build-openstack-releasenotes http://logs.openstack.org/91/640491/2/check/build-openstack-releasenotes/c6705c1/html/ : SUCCESS in 4m 07s\n- ironicclient-dsvm-functional http://logs.openstack.org/91/640491/2/check/ironicclient-dsvm-functional/a029137/ : SUCCESS in 16m 49s\n- ironicclient-tempest-dsvm-src http://logs.openstack.org/91/640491/2/check/ironicclient-tempest-dsvm-src/057aa33/ : SUCCESS in 50m 16s","accounts_in_message":[],"_revision_number":2},{"id":"76b9f0aeca018ce33ac187b1703790bb3a00624c","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-03-02 06:46:22.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6ade3f0f5f87a2ebb5b6db7a3d4702c7c21f4934","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-02 07:30:35.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/91/640491/3/check/openstack-tox-cover/1146228/cover/ : SUCCESS in 5m 40s\n- openstack-tox-lower-constraints http://logs.openstack.org/91/640491/3/check/openstack-tox-lower-constraints/79a2648/ : SUCCESS in 7m 20s\n- openstack-tox-pep8 http://logs.openstack.org/91/640491/3/check/openstack-tox-pep8/ad6b608/ : SUCCESS in 4m 15s\n- openstack-tox-py27 http://logs.openstack.org/91/640491/3/check/openstack-tox-py27/484b0a7/ : SUCCESS in 4m 25s\n- openstack-tox-py35 http://logs.openstack.org/91/640491/3/check/openstack-tox-py35/538a64c/ : SUCCESS in 4m 27s\n- openstack-tox-py36 http://logs.openstack.org/91/640491/3/check/openstack-tox-py36/16dfd9b/ : SUCCESS in 4m 41s\n- openstack-tox-py37 http://logs.openstack.org/91/640491/3/check/openstack-tox-py37/c05c465/ : SUCCESS in 4m 50s\n- openstackclient-check-plugins http://logs.openstack.org/91/640491/3/check/openstackclient-check-plugins/311e694/ : SUCCESS in 6m 27s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/91/640491/3/check/openstack-tox-docs/93ab202/html/ : SUCCESS in 4m 15s\n- build-openstack-releasenotes http://logs.openstack.org/91/640491/3/check/build-openstack-releasenotes/f586337/html/ : SUCCESS in 4m 16s\n- ironicclient-dsvm-functional http://logs.openstack.org/91/640491/3/check/ironicclient-dsvm-functional/c0ca0f2/ : SUCCESS in 18m 41s\n- ironicclient-tempest-dsvm-src http://logs.openstack.org/91/640491/3/check/ironicclient-tempest-dsvm-src/cb41373/ : SUCCESS in 41m 22s","accounts_in_message":[],"_revision_number":3},{"id":"a06e637846519ab09081cab302dd2cfd3f130f99","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-03-04 11:02:41.000000000","message":"Patch Set 3: Code-Review+1\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"eddbf19ef3689a3f047581ed62afda77e753eaef","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-03-04 16:45:37.000000000","message":"Patch Set 3:\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"4b8bb9b78fc42f32f051426d3d3579d85e1f1384","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-03-04 16:47:23.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"8fe0f03b8051dec4978d3e9d9454569efa8b4157","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-04 19:08:39.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/91/640491/4/check/openstack-tox-cover/d10a3ee/cover/ : SUCCESS in 4m 52s\n- openstack-tox-lower-constraints http://logs.openstack.org/91/640491/4/check/openstack-tox-lower-constraints/236516b/ : SUCCESS in 6m 55s\n- openstack-tox-pep8 http://logs.openstack.org/91/640491/4/check/openstack-tox-pep8/f9514a1/ : SUCCESS in 7m 03s\n- openstack-tox-py27 http://logs.openstack.org/91/640491/4/check/openstack-tox-py27/0e06115/ : SUCCESS in 4m 47s\n- openstack-tox-py35 http://logs.openstack.org/91/640491/4/check/openstack-tox-py35/37bdfcf/ : SUCCESS in 5m 00s\n- openstack-tox-py36 http://logs.openstack.org/91/640491/4/check/openstack-tox-py36/8a5506f/ : SUCCESS in 4m 36s\n- openstack-tox-py37 http://logs.openstack.org/91/640491/4/check/openstack-tox-py37/2d24bd9/ : SUCCESS in 7m 20s\n- openstackclient-check-plugins http://logs.openstack.org/91/640491/4/check/openstackclient-check-plugins/646a2ca/ : SUCCESS in 7m 06s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/91/640491/4/check/openstack-tox-docs/48c61fe/html/ : SUCCESS in 4m 35s\n- build-openstack-releasenotes http://logs.openstack.org/91/640491/4/check/build-openstack-releasenotes/19977ec/html/ : SUCCESS in 4m 42s\n- ironicclient-dsvm-functional http://logs.openstack.org/91/640491/4/check/ironicclient-dsvm-functional/20f9c3c/ : SUCCESS in 30m 22s\n- ironicclient-tempest-dsvm-src http://logs.openstack.org/91/640491/4/check/ironicclient-tempest-dsvm-src/c569d51/ : SUCCESS in 47m 33s","accounts_in_message":[],"_revision_number":4},{"id":"e48eaa269d3c5778736431885446b4b0075b3bdd","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-03-05 11:50:42.000000000","message":"Patch Set 4: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"02b7cfdc00a6d409a557cf7a67ba8a0c06d720c2","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2019-03-05 20:13:09.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)\n\nThanks for fixing this.\n\nI think there are two issues:\n1. \u0027interface\u0027 argument is broken; we aren\u0027t taking that into consideration. Broken since Pike.\n2. new \u0027valid_interfaces\u0027 argument that we don\u0027t support, but which (I think) nova started to use in Queens, with ironicclient.\n\nIf that is true, then this is a feature and a bug? Or do we consider both to be bugs?","accounts_in_message":[],"_revision_number":4},{"id":"7f406feda6090c4e5e326397c11d825c70e451ee","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-03-05 23:59:47.000000000","message":"Patch Set 4:\n\n(4 comments)\n\n\u003e (1 comment)\n \u003e \n \u003e Thanks for fixing this.\n \u003e \n \u003e I think there are two issues:\n \u003e 1. \u0027interface\u0027 argument is broken; we aren\u0027t taking that into\n \u003e consideration. Broken since Pike.\n \u003e 2. new \u0027valid_interfaces\u0027 argument that we don\u0027t support, but which\n \u003e (I think) nova started to use in Queens, with ironicclient.\n \u003e \n \u003e If that is true, then this is a feature and a bug? Or do we\n \u003e consider both to be bugs?\n\nThis is very much a bug, and we should backport the fix because:\n\n 1. ironicclient broke backward compatibility in queens by not allowing any endpoint other than public endpoint, which bakes the second argument.\n 2. this represents a security risk because this limitation force operators to open up public network access for the controllers. The controller network in production is segmented off, which does not have routes to public networks.\n\nRight now, as I mentioned in the comments, KSA only cares about the \u0027interface\u0027 argument as far as get_endpoint() is concerned. \u0027valid_interfaces\u0027 is done via loading. The problem with ironicclient right now is that it is using using the legacy interfaces. We really need to modernize the code. We don\u0027t need to SessionClient wrapping anymore I think. But that should be done in a separate story though.","accounts_in_message":[],"_revision_number":4},{"id":"6e72efd9f2215b541d229eb5af653de9693b630d","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-03-06 00:43:58.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"7debc972815f3d1085efc63b600538880dff54d0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-06 01:45:44.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/91/640491/5/check/openstack-tox-cover/e76162e/cover/ : SUCCESS in 5m 13s\n- openstack-tox-lower-constraints http://logs.openstack.org/91/640491/5/check/openstack-tox-lower-constraints/fae131f/ : SUCCESS in 6m 33s\n- openstack-tox-pep8 http://logs.openstack.org/91/640491/5/check/openstack-tox-pep8/8b9d12c/ : SUCCESS in 4m 44s\n- openstack-tox-py27 http://logs.openstack.org/91/640491/5/check/openstack-tox-py27/3b79b39/ : SUCCESS in 5m 06s\n- openstack-tox-py35 http://logs.openstack.org/91/640491/5/check/openstack-tox-py35/0ed92e8/ : SUCCESS in 5m 33s\n- openstack-tox-py36 http://logs.openstack.org/91/640491/5/check/openstack-tox-py36/32fbcfd/ : SUCCESS in 5m 05s\n- openstack-tox-py37 http://logs.openstack.org/91/640491/5/check/openstack-tox-py37/6302f2c/ : SUCCESS in 5m 40s\n- openstackclient-check-plugins http://logs.openstack.org/91/640491/5/check/openstackclient-check-plugins/9b0fb80/ : SUCCESS in 7m 03s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/91/640491/5/check/openstack-tox-docs/dec9688/html/ : SUCCESS in 4m 28s\n- build-openstack-releasenotes http://logs.openstack.org/91/640491/5/check/build-openstack-releasenotes/c2aaab3/html/ : SUCCESS in 3m 58s\n- ironicclient-dsvm-functional http://logs.openstack.org/91/640491/5/check/ironicclient-dsvm-functional/0beb21d/ : SUCCESS in 22m 09s\n- ironicclient-tempest-dsvm-src http://logs.openstack.org/91/640491/5/check/ironicclient-tempest-dsvm-src/02c47c5/ : SUCCESS in 51m 09s","accounts_in_message":[],"_revision_number":5},{"id":"b17363177adbf473d93179b9c807f4da0eed97d3","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2019-03-06 15:13:35.000000000","message":"Patch Set 5: Code-Review+1\n\n(3 comments)\n\nThanks, I\u0027m good with this. Would like some clarification first. At this point, you know more about the code than I do :) I find the unit tests to be odd; I\u0027m not totally sure what-all is being tested and left a question there for you.\n\nIf \u0027valid_interfaces\u0027 isn\u0027t used by Session etc, why is it being passed in as an argument. Is it because there is some other way to authenticate, that the client doesn\u0027t support yet?","accounts_in_message":[],"_revision_number":5},{"id":"7f6b82cb33ac8035275e8bb30776a1d79da4da2b","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2019-03-06 15:15:02.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"93ad77ce153189b95cf769bcb1d27cf3296c79b4","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-06 16:28:07.000000000","message":"Patch Set 5:\n\n\u003e If \u0027valid_interfaces\u0027 isn\u0027t used by Session etc, why is it being passed in as an argument. Is it because there is some other way to authenticate, that the client doesn\u0027t support yet?\n\nHi Ruby. It\u0027s a ksa thing, which means it\u0027s part of the config inherited from ksa, which means operators will be encouraged to start using \u0027valid_interfaces\u0027 instead of \u0027interface\u0027 in their configs. I can\u0027t speak to other consumers of this client (are there any?) but from the nova side, since we still have this hacked-up translation layer from the conf to ksa adapter to ironicclient kwargs back to ksa adapter, we could definitely get away with not including the \u0027valid_interfaces\u0027 support in the *backportable* version of this patch. In fact, that\u0027s probably the right thing to do: just support \u0027interfaces\u0027 here for backporting purposes, and then do a master-only change to add support for \u0027valid_interfaces\u0027.\n\nSee discussion on the nova side of this [1] - whose split-out changes would actually then map 1:1 with the above proposed split-out of this change.\n\n[1] https://review.openstack.org/#/c/640879/","accounts_in_message":[],"_revision_number":5},{"id":"7380a10d1b95610459319657e076527cd91b6753","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-06 16:57:45.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"0127cf7744fc26f4476eb184e50d489349eb96ab","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2019-03-06 17:11:37.000000000","message":"Patch Set 6: Code-Review+2\n\n(2 comments)\n\nThanks! I think this makes more sense for backporting, and a separate PR to handle \u0027valid_interfaces\u0027.","accounts_in_message":[],"_revision_number":6},{"id":"3ac3013679c7113ab3231d6bf66e2dc6e416a7eb","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-06 17:14:33.000000000","message":"Patch Set 5:\n\n(3 comments)","accounts_in_message":[],"_revision_number":5},{"id":"15a06a5bd93b53fed944e615cc423d94ad1b74b5","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2019-03-06 17:15:11.000000000","message":"Patch Set 6: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"ad4ac97b6e4874faa526aa55d91e26cc600c9609","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-06 17:16:55.000000000","message":"Patch Set 7: Published edit on patch set 6.","accounts_in_message":[],"_revision_number":7},{"id":"be231c7e285f037305e5ac2032aff1cda0878e64","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-06 17:19:23.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"76197a24deeeaf4cef7a17d9ac224675b2af3880","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2019-03-06 17:24:26.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"057bf75468a85732838bbd2d2141fa0859ad157a","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2019-03-06 17:49:27.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1\n\nThanks!","accounts_in_message":[],"_revision_number":7},{"id":"d505272a10e40a9888c2a76f90ce05773f0a4f38","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-06 18:13:01.000000000","message":"Patch Set 7: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/91/640491/7/check/openstack-tox-cover/3f6185a/cover/ : SUCCESS in 4m 31s\n- openstack-tox-lower-constraints http://logs.openstack.org/91/640491/7/check/openstack-tox-lower-constraints/7572cb3/ : SUCCESS in 7m 48s\n- openstack-tox-pep8 http://logs.openstack.org/91/640491/7/check/openstack-tox-pep8/aba8324/ : SUCCESS in 4m 45s\n- openstack-tox-py27 http://logs.openstack.org/91/640491/7/check/openstack-tox-py27/ddc5ca6/ : SUCCESS in 7m 39s\n- openstack-tox-py35 http://logs.openstack.org/91/640491/7/check/openstack-tox-py35/b09afa8/ : SUCCESS in 5m 33s\n- openstack-tox-py36 http://logs.openstack.org/91/640491/7/check/openstack-tox-py36/f5ca6eb/ : SUCCESS in 5m 41s\n- openstack-tox-py37 http://logs.openstack.org/91/640491/7/check/openstack-tox-py37/bd0e45f/ : SUCCESS in 5m 50s\n- openstackclient-check-plugins http://logs.openstack.org/91/640491/7/check/openstackclient-check-plugins/cda25c6/ : SUCCESS in 6m 53s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/91/640491/7/check/openstack-tox-docs/5d64f04/html/ : SUCCESS in 4m 46s\n- build-openstack-releasenotes http://logs.openstack.org/91/640491/7/check/build-openstack-releasenotes/12cb127/html/ : SUCCESS in 5m 36s\n- ironicclient-dsvm-functional http://logs.openstack.org/91/640491/7/check/ironicclient-dsvm-functional/d582ad4/ : SUCCESS in 20m 50s\n- ironicclient-tempest-dsvm-src http://logs.openstack.org/91/640491/7/check/ironicclient-tempest-dsvm-src/4961aed/ : FAILURE in 49m 44s","accounts_in_message":[],"_revision_number":7},{"id":"87da5dff74821f41bda7ae3fa7b10929b049cbd8","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-03-06 18:30:01.000000000","message":"Patch Set 7:\n\nrecheck","accounts_in_message":[],"_revision_number":7},{"id":"97e1620befd643034c7e4384ad9576352bcb0171","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-06 19:33:23.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/91/640491/7/check/openstack-tox-cover/6e59036/cover/ : SUCCESS in 5m 36s\n- openstack-tox-lower-constraints http://logs.openstack.org/91/640491/7/check/openstack-tox-lower-constraints/ed0f8eb/ : SUCCESS in 6m 48s\n- openstack-tox-pep8 http://logs.openstack.org/91/640491/7/check/openstack-tox-pep8/be26d35/ : SUCCESS in 5m 07s\n- openstack-tox-py27 http://logs.openstack.org/91/640491/7/check/openstack-tox-py27/636a6f1/ : SUCCESS in 24m 26s\n- openstack-tox-py35 http://logs.openstack.org/91/640491/7/check/openstack-tox-py35/213ad3b/ : SUCCESS in 5m 47s\n- openstack-tox-py36 http://logs.openstack.org/91/640491/7/check/openstack-tox-py36/a950918/ : SUCCESS in 10m 09s\n- openstack-tox-py37 http://logs.openstack.org/91/640491/7/check/openstack-tox-py37/eb1b24b/ : SUCCESS in 9m 01s\n- openstackclient-check-plugins http://logs.openstack.org/91/640491/7/check/openstackclient-check-plugins/40ba2db/ : SUCCESS in 6m 42s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/91/640491/7/check/openstack-tox-docs/0d66323/html/ : SUCCESS in 5m 25s\n- build-openstack-releasenotes http://logs.openstack.org/91/640491/7/check/build-openstack-releasenotes/2373f07/html/ : SUCCESS in 4m 18s\n- ironicclient-dsvm-functional http://logs.openstack.org/91/640491/7/check/ironicclient-dsvm-functional/dcb365a/ : SUCCESS in 23m 42s\n- ironicclient-tempest-dsvm-src http://logs.openstack.org/91/640491/7/check/ironicclient-tempest-dsvm-src/85cd24c/ : SUCCESS in 55m 16s","accounts_in_message":[],"_revision_number":7},{"id":"0c768e6a1203ab7d757518e52f3ca8ffa6aa1e5d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-06 19:33:40.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":7},{"id":"f571a7fc62559409e2dfc0e08aa6370c60e3e528","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-06 20:28:00.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":7},{"id":"9cb2177bf721b061d5001eb39ff1eaa659fea021","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-06 20:28:00.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/91/640491/7/gate/openstack-tox-lower-constraints/7caeb59/ : SUCCESS in 6m 57s\n- openstack-tox-pep8 http://logs.openstack.org/91/640491/7/gate/openstack-tox-pep8/fc85d67/ : SUCCESS in 5m 07s\n- openstack-tox-py27 http://logs.openstack.org/91/640491/7/gate/openstack-tox-py27/2346dea/ : SUCCESS in 5m 07s\n- openstack-tox-py35 http://logs.openstack.org/91/640491/7/gate/openstack-tox-py35/f049091/ : SUCCESS in 6m 17s\n- openstack-tox-py36 http://logs.openstack.org/91/640491/7/gate/openstack-tox-py36/8ec84e3/ : SUCCESS in 5m 14s\n- openstack-tox-py37 http://logs.openstack.org/91/640491/7/gate/openstack-tox-py37/8ced8f3/ : SUCCESS in 5m 16s\n- openstack-tox-docs http://logs.openstack.org/91/640491/7/gate/openstack-tox-docs/86ebacd/html/ : SUCCESS in 6m 54s\n- build-openstack-releasenotes http://logs.openstack.org/91/640491/7/gate/build-openstack-releasenotes/f5936f5/html/ : SUCCESS in 3m 48s\n- ironicclient-dsvm-functional http://logs.openstack.org/91/640491/7/gate/ironicclient-dsvm-functional/a818b35/ : SUCCESS in 22m 53s\n- ironicclient-tempest-dsvm-src http://logs.openstack.org/91/640491/7/gate/ironicclient-tempest-dsvm-src/27aae6e/ : SUCCESS in 46m 11s","accounts_in_message":[],"_revision_number":7},{"id":"63a6609bdb3ef8fe236d2de9bb743d583fe64413","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-03-07 06:00:38.000000000","message":"Patch Set 7: Cherry Picked\n\nThis patchset was cherry picked to branch stable/rocky as commit 3768e806522596f56c3af4d4a72643205a8e6cd2","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"d6eea403cbf0d11b06acbecc704f422a7e278462","revisions":{"08cdfb8d1d623f270c06c6a3c6e1d5febc7265e9":{"kind":"REWORK","_number":1,"created":"2019-03-01 19:13:37.000000000","uploader":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"ref":"refs/changes/91/640491/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/91/640491/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/1"}}},"commit":{"parents":[{"commit":"fdba8ed994bcbf1b3fc82803ccec49faf505b081","subject":"[Trivial] Allocation API: fix incorrect parameter description","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/fdba8ed994bcbf1b3fc82803ccec49faf505b081"}]}],"author":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-03-01 18:57:04.000000000","tz":-480},"committer":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-03-01 19:13:36.000000000","tz":-480},"subject":"convey endpoint interface to http client","message":"convey endpoint interface to http client\n\nCurrennt, HTTP client does endpoint lookup from the service catalog using\nendpoint filter. The filter is constructed from the interface attribute, which\nis set to public interface by default. Unfortunately, we never convey\nthe interface when constructing the HTTP client. And consequently, we\nare unable to use any other interfaces other than just public. This is\na severe limitation and also incompatible with Pike configuration.\nThis patch re-enables the endpoint filtering functionality by setting\nthe interface argument when constructing the HTTP client.\n\nChange-Id: I610836e5038774621690aca88b2aee25670f0262\nstory: 2005118\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/08cdfb8d1d623f270c06c6a3c6e1d5febc7265e9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/08cdfb8d1d623f270c06c6a3c6e1d5febc7265e9"}]},"branch":"refs/heads/master"},"c46f2ff4204c08c4a9599aa5a7c3e4f6e61a6a02":{"kind":"REWORK","_number":2,"created":"2019-03-01 21:11:16.000000000","uploader":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"ref":"refs/changes/91/640491/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/91/640491/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/2"}}},"commit":{"parents":[{"commit":"fdba8ed994bcbf1b3fc82803ccec49faf505b081","subject":"[Trivial] Allocation API: fix incorrect parameter description","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/fdba8ed994bcbf1b3fc82803ccec49faf505b081"}]}],"author":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-03-01 18:57:04.000000000","tz":-480},"committer":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-03-01 21:11:08.000000000","tz":-480},"subject":"convey endpoint interface to http client","message":"convey endpoint interface to http client\n\nCurrennt, HTTP client does endpoint lookup from the service catalog using\nendpoint filter. The filter is constructed from the interface attribute, which\nis set to public interface by default. Unfortunately, we never convey\nthe interface when constructing the HTTP client. And consequently, we\nare unable to use any other interfaces other than just public. This is\na severe limitation and also incompatible with Pike configuration.\nThis patch re-enables the endpoint filtering functionality by setting\nthe interface argument when constructing the HTTP client.\n\nChange-Id: I610836e5038774621690aca88b2aee25670f0262\nstory: 2005118\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/c46f2ff4204c08c4a9599aa5a7c3e4f6e61a6a02"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/c46f2ff4204c08c4a9599aa5a7c3e4f6e61a6a02"}]},"branch":"refs/heads/master"},"5e2a198b24336183be00063bc36594a1aafe5442":{"kind":"REWORK","_number":3,"created":"2019-03-02 06:46:22.000000000","uploader":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"ref":"refs/changes/91/640491/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/91/640491/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/3"}}},"commit":{"parents":[{"commit":"fdba8ed994bcbf1b3fc82803ccec49faf505b081","subject":"[Trivial] Allocation API: fix incorrect parameter description","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/fdba8ed994bcbf1b3fc82803ccec49faf505b081"}]}],"author":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-03-01 18:57:04.000000000","tz":-480},"committer":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-03-02 06:42:37.000000000","tz":-480},"subject":"convey endpoint interface to http client","message":"convey endpoint interface to http client\n\nCurrennt, HTTP client does endpoint lookup from the service catalog using\nendpoint filter. The filter is constructed from the interface attribute, which\nis set to public interface by default. Unfortunately, we never convey\nthe interface when constructing the HTTP client. And consequently, we\nare unable to use any other interfaces other than just public. This is\na severe limitation and also incompatible with Pike configuration.\nThis patch re-enables the endpoint filtering functionality by setting\nthe interface argument when constructing the HTTP client.\n\nThis patch also make sure the interface parameter is consistently\nspecified whenever it is needed. There\u0027s also no need to explicitly\nset the interface to \u0027publicURL\u0027 because that\u0027s already the default\nin keystoneauth.\n\nChange-Id: I610836e5038774621690aca88b2aee25670f0262\nstory: 2005118\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/5e2a198b24336183be00063bc36594a1aafe5442"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/5e2a198b24336183be00063bc36594a1aafe5442"}]},"branch":"refs/heads/master"},"e7ea74c1bde174c7f83876d288c87f57c6be237e":{"kind":"REWORK","_number":4,"created":"2019-03-04 16:47:23.000000000","uploader":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"ref":"refs/changes/91/640491/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/91/640491/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/4"}}},"commit":{"parents":[{"commit":"fdba8ed994bcbf1b3fc82803ccec49faf505b081","subject":"[Trivial] Allocation API: fix incorrect parameter description","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/fdba8ed994bcbf1b3fc82803ccec49faf505b081"}]}],"author":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-03-01 18:57:04.000000000","tz":-480},"committer":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-03-04 16:46:38.000000000","tz":-480},"subject":"pass endpoint interface to http client","message":"pass endpoint interface to http client\n\nCurrennt, HTTP client does endpoint lookup from the service catalog using\nendpoint filter. The filter is constructed from the interface attribute, which\nis set to public interface by default. Unfortunately, we never convey\nthe interface when constructing the HTTP client. And consequently, we\nare unable to use any other interfaces other than just public. This is\na severe limitation and also incompatible with Pike configuration.\nThis patch re-enables the endpoint filtering functionality by setting\nthe interface argument when constructing the HTTP client.\n\nThis patch also make sure the interface parameter is consistently\nspecified whenever it is needed. There\u0027s also no need to explicitly\nset the interface to \u0027publicURL\u0027 because that\u0027s already the default\nin keystoneauth.\n\nChange-Id: I610836e5038774621690aca88b2aee25670f0262\nstory: 2005118\ntask: 29802\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e7ea74c1bde174c7f83876d288c87f57c6be237e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e7ea74c1bde174c7f83876d288c87f57c6be237e"}]},"branch":"refs/heads/master"},"6b0c471ce7c95eed1be0e071ae2f71000695116d":{"kind":"REWORK","_number":5,"created":"2019-03-06 00:43:58.000000000","uploader":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"ref":"refs/changes/91/640491/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/91/640491/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/5"}}},"commit":{"parents":[{"commit":"fdba8ed994bcbf1b3fc82803ccec49faf505b081","subject":"[Trivial] Allocation API: fix incorrect parameter description","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/fdba8ed994bcbf1b3fc82803ccec49faf505b081"}]}],"author":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-03-01 18:57:04.000000000","tz":-480},"committer":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-03-06 00:41:10.000000000","tz":-480},"subject":"pass endpoint interface to http client","message":"pass endpoint interface to http client\n\nThe \u0027interface\u0027 argument was being ignored so that the HTTP client was\nalways using the public endpoint for Ironic. This fixes it so that the\n\u0027valid_interfaces\u0027 or \u0027interface\u0027 (deprecated) argument is taken\ninto consideration.\n\nThere\u0027s also no need to explicitly set the interface to \u0027publicURL\u0027\nbecause that\u0027s already the default in keystoneauth.\n\nChange-Id: I610836e5038774621690aca88b2aee25670f0262\nstory: 2005118\ntask: 29802\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/6b0c471ce7c95eed1be0e071ae2f71000695116d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/6b0c471ce7c95eed1be0e071ae2f71000695116d"}]},"branch":"refs/heads/master"},"e37677350726a570ccc2bad946f28ae0e78a8039":{"kind":"REWORK","_number":6,"created":"2019-03-06 16:57:45.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/91/640491/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/91/640491/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/6"}}},"commit":{"parents":[{"commit":"fdba8ed994bcbf1b3fc82803ccec49faf505b081","subject":"[Trivial] Allocation API: fix incorrect parameter description","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/fdba8ed994bcbf1b3fc82803ccec49faf505b081"}]}],"author":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-03-01 18:57:04.000000000","tz":-480},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-06 16:57:26.000000000","tz":-360},"subject":"pass endpoint interface to http client","message":"pass endpoint interface to http client\n\nThe \u0027interface\u0027 argument was being ignored so that the HTTP client was\nalways using the public endpoint for Ironic. This fixes it so that the\n\u0027interface\u0027 argument is taken into consideration.\n\nThere\u0027s also no need to explicitly set the interface to \u0027publicURL\u0027\nbecause that\u0027s already the default in keystoneauth.\n\nChange-Id: I610836e5038774621690aca88b2aee25670f0262\nstory: 2005118\ntask: 29802\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e37677350726a570ccc2bad946f28ae0e78a8039"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e37677350726a570ccc2bad946f28ae0e78a8039"}]},"branch":"refs/heads/master"},"d6eea403cbf0d11b06acbecc704f422a7e278462":{"kind":"REWORK","_number":7,"created":"2019-03-06 17:16:55.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/91/640491/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/91/640491/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/91/640491/7"}}},"commit":{"parents":[{"commit":"fdba8ed994bcbf1b3fc82803ccec49faf505b081","subject":"[Trivial] Allocation API: fix incorrect parameter description","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/fdba8ed994bcbf1b3fc82803ccec49faf505b081"}]}],"author":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-03-01 18:57:04.000000000","tz":-480},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-06 17:16:52.000000000","tz":0},"subject":"pass endpoint interface to http client","message":"pass endpoint interface to http client\n\nThe \u0027interface\u0027 argument was being ignored so that the HTTP client was\nalways using the public endpoint for Ironic. This fixes it so that the\n\u0027interface\u0027 argument is taken into consideration.\n\nThere\u0027s also no need to explicitly set the interface to \u0027publicURL\u0027\nbecause that\u0027s already the default in keystoneauth.\n\nChange-Id: I610836e5038774621690aca88b2aee25670f0262\nstory: 2005118\ntask: 29802\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/d6eea403cbf0d11b06acbecc704f422a7e278462"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/d6eea403cbf0d11b06acbecc704f422a7e278462"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}