)]}'
{"id":"openstack%2Fpython-ironicclient~641444","triplet_id":"openstack%2Fpython-ironicclient~master~I3b6fa53005f143d34f03bb1ed71c0aa04b7fce7b","project":"openstack/python-ironicclient","branch":"master","topic":"story-2005118","hashtags":[],"change_id":"I3b6fa53005f143d34f03bb1ed71c0aa04b7fce7b","subject":"Accept \u0027valid_interfaces\u0027 in client setup","status":"MERGED","created":"2019-03-06 17:14:56.000000000","updated":"2019-03-07 04:41:24.000000000","submitted":"2019-03-07 04:41:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"641444-1551933684867-98014b58","meta_rev_id":"1ec1b9807ddbcaaf5bcab68a81cb3e5c791e10ac","_number":641444,"virtual_id_number":641444,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-03-07 04:41:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":2,"date":"2019-03-07 02:39:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2019-03-07 02:39:44.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-03-07 02:39:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-06 17:16:15.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2019-03-06 17:50:33.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2019-03-07 02:39:59.000000000","updated_by":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"reviewer":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"state":"REVIEWER"},{"updated":"2019-03-07 04:41:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5c70170280449f68f2c8e62d1afb0d3a451b022a","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-06 17:14:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"328a8871d7d80544963223fa7399655b373e1712","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2019-03-06 17:16:15.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f3374a257fbf275227ebec83f56dd6b600a2a35f","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2019-03-06 17:50:33.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a3194b63012f854ad85a67acf908199156a286f1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-06 18:03:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/44/641444/1/check/openstack-tox-cover/6f87751/cover/ : SUCCESS in 6m 25s\n- openstack-tox-lower-constraints http://logs.openstack.org/44/641444/1/check/openstack-tox-lower-constraints/adc650b/ : SUCCESS in 8m 04s\n- openstack-tox-pep8 http://logs.openstack.org/44/641444/1/check/openstack-tox-pep8/adf4491/ : SUCCESS in 5m 03s\n- openstack-tox-py27 http://logs.openstack.org/44/641444/1/check/openstack-tox-py27/26f84c5/ : SUCCESS in 6m 00s\n- openstack-tox-py35 http://logs.openstack.org/44/641444/1/check/openstack-tox-py35/ecae4b1/ : SUCCESS in 5m 18s\n- openstack-tox-py36 http://logs.openstack.org/44/641444/1/check/openstack-tox-py36/d6a5b2f/ : SUCCESS in 4m 48s\n- openstack-tox-py37 http://logs.openstack.org/44/641444/1/check/openstack-tox-py37/fee50b9/ : SUCCESS in 6m 12s\n- openstackclient-check-plugins http://logs.openstack.org/44/641444/1/check/openstackclient-check-plugins/1b00dfc/ : SUCCESS in 9m 30s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/44/641444/1/check/openstack-tox-docs/c0be3de/html/ : SUCCESS in 7m 14s\n- build-openstack-releasenotes http://logs.openstack.org/44/641444/1/check/build-openstack-releasenotes/6fd48e5/html/ : SUCCESS in 4m 27s\n- ironicclient-dsvm-functional http://logs.openstack.org/44/641444/1/check/ironicclient-dsvm-functional/9ebcdb4/ : SUCCESS in 18m 41s\n- ironicclient-tempest-dsvm-src http://logs.openstack.org/44/641444/1/check/ironicclient-tempest-dsvm-src/4c9af13/ : SUCCESS in 44m 57s","accounts_in_message":[],"_revision_number":1},{"id":"c67a7b55c4d52ae3e1305a1c3b1d674ebfda609c","author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"date":"2019-03-07 02:39:44.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"c75b9d9cbcf98928a773fabbe5b7181fdb5b1172","author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"date":"2019-03-07 02:39:59.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"c2b13136aa50d6f85126b35659ac4c2b7522f664","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-07 03:27:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/44/641444/2/check/openstack-tox-cover/d9d8d25/cover/ : SUCCESS in 4m 33s\n- openstack-tox-lower-constraints http://logs.openstack.org/44/641444/2/check/openstack-tox-lower-constraints/1fc4fa8/ : SUCCESS in 6m 35s\n- openstack-tox-pep8 http://logs.openstack.org/44/641444/2/check/openstack-tox-pep8/a435242/ : SUCCESS in 5m 24s\n- openstack-tox-py27 http://logs.openstack.org/44/641444/2/check/openstack-tox-py27/3528e69/ : SUCCESS in 6m 00s\n- openstack-tox-py35 http://logs.openstack.org/44/641444/2/check/openstack-tox-py35/6036f47/ : SUCCESS in 6m 07s\n- openstack-tox-py36 http://logs.openstack.org/44/641444/2/check/openstack-tox-py36/b13bcba/ : SUCCESS in 6m 05s\n- openstack-tox-py37 http://logs.openstack.org/44/641444/2/check/openstack-tox-py37/bc32237/ : SUCCESS in 4m 52s\n- openstackclient-check-plugins http://logs.openstack.org/44/641444/2/check/openstackclient-check-plugins/60011ac/ : SUCCESS in 7m 54s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/44/641444/2/check/openstack-tox-docs/4194b34/html/ : SUCCESS in 4m 12s\n- build-openstack-releasenotes http://logs.openstack.org/44/641444/2/check/build-openstack-releasenotes/56939f7/html/ : SUCCESS in 5m 52s\n- ironicclient-dsvm-functional http://logs.openstack.org/44/641444/2/check/ironicclient-dsvm-functional/531aa73/ : SUCCESS in 20m 50s\n- ironicclient-tempest-dsvm-src http://logs.openstack.org/44/641444/2/check/ironicclient-tempest-dsvm-src/bab79c4/ : SUCCESS in 43m 08s","accounts_in_message":[],"_revision_number":2},{"id":"058d5e7e3b70fdeaac7a6116b7b8a6cb69c23b86","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-07 03:27:15.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"06ca97d496a7f8aa5979bddb5fe9c417b5827854","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-07 04:41:24.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/44/641444/2/gate/openstack-tox-lower-constraints/f240c80/ : SUCCESS in 7m 19s\n- openstack-tox-pep8 http://logs.openstack.org/44/641444/2/gate/openstack-tox-pep8/d281175/ : SUCCESS in 6m 30s\n- openstack-tox-py27 http://logs.openstack.org/44/641444/2/gate/openstack-tox-py27/5991764/ : SUCCESS in 4m 19s\n- openstack-tox-py35 http://logs.openstack.org/44/641444/2/gate/openstack-tox-py35/71c879c/ : SUCCESS in 7m 29s\n- openstack-tox-py36 http://logs.openstack.org/44/641444/2/gate/openstack-tox-py36/da8347e/ : SUCCESS in 5m 33s\n- openstack-tox-py37 http://logs.openstack.org/44/641444/2/gate/openstack-tox-py37/e49b079/ : SUCCESS in 5m 34s\n- openstack-tox-docs http://logs.openstack.org/44/641444/2/gate/openstack-tox-docs/9382328/html/ : SUCCESS in 6m 18s\n- build-openstack-releasenotes http://logs.openstack.org/44/641444/2/gate/build-openstack-releasenotes/a8ffed6/html/ : SUCCESS in 6m 19s\n- ironicclient-dsvm-functional http://logs.openstack.org/44/641444/2/gate/ironicclient-dsvm-functional/a279467/ : SUCCESS in 22m 24s\n- ironicclient-tempest-dsvm-src http://logs.openstack.org/44/641444/2/gate/ironicclient-tempest-dsvm-src/a8312b9/ : SUCCESS in 44m 40s","accounts_in_message":[],"_revision_number":2},{"id":"a5a7db19634ecef8364ae966cd5b43e86b0165bd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-07 04:41:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ae1743d2c194c690c4d4629e51e860b5f5b84252","revisions":{"e125e4a1e5035ec8ec5bc607973da89306ac6dc5":{"kind":"REWORK","_number":1,"created":"2019-03-06 17:14:56.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/44/641444/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/44/641444/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/44/641444/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/44/641444/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/44/641444/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/44/641444/1"}}},"commit":{"parents":[{"commit":"e37677350726a570ccc2bad946f28ae0e78a8039","subject":"pass endpoint interface to http client","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e37677350726a570ccc2bad946f28ae0e78a8039"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-06 17:07:28.000000000","tz":-360},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-06 17:13:50.000000000","tz":-360},"subject":"Accept \u0027valid_interfaces\u0027 in client setup","message":"Accept \u0027valid_interfaces\u0027 in client setup\n\nThe consumer of ironicclient may be deriving their get_client kwargs\nfrom config inherited from ksa, where the \u0027interface\u0027 option has been\ndeprecated in favor of \u0027valid_interfaces\u0027. To accomodate this, we accept\n\u0027valid_interfaces\u0027 as a kwarg, giving it precedence over \u0027interface\u0027.\nHowever, we still accept \u0027interface\u0027, as the consumer may be deriving\nkwargs from a non-conf source (such as an already-created ksa Adapter\nwhere \u0027valid_interfaces\u0027 has already been translated to \u0027interfaces\u0027.\n\nCo-Authored-By: guang-yee \u003cguang.yee@suse.com\u003e\n\nChange-Id: I3b6fa53005f143d34f03bb1ed71c0aa04b7fce7b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e125e4a1e5035ec8ec5bc607973da89306ac6dc5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e125e4a1e5035ec8ec5bc607973da89306ac6dc5"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"e37677350726a570ccc2bad946f28ae0e78a8039","is_merged_in_target_branch":false,"change_id":"I610836e5038774621690aca88b2aee25670f0262","change_number":640491,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/master"},"ae1743d2c194c690c4d4629e51e860b5f5b84252":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-03-07 02:39:44.000000000","uploader":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"ref":"refs/changes/44/641444/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/44/641444/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/44/641444/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/44/641444/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/44/641444/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/44/641444/2"}}},"commit":{"parents":[{"commit":"aa2c7fc9ac0b9c094db0f09bb3b75a09fa92063f","subject":"Merge \"pass endpoint interface to http client\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/aa2c7fc9ac0b9c094db0f09bb3b75a09fa92063f"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-06 17:07:28.000000000","tz":-360},"committer":{"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","date":"2019-03-07 02:39:44.000000000","tz":0},"subject":"Accept \u0027valid_interfaces\u0027 in client setup","message":"Accept \u0027valid_interfaces\u0027 in client setup\n\nThe consumer of ironicclient may be deriving their get_client kwargs\nfrom config inherited from ksa, where the \u0027interface\u0027 option has been\ndeprecated in favor of \u0027valid_interfaces\u0027. To accomodate this, we accept\n\u0027valid_interfaces\u0027 as a kwarg, giving it precedence over \u0027interface\u0027.\nHowever, we still accept \u0027interface\u0027, as the consumer may be deriving\nkwargs from a non-conf source (such as an already-created ksa Adapter\nwhere \u0027valid_interfaces\u0027 has already been translated to \u0027interfaces\u0027.\n\nCo-Authored-By: guang-yee \u003cguang.yee@suse.com\u003e\n\nChange-Id: I3b6fa53005f143d34f03bb1ed71c0aa04b7fce7b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/ae1743d2c194c690c4d4629e51e860b5f5b84252"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/ae1743d2c194c690c4d4629e51e860b5f5b84252"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"aa2c7fc9ac0b9c094db0f09bb3b75a09fa92063f","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}