)]}'
{"ironicclient/shell.py":[{"author":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"change_message_id":"59a7a8f53bb38f185e22694a56fe3322b891ab8f","unresolved":false,"context_lines":[{"line_number":244,"context_line":"                \u0027insecure\u0027: self.opts.get(\u0027insecure\u0027),"},{"line_number":245,"context_line":"            }"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"            _ksclient \u003d iroclient._get_ksclient(**ks_kwargs)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"            token \u003d (self.opts.get(\u0027token\u0027)"},{"line_number":250,"context_line":"                     if self.opts.get(\u0027token\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fzns%3D","line":247,"updated":"2014-01-08 08:32:24.000000000","message":"I don\u0027t like variable names chosen here","commit_id":"e17db66b2c9ad779adba36591482a0d1da6da15f"}],"ironicclient/tests/test_client.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"15744d304ec09fedf7ced63bd6ea21660c4c208a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":40,"context_line":"            \u0027ironicclient.client._get_ksclient\u0027, fake_get_ksclient))"},{"line_number":41,"context_line":"        self.auth._do_authenticate(self.client)"},{"line_number":42,"context_line":"        self.assertEqual(self.auth.opts[\u0027token\u0027], \u0027KSCLIENT_AUTH_TOKEN\u0027)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_get_client_with_auth_token(self):"},{"line_number":45,"context_line":"        self.useFixture(fixtures.MonkeyPatch("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FzKI%3D","line":42,"updated":"2014-01-08 10:07:42.000000000","message":"The assertEqual method first argument is the expected value, and the last one is the actual value, so it is better tha we can keep in correct position for passing arguments, this applies to all code change of assertEqual,  thank you.","commit_id":"e17db66b2c9ad779adba36591482a0d1da6da15f"},{"author":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"change_message_id":"4207dd385ad7a0484fd563910c10a7d6a08858f5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":40,"context_line":"            \u0027ironicclient.client._get_ksclient\u0027, fake_get_ksclient))"},{"line_number":41,"context_line":"        self.auth._do_authenticate(self.client)"},{"line_number":42,"context_line":"        self.assertEqual(self.auth.opts[\u0027token\u0027], \u0027KSCLIENT_AUTH_TOKEN\u0027)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_get_client_with_auth_token(self):"},{"line_number":45,"context_line":"        self.useFixture(fixtures.MonkeyPatch("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FyNk%3D","line":42,"in_reply_to":"AAAAUH%2F%2FzKI%3D","updated":"2014-01-08 14:21:39.000000000","message":"Done","commit_id":"e17db66b2c9ad779adba36591482a0d1da6da15f"}],"requirements.txt":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"15744d304ec09fedf7ced63bd6ea21660c4c208a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"PrettyTable\u003e\u003d0.7,\u003c0.8"},{"line_number":7,"context_line":"python-keystoneclient\u003e\u003d0.4.1"},{"line_number":8,"context_line":"six\u003e\u003d1.4.1"},{"line_number":9,"context_line":"stevedore\u003e\u003d0.12"}],"source_content_type":"text/plain","patch_set":1,"id":"AAAAUH%2F%2FzHU%3D","line":9,"updated":"2014-01-08 10:07:42.000000000","message":"We need follow the process to add new 3rd lib requirement in global requirement project first [1], than sync to our Ironic client code by manually or automatically.\n\n[1]\nhttps://github.com/openstack/requirements/blob/master/global-requirements.txt","commit_id":"e17db66b2c9ad779adba36591482a0d1da6da15f"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"15744d304ec09fedf7ced63bd6ea21660c4c208a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"PrettyTable\u003e\u003d0.7,\u003c0.8"},{"line_number":7,"context_line":"python-keystoneclient\u003e\u003d0.4.1"},{"line_number":8,"context_line":"six\u003e\u003d1.4.1"},{"line_number":9,"context_line":"stevedore\u003e\u003d0.12"}],"source_content_type":"text/plain","patch_set":1,"id":"AAAAUH%2F%2FzBc%3D","line":9,"in_reply_to":"AAAAUH%2F%2FzHU%3D","updated":"2014-01-08 10:39:31.000000000","message":"It is in global-requirements already, ignore my previous comments please.","commit_id":"e17db66b2c9ad779adba36591482a0d1da6da15f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"unresolved":false,"context_lines":[{"line_number":6,"context_line":"PrettyTable\u003e\u003d0.7,\u003c0.8"},{"line_number":7,"context_line":"python-keystoneclient\u003e\u003d0.4.1"},{"line_number":8,"context_line":"six\u003e\u003d1.4.1"},{"line_number":9,"context_line":"stevedore\u003e\u003d0.12"}],"source_content_type":"text/plain","patch_set":2,"id":"AAAAUH%2F9vl0%3D","line":9,"updated":"2014-02-04 13:38:02.000000000","message":"The new version at the global requirements is 0.14[1][2], we had to bump it to unbreak Ironic.\n\nSo we need to update it here as well.\n\n[1] https://review.openstack.org/#/c/69496/\n\n[2] https://github.com/openstack/requirements/blob/master/global-requirements.txt#L103","commit_id":"a1f52cc45149750ba8fdc073573f9060800fb109"},{"author":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"change_message_id":"4207dd385ad7a0484fd563910c10a7d6a08858f5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"PrettyTable\u003e\u003d0.7,\u003c0.8"},{"line_number":7,"context_line":"python-keystoneclient\u003e\u003d0.4.1"},{"line_number":8,"context_line":"six\u003e\u003d1.4.1"},{"line_number":9,"context_line":"stevedore\u003e\u003d0.12"}],"source_content_type":"text/plain","patch_set":2,"id":"AAAAUX%2F%2F0CM%3D","line":9,"in_reply_to":"AAAAUH%2F9vl0%3D","updated":"2014-02-10 17:04:49.000000000","message":"Done","commit_id":"a1f52cc45149750ba8fdc073573f9060800fb109"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"unresolved":false,"context_lines":[{"line_number":6,"context_line":"PrettyTable\u003e\u003d0.7,\u003c0.8"},{"line_number":7,"context_line":"python-keystoneclient\u003e\u003d0.4.2"},{"line_number":8,"context_line":"six\u003e\u003d1.4.1"},{"line_number":9,"context_line":"stevedore\u003e\u003d0.14"}],"source_content_type":"text/plain","patch_set":3,"id":"AAAAUX%2F%2FuG4%3D","line":9,"updated":"2014-02-11 08:41:08.000000000","message":"We have this already now:\n\nhttps://github.com/openstack/ironic/blob/master/requirements.txt#L20\n\nWhich is synced from global requirements.","commit_id":"a11897b71c580b8f93a89dfc9ea887d978c07840"},{"author":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"change_message_id":"4207dd385ad7a0484fd563910c10a7d6a08858f5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"PrettyTable\u003e\u003d0.7,\u003c0.8"},{"line_number":7,"context_line":"python-keystoneclient\u003e\u003d0.4.2"},{"line_number":8,"context_line":"six\u003e\u003d1.4.1"},{"line_number":9,"context_line":"stevedore\u003e\u003d0.14"}],"source_content_type":"text/plain","patch_set":3,"id":"AAAAUX%2F%2FtlI%3D","line":9,"in_reply_to":"AAAAUX%2F%2FuG4%3D","updated":"2014-02-11 09:44:17.000000000","message":"Done","commit_id":"a11897b71c580b8f93a89dfc9ea887d978c07840"},{"author":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"change_message_id":"4207dd385ad7a0484fd563910c10a7d6a08858f5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"PrettyTable\u003e\u003d0.7,\u003c0.8"},{"line_number":7,"context_line":"python-keystoneclient\u003e\u003d0.4.2"},{"line_number":8,"context_line":"six\u003e\u003d1.4.1"},{"line_number":9,"context_line":"stevedore\u003e\u003d0.14"}],"source_content_type":"text/plain","patch_set":3,"id":"AAAAUX%2F%2FsNM%3D","line":9,"in_reply_to":"AAAAUX%2F%2FuG4%3D","updated":"2014-02-11 13:35:38.000000000","message":"Requirements is synced in ironic project. In ironicclient stevedore is nedeed by auth module from oslo.","commit_id":"a11897b71c580b8f93a89dfc9ea887d978c07840"}]}