)]}'
{"id":"openstack%2Fpython-ironicclient~643624","triplet_id":"openstack%2Fpython-ironicclient~master~I69dc2c88648ba1d09a9ad3ab3435662e8d1ea6ff","project":"openstack/python-ironicclient","branch":"master","topic":"bug/1818295","hashtags":[],"change_id":"I69dc2c88648ba1d09a9ad3ab3435662e8d1ea6ff","subject":"Use endpoint_override in version negotiation","status":"MERGED","created":"2019-03-15 16:18:26.000000000","updated":"2019-03-20 11:02:36.000000000","submitted":"2019-03-20 11:02:36.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"643624-1553079756141-9906e730","meta_rev_id":"d743eabdbabd22a04ae79322e6c92385622ae997","_number":643624,"virtual_id_number":643624,"owner":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"date":"2019-03-18 16:13:29.000000000","_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},{"value":2,"date":"2019-03-20 11:02:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"recommended":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"all":[{"value":1,"date":"2019-03-19 06:26:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},{"value":2,"date":"2019-03-18 18:39:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-03-20 10:08:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-03-20 10:08:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-18 18:39:48.000000000","updated_by":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"reviewer":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"state":"REVIEWER"},{"updated":"2019-03-19 06:26:06.000000000","updated_by":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"reviewer":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"state":"REVIEWER"},{"updated":"2019-03-20 10:08:00.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2019-03-20 11:02:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3bef8646aea5ba564a2a0eef53f5e5adaaee95a2","author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"date":"2019-03-15 16:18:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5b0906f396230cafdac44f27cc602711b8cd056c","author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"date":"2019-03-15 16:25:12.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"41a0c5ba9d33b7b099afcaefdac5fbc4c2d60621","author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"date":"2019-03-15 16:26:24.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"130303caeea18a34bea13d561a196b2bc092b9f4","author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"date":"2019-03-15 16:27:40.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"bcfccde65f4bb65511750367a751b2317fdb6fe6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-15 17:26:53.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/24/643624/4/check/openstack-tox-cover/21e2af3/cover/ : SUCCESS in 5m 06s\n- openstack-tox-lower-constraints http://logs.openstack.org/24/643624/4/check/openstack-tox-lower-constraints/0aa3b72/ : SUCCESS in 6m 39s\n- openstack-tox-pep8 http://logs.openstack.org/24/643624/4/check/openstack-tox-pep8/e1bfeb2/ : SUCCESS in 5m 00s\n- openstack-tox-py27 http://logs.openstack.org/24/643624/4/check/openstack-tox-py27/b8ccad2/ : SUCCESS in 5m 00s\n- openstack-tox-py35 http://logs.openstack.org/24/643624/4/check/openstack-tox-py35/f1e1dd6/ : SUCCESS in 6m 04s\n- openstack-tox-py36 http://logs.openstack.org/24/643624/4/check/openstack-tox-py36/1d7bfc6/ : SUCCESS in 4m 40s\n- openstack-tox-py37 http://logs.openstack.org/24/643624/4/check/openstack-tox-py37/fcc331f/ : SUCCESS in 5m 55s\n- openstackclient-check-plugins http://logs.openstack.org/24/643624/4/check/openstackclient-check-plugins/cab0476/ : SUCCESS in 5m 38s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/24/643624/4/check/openstack-tox-docs/0703c00/html/ : SUCCESS in 5m 37s\n- ironicclient-functional http://logs.openstack.org/24/643624/4/check/ironicclient-functional/7b75436/ : POST_FAILURE in 21m 45s\n- ironicclient-tempest http://logs.openstack.org/24/643624/4/check/ironicclient-tempest/d6a4e6b/ : SUCCESS in 51m 31s","accounts_in_message":[],"_revision_number":4},{"id":"4d0a29b1ea68478aa2019c818fbf5ebec481a14d","author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"date":"2019-03-15 18:10:23.000000000","message":"Patch Set 4:\n\nTest failure is addressed by [1], another changeset.\n\n[1]: I55abc999f6f397b171d05fd9e9b39d833ca95e55","accounts_in_message":[],"_revision_number":4},{"id":"3942dbb50742e48db9a1d14e5f41b507757a9679","author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"date":"2019-03-18 16:13:29.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"6ca79392b6afc5c99180bfce31212f047bbb8766","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-18 17:18:00.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/24/643624/4/check/openstack-tox-cover/1fc64b3/cover/ : SUCCESS in 8m 38s\n- openstack-tox-lower-constraints http://logs.openstack.org/24/643624/4/check/openstack-tox-lower-constraints/6d3a86b/ : SUCCESS in 7m 44s\n- openstack-tox-pep8 http://logs.openstack.org/24/643624/4/check/openstack-tox-pep8/56eb820/ : SUCCESS in 5m 33s\n- openstack-tox-py27 http://logs.openstack.org/24/643624/4/check/openstack-tox-py27/9558809/ : SUCCESS in 5m 12s\n- openstack-tox-py35 http://logs.openstack.org/24/643624/4/check/openstack-tox-py35/571c73b/ : SUCCESS in 5m 19s\n- openstack-tox-py36 http://logs.openstack.org/24/643624/4/check/openstack-tox-py36/bbe5a0a/ : SUCCESS in 5m 01s\n- openstack-tox-py37 http://logs.openstack.org/24/643624/4/check/openstack-tox-py37/7188e13/ : SUCCESS in 5m 12s\n- openstackclient-check-plugins http://logs.openstack.org/24/643624/4/check/openstackclient-check-plugins/195093d/ : SUCCESS in 6m 19s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/24/643624/4/check/openstack-tox-docs/d3d90be/html/ : SUCCESS in 5m 08s\n- ironicclient-functional http://logs.openstack.org/24/643624/4/check/ironicclient-functional/07287e3/ : SUCCESS in 23m 09s\n- ironicclient-functional-python2 http://logs.openstack.org/24/643624/4/check/ironicclient-functional-python2/78a6830/ : SUCCESS in 25m 08s\n- ironicclient-tempest http://logs.openstack.org/24/643624/4/check/ironicclient-tempest/040b646/ : SUCCESS in 49m 48s\n- ironicclient-tempest-python2 http://logs.openstack.org/24/643624/4/check/ironicclient-tempest-python2/e59fb54/ : SUCCESS in 43m 10s","accounts_in_message":[],"_revision_number":4},{"id":"89d15289759904035fb4a9bb195ebd622bb340b0","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2019-03-18 18:39:48.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"86889692c2887755ecca16a2fa41ab23cb515560","author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"date":"2019-03-19 06:26:06.000000000","message":"Patch Set 4: Code-Review+1\n\nThanks for the patch.","accounts_in_message":[],"_revision_number":4},{"id":"acfae28c43195e01d94d78c681d734af710bb035","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-03-20 10:08:00.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"4cfe59f27566e57d0047024d95e470767a6a00ee","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-20 10:08:11.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"8ec27884bddc8121f011097016f0dded8fde4d73","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-20 11:02:35.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/24/643624/4/gate/openstack-tox-lower-constraints/cc0e140/ : SUCCESS in 6m 12s\n- openstack-tox-pep8 http://logs.openstack.org/24/643624/4/gate/openstack-tox-pep8/2861112/ : SUCCESS in 5m 07s\n- openstack-tox-py27 http://logs.openstack.org/24/643624/4/gate/openstack-tox-py27/5897349/ : SUCCESS in 5m 55s\n- openstack-tox-py35 http://logs.openstack.org/24/643624/4/gate/openstack-tox-py35/2d86236/ : SUCCESS in 4m 03s\n- openstack-tox-py36 http://logs.openstack.org/24/643624/4/gate/openstack-tox-py36/94e6760/ : SUCCESS in 5m 36s\n- openstack-tox-py37 http://logs.openstack.org/24/643624/4/gate/openstack-tox-py37/84bd8a2/ : SUCCESS in 6m 39s\n- openstack-tox-docs http://logs.openstack.org/24/643624/4/gate/openstack-tox-docs/49194e0/html/ : SUCCESS in 4m 38s\n- ironicclient-functional http://logs.openstack.org/24/643624/4/gate/ironicclient-functional/33f03cf/ : SUCCESS in 22m 49s\n- ironicclient-functional-python2 http://logs.openstack.org/24/643624/4/gate/ironicclient-functional-python2/ce37eab/ : SUCCESS in 19m 30s\n- ironicclient-tempest http://logs.openstack.org/24/643624/4/gate/ironicclient-tempest/a0a0b29/ : SUCCESS in 46m 46s\n- ironicclient-tempest-python2 http://logs.openstack.org/24/643624/4/gate/ironicclient-tempest-python2/db17cbf/ : SUCCESS in 48m 29s","accounts_in_message":[],"_revision_number":4},{"id":"1c78f2f1d62aa55980bde1a43c025a1601e3fe6d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-20 11:02:36.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"8071d5de57c728ce09d25d04c8c9fe48cd7db42e","revisions":{"81251d250c7f594790dfd48328bed27444aee9ba":{"kind":"REWORK","_number":1,"created":"2019-03-15 16:18:26.000000000","uploader":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"ref":"refs/changes/24/643624/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/24/643624/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/1"}}},"commit":{"parents":[{"commit":"66392a90df2d61adf780f3a95a7da37d639d227c","subject":"Merge \"Move to zuulv3\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/66392a90df2d61adf780f3a95a7da37d639d227c"}]}],"author":{"name":"Jason","email":"jasonanderson@uchicago.edu","date":"2019-03-15 15:57:57.000000000","tz":-300},"committer":{"name":"Jason","email":"jasonanderson@uchicago.edu","date":"2019-03-15 16:18:25.000000000","tz":-300},"subject":"Use endpoint_override in version negotiation","message":"Use endpoint_override in version negotiation\n\nChange [1] introduced the usage of endpoint_filter when deciding which\nendpoint to use during version negotiation. This requires properly\nsetting interface/region/service_type in order to properly pick the\nendpoint. But, sometimes (for example in Kolla-ansible), the endpoint\nurl is explicitly defined. In the event of the endpoint being explicitly\ndefined, it should take priority here.\n\nIt should be noted that even though SessionClient extends from\nkeystoneauth1\u0027s adapter.LegacyJsonAdapter, the `request` function within\n_make_simple_request is being called on the nested Session object, not\nthe Adapter itself. If it was called on the Adapter this problem\nwouldn\u0027t exist, as the `endpoint_override` (or `endpoint`) kwarg passed\nin to the constructor of the SessionClient would already take\nprecedence.\n\n[1]: https://review.openstack.org/#/c/640879/\n\nChange-Id: I69dc2c88648ba1d09a9ad3ab3435662e8d1ea6ff\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/81251d250c7f594790dfd48328bed27444aee9ba"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/81251d250c7f594790dfd48328bed27444aee9ba"}]},"branch":"refs/heads/master"},"59204f033b1e6f7636045fd9e8326cb7f6bb1867":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-03-15 16:25:12.000000000","uploader":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"ref":"refs/changes/24/643624/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/24/643624/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/2"}}},"commit":{"parents":[{"commit":"66392a90df2d61adf780f3a95a7da37d639d227c","subject":"Merge \"Move to zuulv3\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/66392a90df2d61adf780f3a95a7da37d639d227c"}]}],"author":{"name":"Jason","email":"jasonanderson@uchicago.edu","date":"2019-03-15 15:57:57.000000000","tz":-300},"committer":{"name":"Jason","email":"jasonanderson@uchicago.edu","date":"2019-03-15 16:24:27.000000000","tz":-300},"subject":"Use endpoint_override in version negotiation","message":"Use endpoint_override in version negotiation\n\nChange [1] introduced the usage of endpoint_filter when deciding which\nendpoint to use during version negotiation. This requires properly\nsetting interface/region/service_type in order to properly pick the\nendpoint. But, sometimes (for example in Kolla-ansible), the endpoint\nurl is explicitly defined. In the event of the endpoint being explicitly\ndefined, it should take priority here.\n\nIt should be noted that even though SessionClient extends from\nkeystoneauth1\u0027s adapter.LegacyJsonAdapter, the `request` function within\n_make_simple_request is being called on the nested Session object, not\nthe Adapter itself. If it was called on the Adapter this problem\nwouldn\u0027t exist, as the `endpoint_override` (or `endpoint`) kwarg passed\nin to the constructor of the SessionClient would already take\nprecedence.\n\n[1]: https://review.openstack.org/#/c/640879/\n\nChange-Id: I69dc2c88648ba1d09a9ad3ab3435662e8d1ea6ff\nRelated-To-Bug: #1818295\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/59204f033b1e6f7636045fd9e8326cb7f6bb1867"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/59204f033b1e6f7636045fd9e8326cb7f6bb1867"}]},"branch":"refs/heads/master"},"57bf2f01e578b4973e91fd4026592464b83499b2":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2019-03-15 16:26:24.000000000","uploader":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"ref":"refs/changes/24/643624/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/24/643624/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/3"}}},"commit":{"parents":[{"commit":"66392a90df2d61adf780f3a95a7da37d639d227c","subject":"Merge \"Move to zuulv3\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/66392a90df2d61adf780f3a95a7da37d639d227c"}]}],"author":{"name":"Jason","email":"jasonanderson@uchicago.edu","date":"2019-03-15 15:57:57.000000000","tz":-300},"committer":{"name":"Jason","email":"jasonanderson@uchicago.edu","date":"2019-03-15 16:26:12.000000000","tz":-300},"subject":"Use endpoint_override in version negotiation","message":"Use endpoint_override in version negotiation\n\nChange [1] introduced the usage of endpoint_filter when deciding which\nendpoint to use during version negotiation. This requires properly\nsetting interface/region/service_type in order to properly pick the\nendpoint. But, sometimes (for example in Kolla-ansible), the endpoint\nurl is explicitly defined. In the event of the endpoint being explicitly\ndefined, it should take priority here.\n\nIt should be noted that even though SessionClient extends from\nkeystoneauth1\u0027s adapter.LegacyJsonAdapter, the `request` function within\n_make_simple_request is being called on the nested Session object, not\nthe Adapter itself. If it was called on the Adapter this problem\nwouldn\u0027t exist, as the `endpoint_override` (or `endpoint`) kwarg passed\nin to the constructor of the SessionClient would already take\nprecedence.\n\n[1]: I42b66daea1f4397273a3f4eb1638abafb3bb28ce\n\nChange-Id: I69dc2c88648ba1d09a9ad3ab3435662e8d1ea6ff\nRelated-To-Bug: #1818295\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/57bf2f01e578b4973e91fd4026592464b83499b2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/57bf2f01e578b4973e91fd4026592464b83499b2"}]},"branch":"refs/heads/master"},"8071d5de57c728ce09d25d04c8c9fe48cd7db42e":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2019-03-15 16:27:40.000000000","uploader":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"ref":"refs/changes/24/643624/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/24/643624/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/24/643624/4"}}},"commit":{"parents":[{"commit":"66392a90df2d61adf780f3a95a7da37d639d227c","subject":"Merge \"Move to zuulv3\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/66392a90df2d61adf780f3a95a7da37d639d227c"}]}],"author":{"name":"Jason","email":"jasonanderson@uchicago.edu","date":"2019-03-15 15:57:57.000000000","tz":-300},"committer":{"name":"Jason","email":"jasonanderson@uchicago.edu","date":"2019-03-15 16:27:29.000000000","tz":-300},"subject":"Use endpoint_override in version negotiation","message":"Use endpoint_override in version negotiation\n\nChange [1] introduced the usage of endpoint_filter when deciding which\nendpoint to use during version negotiation. This requires properly\nsetting interface/region/service_type in order to properly pick the\nendpoint. But, sometimes (for example in Kolla-ansible), the endpoint\nurl is explicitly defined. In the event of the endpoint being explicitly\ndefined, it should take priority here.\n\nIt should be noted that even though SessionClient extends from\nkeystoneauth1\u0027s adapter.LegacyJsonAdapter, the `request` function within\n_make_simple_request is being called on the nested Session object, not\nthe Adapter itself. If it was called on the Adapter this problem\nwouldn\u0027t exist, as the `endpoint_override` (or `endpoint`) kwarg passed\nin to the constructor of the SessionClient would already take\nprecedence.\n\n[1]: I42b66daea1f4397273a3f4eb1638abafb3bb28ce\n\nChange-Id: I69dc2c88648ba1d09a9ad3ab3435662e8d1ea6ff\nRelated-Bug: #1818295\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/8071d5de57c728ce09d25d04c8c9fe48cd7db42e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/8071d5de57c728ce09d25d04c8c9fe48cd7db42e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}