)]}'
{"id":"openstack%2Fpython-ironicclient~65277","triplet_id":"openstack%2Fpython-ironicclient~master~Ibc2005d4cb9a43ac20ec0624f95dce002b0e02b2","project":"openstack/python-ironicclient","branch":"master","topic":"fix_node_set_power_state_output","hashtags":[],"change_id":"Ibc2005d4cb9a43ac20ec0624f95dce002b0e02b2","subject":"Fix empty node-set-power-state output in CLI","status":"ABANDONED","created":"2014-01-07 14:14:30.000000000","updated":"2014-02-03 11:13:31.000000000","total_comment_count":18,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a98c438ddea697a59bd7be3196eb48ea5c2809e8","_number":65277,"virtual_id_number":65277,"owner":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-01-09 10:27:18.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"disliked":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2014-01-30 19:06:30.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":-1,"date":"2014-01-28 17:22:15.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},{"value":1,"date":"2014-01-16 03:19:37.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":1,"date":"2014-01-13 08:35:19.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":0,"date":"2014-01-09 11:55:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-01-30 19:06:30.000000000","_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"date":"2014-01-28 15:52:21.000000000","_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},{"date":"2014-01-16 03:19:37.000000000","_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-09 10:27:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-01-13 08:35:19.000000000","updated_by":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"reviewer":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"state":"REVIEWER"},{"updated":"2014-01-16 03:19:37.000000000","updated_by":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"reviewer":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"state":"REVIEWER"},{"updated":"2014-01-28 15:52:21.000000000","updated_by":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"reviewer":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"state":"REVIEWER"},{"updated":"2014-01-30 19:06:30.000000000","updated_by":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"reviewer":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"state":"REVIEWER"}],"messages":[{"id":"451f84f2e68aa84f8af46925fbd112fe96a7ed0d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-07 14:35:47.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-ironicclient-pep8 http://logs.openstack.org/77/65277/1/check/gate-python-ironicclient-pep8/2a01866 : SUCCESS in 2m 01s\n- gate-python-ironicclient-python26 http://logs.openstack.org/77/65277/1/check/gate-python-ironicclient-python26/1d20cfc : SUCCESS in 2m 26s\n- gate-python-ironicclient-python27 http://logs.openstack.org/77/65277/1/check/gate-python-ironicclient-python27/f38b6e4 : SUCCESS in 2m 05s\n- gate-python-ironicclient-python33 http://logs.openstack.org/77/65277/1/check/gate-python-ironicclient-python33/09e8eb3 : FAILURE in 5m 24s (non-voting)\n- gate-python-ironicclient-pypy http://logs.openstack.org/77/65277/1/check/gate-python-ironicclient-pypy/03776a4 : SUCCESS in 1m 41s\n","accounts_in_message":[],"_revision_number":1},{"id":"5b991cc7fd2ffe314ce0616195e3e48d0258c6ea","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2014-01-08 10:30:53.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\nGood patch, I left some inline comments, please check, thank you Imre.","accounts_in_message":[],"_revision_number":1},{"id":"7e7b849e5bb351e9fdc5b83153d35f3c35e35ca2","author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"date":"2014-01-09 10:05:08.000000000","message":"Patch Set 1: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"353fbb61c0ced509b9a35705683fb3456109c17a","author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"date":"2014-01-09 10:08:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6d26c3419327e305b1ff3f4528dfbbbc01d45fa4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-09 10:27:18.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-ironicclient-pep8 http://logs.openstack.org/77/65277/2/check/gate-python-ironicclient-pep8/f843c8d : SUCCESS in 2m 22s\n- gate-python-ironicclient-python26 http://logs.openstack.org/77/65277/2/check/gate-python-ironicclient-python26/5958c5e : SUCCESS in 54s\n- gate-python-ironicclient-python27 http://logs.openstack.org/77/65277/2/check/gate-python-ironicclient-python27/1f2d74b : SUCCESS in 2m 20s\n- gate-python-ironicclient-python33 http://logs.openstack.org/77/65277/2/check/gate-python-ironicclient-python33/51f52cb : FAILURE in 5m 27s (non-voting)\n- gate-python-ironicclient-pypy http://logs.openstack.org/77/65277/2/check/gate-python-ironicclient-pypy/dec3bb6 : SUCCESS in 1m 51s\n","accounts_in_message":[],"_revision_number":2},{"id":"51f5a1eb38e26c5b925a1b2d3ff52f8565d510c2","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2014-01-09 11:34:03.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n(2 inline comments)\n\nThank you Imre, left some concern about the new test code.","accounts_in_message":[],"_revision_number":2},{"id":"e78593390f99a524a352082b60e21d437da2c1b4","author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"date":"2014-01-09 11:55:36.000000000","message":"Patch Set 2: (2 inline comments)\n\nThanks for the feedback, Haomeng! I will update the patch.","accounts_in_message":[],"_revision_number":2},{"id":"38c346121960bd35ee3c7bce9c2a1c8cfcfda29b","author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"date":"2014-01-09 12:03:14.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"bf56162dca03d0d6c0e87e86986210778c1b84f7","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2014-01-10 11:32:36.000000000","message":"Patch Set 2: No score\n\ncheck experimental","accounts_in_message":[],"_revision_number":2},{"id":"ae7feeb3124883b2d5660f59a628ab4dcd46cb67","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2014-01-13 08:35:19.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n(2 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"66fdc8271e9f4ca2150ef2d151a7083208b7249b","author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"date":"2014-01-14 10:06:49.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"9c39e5412d424d1845346aefe9dc11b760e2d0df","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2014-01-15 08:40:09.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"c74d7035c9d768537c7a219131d2a6b5ca2468fd","author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"date":"2014-01-15 13:49:48.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"80d136fe8148d083f56f60f50dfc94ea8f108b50","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2014-01-16 03:12:09.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"a25d0530950ba652e5df2bf2fa035f0417b63e88","author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"date":"2014-01-16 03:19:37.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nLGTM, but I haven\u0027t tested it against a current build yet. Will change to +2 after I confirm.","accounts_in_message":[],"_revision_number":2},{"id":"cafbb0133f7fef6b4ccfb2d5fc6ccd4555e85269","author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"date":"2014-01-20 08:46:07.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"a2055c059aaaed0b1c50d764d999e95b928b2b4c","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2014-01-20 08:57:02.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"d5732627d4b1ac420b478ef863644f2eb7696e28","author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"date":"2014-01-28 17:22:15.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nHi Imre!\n\nThanks for the patch! It seems it\u0027s intersects with other work being made in Ironic so we need to discuss it and synchronize. Please see my explanation inline. Thanks!","accounts_in_message":[],"_revision_number":2},{"id":"56c396b495fcbbfe7a463e6aead51569d5fd680f","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2014-01-30 19:06:30.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nHi Imre,\n\nAs max pointed out, having the node-set-power-state returning a reponse message is an inconsistency in our API (Since setting the provision state does not return any response body). Currently there\u0027s a patch in Ironic fixing it, after it lands we might want to reflect that change here in the CLI (by removing that print_dict)\n\nThank you","accounts_in_message":[],"_revision_number":2},{"id":"b3f0403d20c8089a8d86bf9f2f1671690a9bad3e","author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"date":"2014-02-03 11:13:31.000000000","message":"Patch Set 2: Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"190f291edc1bee1f731819f0bea6bcee61511374","revisions":{"103ad7dc325e7018128fa105198c9f8420fd6608":{"kind":"REWORK","_number":1,"created":"2014-01-07 14:14:30.000000000","uploader":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"ref":"refs/changes/77/65277/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/77/65277/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/77/65277/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/77/65277/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/77/65277/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/77/65277/1"}}},"commit":{"parents":[{"commit":"77cb336292472e584767a1d89d471524c1b1831c","subject":"Merge \"Update openstack-common.conf list, sync with oslo (0d8f18b)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/77cb336292472e584767a1d89d471524c1b1831c"}]}],"author":{"name":"Imre Farkas","email":"ifarkas@redhat.com","date":"2014-01-07 13:44:10.000000000","tz":60},"committer":{"name":"Imre Farkas","email":"ifarkas@redhat.com","date":"2014-01-07 14:09:39.000000000","tz":60},"subject":"Fix empty node-set-power-state output","message":"Fix empty node-set-power-state output\n\nCloses-Bug: #1266775\nChange-Id: Ibc2005d4cb9a43ac20ec0624f95dce002b0e02b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/103ad7dc325e7018128fa105198c9f8420fd6608"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/103ad7dc325e7018128fa105198c9f8420fd6608"}]},"branch":"refs/heads/master"},"190f291edc1bee1f731819f0bea6bcee61511374":{"kind":"REWORK","_number":2,"created":"2014-01-09 10:08:16.000000000","uploader":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"ref":"refs/changes/77/65277/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/77/65277/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/77/65277/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/77/65277/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/77/65277/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/77/65277/2"}}},"commit":{"parents":[{"commit":"77cb336292472e584767a1d89d471524c1b1831c","subject":"Merge \"Update openstack-common.conf list, sync with oslo (0d8f18b)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/77cb336292472e584767a1d89d471524c1b1831c"}]}],"author":{"name":"Imre Farkas","email":"ifarkas@redhat.com","date":"2014-01-07 13:44:10.000000000","tz":60},"committer":{"name":"Imre Farkas","email":"ifarkas@redhat.com","date":"2014-01-09 09:57:31.000000000","tz":60},"subject":"Fix empty node-set-power-state output in CLI","message":"Fix empty node-set-power-state output in CLI\n\nWith the NodeStates object returned by API, printing the output has 2\nissues:\n- the current power state has the key \u0027power_state\u0027 instead of \u0027current\u0027\n- it does not contain the target_power_state requested by the user\n\nCloses-Bug: #1266775\nChange-Id: Ibc2005d4cb9a43ac20ec0624f95dce002b0e02b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/190f291edc1bee1f731819f0bea6bcee61511374"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/190f291edc1bee1f731819f0bea6bcee61511374"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}