)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9babbf780674839218ff5c8cc74c0af510e80fcf","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This can cause the wrong version to be negotiated,"},{"line_number":16,"context_line":"or even worse make the call fail because the other"},{"line_number":17,"context_line":"region was uncreachable."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id1912ff5115e0679188bb02d6252e15ab1d906f5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fce034c_f9ae9c96","line":18,"updated":"2019-04-17 03:33:03.000000000","message":"If you need this backported to stable branch versions of ironicclient you should report a bug for this (you should have a bug regardless really).","commit_id":"d08ef9b361a7ce4cc5855a4bb013d97721d49639"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f87276f1a8b498f0582abcd11fa0b97a8ed0078f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This can cause the wrong version to be negotiated,"},{"line_number":16,"context_line":"or even worse make the call fail because the other"},{"line_number":17,"context_line":"region was uncreachable."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id1912ff5115e0679188bb02d6252e15ab1d906f5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fce034c_b40ed92f","line":18,"in_reply_to":"3fce034c_f9ae9c96","updated":"2019-04-17 04:13:47.000000000","message":"Yeah, story and task from storyboard and we\u0027ll need a release note since we\u0027ll want to turn around and release this soon after landing it.","commit_id":"d08ef9b361a7ce4cc5855a4bb013d97721d49639"}],"ironicclient/common/http.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f87276f1a8b498f0582abcd11fa0b97a8ed0078f","unresolved":false,"context_lines":[{"line_number":621,"context_line":"        return conn.request(url, method, raise_exc\u003dFalse,"},{"line_number":622,"context_line":"                            user_agent\u003dUSER_AGENT,"},{"line_number":623,"context_line":"                            endpoint_filter\u003dendpoint_filter,"},{"line_number":624,"context_line":"                            endpoint_override\u003dself.endpoint_override)"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    @with_retries"},{"line_number":627,"context_line":"    def _http_request(self, url, method, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_194da899","side":"PARENT","line":624,"updated":"2019-04-17 04:13:47.000000000","message":"Hmm... yeah, I think this is indeed wrong. endpoint_override is a class argument for a request adapter and an argument for a session request... and the place where this is actually critical for sessions is actually passed as a kwarg dictionary to get_endpoint which looks for the keyword.\n\nI think what happened is this became cruft during refactors. Endpoint overrides and noauth seem to be the big things that get forgotten about in refactors. :(","commit_id":"7f69c5388df1ac416cf6fd2affe442593f0a3a8f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f87276f1a8b498f0582abcd11fa0b97a8ed0078f","unresolved":false,"context_lines":[{"line_number":612,"context_line":""},{"line_number":613,"context_line":"    def _make_simple_request(self, conn, method, url):"},{"line_number":614,"context_line":"        endpoint_filter \u003d {"},{"line_number":615,"context_line":"            \u0027endpoint_override\u0027: self.endpoint_override,"},{"line_number":616,"context_line":"            \u0027interface\u0027: self.interface,"},{"line_number":617,"context_line":"            \u0027service_type\u0027: self.service_type,"},{"line_number":618,"context_line":"            \u0027region_name\u0027: self.region_name"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_391e6470","line":615,"updated":"2019-04-17 04:13:47.000000000","message":"Confirmed, if present in the dictionary, get_endpoint returns back the override, otherwise it will try and if somehow invoked via the adapter it looks like it falls back to session get_endpoint and still gets incorporated.","commit_id":"d08ef9b361a7ce4cc5855a4bb013d97721d49639"}]}