)]}'
{"id":"openstack%2Fpython-ironicclient~653233","triplet_id":"openstack%2Fpython-ironicclient~master~Id1912ff5115e0679188bb02d6252e15ab1d906f5","project":"openstack/python-ironicclient","branch":"master","hashtags":[],"change_id":"Id1912ff5115e0679188bb02d6252e15ab1d906f5","subject":"Make ironicclient always respect endpoint_override","status":"ABANDONED","created":"2019-04-17 03:01:57.000000000","updated":"2019-04-17 11:06:19.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e1da21bfce40b24d86b0e0e9c4b8270efef87c0e","_number":653233,"virtual_id_number":653233,"owner":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"date":"2019-04-17 03:33:03.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"date":"2019-04-17 03:35:33.000000000","_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":-1,"date":"2019-04-17 04:13:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-17 03:33:03.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-04-17 04:13:47.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"}],"messages":[{"id":"2aa3b000709f319d5145dfb2883ca453a390d4ae","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-04-17 03:01:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"632b86469a755700b0e91a77b91180747ec89deb","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-04-17 03:21:35.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9babbf780674839218ff5c8cc74c0af510e80fcf","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-17 03:33:03.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c29df0b045466f26b257843e68a8a30e829bedb2","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-04-17 03:35:33.000000000","message":"Patch Set 2:\n\n\u003e (1 comment)\n\nFor sure. Will do that tomorrow. We will need that backported to at least Rocky (possible further than that).","accounts_in_message":[],"_revision_number":2},{"id":"f87276f1a8b498f0582abcd11fa0b97a8ed0078f","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2019-04-17 04:13:47.000000000","message":"Patch Set 2: Code-Review-1\n\n(3 comments)\n\nGreat catch! Wow! I\u0027m +2 on the code fix, A reno and commit message change will be needed to track this, and as such marking -1 as we\u0027ll need them to backport this.","accounts_in_message":[],"_revision_number":2},{"id":"e6b0f122f40895648a99868a3c2d71af8de8a20d","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-04-17 04:16:57.000000000","message":"Abandoned\n\nThe fix is already in master, we just need to backport\nhttps://github.com/openstack/python-ironicclient/commit/8071d5de57c728ce09d25d04c8c9fe48cd7db42e","accounts_in_message":[],"_revision_number":2},{"id":"e1da21bfce40b24d86b0e0e9c4b8270efef87c0e","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-04-17 11:06:19.000000000","message":"Patch Set 2:\n\nDo you think we could drop our homegrown code and just use the fact that we inherit from an adapter?","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d08ef9b361a7ce4cc5855a4bb013d97721d49639","revisions":{"3bcf8d8d511f36be6644ce2e751e28626c21bd85":{"kind":"REWORK","_number":1,"created":"2019-04-17 03:01:57.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/33/653233/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/33/653233/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/33/653233/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/33/653233/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/33/653233/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/33/653233/1"}}},"commit":{"parents":[{"commit":"7f69c5388df1ac416cf6fd2affe442593f0a3a8f","subject":"Dropping the py35 testing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/7f69c5388df1ac416cf6fd2affe442593f0a3a8f"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-04-17 02:58:15.000000000","tz":-420},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-04-17 02:58:51.000000000","tz":-420},"subject":"[WIP] Make ironicclient respect endpoint_override","message":"[WIP] Make ironicclient respect endpoint_override\n\nChange-Id: Id1912ff5115e0679188bb02d6252e15ab1d906f5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/3bcf8d8d511f36be6644ce2e751e28626c21bd85"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/3bcf8d8d511f36be6644ce2e751e28626c21bd85"}]},"branch":"refs/heads/master"},"d08ef9b361a7ce4cc5855a4bb013d97721d49639":{"kind":"REWORK","_number":2,"created":"2019-04-17 03:21:35.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/33/653233/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/33/653233/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/33/653233/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/33/653233/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/33/653233/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/33/653233/2"}}},"commit":{"parents":[{"commit":"7f69c5388df1ac416cf6fd2affe442593f0a3a8f","subject":"Dropping the py35 testing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/7f69c5388df1ac416cf6fd2affe442593f0a3a8f"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-04-17 02:58:15.000000000","tz":-420},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-04-17 03:16:30.000000000","tz":-420},"subject":"Make ironicclient always respect endpoint_override","message":"Make ironicclient always respect endpoint_override\n\nIn the current implementation the endpoint_override\nis not respected during version negotiations. This\nmeans that a critical components of any api call\nthat does endpoint_override is going to be done\nagainst the wrong region.\n\nThis can cause the wrong version to be negotiated,\nor even worse make the call fail because the other\nregion was uncreachable.\n\nChange-Id: Id1912ff5115e0679188bb02d6252e15ab1d906f5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/d08ef9b361a7ce4cc5855a4bb013d97721d49639"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/d08ef9b361a7ce4cc5855a4bb013d97721d49639"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}