)]}'
{"id":"openstack%2Fpython-ironicclient~653279","triplet_id":"openstack%2Fpython-ironicclient~stable%2Frocky~I69dc2c88648ba1d09a9ad3ab3435662e8d1ea6ff","project":"openstack/python-ironicclient","branch":"stable/rocky","topic":"bug/1818295","hashtags":[],"change_id":"I69dc2c88648ba1d09a9ad3ab3435662e8d1ea6ff","subject":"Use endpoint_override in version negotiation","status":"MERGED","created":"2019-04-17 04:28:03.000000000","updated":"2019-05-17 06:02:56.000000000","submitted":"2019-04-17 11:18:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"653279-1555499938407-06c4f5fb","meta_rev_id":"b736de0092b6d8b0f2204e91819cc8fd0b96f6f7","_number":653279,"virtual_id_number":653279,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},{"value":2,"date":"2019-04-17 11:18:58.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"recommended":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"all":[{"value":0,"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-04-17 04:30:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"value":2,"date":"2019-04-17 07:37:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"date":"2019-04-17 04:28:03.000000000","_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"value":1,"date":"2019-04-17 07:37:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-17 04:28:03.000000000","updated_by":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"reviewer":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"state":"REVIEWER"},{"updated":"2019-04-17 04:30:33.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2019-04-17 07:37:33.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2019-04-17 11:18:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d6871660cca59fb30fec80c63d346779606af694","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2019-04-17 04:28:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4798c34c8cd9240ae76d0b1ab9c3eba7ebd54690","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-04-17 04:30:33.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"60e2ca3ead0f8eb665c2d5d42f8e9732fc81e1f3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-17 05:16:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-py35 http://logs.openstack.org/79/653279/1/check/openstack-tox-py35/7ba7974/ : SUCCESS in 6m 51s\n- openstack-tox-pep8 http://logs.openstack.org/79/653279/1/check/openstack-tox-pep8/588a29d/ : SUCCESS in 4m 55s\n- openstack-tox-py27 http://logs.openstack.org/79/653279/1/check/openstack-tox-py27/1ff0d91/ : SUCCESS in 4m 30s\n- build-openstack-sphinx-docs http://logs.openstack.org/79/653279/1/check/build-openstack-sphinx-docs/f3c19c2/html/ : SUCCESS in 4m 17s\n- build-openstack-releasenotes http://logs.openstack.org/79/653279/1/check/build-openstack-releasenotes/14e8bc5/html/ : SUCCESS in 3m 30s\n- openstackclient-check-plugins http://logs.openstack.org/79/653279/1/check/openstackclient-check-plugins/64ce1c6/ : SUCCESS in 5m 42s (non-voting)\n- ironicclient-dsvm-functional http://logs.openstack.org/79/653279/1/check/ironicclient-dsvm-functional/8b2b76f/ : SUCCESS in 21m 02s\n- ironicclient-tempest-dsvm-src http://logs.openstack.org/79/653279/1/check/ironicclient-tempest-dsvm-src/224a921/ : SUCCESS in 42m 24s\n- openstack-tox-lower-constraints http://logs.openstack.org/79/653279/1/check/openstack-tox-lower-constraints/0180f65/ : SUCCESS in 7m 06s\n- openstack-tox-cover http://logs.openstack.org/79/653279/1/check/openstack-tox-cover/48039bf/cover/ : SUCCESS in 6m 01s","accounts_in_message":[],"_revision_number":1},{"id":"09d8e900fd4c5575ee49bbb205dcd5ca1e463334","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-04-17 07:37:33.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"930925a41173bba0d3e115879ab57cc6c57b4534","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-17 07:37:50.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"237f874888e0671f2f8e9ab6fc5d75b534532f1a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-17 11:18:58.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"c8fec149f2968b96ea0db02526df57b1137c0f09","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-17 11:18:58.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-py35 http://logs.openstack.org/79/653279/1/gate/openstack-tox-py35/9a8abde/ : SUCCESS in 5m 11s\n- openstack-tox-pep8 http://logs.openstack.org/79/653279/1/gate/openstack-tox-pep8/f3a45ca/ : SUCCESS in 6m 20s\n- openstack-tox-py27 http://logs.openstack.org/79/653279/1/gate/openstack-tox-py27/ca849b1/ : SUCCESS in 6m 12s\n- build-openstack-sphinx-docs http://logs.openstack.org/79/653279/1/gate/build-openstack-sphinx-docs/311c89c/html/ : SUCCESS in 7m 27s\n- build-openstack-releasenotes http://logs.openstack.org/79/653279/1/gate/build-openstack-releasenotes/f02d4c7/html/ : SUCCESS in 4m 18s\n- ironicclient-dsvm-functional http://logs.openstack.org/79/653279/1/gate/ironicclient-dsvm-functional/31019aa/ : SUCCESS in 23m 09s\n- ironicclient-tempest-dsvm-src http://logs.openstack.org/79/653279/1/gate/ironicclient-tempest-dsvm-src/5dcbab1/ : SUCCESS in 45m 25s\n- openstack-tox-lower-constraints http://logs.openstack.org/79/653279/1/gate/openstack-tox-lower-constraints/a2970e6/ : SUCCESS in 9m 32s","accounts_in_message":[],"_revision_number":1},{"id":"66c2d94dd42777349517a5420b79c87a7b2966cd","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2019-05-16 18:22:53.000000000","message":"Patch Set 1:\n\nThis or https://review.opendev.org/#/c/641562 seems to have broken some ironic jobs in nova and TripleO in stable/rocky[1] for example:- http://logs.openstack.org/04/658504/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/63601a1/controller/logs/screen-n-cpu.txt.gz#_May_13_20_14_29_997867\n\n\n[1] http://zuul.openstack.org/builds?job_name\u003dironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa\u0026branch\u003dstable%2Frocky\n\nAlso seeing issue in TripleO example log:- https://logs.rdoproject.org/openstack-periodic-24hr/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035-rocky/9dc601a/logs/undercloud/var/log/containers/nova/nova-compute.log.txt.gz#_2019-05-16_05_59_59_875","accounts_in_message":[],"_revision_number":1},{"id":"557e84200d019f7da1a14ca4cc6fe31a0bc45da6","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2019-05-17 06:02:56.000000000","message":"Patch Set 1:\n\n\u003e This or https://review.opendev.org/#/c/641562 seems to have broken\n \u003e some ironic jobs in nova and TripleO in stable/rocky[1] for\n \u003e example:- http://logs.openstack.org/04/658504/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/63601a1/controller/logs/screen-n-cpu.txt.gz#_May_13_20_14_29_997867\n \u003e \n \u003e \n \u003e [1] http://zuul.openstack.org/builds?job_name\u003dironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa\u0026branch\u003dstable%2Frocky\n \u003e \n \u003e Also seeing issue in TripleO example log:- https://logs.rdoproject.org/openstack-periodic-24hr/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035-rocky/9dc601a/logs/undercloud/var/log/containers/nova/nova-compute.log.txt.gz#_2019-05-16_05_59_59_875\n\nSeems https://review.opendev.org/#/c/659592/ will fix it","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"466be3b6568b643605d826e5aa26d9a344cc74ae","revisions":{"466be3b6568b643605d826e5aa26d9a344cc74ae":{"kind":"REWORK","_number":1,"created":"2019-04-17 04:28:03.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/79/653279/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/79/653279/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/79/653279/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/79/653279/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/79/653279/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/79/653279/1"}}},"commit":{"parents":[{"commit":"e81f74502132d891bc4db2ff1df98f4940d21fe7","subject":"Replace openstack.org git:// URLs with https://","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e81f74502132d891bc4db2ff1df98f4940d21fe7"}]}],"author":{"name":"Jason","email":"jasonanderson@uchicago.edu","date":"2019-03-15 15:57:57.000000000","tz":-300},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2019-04-17 04:27:56.000000000","tz":-420},"subject":"Use endpoint_override in version negotiation","message":"Use endpoint_override in version negotiation\n\nChange [1] introduced the usage of endpoint_filter when deciding which\nendpoint to use during version negotiation. This requires properly\nsetting interface/region/service_type in order to properly pick the\nendpoint. But, sometimes (for example in Kolla-ansible), the endpoint\nurl is explicitly defined. In the event of the endpoint being explicitly\ndefined, it should take priority here.\n\nIt should be noted that even though SessionClient extends from\nkeystoneauth1\u0027s adapter.LegacyJsonAdapter, the `request` function within\n_make_simple_request is being called on the nested Session object, not\nthe Adapter itself. If it was called on the Adapter this problem\nwouldn\u0027t exist, as the `endpoint_override` (or `endpoint`) kwarg passed\nin to the constructor of the SessionClient would already take\nprecedence.\n\nAdditionally: Adds a release note to the older branch as this is a\nfix that needs to be released and is worthy of change visibility\nin release notes.\n\n[1]: I42b66daea1f4397273a3f4eb1638abafb3bb28ce\n\nChange-Id: I69dc2c88648ba1d09a9ad3ab3435662e8d1ea6ff\nRelated-Bug: #1818295\n(cherry picked from commit 8071d5de57c728ce09d25d04c8c9fe48cd7db42e)\n(cherry picked from commit b40630f3b3e747ae4a26d31e8e292554b99713f2)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/466be3b6568b643605d826e5aa26d9a344cc74ae"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/466be3b6568b643605d826e5aa26d9a344cc74ae"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}