)]}'
{"id":"openstack%2Fpython-ironicclient~653338","triplet_id":"openstack%2Fpython-ironicclient~stable%2Fqueens~I69dc2c88648ba1d09a9ad3ab3435662e8d1ea6ff","project":"openstack/python-ironicclient","branch":"stable/queens","topic":"bug/1818295-stable/queens","hashtags":[],"change_id":"I69dc2c88648ba1d09a9ad3ab3435662e8d1ea6ff","subject":"Use endpoint_override in version negotiation","status":"ABANDONED","created":"2019-04-17 07:38:06.000000000","updated":"2019-05-29 08:47:54.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"aa36fda2bf2bd0d4253971eeaf845c1903fc3291","_number":653338,"virtual_id_number":653338,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":1,"date":"2019-04-17 08:54:25.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":1,"date":"2019-04-17 08:57:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2019-04-17 07:38:06.000000000","_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},{"value":-1,"date":"2019-05-16 13:22:24.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-17 07:38:06.000000000","updated_by":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"reviewer":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"state":"REVIEWER"},{"updated":"2019-04-17 08:54:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-17 08:57:46.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"}],"messages":[{"id":"86272e60364f194b59aef456a10c8a410d9298fd","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-04-17 07:38:06.000000000","message":"Patch Set 1: Cherry Picked from branch stable/stein.","accounts_in_message":[],"_revision_number":1},{"id":"1f602d9a93925679861a73a650bd7a5a69930664","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-17 08:54:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-py35 http://logs.openstack.org/38/653338/1/check/openstack-tox-py35/67742fd/ : SUCCESS in 5m 44s\n- openstack-tox-pep8 http://logs.openstack.org/38/653338/1/check/openstack-tox-pep8/4dfc894/ : SUCCESS in 5m 46s\n- openstack-tox-py27 http://logs.openstack.org/38/653338/1/check/openstack-tox-py27/bd47e93/ : SUCCESS in 5m 07s\n- build-openstack-sphinx-docs http://logs.openstack.org/38/653338/1/check/build-openstack-sphinx-docs/c1d16ee/html/ : SUCCESS in 5m 49s\n- build-openstack-releasenotes http://logs.openstack.org/38/653338/1/check/build-openstack-releasenotes/6e67e88/html/ : SUCCESS in 4m 30s\n- openstackclient-check-plugins http://logs.openstack.org/38/653338/1/check/openstackclient-check-plugins/7541343/ : FAILURE in 6m 29s (non-voting)\n- ironicclient-dsvm-functional http://logs.openstack.org/38/653338/1/check/ironicclient-dsvm-functional/cccaa10/ : SUCCESS in 25m 18s\n- ironicclient-tempest-dsvm-src http://logs.openstack.org/38/653338/1/check/ironicclient-tempest-dsvm-src/636f618/ : SUCCESS in 48m 06s\n- openstack-tox-cover http://logs.openstack.org/38/653338/1/check/openstack-tox-cover/76e995a/cover/ : SUCCESS in 5m 16s","accounts_in_message":[],"_revision_number":1},{"id":"3860f9138e8303fede720899e6762e104ca800cf","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-04-17 08:57:46.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"c62d874a4d52332fec976210b85b29371daa1101","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-05-16 13:22:24.000000000","message":"Patch Set 1: Workflow-1\n\nThis change may be breaking, hold on.","accounts_in_message":[],"_revision_number":1},{"id":"27aa400ac99ad5c66f61e5ad4b8e318334ee2c4e","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-05-29 08:47:54.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2d3807a5216a564eb5341a84232c434da2866964","revisions":{"2d3807a5216a564eb5341a84232c434da2866964":{"kind":"REWORK","_number":1,"created":"2019-04-17 07:38:06.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/38/653338/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/38/653338/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/38/653338/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/38/653338/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/38/653338/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/38/653338/1"}}},"commit":{"parents":[{"commit":"110257b4f50596ec2e2f4ac72ff038ce48a2905d","subject":"Replace openstack.org git:// URLs with https://","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/110257b4f50596ec2e2f4ac72ff038ce48a2905d"}]}],"author":{"name":"Jason","email":"jasonanderson@uchicago.edu","date":"2019-03-15 15:57:57.000000000","tz":-300},"committer":{"name":"Dmitry Tantsur","email":"divius.inside@gmail.com","date":"2019-04-17 07:38:06.000000000","tz":0},"subject":"Use endpoint_override in version negotiation","message":"Use endpoint_override in version negotiation\n\nChange [1] introduced the usage of endpoint_filter when deciding which\nendpoint to use during version negotiation. This requires properly\nsetting interface/region/service_type in order to properly pick the\nendpoint. But, sometimes (for example in Kolla-ansible), the endpoint\nurl is explicitly defined. In the event of the endpoint being explicitly\ndefined, it should take priority here.\n\nIt should be noted that even though SessionClient extends from\nkeystoneauth1\u0027s adapter.LegacyJsonAdapter, the `request` function within\n_make_simple_request is being called on the nested Session object, not\nthe Adapter itself. If it was called on the Adapter this problem\nwouldn\u0027t exist, as the `endpoint_override` (or `endpoint`) kwarg passed\nin to the constructor of the SessionClient would already take\nprecedence.\n\nAdditionally: Adds a release note to the older branch as this is a\nfix that needs to be released and is worthy of change visibility\nin release notes.\n\n[1]: I42b66daea1f4397273a3f4eb1638abafb3bb28ce\n\nChange-Id: I69dc2c88648ba1d09a9ad3ab3435662e8d1ea6ff\nRelated-Bug: #1818295\n(cherry picked from commit 8071d5de57c728ce09d25d04c8c9fe48cd7db42e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/2d3807a5216a564eb5341a84232c434da2866964"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/2d3807a5216a564eb5341a84232c434da2866964"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}