)]}'
{"id":"openstack%2Fpython-ironicclient~659592","triplet_id":"openstack%2Fpython-ironicclient~master~I3b25f4fb170aa93159ffa8074dc74fa6f50671b7","project":"openstack/python-ironicclient","branch":"master","topic":"gate","hashtags":[],"change_id":"I3b25f4fb170aa93159ffa8074dc74fa6f50671b7","subject":"Do not try to use /v1/v1 when endpoint_override is used","status":"MERGED","created":"2019-05-16 15:02:45.000000000","updated":"2019-05-17 02:18:23.000000000","submitted":"2019-05-17 02:18:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"659592-1558059503485-cfabfb19","meta_rev_id":"4aa75e63e540e64c5969bd807ae21b5b7fe6e0f6","_number":659592,"virtual_id_number":659592,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":2,"date":"2019-05-17 02:18:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-05-16 16:03:23.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":2,"date":"2019-05-16 19:24:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":2,"date":"2019-05-17 01:23:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"all":[{"value":0,"date":"2019-05-16 16:02:48.000000000","_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"date":"2019-05-16 16:03:01.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"date":"2019-05-16 16:03:10.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":1,"date":"2019-05-17 01:23:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-16 16:02:48.000000000","updated_by":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"reviewer":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"state":"REVIEWER"},{"updated":"2019-05-16 16:03:01.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2019-05-16 16:03:10.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2019-05-16 19:24:35.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2019-05-17 01:23:21.000000000","updated_by":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"reviewer":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"state":"REVIEWER"},{"updated":"2019-05-17 02:18:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"91ae9de7c96784968266f994b7537285f3341b63","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-05-16 15:02:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"99d49c69d55b62e7a129eaabab8b0e124f519565","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-16 15:59:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/92/659592/1/check/openstack-tox-cover/7193b2a/cover/ : SUCCESS in 4m 44s\n- openstack-tox-lower-constraints http://logs.openstack.org/92/659592/1/check/openstack-tox-lower-constraints/9b968df/ : SUCCESS in 6m 07s\n- openstack-tox-pep8 http://logs.openstack.org/92/659592/1/check/openstack-tox-pep8/724740a/ : SUCCESS in 4m 23s\n- openstack-tox-py27 http://logs.openstack.org/92/659592/1/check/openstack-tox-py27/c13a7a9/ : SUCCESS in 5m 58s\n- openstack-tox-py36 http://logs.openstack.org/92/659592/1/check/openstack-tox-py36/6844b16/ : SUCCESS in 4m 11s\n- openstack-tox-py37 http://logs.openstack.org/92/659592/1/check/openstack-tox-py37/3706b17/ : SUCCESS in 7m 07s\n- openstackclient-check-plugins http://logs.openstack.org/92/659592/1/check/openstackclient-check-plugins/aaddb28/ : SUCCESS in 5m 45s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/92/659592/1/check/openstack-tox-docs/0be6abe/html/ : SUCCESS in 4m 33s\n- build-openstack-releasenotes http://logs.openstack.org/92/659592/1/check/build-openstack-releasenotes/294cab0/html/ : SUCCESS in 3m 45s\n- ironicclient-functional http://logs.openstack.org/92/659592/1/check/ironicclient-functional/2190e7e/ : SUCCESS in 21m 20s\n- ironicclient-functional-python2 http://logs.openstack.org/92/659592/1/check/ironicclient-functional-python2/dda16d4/ : SUCCESS in 21m 34s\n- ironicclient-tempest http://logs.openstack.org/92/659592/1/check/ironicclient-tempest/75d16d5/ : SUCCESS in 50m 47s\n- ironicclient-tempest-python2 http://logs.openstack.org/92/659592/1/check/ironicclient-tempest-python2/3005c6c/ : SUCCESS in 47m 02s","accounts_in_message":[],"_revision_number":1},{"id":"2997c16b93322c3d891b8757d3819a1c8cb08802","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-05-16 16:03:23.000000000","message":"Patch Set 1:\n\nWhen released, this will hopefully fix the CI.","accounts_in_message":[],"_revision_number":1},{"id":"c7cb9ec55d00420cb5f19e7778042b5d36eaa8e2","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-05-16 19:24:35.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks Dmitry!","accounts_in_message":[],"_revision_number":1},{"id":"9d019970f8840e741ba7e0dab35e737ab372d17a","author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"date":"2019-05-17 01:23:21.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"73cc533a3d2b5a86091c093403be389ee8b9e9b2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-17 01:23:33.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"68c80374de5020ab571d022ca79b23636fc5c8ef","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-17 02:18:23.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"3e3e815021816c0f0c95de4784b0f55e7811c9e8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-17 02:18:23.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/92/659592/1/gate/openstack-tox-lower-constraints/8b5b285/ : SUCCESS in 5m 48s\n- openstack-tox-pep8 http://logs.openstack.org/92/659592/1/gate/openstack-tox-pep8/7687b5d/ : SUCCESS in 4m 44s\n- openstack-tox-py27 http://logs.openstack.org/92/659592/1/gate/openstack-tox-py27/584a2f0/ : SUCCESS in 4m 23s\n- openstack-tox-py36 http://logs.openstack.org/92/659592/1/gate/openstack-tox-py36/c5829e0/ : SUCCESS in 7m 00s\n- openstack-tox-py37 http://logs.openstack.org/92/659592/1/gate/openstack-tox-py37/423e0ae/ : SUCCESS in 4m 47s\n- openstack-tox-docs http://logs.openstack.org/92/659592/1/gate/openstack-tox-docs/4e66db8/html/ : SUCCESS in 4m 05s\n- build-openstack-releasenotes http://logs.openstack.org/92/659592/1/gate/build-openstack-releasenotes/9a69358/html/ : SUCCESS in 4m 03s\n- ironicclient-functional http://logs.openstack.org/92/659592/1/gate/ironicclient-functional/b4d3c80/ : SUCCESS in 16m 10s\n- ironicclient-functional-python2 http://logs.openstack.org/92/659592/1/gate/ironicclient-functional-python2/8a6a1c7/ : SUCCESS in 18m 05s\n- ironicclient-tempest http://logs.openstack.org/92/659592/1/gate/ironicclient-tempest/bb390a2/ : SUCCESS in 53m 59s\n- ironicclient-tempest-python2 http://logs.openstack.org/92/659592/1/gate/ironicclient-tempest-python2/22dcca0/ : SUCCESS in 39m 17s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4565af8ccd8aaa35868fae6ae31216c3e57014f3","revisions":{"4565af8ccd8aaa35868fae6ae31216c3e57014f3":{"kind":"REWORK","_number":1,"created":"2019-05-16 15:02:45.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/92/659592/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/92/659592/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/92/659592/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/92/659592/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/92/659592/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/92/659592/1"}}},"commit":{"parents":[{"commit":"5e8680c11e7c1fac53c354ff94411da578e58f4f","subject":"Fetch requirements from opendev","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/5e8680c11e7c1fac53c354ff94411da578e58f4f"}]}],"author":{"name":"Dmitry Tantsur","email":"divius.inside@gmail.com","date":"2019-05-16 14:52:36.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"divius.inside@gmail.com","date":"2019-05-16 15:01:48.000000000","tz":120},"subject":"Do not try to use /v1/v1 when endpoint_override is used","message":"Do not try to use /v1/v1 when endpoint_override is used\n\nIn one of the places where endpoint_override is used we did not strip\nthe /v1 suffix, resulting in doube /v1/v1 sometimes.\n\nThis patch also corrects the way we strip this suffix (str.rstrip accepts\na set of symbols, not a substring; use regex instead).\n\nIt remains unclear why the breakage passed the gate initially. I assume\nit was not on the active code path until some Nova change.\n\nStory: #2005723\nTask: #31051\nChange-Id: I3b25f4fb170aa93159ffa8074dc74fa6f50671b7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/4565af8ccd8aaa35868fae6ae31216c3e57014f3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/4565af8ccd8aaa35868fae6ae31216c3e57014f3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}