)]}'
{"id":"openstack%2Fpython-ironicclient~683944","triplet_id":"openstack%2Fpython-ironicclient~master~Ia942858abe980abf95c1ca136767983e7a0a285e","project":"openstack/python-ironicclient","branch":"master","topic":"typerror","hashtags":[],"change_id":"Ia942858abe980abf95c1ca136767983e7a0a285e","subject":"Fix TypeError when using endpoint_override with SessionClient","status":"MERGED","created":"2019-09-23 12:27:42.000000000","updated":"2019-09-24 11:20:25.000000000","submitted":"2019-09-23 17:05:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"683944-1569258343032-f5fe0389","meta_rev_id":"1a26a219a35209a1ef752957a81e39fc1150804f","_number":683944,"virtual_id_number":683944,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-09-23 17:05:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"all":[{"value":2,"date":"2019-09-23 15:57:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":2,"date":"2019-09-23 15:08:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"all":[{"value":1,"date":"2019-09-23 15:57:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-23 15:08:54.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2019-09-23 15:57:09.000000000","updated_by":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"reviewer":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"state":"REVIEWER"},{"updated":"2019-09-23 17:05:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"359d60b4f6a459d6f5d22db59f2b838f97f59747","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-09-23 12:27:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"33bf7f807cd7586817fab2d31e761c04404909e4","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-09-23 12:51:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ceadb2e49deee2ce3b0b4b7bde63de719aa110f7","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-09-23 13:31:23.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"7b1f5bc83ea9004013a4e598aceab858b8e206ee","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 15:04:35.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4508ada443f44134a4dacd1ab23e51c3 : SUCCESS in 3m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d3c21613df6e463abc384dca98bfc7c7 : SUCCESS in 6m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d6543ba0b08342fba5cb2cd4a20a3828 : SUCCESS in 3m 14s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/e82e1a1c02094b0a85da0ca7d46b3a0d : SUCCESS in 30m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/899c31f5bfb54078bbc75c6ecb737e09 : SUCCESS in 5m 50s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/1665064864c74bf99e7aa83577a44531 : SUCCESS in 5m 45s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/cd106a48c55a46d8adc9c393348cb8e3 : SUCCESS in 4m 50s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/99547ea9ac9f4e1f9a012bad13030f82 : SUCCESS in 7m 10s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/05817b913c044829968909dae8a213b0 : SUCCESS in 4m 20s\n- ironicclient-functional https://zuul.opendev.org/t/openstack/build/6af2e43df5e641cca91e418c66a1ff92 : SUCCESS in 21m 08s\n- ironicclient-functional-python2 https://zuul.opendev.org/t/openstack/build/ed60e4497e1646d48f51fd2927ca2b3c : SUCCESS in 20m 51s\n- ironicclient-tempest https://zuul.opendev.org/t/openstack/build/8ee99430fb2c49baabe178228465582d : SUCCESS in 1h 05m 30s\n- ironicclient-tempest-python2 https://zuul.opendev.org/t/openstack/build/2d5edb9b12854071befa9a8823f1a8e9 : SUCCESS in 56m 48s","accounts_in_message":[],"_revision_number":3},{"id":"a8f28e077a8d1deed8db88ddaedb240651600d52","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-09-23 15:08:54.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"57ee9d1ce3a7adef370f3378d7843f1646451bed","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2019-09-23 15:57:09.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"cee6f620a06456f0a025c12cb34f41c678ad4ec8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 15:57:21.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"d58626b560c3e497eea934a8a4ec6544399ae5e9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 17:05:42.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a61d002607314cccaaa27d3f2189da9e : SUCCESS in 4m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cf20b8dab5534911a00bb340ca698545 : SUCCESS in 4m 50s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/f78cf97114a049c48ebfe1c1293d3ef2 : SUCCESS in 3m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6b09066307a6493bae5b106065f6721f : SUCCESS in 4m 42s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/1a86379930c34c37a22d48d06ecab3c8 : SUCCESS in 4m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/62a3655a6c484c4b97ff170835965188 : SUCCESS in 5m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9020a154c5a444d68f68d4a6fe5b96c1 : SUCCESS in 3m 14s\n- ironicclient-functional https://zuul.opendev.org/t/openstack/build/cc90f28c21e649588e09e4f68acb17b8 : SUCCESS in 23m 52s\n- ironicclient-functional-python2 https://zuul.opendev.org/t/openstack/build/79bc2ce7e11e42ddad3d24f2bb20d9cc : SUCCESS in 24m 02s\n- ironicclient-tempest https://zuul.opendev.org/t/openstack/build/482c23f6e80d4a32877e74ca8f704e85 : SUCCESS in 58m 11s\n- ironicclient-tempest-python2 https://zuul.opendev.org/t/openstack/build/f3afe7bfbd7446f9a58fcd8586779b09 : SUCCESS in 57m 13s","accounts_in_message":[],"_revision_number":3},{"id":"70bf658c91e1ef6b9c51aa4a399232582b823056","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 17:05:43.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"86b39b63d332128a6a424dfd51106081fde0cf08","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 17:07:45.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/587bb8879bce420695fa9800c542125b : SUCCESS in 1m 40s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3166fb730f8447408965f5959a52e354 : SUCCESS in 1m 02s","accounts_in_message":[],"_revision_number":3},{"id":"716f2b367058bf7b589eccc1d8b6937a758f1cfe","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-09-24 11:20:25.000000000","message":"Patch Set 3: Cherry Picked\n\nThis patchset was cherry picked to branch stable/train as commit cbd4418e09774098ed1d003faf7a1adcd42aec3a","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"7f003e1e045e3e20b824a94676310315f8fef9fc","revisions":{"daf26738d15c4e677394af41e5db1242bc452308":{"kind":"REWORK","_number":1,"created":"2019-09-23 12:27:42.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/44/683944/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/44/683944/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/44/683944/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/44/683944/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/44/683944/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/44/683944/1"}}},"commit":{"parents":[{"commit":"5a9964b17601bda378fa71296737e97451300fb7","subject":"Update master for stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/5a9964b17601bda378fa71296737e97451300fb7"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2019-09-23 12:26:37.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2019-09-23 12:26:37.000000000","tz":120},"subject":"Fix TypeError when endpoint cannot be detected from a session","message":"Fix TypeError when endpoint cannot be detected from a session\n\nNone is returned from get_endpoint in this case, causing subsequent\ncode to fail. This changes fixes it.\n\nChange-Id: Ia942858abe980abf95c1ca136767983e7a0a285e\nStory: #2006600\nTask: #36763\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/daf26738d15c4e677394af41e5db1242bc452308"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/daf26738d15c4e677394af41e5db1242bc452308"}]},"branch":"refs/heads/master"},"b6c89497d8575b7a153b1fcf069ca2bc4e8b072a":{"kind":"REWORK","_number":2,"created":"2019-09-23 12:51:16.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/44/683944/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/44/683944/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/44/683944/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/44/683944/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/44/683944/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/44/683944/2"}}},"commit":{"parents":[{"commit":"5a9964b17601bda378fa71296737e97451300fb7","subject":"Update master for stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/5a9964b17601bda378fa71296737e97451300fb7"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2019-09-23 12:26:37.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2019-09-23 12:49:51.000000000","tz":120},"subject":"Fix TypeError when using endpoint_override with SessionClient","message":"Fix TypeError when using endpoint_override with SessionClient\n\nFirst, when endpoint cannot be detected from a session None is returned\nfrom get_endpoint, causing subsequent code to fail. This changes fixes it.\n\nSecond, endpoint_override is not passed to a Session (it\u0027s an Adapter)\nproperty, doing it has no effect. Use get_endpoint from Adapter instead.\n\nChange-Id: Ia942858abe980abf95c1ca136767983e7a0a285e\nStory: #2006600\nTask: #36763\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/b6c89497d8575b7a153b1fcf069ca2bc4e8b072a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/b6c89497d8575b7a153b1fcf069ca2bc4e8b072a"}]},"branch":"refs/heads/master"},"7f003e1e045e3e20b824a94676310315f8fef9fc":{"kind":"REWORK","_number":3,"created":"2019-09-23 13:31:23.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/44/683944/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/44/683944/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/44/683944/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/44/683944/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/44/683944/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/44/683944/3"}}},"commit":{"parents":[{"commit":"5a9964b17601bda378fa71296737e97451300fb7","subject":"Update master for stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/5a9964b17601bda378fa71296737e97451300fb7"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2019-09-23 12:26:37.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2019-09-23 13:31:09.000000000","tz":120},"subject":"Fix TypeError when using endpoint_override with SessionClient","message":"Fix TypeError when using endpoint_override with SessionClient\n\nFirst, when endpoint cannot be detected from a session None is returned\nfrom get_endpoint, causing subsequent code to fail. This changes fixes it.\n\nSecond, endpoint_override is not passed to a Session (it\u0027s an Adapter)\nproperty, doing it has no effect. Use get_endpoint from Adapter instead.\n\nChange-Id: Ia942858abe980abf95c1ca136767983e7a0a285e\nStory: #2006600\nTask: #36763\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/7f003e1e045e3e20b824a94676310315f8fef9fc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/7f003e1e045e3e20b824a94676310315f8fef9fc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}