)]}'
{"id":"openstack%2Fpython-ironicclient~697269","triplet_id":"openstack%2Fpython-ironicclient~stable%2Ftrain~Ib62ca3ee4626084e5e9b90e93e4fa97938023457","project":"openstack/python-ironicclient","branch":"stable/train","topic":"story/2006393-stable/train","hashtags":[],"change_id":"Ib62ca3ee4626084e5e9b90e93e4fa97938023457","subject":"Fix AttributeError in negotiate_version","status":"MERGED","created":"2019-12-04 11:25:39.000000000","updated":"2019-12-09 16:29:05.000000000","submitted":"2019-12-09 16:26:07.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"697269-1575908768209-eb4fed8d","meta_rev_id":"26a87872839852a67b489ce6773d2cc29e08b7e5","_number":697269,"virtual_id_number":697269,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-09 16:26:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"recommended":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-12-06 06:00:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"value":2,"date":"2019-12-09 15:25:26.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":2,"date":"2019-12-05 11:02:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"value":1,"date":"2019-12-09 15:25:26.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-05 11:02:01.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2019-12-06 06:00:04.000000000","updated_by":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"reviewer":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"state":"REVIEWER"},{"updated":"2019-12-09 15:25:26.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2019-12-09 16:26:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b1c78f14cc79efbf3152cab2355184dbc94ea6e6","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2019-12-04 11:25:39.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"20eef2f244eba8bffc715648f9540201f9459712","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2019-12-04 11:26:01.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit 0bd26cc47ed51d19e07280db9e770ad09edd2bf8","accounts_in_message":[],"_revision_number":1},{"id":"32a7ee5d44a5484e05b06a6b0df0fc5ecb837051","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-04 12:18:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c4b239b430d040fdabb271d9b9daac5c : SUCCESS in 4m 55s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3df65ab6935d447998012960f34c9e16 : SUCCESS in 6m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3865f8955a744fdc973d38bee7241a87 : SUCCESS in 4m 23s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/77d7310f084b43599dc3212c3e9cc54b : SUCCESS in 4m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9c3a94a0b94b46dfaa85274627dd5044 : SUCCESS in 4m 41s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/581f56b86cb749d7a81b2aa6f6972dcb : SUCCESS in 4m 08s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/6b79ab450ca44de4b8b204dc37817dc5 : SUCCESS in 5m 10s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/10ed879fdaa146ceab786f7fae95c057 : SUCCESS in 7m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f161dd114c93417cbef4739a9c3564e1 : SUCCESS in 5m 21s\n- ironicclient-functional https://zuul.opendev.org/t/openstack/build/3059a31bb1ed4267a7934ffa18c98fbe : SUCCESS in 26m 00s\n- ironicclient-functional-python2 https://zuul.opendev.org/t/openstack/build/b3ecbbf623b4438dad38cce676a7b1ca : SUCCESS in 23m 03s\n- ironicclient-tempest https://zuul.opendev.org/t/openstack/build/c15bb35563d8410c8cc62e2f6e5c2316 : SUCCESS in 45m 13s\n- ironicclient-tempest-python2 https://zuul.opendev.org/t/openstack/build/1004ad53b2424994869fb320d9856ac1 : SUCCESS in 44m 39s","accounts_in_message":[],"_revision_number":1},{"id":"6c5f2721b414c1ae7267e3de97bd4567aafb1d3f","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-12-05 11:02:01.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9ecc5097fbcf101a4531b3296ce4896243dc6d38","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2019-12-06 06:00:04.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"7018ed36dee6c18b94368453fdf2f82ee7f2dcf2","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2019-12-09 15:25:26.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7f699a1ec38877da1523fbbb1ec061667d6d9f40","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-09 15:25:49.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"845a8f5a932b2e2bd5ee5dc85aa1537e1b2a795e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-09 16:26:07.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2f8bd01b18454d2ea447bca9fb40aa4f : SUCCESS in 4m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1946b208bd354d01bbccfa71e73cbcf2 : SUCCESS in 2m 56s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/4c2e9e2c84fd407bb18f8a46abb21e12 : SUCCESS in 4m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bc6581751e4b4773a7f60f15330050bf : SUCCESS in 4m 24s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/380fa062d1e1448fbdc32419419e7e76 : SUCCESS in 3m 56s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b20e39c214e54c5ab83cdf2d92a10df5 : SUCCESS in 6m 05s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d8374bcd711e42a597beb9868bdeb589 : SUCCESS in 4m 11s\n- ironicclient-functional https://zuul.opendev.org/t/openstack/build/7506e8052a994adcaa21803b71a95a27 : SUCCESS in 24m 36s\n- ironicclient-functional-python2 https://zuul.opendev.org/t/openstack/build/1c339a6122754c8296e3db448c62172f : SUCCESS in 30m 52s\n- ironicclient-tempest https://zuul.opendev.org/t/openstack/build/6c62bfb9b4334c0b860bfc71283144f0 : SUCCESS in 54m 09s\n- ironicclient-tempest-python2 https://zuul.opendev.org/t/openstack/build/d6ca41d097124843a8007bfcb3223005 : SUCCESS in 54m 37s","accounts_in_message":[],"_revision_number":1},{"id":"b6dd9514206fb5378c7c5f9dcd8b3bd359ac1380","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-09 16:26:08.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"2bb5f54f380c9a2ec10cbe1751f12b8b4e3b07ef","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-09 16:29:05.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/819690e91f9e40f0ac6236f45b2afac6 : SUCCESS in 2m 17s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6b84e56c722c42d38dce32426e8e13e1 : SUCCESS in 51s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8188c01489f63b5fd10702ebccbd742b62488d6e","revisions":{"8188c01489f63b5fd10702ebccbd742b62488d6e":{"kind":"REWORK","_number":1,"created":"2019-12-04 11:25:39.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/69/697269/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/69/697269/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/69/697269/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/69/697269/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/69/697269/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/69/697269/1"}}},"commit":{"parents":[{"commit":"04ef2d7b04caad162e299c52542b2cb581552ea3","subject":"Fix usage of --owner filter during node list","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/04ef2d7b04caad162e299c52542b2cb581552ea3"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2019-08-12 15:19:37.000000000","tz":60},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2019-12-04 11:25:39.000000000","tz":0},"subject":"Fix AttributeError in negotiate_version","message":"Fix AttributeError in negotiate_version\n\nSeen in kolla-ansible CI, if ironic inspector starts up before ironic\nAPI is properly up, we see the following error:\n\nThe PXE filter DnsmasqFilter, state\u003dinitialized encountered an\nexception: StrictVersion instance has no attribute \u0027version\u0027; resetting\nthe filter: AttributeError: StrictVersion instance has no attribute\n\u0027version\u0027\n\nExample: http://paste.openstack.org/show/756342/\n\nThe usual cause of this error is when StrictVersion is initialised with\na version of None. This suggests to me that max_ver is None.\n\nThis leads to an exception being raised that circumvents the client\u0027s\nretry mechanisms.\n\nIn the particular case of kolla-ansible CI, Ironic API is behind a load\nbalancer, and all backends are down resulting in a 503. The lack of a\nretry caused ironic inspector to fail on startup.\n\nThis patch catches the case where we get a 4xx or 5xx return code when\nchecking the version, and raises an error that works with the client\u0027s\nretry mechanisms.\n\nChange-Id: Ib62ca3ee4626084e5e9b90e93e4fa97938023457\nStory: 2006393\nTask: 36266\n(cherry picked from commit 0e9bf337f1f6aa41f67df2966dacf9e8e897b7da)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/8188c01489f63b5fd10702ebccbd742b62488d6e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/8188c01489f63b5fd10702ebccbd742b62488d6e"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}