)]}'
{"id":"openstack%2Fpython-ironicclient~697270","triplet_id":"openstack%2Fpython-ironicclient~stable%2Fstein~Ib62ca3ee4626084e5e9b90e93e4fa97938023457","project":"openstack/python-ironicclient","branch":"stable/stein","topic":"story/2006393-stable/train-stable/stein","hashtags":[],"change_id":"Ib62ca3ee4626084e5e9b90e93e4fa97938023457","subject":"Fix AttributeError in negotiate_version","status":"MERGED","created":"2019-12-04 11:26:01.000000000","updated":"2019-12-09 16:28:45.000000000","submitted":"2019-12-09 16:26:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"697270-1575908771699-758459c9","meta_rev_id":"668d51f952a144d9b1223f671ff450762cc4e064","_number":697270,"virtual_id_number":697270,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-09 16:26:11.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-12-09 15:25:59.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":2,"date":"2019-12-05 11:01:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-12-09 15:25:59.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-05 11:01:18.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2019-12-09 15:25:59.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2019-12-09 16:26:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f52024ed65bd290af2c73a94ce07e56e31748371","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2019-12-04 11:26:01.000000000","message":"Patch Set 1: Cherry Picked from branch stable/train.","accounts_in_message":[],"_revision_number":1},{"id":"772ce75687244667b379e8293584a26041a3d009","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2019-12-04 11:26:10.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/rocky as commit 114962db580c93536ebef8547c6654aa9454a368","accounts_in_message":[],"_revision_number":1},{"id":"cf3b96861e81285f57fc1bc80c4e961edeae00af","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-04 12:30:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1ef141a4dc764201bcb0568a046f56bf : SUCCESS in 4m 04s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/814af630d2b4449e91e18c04abdf2c20 : SUCCESS in 4m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/071de86130f34ac7a0fb743d592d989d : SUCCESS in 4m 06s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/5a04ef7712c24f7596d156764ca33e15 : SUCCESS in 3m 55s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/46070ee7dd2e4378b962d9637af6409d : SUCCESS in 3m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5f142ab4adc1445f99763e170aa69f17 : SUCCESS in 4m 05s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/94748d5993a2477faa7113520a899f96 : SUCCESS in 4m 33s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/7beea394240949448d5a8d2761f90b1a : FAILURE in 8m 16s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ae48260be5ed4252b1b832e059cfc7f1 : SUCCESS in 5m 22s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/23d8cade720543b7849d3a4a38181a36 : SUCCESS in 5m 59s\n- ironicclient-functional https://zuul.opendev.org/t/openstack/build/3e951131ea504b6d9b5c7c8ad296784e : SUCCESS in 25m 30s\n- ironicclient-functional-python2 https://zuul.opendev.org/t/openstack/build/2148a220991742f19213520b3eac0aa4 : SUCCESS in 23m 58s\n- ironicclient-tempest https://zuul.opendev.org/t/openstack/build/ae24d080da964e22a71afd0bebac2b53 : SUCCESS in 51m 20s\n- ironicclient-tempest-python2 https://zuul.opendev.org/t/openstack/build/bccf18c0ae5d4e90811f4736fbdaa9b8 : SUCCESS in 54m 10s","accounts_in_message":[],"_revision_number":1},{"id":"f2827ee39c739ef8272ee1481ad127a92c20a20f","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-12-05 11:01:18.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f6f73cafd43c23a2db486e5b29efa6793ae0bb7b","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2019-12-09 15:25:59.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"97174a06180c2146b84a49a8986e673c81d5b48e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-09 15:26:15.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"dd327927ff4047f26aa45c7ba7b30b990247f62b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-09 16:26:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"1a44942edefcc048d10d15f586c81ce4f1a322e8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-09 16:26:11.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fa1537a52a8d4835902c131ee00c2b13 : SUCCESS in 6m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/696f3d9226c8466d9fff45bbe59daa2b : SUCCESS in 4m 19s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/c01c5f52e557499aa7231540b08f0eaf : SUCCESS in 4m 45s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/619aaef72bef49f9943b7a7723b12d7c : SUCCESS in 5m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e446508d4940493192c7d23c980faf05 : SUCCESS in 4m 26s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2820145572384b60b17a82c2ae9d8e17 : SUCCESS in 6m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/34241511c4b749bba8c4cc66748b01c3 : SUCCESS in 4m 50s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5e1c726e81094d2f8680ec38bc1219d2 : SUCCESS in 4m 21s\n- ironicclient-functional https://zuul.opendev.org/t/openstack/build/de288499c5c644e0b6684087332c7065 : SUCCESS in 26m 21s\n- ironicclient-functional-python2 https://zuul.opendev.org/t/openstack/build/0c74b0099ca24a31a7b56fa59728bcf1 : SUCCESS in 23m 03s\n- ironicclient-tempest https://zuul.opendev.org/t/openstack/build/fda9370d2fb348c1a0d264dde580c476 : SUCCESS in 50m 40s\n- ironicclient-tempest-python2 https://zuul.opendev.org/t/openstack/build/1732022d0d2349268da52411a955fd16 : SUCCESS in 56m 13s","accounts_in_message":[],"_revision_number":1},{"id":"797e8b5586b6dbb677566919498ca01fd1e30759","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-09 16:28:45.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d07241ed7d6d4eed90984d15246e93b5 : SUCCESS in 2m 10s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/afd70d687bac47f18c18dea25a148cb6 : SUCCESS in 1m 28s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0bd26cc47ed51d19e07280db9e770ad09edd2bf8","revisions":{"0bd26cc47ed51d19e07280db9e770ad09edd2bf8":{"kind":"REWORK","_number":1,"created":"2019-12-04 11:26:01.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/70/697270/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/70/697270/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/70/697270/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/70/697270/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/70/697270/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/70/697270/1"}}},"commit":{"parents":[{"commit":"42faaabdeeaa45c8916f601ece2ca60f37443a3d","subject":"fix session cert arguments","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/42faaabdeeaa45c8916f601ece2ca60f37443a3d"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2019-08-12 15:19:37.000000000","tz":60},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2019-12-04 11:26:01.000000000","tz":0},"subject":"Fix AttributeError in negotiate_version","message":"Fix AttributeError in negotiate_version\n\nSeen in kolla-ansible CI, if ironic inspector starts up before ironic\nAPI is properly up, we see the following error:\n\nThe PXE filter DnsmasqFilter, state\u003dinitialized encountered an\nexception: StrictVersion instance has no attribute \u0027version\u0027; resetting\nthe filter: AttributeError: StrictVersion instance has no attribute\n\u0027version\u0027\n\nExample: http://paste.openstack.org/show/756342/\n\nThe usual cause of this error is when StrictVersion is initialised with\na version of None. This suggests to me that max_ver is None.\n\nThis leads to an exception being raised that circumvents the client\u0027s\nretry mechanisms.\n\nIn the particular case of kolla-ansible CI, Ironic API is behind a load\nbalancer, and all backends are down resulting in a 503. The lack of a\nretry caused ironic inspector to fail on startup.\n\nThis patch catches the case where we get a 4xx or 5xx return code when\nchecking the version, and raises an error that works with the client\u0027s\nretry mechanisms.\n\nChange-Id: Ib62ca3ee4626084e5e9b90e93e4fa97938023457\nStory: 2006393\nTask: 36266\n(cherry picked from commit 0e9bf337f1f6aa41f67df2966dacf9e8e897b7da)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/0bd26cc47ed51d19e07280db9e770ad09edd2bf8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/0bd26cc47ed51d19e07280db9e770ad09edd2bf8"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}