)]}'
{"ironicclient/osc/v1/baremetal_node.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2facd1a0ebfd0a787e47d86d1fc44d45c1b27da2","unresolved":false,"context_lines":[{"line_number":592,"context_line":"            help\u003d_(\"Limit list to nodes not in maintenance mode\"),"},{"line_number":593,"context_line":"        )"},{"line_number":594,"context_line":"        parser.add_argument("},{"line_number":595,"context_line":"            \u0027--retired\u0027,"},{"line_number":596,"context_line":"            dest\u003d\u0027retired\u0027,"},{"line_number":597,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":598,"context_line":"            default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_516b9c52","line":595,"updated":"2020-01-27 14:08:37.000000000","message":"could it be useful to have a no-retired option as for no-maintenance ?","commit_id":"477e05ff1767472a87024feb4e2cff97c38c31bb"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"49bff6c118fd9e1a9c5695035ddde3651fea7f62","unresolved":false,"context_lines":[{"line_number":592,"context_line":"            help\u003d_(\"Limit list to nodes not in maintenance mode\"),"},{"line_number":593,"context_line":"        )"},{"line_number":594,"context_line":"        parser.add_argument("},{"line_number":595,"context_line":"            \u0027--retired\u0027,"},{"line_number":596,"context_line":"            dest\u003d\u0027retired\u0027,"},{"line_number":597,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":598,"context_line":"            default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1a28d082","line":595,"in_reply_to":"3fa7e38b_516b9c52","updated":"2020-01-28 09:17:13.000000000","message":"Certainly easy to do, but I wasn\u0027t sure if this adds a lot of value for daily operations.","commit_id":"477e05ff1767472a87024feb4e2cff97c38c31bb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6651f5752be839df7b4648c11044dd1c15c8e9fc","unresolved":false,"context_lines":[{"line_number":596,"context_line":"            dest\u003d\u0027retired\u0027,"},{"line_number":597,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":598,"context_line":"            default\u003dNone,"},{"line_number":599,"context_line":"            help\u003d_(\"Limit list to retired nodes.\"))"},{"line_number":600,"context_line":"        parser.add_argument("},{"line_number":601,"context_line":"            \u0027--fault\u0027,"},{"line_number":602,"context_line":"            dest\u003d\u0027fault\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_7ca3449d","line":599,"updated":"2020-02-10 15:16:08.000000000","message":"I haven\u0027t read the spec yet :-(. Just wondering, if anyone discussed whether to add an eg \u0027--non-retired\u0027 argument, similar to the --no-maintenance, to \u0027limit list to non-retired nodes. [Not sure if \u0027non-retired\u0027 is the correct term.]","commit_id":"81eebfc404396345055b50c124962c4069048481"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8251866dfb84b196ca84bf5f0513c642625a2311","unresolved":false,"context_lines":[{"line_number":596,"context_line":"            dest\u003d\u0027retired\u0027,"},{"line_number":597,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":598,"context_line":"            default\u003dNone,"},{"line_number":599,"context_line":"            help\u003d_(\"Limit list to retired nodes.\"))"},{"line_number":600,"context_line":"        parser.add_argument("},{"line_number":601,"context_line":"            \u0027--fault\u0027,"},{"line_number":602,"context_line":"            dest\u003d\u0027fault\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_898ef223","line":599,"in_reply_to":"3fa7e38b_7c2584bf","updated":"2020-02-11 10:45:36.000000000","message":"it was briefly discussed btw, see my comment in patch set 2 and Arne reply","commit_id":"81eebfc404396345055b50c124962c4069048481"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ef06148ee0d6828ae533b56546b0445e7b750951","unresolved":false,"context_lines":[{"line_number":596,"context_line":"            dest\u003d\u0027retired\u0027,"},{"line_number":597,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":598,"context_line":"            default\u003dNone,"},{"line_number":599,"context_line":"            help\u003d_(\"Limit list to retired nodes.\"))"},{"line_number":600,"context_line":"        parser.add_argument("},{"line_number":601,"context_line":"            \u0027--fault\u0027,"},{"line_number":602,"context_line":"            dest\u003d\u0027fault\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_7c2584bf","line":599,"in_reply_to":"3fa7e38b_7ca3449d","updated":"2020-02-10 15:25:22.000000000","message":"Good idea, can be an easy follow-up.","commit_id":"81eebfc404396345055b50c124962c4069048481"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6651f5752be839df7b4648c11044dd1c15c8e9fc","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"            \u0027--retired-reason\u0027,"},{"line_number":1176,"context_line":"            metavar\u003d\u0027\u003cretired_reason\u003e\u0027,"},{"line_number":1177,"context_line":"            help\u003d_(\u0027Set the reason of marking the node as retired\u0027),"},{"line_number":1178,"context_line":"        )"},{"line_number":1179,"context_line":"        parser.add_argument("},{"line_number":1180,"context_line":"            \u0027--target-raid-config\u0027,"},{"line_number":1181,"context_line":"            metavar\u003d\u0027\u003ctarget_raid_config\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_5c2be8e8","line":1178,"updated":"2020-02-10 15:16:08.000000000","message":"For maintenance, we added them as (first) class citizens, MaintenanceSetBaremetalNode \u0026 MaintenanceUnsetBaremetalNode. Wondering if that makes more sense for retired as well.","commit_id":"81eebfc404396345055b50c124962c4069048481"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ef06148ee0d6828ae533b56546b0445e7b750951","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"            \u0027--retired-reason\u0027,"},{"line_number":1176,"context_line":"            metavar\u003d\u0027\u003cretired_reason\u003e\u0027,"},{"line_number":1177,"context_line":"            help\u003d_(\u0027Set the reason of marking the node as retired\u0027),"},{"line_number":1178,"context_line":"        )"},{"line_number":1179,"context_line":"        parser.add_argument("},{"line_number":1180,"context_line":"            \u0027--target-raid-config\u0027,"},{"line_number":1181,"context_line":"            metavar\u003d\u0027\u003ctarget_raid_config\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_bc08dc2d","line":1178,"in_reply_to":"3fa7e38b_5c2be8e8","updated":"2020-02-10 15:25:22.000000000","message":"I may be a minority, but I think what we\u0027ve done with maintenance is a huge mistake. To me, we should have taked the same restful approach of modifying the fields as we\u0027ve done later with protected and retired. I don\u0027t remember our reasoning back in the time....","commit_id":"81eebfc404396345055b50c124962c4069048481"}],"ironicclient/v1/node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f9972bcd18c9bfbabccc84ca88702827a88ebf52","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                            \u0027automated_clean\u0027]"},{"line_number":57,"context_line":"    _resource_name \u003d \u0027nodes\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def list(self, associated\u003dNone, maintenance\u003dNone, retired\u003dNone,"},{"line_number":60,"context_line":"             marker\u003dNone, limit\u003dNone, detail\u003dFalse, sort_key\u003dNone,"},{"line_number":61,"context_line":"             sort_dir\u003dNone, fields\u003dNone, provision_state\u003dNone,"},{"line_number":62,"context_line":"             driver\u003dNone, resource_class\u003dNone, chassis\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a4a570a2","line":59,"updated":"2020-02-05 07:59:08.000000000","message":"The new parameter has to go last in case somebody is insane enough to use this call with positional arguments.","commit_id":"53d5f4a86ed2cba7d1e9b4cb54b87534baab81c4"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"14a2dadfb9c5c1175dfbc2c9bff07378780b352f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                            \u0027automated_clean\u0027]"},{"line_number":57,"context_line":"    _resource_name \u003d \u0027nodes\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def list(self, associated\u003dNone, maintenance\u003dNone, retired\u003dNone,"},{"line_number":60,"context_line":"             marker\u003dNone, limit\u003dNone, detail\u003dFalse, sort_key\u003dNone,"},{"line_number":61,"context_line":"             sort_dir\u003dNone, fields\u003dNone, provision_state\u003dNone,"},{"line_number":62,"context_line":"             driver\u003dNone, resource_class\u003dNone, chassis\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_81db6978","line":59,"in_reply_to":"3fa7e38b_a4a570a2","updated":"2020-02-06 15:10:53.000000000","message":"Done","commit_id":"53d5f4a86ed2cba7d1e9b4cb54b87534baab81c4"}]}