)]}'
{"id":"openstack%2Fpython-ironicclient~706819","triplet_id":"openstack%2Fpython-ironicclient~stable%2Ftrain~I96073dc80d225a9b88fdc12bb058c0145aca623b","project":"openstack/python-ironicclient","branch":"stable/train","topic":"session-stable/train","hashtags":[],"change_id":"I96073dc80d225a9b88fdc12bb058c0145aca623b","subject":"Provide a clear error message when using client.Client without a session","status":"MERGED","created":"2020-02-10 12:58:54.000000000","updated":"2020-02-10 15:00:14.000000000","submitted":"2020-02-10 14:57:13.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"706819-1581346633204-e685ee51","meta_rev_id":"55b69acfb9c4af8c7c265d103a24c6f779c2a18b","_number":706819,"virtual_id_number":706819,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-02-10 14:57:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":2,"date":"2020-02-10 13:51:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":1,"date":"2020-02-10 13:51:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-10 13:51:18.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-02-10 14:57:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9c18c861bd74be0b3a01d7600262fe7e3bc3ee8e","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-02-10 12:58:54.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"f10478341bd2999f655ed77f476b34bdaf339d11","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-02-10 13:51:18.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"c841a20f735e8170b0d193476b8b5136077b6592","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-10 13:59:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/026cc9132f1a44efa84ed9ada2d6ba5b : SUCCESS in 4m 28s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9306a3d902c14cd58b962671f04c052b : SUCCESS in 6m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/34ab1db72723445b93d068f724b71625 : SUCCESS in 4m 58s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/1b4522af333a42b68b5aa26eae97cb1a : SUCCESS in 4m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/76cdcbeee0df4477b5d83ce238d057a3 : SUCCESS in 5m 18s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/b37979e54b6b4b269f8d23dae79eb4ef : SUCCESS in 4m 56s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8f6c2d04692d46b7a942180daf9ea20c : SUCCESS in 5m 39s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1ddcb37c8e094ce381728d1c4cfcf480 : SUCCESS in 5m 00s\n- ironicclient-functional https://zuul.opendev.org/t/openstack/build/386235ac1b11474da196678cda52a039 : SUCCESS in 20m 07s\n- ironicclient-functional-python2 https://zuul.opendev.org/t/openstack/build/a5b99b3078ae497385af22147bbe66d9 : SUCCESS in 19m 50s\n- ironicclient-tempest https://zuul.opendev.org/t/openstack/build/b01808483af0468f85609170673a56e7 : SUCCESS in 46m 53s\n- ironicclient-tempest-python2 https://zuul.opendev.org/t/openstack/build/e877d69d88cb43018259b08578407885 : SUCCESS in 54m 21s","accounts_in_message":[],"_revision_number":1},{"id":"c96c3c820bc26a2263ce155c87e4d553b6eba60c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-10 14:00:05.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"2250f6861fbea8fa24d68fab6323d861a55a90f1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-10 14:57:13.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e4c41507d35e481589595b678bf0bf44 : SUCCESS in 5m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/be328b3b7f6443eea120d2283303fd9c : SUCCESS in 5m 27s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0db0706ff7ea4a0f8b772f06e50c9607 : SUCCESS in 4m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/78f57b65427547d7b820bf186660593a : SUCCESS in 7m 17s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/7c2b35a6f50d43af9311864dac826441 : SUCCESS in 5m 45s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f75cdcf28bfb496597475db0cb26f6ac : SUCCESS in 7m 35s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5552f813608d44b6b012c07f98c4ced4 : SUCCESS in 4m 26s\n- ironicclient-functional https://zuul.opendev.org/t/openstack/build/f3f441483c1346929f0bf82b9689aec8 : SUCCESS in 25m 37s\n- ironicclient-functional-python2 https://zuul.opendev.org/t/openstack/build/e6c0947bce784e04bb7d91bbb06bfd1e : SUCCESS in 21m 48s\n- ironicclient-tempest https://zuul.opendev.org/t/openstack/build/bd2244f83ba741e8a0570dff7b029d79 : SUCCESS in 51m 15s\n- ironicclient-tempest-python2 https://zuul.opendev.org/t/openstack/build/225be06c1d7c4382ada6d60dc70cc5b1 : SUCCESS in 50m 41s","accounts_in_message":[],"_revision_number":1},{"id":"3daf22580f3e8b1d6d509b2408e8cb52b5090fc9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-10 14:57:13.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"3646b7d4ba8b1961a691ae4f153d93b81f33edf9","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-10 15:00:14.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ce8a2da92b8a40de871894fbe2b01851 : SUCCESS in 2m 19s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cf66646853704710b257a1ca05c3674b : SUCCESS in 2m 14s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1220d7685723b8235135d2d02c11008c7f7fb18a","revisions":{"1220d7685723b8235135d2d02c11008c7f7fb18a":{"kind":"REWORK","_number":1,"created":"2020-02-10 12:58:54.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/19/706819/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/19/706819/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/19/706819/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/19/706819/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/19/706819/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/19/706819/1"}}},"commit":{"parents":[{"commit":"8188c01489f63b5fd10702ebccbd742b62488d6e","subject":"Fix AttributeError in negotiate_version","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/8188c01489f63b5fd10702ebccbd742b62488d6e"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-02-10 10:02:09.000000000","tz":60},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-02-10 12:58:54.000000000","tz":0},"subject":"Provide a clear error message when using client.Client without a session","message":"Provide a clear error message when using client.Client without a session\n\nCurrently we fail with _construct_http_client() takes at least 1 argument.\nThis change provides a proper TypeError and updates documentation to make\nit clear where a session is required. Also provided are explicit unit\ntests on passing a session via various means.\n\nChange-Id: I96073dc80d225a9b88fdc12bb058c0145aca623b\n(cherry picked from commit e8914a7ef9eb582441a7067f2663e19209f32822)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/1220d7685723b8235135d2d02c11008c7f7fb18a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/1220d7685723b8235135d2d02c11008c7f7fb18a"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}