)]}'
{"id":"openstack%2Fpython-ironicclient~73166","triplet_id":"openstack%2Fpython-ironicclient~master~Iff0d2e4725355800f923a04a1bfcac3003a6abd2","project":"openstack/python-ironicclient","branch":"master","topic":"master","hashtags":[],"change_id":"Iff0d2e4725355800f923a04a1bfcac3003a6abd2","subject":"Remove vim header","status":"MERGED","created":"2014-02-13 06:40:42.000000000","updated":"2014-02-13 17:58:11.000000000","submitted":"2014-02-13 17:58:11.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f7996affb821c85d365d6182db1ea37072dba240","_number":73166,"virtual_id_number":73166,"owner":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-02-13 17:58:11.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},{"value":0,"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":0,"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-02-13 17:51:05.000000000","_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},{"value":2,"date":"2014-02-13 17:50:02.000000000","_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},{"value":2,"date":"2014-02-13 17:50:57.000000000","_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":2,"date":"2014-02-13 17:48:45.000000000","_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":2,"date":"2014-02-13 17:48:25.000000000","_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-02-13 17:51:05.000000000","_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"date":"2014-02-13 07:08:10.000000000","_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},{"value":0,"date":"2014-02-13 17:44:38.000000000","_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},{"value":1,"date":"2014-02-13 17:51:05.000000000","_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"date":"2014-02-13 17:48:45.000000000","_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":0,"date":"2014-02-13 17:48:25.000000000","_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},{"value":0,"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":0,"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-02-13 17:44:38.000000000","updated_by":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"reviewer":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"state":"REVIEWER"},{"updated":"2014-02-13 17:48:25.000000000","updated_by":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"reviewer":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"state":"REVIEWER"},{"updated":"2014-02-13 17:48:45.000000000","updated_by":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"reviewer":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"state":"REVIEWER"},{"updated":"2014-02-13 17:51:05.000000000","updated_by":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"reviewer":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"state":"REVIEWER"},{"updated":"2014-02-13 17:51:05.000000000","updated_by":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"reviewer":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"state":"REVIEWER"},{"updated":"2014-02-13 17:58:11.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5e1545679caf2252d7e08230ae1b6ad021363758","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-13 06:40:43.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"7caa8c647b3139dd7733232ca4fb3d2fd83bceef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-13 07:08:10.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"8fb7cab207b44e868c18144a0f7ab27f552cf17e","author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"date":"2014-02-13 07:08:10.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"170b6b2b0c8a3ad3a49f8fbbdc23b6b4d7d285a4","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2014-02-13 07:08:16.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"e09ee28caee04d2822c9bdf97633234a18b9c43f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-13 07:22:07.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-ironicclient-pep8 http://logs.openstack.org/66/73166/2/check/gate-python-ironicclient-pep8/f42b484 : SUCCESS in 1m 26s\n- gate-python-ironicclient-python26 http://logs.openstack.org/66/73166/2/check/gate-python-ironicclient-python26/d79491c : SUCCESS in 2m 41s\n- gate-python-ironicclient-python27 http://logs.openstack.org/66/73166/2/check/gate-python-ironicclient-python27/eac9bcc : SUCCESS in 2m 24s\n- gate-python-ironicclient-python33 http://logs.openstack.org/66/73166/2/check/gate-python-ironicclient-python33/209d51f : SUCCESS in 5m 36s\n- gate-python-ironicclient-pypy http://logs.openstack.org/66/73166/2/check/gate-python-ironicclient-pypy/f4bbdea : SUCCESS in 1m 43s\n","accounts_in_message":[],"_revision_number":2},{"id":"5e33f262457fc82ab265035f193d8539702de665","author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"date":"2014-02-13 17:48:25.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nLGTM, thanks!","accounts_in_message":[],"_revision_number":2},{"id":"a6167e1d157f124b6eac94ef1ae4578f806fc19d","author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"date":"2014-02-13 17:48:45.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nI\u0027m good with this patch as is, but we should go back and remove the shebang (!#.../python lines).","accounts_in_message":[],"_revision_number":2},{"id":"8c40063aaf217f7f8723d56fce391f738932fb4e","author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"date":"2014-02-13 17:50:02.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"80f79c55dab5d8b4c8eae6b34d41a18823d34723","author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"date":"2014-02-13 17:50:57.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"57aef9a3557a3a166ec50e15157a79f73a57093c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-13 17:51:05.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"0f4ef8b8574f09cca6b280496f8e8b6779a0fd7e","author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"date":"2014-02-13 17:51:05.000000000","message":"Patch Set 2: Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"56db38a665951703da524a7833e4d80ed0c1495a","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2014-02-13 17:51:05.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nlgtm\n\n@agree with NobodyCam we should remove the shebang lines, but it\u0027s another problem than this patch is aiming to fix.\n\nThank you","accounts_in_message":[],"_revision_number":2},{"id":"a872f2998e6033b1499dc2bf0c896b4ee24d0663","author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"date":"2014-02-13 17:55:16.000000000","message":"Patch Set 2:\n\nLGTM Yongli","accounts_in_message":[],"_revision_number":2},{"id":"938325cbb5dfaa6dfef8a751ca6cdd40f2feaa02","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-13 17:58:11.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"d36bc19c87083fceb187f0bcef4469ec559a08d0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-13 17:58:11.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-python-ironicclient-pep8 http://logs.openstack.org/66/73166/2/gate/gate-python-ironicclient-pep8/8a954f5 : SUCCESS in 33s\n- gate-python-ironicclient-python26 http://logs.openstack.org/66/73166/2/gate/gate-python-ironicclient-python26/f80482d : SUCCESS in 1m 57s\n- gate-python-ironicclient-python27 http://logs.openstack.org/66/73166/2/gate/gate-python-ironicclient-python27/a680a21 : SUCCESS in 2m 11s\n- gate-python-ironicclient-python33 http://logs.openstack.org/66/73166/2/gate/gate-python-ironicclient-python33/c655eca : SUCCESS in 5m 39s\n- gate-python-ironicclient-pypy http://logs.openstack.org/66/73166/2/gate/gate-python-ironicclient-pypy/327b35c : SUCCESS in 1m 44s\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3622dfa2fb4c66fd8cbb76bc8a730195f4c32305","revisions":{"a8f8257774868a3b069363b1b057041c7b4ad93d":{"kind":"REWORK","_number":1,"created":"2014-02-13 06:40:42.000000000","uploader":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"ref":"refs/changes/66/73166/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/66/73166/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/66/73166/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/66/73166/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/66/73166/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/66/73166/1"}}},"commit":{"parents":[{"commit":"3fcbdf571a739bb86047c9282a59bf2191abab2a","subject":"Fix node-create help requiring chassis uuid","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/3fcbdf571a739bb86047c9282a59bf2191abab2a"}]}],"author":{"name":"He Yongli","email":"yongli.he@intel.com","date":"2014-02-13 06:42:16.000000000","tz":480},"committer":{"name":"He Yongli","email":"yongli.he@intel.com","date":"2014-02-13 06:44:14.000000000","tz":480},"subject":"Remove vim header","message":"Remove vim header\n\nNo need to set tabstop tons of times, this can be set in your vimrc\nfile instead.\n\nMore disucssion:\nhttp://openstack.10931.n7.nabble.com/Remove-vim-modelines-td21780.html\n\nChange-Id: Iff0d2e4725355800f923a04a1bfcac3003a6abd2\nClose-Bug: #1229324\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/a8f8257774868a3b069363b1b057041c7b4ad93d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/a8f8257774868a3b069363b1b057041c7b4ad93d"}]},"branch":"refs/heads/master"},"3622dfa2fb4c66fd8cbb76bc8a730195f4c32305":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2014-02-13 07:08:10.000000000","uploader":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"ref":"refs/changes/66/73166/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/66/73166/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/66/73166/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/66/73166/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/66/73166/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/66/73166/2"}}},"commit":{"parents":[{"commit":"a7f2ee901ea6366f9b4bf4a51250e4e53945ca96","subject":"Merge \"Add node.states() to the client library\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/a7f2ee901ea6366f9b4bf4a51250e4e53945ca96"}]}],"author":{"name":"He Yongli","email":"yongli.he@intel.com","date":"2014-02-13 06:42:16.000000000","tz":480},"committer":{"name":"He Yongli","email":"yongli.he@intel.com","date":"2014-02-13 07:11:42.000000000","tz":480},"subject":"Remove vim header","message":"Remove vim header\n\nNo need to set tabstop tons of times, this can be set in your vimrc\nfile instead.\n\nMore disucssion:\nhttp://openstack.10931.n7.nabble.com/Remove-vim-modelines-td21780.html\n\nChange-Id: Iff0d2e4725355800f923a04a1bfcac3003a6abd2\nClose-bug: #1229324\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/3622dfa2fb4c66fd8cbb76bc8a730195f4c32305"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/3622dfa2fb4c66fd8cbb76bc8a730195f4c32305"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
