)]}'
{"ironicclient/tests/v1/test_node.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d7bfbc21fd40b1cbede628bef2f367aa4aee3ebe","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    {"},{"line_number":123,"context_line":"        \u0027GET\u0027: ("},{"line_number":124,"context_line":"            {},"},{"line_number":125,"context_line":"            {\"nodes\": [NODE3]},"},{"line_number":126,"context_line":"        )"},{"line_number":127,"context_line":"    },"},{"line_number":128,"context_line":"    \u0027/v1/nodes/?instance_uuid\u003d%s\u0027 % NODE2[\u0027instance_uuid\u0027]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BTio%3D","line":125,"updated":"2014-02-22 01:12:11.000000000","message":"In your sample data set, both NODE2 and NODE3 are both associated and in maintenance.\n\nThis does not match your sample response.","commit_id":"478780e8521af770229f144de863a59b38fe70e0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7dd8d27f66a42ec3d7d9494dcfe4fd95b01dad56","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    {"},{"line_number":123,"context_line":"        \u0027GET\u0027: ("},{"line_number":124,"context_line":"            {},"},{"line_number":125,"context_line":"            {\"nodes\": [NODE3]},"},{"line_number":126,"context_line":"        )"},{"line_number":127,"context_line":"    },"},{"line_number":128,"context_line":"    \u0027/v1/nodes/?instance_uuid\u003d%s\u0027 % NODE2[\u0027instance_uuid\u0027]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2F2V0%3D","line":125,"in_reply_to":"AAAAUX%2F%2BTio%3D","updated":"2014-02-24 14:17:21.000000000","message":"a-ha, indeed, I will just use NODE2 then, no need to create NODE3 at all :) thanks for pointing it out","commit_id":"478780e8521af770229f144de863a59b38fe70e0"}],"ironicclient/v1/node.py":[{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"ac1ce029671fa770b4f5b7a80a33dde397108903","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        if maintenance is not None:"},{"line_number":41,"context_line":"            filters.append(\u0027maintenance\u003d%s\u0027 % maintenance)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        path \u003d \u0027?\u0027 + \u0027\u0026\u0027.join(filters) if filters else None"},{"line_number":44,"context_line":"        return self._list(self._path(path), \"nodes\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def list_ports(self, node_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2BYEg%3D","line":43,"updated":"2014-02-21 14:57:23.000000000","message":"Honestly I liked the previous version with full \"if-else\" and two returns. I\u0027d appreciate if you rollback to that code.\n\nHowever, if you still want to leave this one, please add parentheses because it\u0027s not clear to the reader what operation has higher priority:\n\n(\u0027?\u0027 + \u0027\u0026\u0027.join(filters)) if filters else None","commit_id":"72fe4ecde40a213c80c62e1697eab6233b122854"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"da1b2ccab5591c9593a37a234fba2960975695b1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        if maintenance is not None:"},{"line_number":41,"context_line":"            filters.append(\u0027maintenance\u003d%s\u0027 % maintenance)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        path \u003d \u0027?\u0027 + \u0027\u0026\u0027.join(filters) if filters else None"},{"line_number":44,"context_line":"        return self._list(self._path(path), \"nodes\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def list_ports(self, node_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2BX%2F4%3D","line":43,"in_reply_to":"AAAAUX%2F%2BYEg%3D","updated":"2014-02-21 15:05:24.000000000","message":"Makes sense. I tried to take off some lines of the code but yeah I think it\u0027s obscure now. I will rollback it.\n\nThanks","commit_id":"72fe4ecde40a213c80c62e1697eab6233b122854"}],"ironicclient/v1/node_shell.py":[{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"7c5f5dbe03be9c9a2250478a6b47feb019dbe54c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    if not params:"},{"line_number":64,"context_line":"        nodes \u003d cc.node.list()"},{"line_number":65,"context_line":"    else:"},{"line_number":66,"context_line":"        nodes \u003d cc.node.list(**params)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    field_labels \u003d [\u0027UUID\u0027, \u0027Instance UUID\u0027,"},{"line_number":69,"context_line":"                    \u0027Power State\u0027, \u0027Provisioning State\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2Beu4%3D","line":66,"updated":"2014-02-20 23:42:39.000000000","message":"I believe in python we can unbox an empty dict as well, so this can be changed just to \n\nnodes \u003d cc.node.list(**params)","commit_id":"f00c4d363ed86c33888e81d139438ec286887fa3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0ddfa2d87115b444a01024d2fb5b2ec37997f234","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    if not params:"},{"line_number":64,"context_line":"        nodes \u003d cc.node.list()"},{"line_number":65,"context_line":"    else:"},{"line_number":66,"context_line":"        nodes \u003d cc.node.list(**params)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    field_labels \u003d [\u0027UUID\u0027, \u0027Instance UUID\u0027,"},{"line_number":69,"context_line":"                    \u0027Power State\u0027, \u0027Provisioning State\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2BYc8%3D","line":66,"in_reply_to":"AAAAUX%2F%2Beu4%3D","updated":"2014-02-21 14:14:23.000000000","message":"Ah, indeed! Good catch. Thanks max","commit_id":"f00c4d363ed86c33888e81d139438ec286887fa3"}]}