)]}'
{"ironicclient/common/http.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"efca0221381ca41086a71aa86dcd1442e2448ca3","unresolved":true,"context_lines":[{"line_number":37,"context_line":"#             http://specs.openstack.org/openstack/ironic-specs/specs/kilo/api-microversions.html # noqa"},{"line_number":38,"context_line":"#             for full details."},{"line_number":39,"context_line":"DEFAULT_VER \u003d \u00271.9\u0027"},{"line_number":40,"context_line":"LAST_KNOWN_API_VERSION \u003d 69"},{"line_number":41,"context_line":"LATEST_VERSION \u003d \u00271.{}\u0027.format(LAST_KNOWN_API_VERSION)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e8b7b682_9c0bec30","line":40,"updated":"2021-01-14 18:12:28.000000000","message":"Sorry if this is a dumb question, but where did 69 come from? I thought the number was from https://opendev.org/openstack/ironic/src/branch/master/ironic/api/controllers/v1/versions.py#L178, which is 68.","commit_id":"8df29e00a28b5b619f31355dca8be08ab975333a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a87000283087e7ff852d2da99bdc5dc5799c8b51","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#             http://specs.openstack.org/openstack/ironic-specs/specs/kilo/api-microversions.html # noqa"},{"line_number":38,"context_line":"#             for full details."},{"line_number":39,"context_line":"DEFAULT_VER \u003d \u00271.9\u0027"},{"line_number":40,"context_line":"LAST_KNOWN_API_VERSION \u003d 69"},{"line_number":41,"context_line":"LATEST_VERSION \u003d \u00271.{}\u0027.format(LAST_KNOWN_API_VERSION)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":4,"id":"29dd501b_442cc91a","line":40,"in_reply_to":"5f0b6f87_62c1cc01","updated":"2021-01-25 15:28:08.000000000","message":"Ugh, brain fart. Thx for clarifying! :)","commit_id":"8df29e00a28b5b619f31355dca8be08ab975333a"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"441e7bdbf94acf9eb9b69db6c3ac33658b00860d","unresolved":true,"context_lines":[{"line_number":37,"context_line":"#             http://specs.openstack.org/openstack/ironic-specs/specs/kilo/api-microversions.html # noqa"},{"line_number":38,"context_line":"#             for full details."},{"line_number":39,"context_line":"DEFAULT_VER \u003d \u00271.9\u0027"},{"line_number":40,"context_line":"LAST_KNOWN_API_VERSION \u003d 69"},{"line_number":41,"context_line":"LATEST_VERSION \u003d \u00271.{}\u0027.format(LAST_KNOWN_API_VERSION)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f0b6f87_62c1cc01","line":40,"in_reply_to":"e8b7b682_9c0bec30","updated":"2021-01-14 18:40:41.000000000","message":"it is and in parent/Depends-On patch 69 is added, see https://review.opendev.org/c/openstack/ironic/+/768353/4/ironic/api/controllers/v1/versions.py#180","commit_id":"8df29e00a28b5b619f31355dca8be08ab975333a"}],"ironicclient/tests/unit/v1/test_node.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"22d26b2745e30d31f8cbba6c810f8a3ba3505c72","unresolved":true,"context_lines":[{"line_number":1564,"context_line":"        ]"},{"line_number":1565,"context_line":"        self.assertEqual(expect, self.api.calls)"},{"line_number":1566,"context_line":""},{"line_number":1567,"context_line":"    def test_node_set_provision_state_with_deploysteps(self):"},{"line_number":1568,"context_line":"        deploysteps \u003d [{\"step\": \"upgrade\", \"interface\": \"deploy\"}]"},{"line_number":1569,"context_line":"        target_state \u003d \u0027active\u0027"},{"line_number":1570,"context_line":"        self.mgr.set_provision_state(NODE1[\u0027uuid\u0027], target_state,"}],"source_content_type":"text/x-python","patch_set":1,"id":"cf7d372f_a5333cbf","line":1567,"updated":"2021-01-06 09:17:18.000000000","message":"Can you add a test with both deploy steps and configdrive?","commit_id":"95bf12f10e5c7a469b021461bcecc0a6d032a804"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d3a4953f9e9f312254489336004c7ca1f50ab7a5","unresolved":false,"context_lines":[{"line_number":1564,"context_line":"        ]"},{"line_number":1565,"context_line":"        self.assertEqual(expect, self.api.calls)"},{"line_number":1566,"context_line":""},{"line_number":1567,"context_line":"    def test_node_set_provision_state_with_deploysteps(self):"},{"line_number":1568,"context_line":"        deploysteps \u003d [{\"step\": \"upgrade\", \"interface\": \"deploy\"}]"},{"line_number":1569,"context_line":"        target_state \u003d \u0027active\u0027"},{"line_number":1570,"context_line":"        self.mgr.set_provision_state(NODE1[\u0027uuid\u0027], target_state,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b8c28af9_d5c7cbe5","line":1567,"in_reply_to":"cf7d372f_a5333cbf","updated":"2021-01-07 12:35:38.000000000","message":"Done","commit_id":"95bf12f10e5c7a469b021461bcecc0a6d032a804"}],"ironicclient/v1/node.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"22d26b2745e30d31f8cbba6c810f8a3ba3505c72","unresolved":true,"context_lines":[{"line_number":673,"context_line":"            body[\u0027configdrive\u0027] \u003d configdrive"},{"line_number":674,"context_line":"        elif cleansteps:"},{"line_number":675,"context_line":"            body[\u0027clean_steps\u0027] \u003d cleansteps"},{"line_number":676,"context_line":"        elif deploysteps:"},{"line_number":677,"context_line":"            body[\u0027deploy_steps\u0027] \u003d deploysteps"},{"line_number":678,"context_line":"        elif rescue_password:"},{"line_number":679,"context_line":"            body[\u0027rescue_password\u0027] \u003d rescue_password"},{"line_number":680,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2f019b2a_94699c68","line":677,"range":{"start_line":676,"start_character":0,"end_line":677,"end_character":46},"updated":"2021-01-06 09:17:18.000000000","message":"This does not allow setting configdrive and deploy steps simultaneously.","commit_id":"95bf12f10e5c7a469b021461bcecc0a6d032a804"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d3a4953f9e9f312254489336004c7ca1f50ab7a5","unresolved":false,"context_lines":[{"line_number":673,"context_line":"            body[\u0027configdrive\u0027] \u003d configdrive"},{"line_number":674,"context_line":"        elif cleansteps:"},{"line_number":675,"context_line":"            body[\u0027clean_steps\u0027] \u003d cleansteps"},{"line_number":676,"context_line":"        elif deploysteps:"},{"line_number":677,"context_line":"            body[\u0027deploy_steps\u0027] \u003d deploysteps"},{"line_number":678,"context_line":"        elif rescue_password:"},{"line_number":679,"context_line":"            body[\u0027rescue_password\u0027] \u003d rescue_password"},{"line_number":680,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0045cd35_93b36e1f","line":677,"range":{"start_line":676,"start_character":0,"end_line":677,"end_character":46},"in_reply_to":"2f019b2a_94699c68","updated":"2021-01-07 12:35:38.000000000","message":"Done","commit_id":"95bf12f10e5c7a469b021461bcecc0a6d032a804"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2cd1e864b04ca39ab53f110119513c50de86b05f","unresolved":true,"context_lines":[{"line_number":619,"context_line":"    def set_provision_state("},{"line_number":620,"context_line":"            self, node_uuid, state, configdrive\u003dNone, cleansteps\u003dNone,"},{"line_number":621,"context_line":"            deploysteps\u003dNone, rescue_password\u003dNone, os_ironic_api_version\u003dNone,"},{"line_number":622,"context_line":"            global_request_id\u003dNone):"},{"line_number":623,"context_line":"        \"\"\"Set the provision state for the node."},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        :param node_uuid: The UUID or name of the node."}],"source_content_type":"text/x-python","patch_set":2,"id":"97466751_2dae3136","line":622,"updated":"2021-01-08 15:34:06.000000000","message":"I think this should be added to the end. Because (unfortunately) some people may call this like  set_provision_state(uuid, state, configdrive, cleansteps, rescue_password, api_version, global_request_id). Changing this so deploysteps is not at the end will mess up the order :-(","commit_id":"869ac86d369cdf6bbd2d6c4f3b183f482d6036b8"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"b261f16f398dbc11f89794f9578ff474ac7ee7d4","unresolved":false,"context_lines":[{"line_number":619,"context_line":"    def set_provision_state("},{"line_number":620,"context_line":"            self, node_uuid, state, configdrive\u003dNone, cleansteps\u003dNone,"},{"line_number":621,"context_line":"            deploysteps\u003dNone, rescue_password\u003dNone, os_ironic_api_version\u003dNone,"},{"line_number":622,"context_line":"            global_request_id\u003dNone):"},{"line_number":623,"context_line":"        \"\"\"Set the provision state for the node."},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        :param node_uuid: The UUID or name of the node."}],"source_content_type":"text/x-python","patch_set":2,"id":"fbf5cad6_b3f92a65","line":622,"in_reply_to":"97466751_2dae3136","updated":"2021-01-11 14:08:42.000000000","message":"Done","commit_id":"869ac86d369cdf6bbd2d6c4f3b183f482d6036b8"}],"releasenotes/notes/add-deploy-steps-arg-0b127e29c8cf976d.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2cd1e864b04ca39ab53f110119513c50de86b05f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    standard input; OR a string. The value should be a list of deploy-step"},{"line_number":11,"context_line":"    dictionaries; each dictionary should have keys \u0027interface\u0027, \u0027step\u0027 and"},{"line_number":12,"context_line":"    \u0027priority\u0027, and optional key \u0027args\u0027. When overlapping, these steps override"},{"line_number":13,"context_line":"    deploy template and driver steps."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b46d66cc_075b7341","line":13,"updated":"2021-01-08 15:34:06.000000000","message":"I don\u0027t know if we have any documentation about this. If we do, would be good to add a link here.","commit_id":"869ac86d369cdf6bbd2d6c4f3b183f482d6036b8"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"b261f16f398dbc11f89794f9578ff474ac7ee7d4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    standard input; OR a string. The value should be a list of deploy-step"},{"line_number":11,"context_line":"    dictionaries; each dictionary should have keys \u0027interface\u0027, \u0027step\u0027 and"},{"line_number":12,"context_line":"    \u0027priority\u0027, and optional key \u0027args\u0027. When overlapping, these steps override"},{"line_number":13,"context_line":"    deploy template and driver steps."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0a66d64f_6bbd37d9","line":13,"in_reply_to":"b46d66cc_075b7341","updated":"2021-01-11 14:08:42.000000000","message":"Some updates will be made in parent patch in ironic project [1], added a link.\n\n[1] https://review.opendev.org/c/openstack/ironic/+/768353/4/doc/source/admin/node-deployment.rst","commit_id":"869ac86d369cdf6bbd2d6c4f3b183f482d6036b8"}]}