)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"02691c1c5c9d5ca535f9f65e40ae1527983c022f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Convert mac addresses to lowercase to avoid mismatch"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Convert mac addresses to lowercase to avoid mismatch"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7cd21f247239cd4b5406392860b81869a99eaf10"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5e22413c_be2a4a63","line":9,"updated":"2021-11-30 22:17:48.000000000","message":"could you elaborate on this issue? This seems like tests need to be \"fixed\" but also seems like it is a behavior change. I guess ultimately, what drove this patch to become a thing since we just pass-through what is supplied?","commit_id":"c36ae7c678615bba254c8b372825a772de976d8b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0289352fd9008164b852c172cc5421409222432e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Convert mac addresses to lowercase to avoid mismatch"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Convert mac addresses to lowercase to avoid mismatch"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7cd21f247239cd4b5406392860b81869a99eaf10"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ecc5cb30_47847618","line":9,"in_reply_to":"0c262b60_4cedf8c4","updated":"2023-06-26 18:39:49.000000000","message":"It is a reasonable fix, but it is more than just changing the code, the integrated tests are broken by this change.","commit_id":"c36ae7c678615bba254c8b372825a772de976d8b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2bcd48495a2b0805cce95db763d04d557bd3e54c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Convert mac addresses to lowercase to avoid mismatch"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Convert mac addresses to lowercase to avoid mismatch"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7cd21f247239cd4b5406392860b81869a99eaf10"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"58532872_0b8d8f7d","line":9,"in_reply_to":"1368d948_28b17aaa","updated":"2021-12-06 18:34:29.000000000","message":"Okay. I guess that is reasonable. It would be good to open a bug or item in storyboard, because this is likely a consideration we need to check elsewhere, and also this is a behavior change, so we would at least need to add a release note to this change set to communicate it through.\n\nI *guess* it could be qualified as a fix so we can backport it.... maybe.","commit_id":"c36ae7c678615bba254c8b372825a772de976d8b"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"c8b55e121e26a46b18e9b1307c6e714d69e5ae93","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Convert mac addresses to lowercase to avoid mismatch"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Convert mac addresses to lowercase to avoid mismatch"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7cd21f247239cd4b5406392860b81869a99eaf10"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0c262b60_4cedf8c4","line":9,"in_reply_to":"58532872_0b8d8f7d","updated":"2023-06-05 15:07:24.000000000","message":"This is quite old ... should we abandon this commit or do you see a need for it ?","commit_id":"c36ae7c678615bba254c8b372825a772de976d8b"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"304f3d7e2f2202a789e5a6f9c483dd44d852410a","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Convert mac addresses to lowercase to avoid mismatch"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Convert mac addresses to lowercase to avoid mismatch"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7cd21f247239cd4b5406392860b81869a99eaf10"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1368d948_28b17aaa","line":9,"in_reply_to":"5e22413c_be2a4a63","updated":"2021-11-30 23:15:50.000000000","message":"If customers provide an uppercase mac , fencing of nodes will not work as the mac will not match anything on the compute itself.   I feel like we should prevent this from happening through code instead of a doc bug as users will most probably not read it, not notice it and still hit this issue which puts a bit of pressure on support .","commit_id":"c36ae7c678615bba254c8b372825a772de976d8b"}]}
