)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6515fdc1544aeb2067d03b92aada724472376acd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a6dcb3bf_e0c7fa34","updated":"2023-08-03 22:55:36.000000000","message":"Followup at https://review.opendev.org/c/openstack/python-ironicclient/+/890467","commit_id":"b57429ffdbd6a474fb642641d7f5864450f95da2"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3235203854d3ee6dc8cc6ef9953f583c29741cb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7e4b8bfe_c1e57112","updated":"2023-08-03 21:39:39.000000000","message":"We can fix the tests in a followup, I\u0027d rather this land 😊","commit_id":"b57429ffdbd6a474fb642641d7f5864450f95da2"}],"ironicclient/osc/v1/baremetal_node.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4707e2e2f4fd24709eee7f15accc2263388cdeda","unresolved":true,"context_lines":[{"line_number":1430,"context_line":"            help\u003d_(\u0027Set the shard for the node\u0027),"},{"line_number":1431,"context_line":"        )"},{"line_number":1432,"context_line":"        parser.add_argument("},{"line_number":1433,"context_line":"            \"--parent_node\","},{"line_number":1434,"context_line":"            metavar\u003d\u0027\u003cparent_node\u003e\u0027,"},{"line_number":1435,"context_line":"            help\u003d_(\u0027Set the parent_node for the node\u0027),"},{"line_number":1436,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"36e6efcd_5b17bd1b","line":1433,"range":{"start_line":1433,"start_character":21,"end_line":1433,"end_character":22},"updated":"2023-07-26 18:04:37.000000000","message":"This should be be parent-node\n\nWhen used as is, works.","commit_id":"edc6e8e5bcd92869fa79f89a82c21262ab1c6cc2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4707e2e2f4fd24709eee7f15accc2263388cdeda","unresolved":true,"context_lines":[{"line_number":528,"context_line":"            metavar\u003d\u0027\u003cshard\u003e\u0027,"},{"line_number":529,"context_line":"            help\u003d_(\"Shard for the node.\"))"},{"line_number":530,"context_line":"        parser.add_argument("},{"line_number":531,"context_line":"            \u0027--parent-node\u0027,"},{"line_number":532,"context_line":"            metavar\u003d\u0027\u003cparent_node\u003e\u0027,"},{"line_number":533,"context_line":"            help\u003d_(\u0027Parent node for the node being created.\u0027))"},{"line_number":534,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ee7c9023_a4f370a6","line":531,"updated":"2023-07-26 18:04:37.000000000","message":"works like a champ on create","commit_id":"12ada7ab252df8eb585481a195b7e3781fd26c72"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4707e2e2f4fd24709eee7f15accc2263388cdeda","unresolved":false,"context_lines":[{"line_number":1832,"context_line":"                      \u0027storage_interface\u0027, \u0027vendor_interface\u0027,"},{"line_number":1833,"context_line":"                      \u0027protected\u0027, \u0027protected_reason\u0027, \u0027retired\u0027,"},{"line_number":1834,"context_line":"                      \u0027retired_reason\u0027, \u0027owner\u0027, \u0027lessee\u0027, \u0027description\u0027,"},{"line_number":1835,"context_line":"                      \u0027shard\u0027, \u0027parent_node\u0027]:"},{"line_number":1836,"context_line":"            if getattr(parsed_args, field):"},{"line_number":1837,"context_line":"                properties.extend(utils.args_array_to_patch(\u0027remove\u0027, [field]))"},{"line_number":1838,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a4881801_fbb7853e","line":1835,"updated":"2023-07-26 18:04:37.000000000","message":"unset works like a champ \\o/","commit_id":"12ada7ab252df8eb585481a195b7e3781fd26c72"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"bc71f6750ddd40ce0c9516d79adee4c15a8159c3","unresolved":true,"context_lines":[{"line_number":801,"context_line":"            \u0027--parent-node\u0027,"},{"line_number":802,"context_line":"            dest\u003d\u0027parent_node\u0027,"},{"line_number":803,"context_line":"            metavar\u003d\"\u003cparent_node\u003e\","},{"line_number":804,"context_line":"            help\u003d_(\u0027List only nodes not associated with an parent node.\u0027),"},{"line_number":805,"context_line":"        )"},{"line_number":806,"context_line":"        return parser"},{"line_number":807,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"58c3431a_2bfe270c","line":804,"updated":"2023-07-27 21:54:05.000000000","message":"not associated? Also \u0027a parent node\u0027. Should this be:\n\n    List only nodes associated with a parent node.","commit_id":"64e0741a20b9ade3d6db22608af4d28ac91b724d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"301fd9443a3e307744d0b63df7e0f11bfa35f531","unresolved":false,"context_lines":[{"line_number":801,"context_line":"            \u0027--parent-node\u0027,"},{"line_number":802,"context_line":"            dest\u003d\u0027parent_node\u0027,"},{"line_number":803,"context_line":"            metavar\u003d\"\u003cparent_node\u003e\","},{"line_number":804,"context_line":"            help\u003d_(\u0027List only nodes not associated with an parent node.\u0027),"},{"line_number":805,"context_line":"        )"},{"line_number":806,"context_line":"        return parser"},{"line_number":807,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"01ee52e5_c30b08a5","line":804,"in_reply_to":"58c3431a_2bfe270c","updated":"2023-07-28 17:41:39.000000000","message":"Done","commit_id":"64e0741a20b9ade3d6db22608af4d28ac91b724d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"bc71f6750ddd40ce0c9516d79adee4c15a8159c3","unresolved":true,"context_lines":[{"line_number":1449,"context_line":"        parser.add_argument("},{"line_number":1450,"context_line":"            \"--parent-node\","},{"line_number":1451,"context_line":"            metavar\u003d\u0027\u003cparent_node\u003e\u0027,"},{"line_number":1452,"context_line":"            help\u003d_(\u0027Set the parent_node for the node\u0027),"},{"line_number":1453,"context_line":"        )"},{"line_number":1454,"context_line":""},{"line_number":1455,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"f18f8c3a_a2a46acb","line":1452,"range":{"start_line":1452,"start_character":28,"end_line":1452,"end_character":39},"updated":"2023-07-27 21:54:05.000000000","message":"s/parent_node/parent node/ it looks like the convention is to use natural language in this help text","commit_id":"64e0741a20b9ade3d6db22608af4d28ac91b724d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"301fd9443a3e307744d0b63df7e0f11bfa35f531","unresolved":false,"context_lines":[{"line_number":1449,"context_line":"        parser.add_argument("},{"line_number":1450,"context_line":"            \"--parent-node\","},{"line_number":1451,"context_line":"            metavar\u003d\u0027\u003cparent_node\u003e\u0027,"},{"line_number":1452,"context_line":"            help\u003d_(\u0027Set the parent_node for the node\u0027),"},{"line_number":1453,"context_line":"        )"},{"line_number":1454,"context_line":""},{"line_number":1455,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"5d836b3d_5c025eff","line":1452,"range":{"start_line":1452,"start_character":28,"end_line":1452,"end_character":39},"in_reply_to":"f18f8c3a_a2a46acb","updated":"2023-07-28 17:41:39.000000000","message":"Done","commit_id":"64e0741a20b9ade3d6db22608af4d28ac91b724d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"bc71f6750ddd40ce0c9516d79adee4c15a8159c3","unresolved":true,"context_lines":[{"line_number":1805,"context_line":"        parser.add_argument("},{"line_number":1806,"context_line":"            \"--parent-node\","},{"line_number":1807,"context_line":"            action\u003d\"store_true\","},{"line_number":1808,"context_line":"            help\u003d_(\u0027Unset the parent_node filed of the node\u0027),"},{"line_number":1809,"context_line":"        )"},{"line_number":1810,"context_line":""},{"line_number":1811,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"ca4e434e_5cccb1fc","line":1808,"range":{"start_line":1808,"start_character":30,"end_line":1808,"end_character":41},"updated":"2023-07-27 21:54:05.000000000","message":"parent node","commit_id":"64e0741a20b9ade3d6db22608af4d28ac91b724d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"301fd9443a3e307744d0b63df7e0f11bfa35f531","unresolved":false,"context_lines":[{"line_number":1805,"context_line":"        parser.add_argument("},{"line_number":1806,"context_line":"            \"--parent-node\","},{"line_number":1807,"context_line":"            action\u003d\"store_true\","},{"line_number":1808,"context_line":"            help\u003d_(\u0027Unset the parent_node filed of the node\u0027),"},{"line_number":1809,"context_line":"        )"},{"line_number":1810,"context_line":""},{"line_number":1811,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"a46be15e_6eb7e136","line":1808,"range":{"start_line":1808,"start_character":30,"end_line":1808,"end_character":41},"in_reply_to":"ca4e434e_5cccb1fc","updated":"2023-07-28 17:41:39.000000000","message":"Done","commit_id":"64e0741a20b9ade3d6db22608af4d28ac91b724d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"bc71f6750ddd40ce0c9516d79adee4c15a8159c3","unresolved":true,"context_lines":[{"line_number":2329,"context_line":"            json.dump(inventory, sys.stdout)"},{"line_number":2330,"context_line":""},{"line_number":2331,"context_line":""},{"line_number":2332,"context_line":"class NodeChildrenList(command.ShowOne):"},{"line_number":2333,"context_line":"    \"\"\"Get history event for a baremetal node.\"\"\""},{"line_number":2334,"context_line":""},{"line_number":2335,"context_line":"    log \u003d logging.getLogger(__name__ + \".NodeChildrenList\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"e2e0d309_6d5bf755","line":2332,"updated":"2023-07-27 21:54:05.000000000","message":"Should this be a command.Lister which conforms to the same format as ListBaremetalNode?\n\nDoes this actually duplicate the function of \"baremetal node list --parent-node\"? I\u0027m sure this command is useful, its purpose just needs to be stated.","commit_id":"64e0741a20b9ade3d6db22608af4d28ac91b724d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"301fd9443a3e307744d0b63df7e0f11bfa35f531","unresolved":true,"context_lines":[{"line_number":2329,"context_line":"            json.dump(inventory, sys.stdout)"},{"line_number":2330,"context_line":""},{"line_number":2331,"context_line":""},{"line_number":2332,"context_line":"class NodeChildrenList(command.ShowOne):"},{"line_number":2333,"context_line":"    \"\"\"Get history event for a baremetal node.\"\"\""},{"line_number":2334,"context_line":""},{"line_number":2335,"context_line":"    log \u003d logging.getLogger(__name__ + \".NodeChildrenList\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"cbba9454_b3a623ae","line":2332,"in_reply_to":"e2e0d309_6d5bf755","updated":"2023-07-28 17:41:39.000000000","message":"So this just hands back a single value with the list of UUIDs, as opposed to enumerating whole node objects. I don\u0027t know how useful it is, but since we explicitly added an api, it made sense to support in the CLI. Also, line 2333 needed to be fixed 😊","commit_id":"64e0741a20b9ade3d6db22608af4d28ac91b724d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"bc71f6750ddd40ce0c9516d79adee4c15a8159c3","unresolved":true,"context_lines":[{"line_number":2330,"context_line":""},{"line_number":2331,"context_line":""},{"line_number":2332,"context_line":"class NodeChildrenList(command.ShowOne):"},{"line_number":2333,"context_line":"    \"\"\"Get history event for a baremetal node.\"\"\""},{"line_number":2334,"context_line":""},{"line_number":2335,"context_line":"    log \u003d logging.getLogger(__name__ + \".NodeChildrenList\")"},{"line_number":2336,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"998489cd_65a54934","line":2333,"updated":"2023-07-27 21:54:05.000000000","message":"This needs to be corrected?","commit_id":"64e0741a20b9ade3d6db22608af4d28ac91b724d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"301fd9443a3e307744d0b63df7e0f11bfa35f531","unresolved":false,"context_lines":[{"line_number":2330,"context_line":""},{"line_number":2331,"context_line":""},{"line_number":2332,"context_line":"class NodeChildrenList(command.ShowOne):"},{"line_number":2333,"context_line":"    \"\"\"Get history event for a baremetal node.\"\"\""},{"line_number":2334,"context_line":""},{"line_number":2335,"context_line":"    log \u003d logging.getLogger(__name__ + \".NodeChildrenList\")"},{"line_number":2336,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dc804746_ce5ef206","line":2333,"in_reply_to":"998489cd_65a54934","updated":"2023-07-28 17:41:39.000000000","message":"Done","commit_id":"64e0741a20b9ade3d6db22608af4d28ac91b724d"}],"ironicclient/tests/unit/osc/v1/test_baremetal_node.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3235203854d3ee6dc8cc6ef9953f583c29741cb7","unresolved":true,"context_lines":[{"line_number":539,"context_line":"    def check_with_options(self, addl_arglist, addl_verifylist, addl_kwargs):"},{"line_number":540,"context_line":"        arglist \u003d copy.copy(self.arglist) + addl_arglist"},{"line_number":541,"context_line":"        verifylist \u003d copy.copy(self.verifylist) + addl_verifylist"},{"line_number":542,"context_line":"        print(verifylist)"},{"line_number":543,"context_line":"        print(arglist)"},{"line_number":544,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":545,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"22792327_79635998","line":542,"updated":"2023-08-03 21:39:39.000000000","message":"Please remove print() from the tests, throughout.","commit_id":"b57429ffdbd6a474fb642641d7f5864450f95da2"}],"ironicclient/v1/node.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4707e2e2f4fd24709eee7f15accc2263388cdeda","unresolved":true,"context_lines":[{"line_number":395,"context_line":"                self._path(path), response_key\u003d\"targets\", limit\u003dlimit,"},{"line_number":396,"context_line":"                obj_class\u003dvolume_target.VolumeTarget, **header_values)"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def list_children_of_node("},{"line_number":399,"context_line":"            self, node_id,"},{"line_number":400,"context_line":"            os_ironic_api_version\u003dNone,"},{"line_number":401,"context_line":"            global_request_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"88ad96da_81eb4eee","line":398,"updated":"2023-07-26 18:04:37.000000000","message":"So, the method does the right thing. The server... doesn\u0027t work.\n\nI\u0027m getting an empty children list, but the links are right. *mindblown*","commit_id":"12ada7ab252df8eb585481a195b7e3781fd26c72"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"bc71f6750ddd40ce0c9516d79adee4c15a8159c3","unresolved":true,"context_lines":[{"line_number":141,"context_line":"                            nodes with the supplied parent node."},{"line_number":142,"context_line":"        :param include_children: Optional. Boolean Value, only True is valid."},{"line_number":143,"context_line":"                                 Tells the ironic API to enumerate all child"},{"line_number":144,"context_line":"                                 nodes which are notmrally hidden from the"},{"line_number":145,"context_line":"                                 node list."},{"line_number":146,"context_line":"        :returns: A list of nodes."},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"335efcdd_85a7a5e1","line":144,"range":{"start_line":144,"start_character":49,"end_line":144,"end_character":58},"updated":"2023-07-27 21:54:05.000000000","message":"normally","commit_id":"64e0741a20b9ade3d6db22608af4d28ac91b724d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"301fd9443a3e307744d0b63df7e0f11bfa35f531","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                            nodes with the supplied parent node."},{"line_number":142,"context_line":"        :param include_children: Optional. Boolean Value, only True is valid."},{"line_number":143,"context_line":"                                 Tells the ironic API to enumerate all child"},{"line_number":144,"context_line":"                                 nodes which are notmrally hidden from the"},{"line_number":145,"context_line":"                                 node list."},{"line_number":146,"context_line":"        :returns: A list of nodes."},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"149540a8_d0072c61","line":144,"range":{"start_line":144,"start_character":49,"end_line":144,"end_character":58},"in_reply_to":"335efcdd_85a7a5e1","updated":"2023-07-28 17:41:39.000000000","message":"Done","commit_id":"64e0741a20b9ade3d6db22608af4d28ac91b724d"}]}