)]}'
{"ironicclient/tests/unit/osc/v1/test_baremetal_node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c661d3ede3e0af5d63aed5627cf0cf4c2bcf8b5","unresolved":false,"context_lines":[{"line_number":4587,"context_line":""},{"line_number":4588,"context_line":"        expected_data \u003d ("},{"line_number":4589,"context_line":"            [(fw[\u0027component\u0027], fw[\u0027initial_version\u0027], fw[\u0027current_version\u0027],"},{"line_number":4590,"context_line":"              fw[\u0027last_version_flashed\u0027], fw[\u0027created_at\u0027], fw[\u0027updated_at\u0027])"},{"line_number":4591,"context_line":"             for fw in baremetal_fakes.FIRMWARE_COMPONENTS])"},{"line_number":4592,"context_line":"        self.assertEqual(tuple(expected_data), tuple(data))"}],"source_content_type":"text/x-python","patch_set":1,"id":"4c10f6b4_6fe6c96b","line":4590,"updated":"2023-08-23 11:52:49.000000000","message":"We shouldn\u0027t show created_at/updated_at without --long IMO. At least, we don\u0027t do it for other resources.","commit_id":"5d73bc7ffcb99994d575ac1be43b8f6c3c856302"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"39ea7aa402ab4257e199803dd3831540808b780b","unresolved":true,"context_lines":[{"line_number":4587,"context_line":""},{"line_number":4588,"context_line":"        expected_data \u003d ("},{"line_number":4589,"context_line":"            [(fw[\u0027component\u0027], fw[\u0027initial_version\u0027], fw[\u0027current_version\u0027],"},{"line_number":4590,"context_line":"              fw[\u0027last_version_flashed\u0027], fw[\u0027created_at\u0027], fw[\u0027updated_at\u0027])"},{"line_number":4591,"context_line":"             for fw in baremetal_fakes.FIRMWARE_COMPONENTS])"},{"line_number":4592,"context_line":"        self.assertEqual(tuple(expected_data), tuple(data))"}],"source_content_type":"text/x-python","patch_set":1,"id":"4d447060_9593f595","line":4590,"in_reply_to":"4c10f6b4_6fe6c96b","updated":"2023-08-28 22:27:05.000000000","message":"This would require adding support to details at the API level \u003d(\nLet\u0027s see what others think about not including --long now and not showing created_at and updated_at","commit_id":"5d73bc7ffcb99994d575ac1be43b8f6c3c856302"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"91dc9e745f3cbd8cfb8f77ecc502472e72a5ec82","unresolved":true,"context_lines":[{"line_number":4587,"context_line":""},{"line_number":4588,"context_line":"        expected_data \u003d ("},{"line_number":4589,"context_line":"            [(fw[\u0027component\u0027], fw[\u0027initial_version\u0027], fw[\u0027current_version\u0027],"},{"line_number":4590,"context_line":"              fw[\u0027last_version_flashed\u0027], fw[\u0027created_at\u0027], fw[\u0027updated_at\u0027])"},{"line_number":4591,"context_line":"             for fw in baremetal_fakes.FIRMWARE_COMPONENTS])"},{"line_number":4592,"context_line":"        self.assertEqual(tuple(expected_data), tuple(data))"}],"source_content_type":"text/x-python","patch_set":1,"id":"cf334cb8_064ae36b","line":4590,"in_reply_to":"4d447060_9593f595","updated":"2023-08-28 22:33:21.000000000","message":"(client) [root@dl380]# baremetal node firmware list 2e31df61-84b1-5856-bfb6-6b5f2cd3dd11\n+-----------+------------------------+------------------------+----------------------+\n| Component | Initial Version        | Current Version        | Last Version Flashed |\n+-----------+------------------------+------------------------+----------------------+\n| bios      | U30 v2.36 (07/16/2020) | U30 v2.36 (07/16/2020) | None                 |\n| bmc       | iLO 5 v2.18            | iLO 5 v2.18            | None                 |\n+-----------+------------------------+------------------------+----------------------+\n(client) [root@dl380gen10-]# baremetal node firmware list 2e31df61-84b1-5856-bfb6-6b5f2cd3dd11 --long\n{\"code\": 405, \"title\": \"Method Not Allowed\", \"description\": \"\"} (HTTP 405)","commit_id":"5d73bc7ffcb99994d575ac1be43b8f6c3c856302"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"668c17620da8cd706864b360ab84eb55d4c460f8","unresolved":false,"context_lines":[{"line_number":4587,"context_line":""},{"line_number":4588,"context_line":"        expected_data \u003d ("},{"line_number":4589,"context_line":"            [(fw[\u0027component\u0027], fw[\u0027initial_version\u0027], fw[\u0027current_version\u0027],"},{"line_number":4590,"context_line":"              fw[\u0027last_version_flashed\u0027], fw[\u0027created_at\u0027], fw[\u0027updated_at\u0027])"},{"line_number":4591,"context_line":"             for fw in baremetal_fakes.FIRMWARE_COMPONENTS])"},{"line_number":4592,"context_line":"        self.assertEqual(tuple(expected_data), tuple(data))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9b064a77_ca0ebd6e","line":4590,"in_reply_to":"5ae3dae0_d65aff60","updated":"2023-08-30 11:50:24.000000000","message":"Done","commit_id":"5d73bc7ffcb99994d575ac1be43b8f6c3c856302"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"760fb98eaeec5555ee1f51e24e263146d7a8dad3","unresolved":true,"context_lines":[{"line_number":4587,"context_line":""},{"line_number":4588,"context_line":"        expected_data \u003d ("},{"line_number":4589,"context_line":"            [(fw[\u0027component\u0027], fw[\u0027initial_version\u0027], fw[\u0027current_version\u0027],"},{"line_number":4590,"context_line":"              fw[\u0027last_version_flashed\u0027], fw[\u0027created_at\u0027], fw[\u0027updated_at\u0027])"},{"line_number":4591,"context_line":"             for fw in baremetal_fakes.FIRMWARE_COMPONENTS])"},{"line_number":4592,"context_line":"        self.assertEqual(tuple(expected_data), tuple(data))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ae3dae0_d65aff60","line":4590,"in_reply_to":"cf334cb8_064ae36b","updated":"2023-08-29 20:36:31.000000000","message":"So Julia, Iury and I spoke about this in a sync video call today.\n\nJulia and I both are of the opinion that the dates are inherent to the information, so knowing \"freshness\" matters. There also seems to be previous patterns in the client of returning this information (without a --long) if it\u0027s felt to be relevant.\n\nWe\u0027ve decided, since you\u0027re out until past the deadline, to merge support for returning all fields without --long. I\u0027m sorry you weren\u0027t around to be a part of the discussion.","commit_id":"5d73bc7ffcb99994d575ac1be43b8f6c3c856302"}]}
