)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"41e1f0537604afc16257f303e65a95036db57ce0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"23fc54d5_945873b5","updated":"2024-03-27 17:21:05.000000000","message":"ugh","commit_id":"72f0b98941d26a5f6c943485d2373346e5efc1ae"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"eef392fed55b20993e2e4f57c1da8895d0412770","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dab98f84_6710d629","updated":"2024-07-25 12:14:56.000000000","message":"recheck","commit_id":"54b878238c712b6bff890fac0a9e51c42214a861"}],"ironicclient/common/http.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38eb7cee2be33d5d5532b7771ae683cda38ea980","unresolved":true,"context_lines":[{"line_number":56,"context_line":"_API_VERSION_RE \u003d re.compile(r\u0027/+(v%d)?/*$\u0027 % _MAJOR_VERSION)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class _Version:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def __init__(self, version):"},{"line_number":62,"context_line":"        # this will raise ValueError if ver is not of format \u0027{MAX}.{MIN}\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"830841b7_a74d17db","line":59,"updated":"2024-03-28 10:01:51.000000000","message":"Could you use https://docs.python.org/3/library/functools.html#functools.total_ordering instead of all these methods?","commit_id":"14a5906248adf908087c08914934e0dbe91df4b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7c8d4258e8d44f44b70e08516b149101144f680a","unresolved":true,"context_lines":[{"line_number":56,"context_line":"_API_VERSION_RE \u003d re.compile(r\u0027/+(v%d)?/*$\u0027 % _MAJOR_VERSION)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class _Version:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def __init__(self, version):"},{"line_number":62,"context_line":"        # this will raise ValueError if ver is not of format \u0027{MAX}.{MIN}\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"d105c656_24491708","line":59,"in_reply_to":"830841b7_a74d17db","updated":"2024-03-28 10:05:45.000000000","message":"I wasn\u0027t aware of that, and I could. Happy to rework if you\u0027d like.","commit_id":"14a5906248adf908087c08914934e0dbe91df4b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"13e4142be000e36b532aaa769303a797b7df9cd3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"_API_VERSION_RE \u003d re.compile(r\u0027/+(v%d)?/*$\u0027 % _MAJOR_VERSION)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class _Version:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def __init__(self, version):"},{"line_number":62,"context_line":"        # this will raise ValueError if ver is not of format \u0027{MAX}.{MIN}\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"f79cbd8b_1acf235a","line":59,"in_reply_to":"d105c656_24491708","updated":"2024-07-25 12:15:40.000000000","message":"Done","commit_id":"14a5906248adf908087c08914934e0dbe91df4b2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38eb7cee2be33d5d5532b7771ae683cda38ea980","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"class VersionNegotiationMixin(object):"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def negotiate_version(self, conn, resp):"},{"line_number":123,"context_line":"        \"\"\"Negotiate the server version"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f0fee2f1_a58b1ef7","line":121,"updated":"2024-03-28 10:01:51.000000000","message":"Please avoid so many unrelated whitespace changes. It\u0027s not a big deal here since this file is rarely changed, but it can be an issue for future backports otherwise.","commit_id":"14a5906248adf908087c08914934e0dbe91df4b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"13e4142be000e36b532aaa769303a797b7df9cd3","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"class VersionNegotiationMixin(object):"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def negotiate_version(self, conn, resp):"},{"line_number":123,"context_line":"        \"\"\"Negotiate the server version"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2ef35d08_c5a66f70","line":121,"in_reply_to":"0e7ddb13_09ade289","updated":"2024-07-25 12:15:40.000000000","message":"Done.","commit_id":"14a5906248adf908087c08914934e0dbe91df4b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7c8d4258e8d44f44b70e08516b149101144f680a","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"class VersionNegotiationMixin(object):"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def negotiate_version(self, conn, resp):"},{"line_number":123,"context_line":"        \"\"\"Negotiate the server version"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0e7ddb13_09ade289","line":121,"in_reply_to":"f0fee2f1_a58b1ef7","updated":"2024-03-28 10:05:45.000000000","message":"Fair point. Can revert","commit_id":"14a5906248adf908087c08914934e0dbe91df4b2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"72f06fb527f178222d78bcce589020ec144115b9","unresolved":true,"context_lines":[{"line_number":61,"context_line":"    _version_re \u003d re.compile(r\u0027^(\\d) \\. (\\d+)$\u0027, re.VERBOSE | re.ASCII)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def __init__(self, version):"},{"line_number":64,"context_line":"        match \u003d self._version_re.match(version)"},{"line_number":65,"context_line":"        if not match:"},{"line_number":66,"context_line":"            raise ValueError(\u0027invalid version number %s\u0027 % version)"},{"line_number":67,"context_line":"        major, minor \u003d match.group(1, 2)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bb29e5d4_06e2698e","line":64,"updated":"2024-07-25 12:15:24.000000000","message":"nit: avoid using keywords for variable names","commit_id":"54b878238c712b6bff890fac0a9e51c42214a861"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0032b74dd5abfa1833453a74078b08fb61ba4651","unresolved":true,"context_lines":[{"line_number":61,"context_line":"    _version_re \u003d re.compile(r\u0027^(\\d) \\. (\\d+)$\u0027, re.VERBOSE | re.ASCII)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def __init__(self, version):"},{"line_number":64,"context_line":"        match \u003d self._version_re.match(version)"},{"line_number":65,"context_line":"        if not match:"},{"line_number":66,"context_line":"            raise ValueError(\u0027invalid version number %s\u0027 % version)"},{"line_number":67,"context_line":"        major, minor \u003d match.group(1, 2)"}],"source_content_type":"text/x-python","patch_set":3,"id":"eed10bcf_3d04c70a","line":64,"in_reply_to":"bb29e5d4_06e2698e","updated":"2024-07-25 12:18:48.000000000","message":"Forgot this was a keyword now. Fortunately it\u0027s a soft keyword. Lemme know if you want to respin.","commit_id":"54b878238c712b6bff890fac0a9e51c42214a861"}]}