)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"82fe9c7c6cf29b63bcfd1618f35a7ff5d88b9fe3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9997086e_084b600c","updated":"2024-07-17 18:06:16.000000000","message":"This cannot merge until runbooks are merged","commit_id":"f7d78fe0206ad66b0a326400a5e2709816fb7b3b"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b7201699e44e5ab6d0e1fda3e511c7d08710c749","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c6abb73a_fc45d3d6","updated":"2024-07-17 18:39:49.000000000","message":"bump minimum microversion, too","commit_id":"f7d78fe0206ad66b0a326400a5e2709816fb7b3b"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"78f288a4da7c63db50742725545301b5e6470fcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1100b5ef_07707510","updated":"2024-07-15 17:08:57.000000000","message":"recheck","commit_id":"f7d78fe0206ad66b0a326400a5e2709816fb7b3b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"10c1bc4386defdc08cf7b6cbb0017cc8c08c2c00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"59d7bcf9_831454fd","updated":"2024-08-14 19:15:47.000000000","message":"LGTM","commit_id":"1035b2b238e888eec705be434d7f7e3fe1d13c4c"}],"ironicclient/common/utils.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b7201699e44e5ab6d0e1fda3e511c7d08710c749","unresolved":true,"context_lines":[{"line_number":238,"context_line":"    if sort_dir is not None:"},{"line_number":239,"context_line":"        filters.append(\u0027sort_dir\u003d%s\u0027 % sort_dir)"},{"line_number":240,"context_line":"    if project is not None:"},{"line_number":241,"context_line":"        filters.append(\u0027fields\u003d%s\u0027 % project)"},{"line_number":242,"context_line":"    if public is not None:"},{"line_number":243,"context_line":"        filters.append(\u0027public\u003dTrue\u0027)"},{"line_number":244,"context_line":"    if fields is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"423adcde_c708a4ef","line":241,"updated":"2024-07-17 18:39:49.000000000","message":"Should this be project?","commit_id":"f7d78fe0206ad66b0a326400a5e2709816fb7b3b"}],"ironicclient/osc/v1/baremetal_node.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b7201699e44e5ab6d0e1fda3e511c7d08710c749","unresolved":true,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    def get_parser(self, prog_name):"},{"line_number":321,"context_line":"        parser \u003d super(ServiceBaremetalNode, self).get_parser(prog_name)"},{"line_number":322,"context_line":"        clean_group \u003d parser.add_mutually_exclusive_group(required\u003dTrue)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        clean_group.add_argument("},{"line_number":325,"context_line":"            \u0027--service-steps\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"8443bcf9_77f97d3e","line":322,"updated":"2024-07-17 18:39:49.000000000","message":"maybe name this service_group?","commit_id":"f7d78fe0206ad66b0a326400a5e2709816fb7b3b"}],"ironicclient/osc/v1/baremetal_runbook.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b7201699e44e5ab6d0e1fda3e511c7d08710c749","unresolved":true,"context_lines":[{"line_number":27,"context_line":"_RUNBOOK_STEPS_HELP \u003d _("},{"line_number":28,"context_line":"    \"The runbook steps. May be the path to a YAML file containing the \""},{"line_number":29,"context_line":"    \"runbook steps; OR \u0027-\u0027, with the runbook steps being read from standard \""},{"line_number":30,"context_line":"    \"input; OR a JSON string. The value should be a list of runbook-step \""},{"line_number":31,"context_line":"    \"dictionaries; each dictionary should have keys \u0027interface\u0027, \u0027step\u0027, \""},{"line_number":32,"context_line":"    \"\u0027args\u0027 and \u0027order\u0027.\")"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2ee99df7_6b0b7203","line":30,"updated":"2024-07-17 18:39:49.000000000","message":"lets be consistent about using hyphen in use of runbook step(s)","commit_id":"f7d78fe0206ad66b0a326400a5e2709816fb7b3b"}],"ironicclient/tests/unit/osc/v1/test_baremetal_node.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b7201699e44e5ab6d0e1fda3e511c7d08710c749","unresolved":true,"context_lines":[{"line_number":249,"context_line":"        self.baremetal_mock.node.set_provision_state.assert_called_once_with("},{"line_number":250,"context_line":"            \u0027node_uuid\u0027, \u0027service\u0027, cleansteps\u003dNone, configdrive\u003dNone,"},{"line_number":251,"context_line":"            deploysteps\u003dNone, rescue_password\u003dNone, servicesteps\u003dNone,"},{"line_number":252,"context_line":"            runbook\u003drunbook_name)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"class TestInspect(TestBaremetal):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3464bf64_96f1ee98","line":252,"updated":"2024-07-17 18:39:49.000000000","message":"I suggest adding a failure test where you try to both call service and cleaning with steps *and* a runbook and validate it is rejected.","commit_id":"f7d78fe0206ad66b0a326400a5e2709816fb7b3b"}]}
