)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5a30f3fc6ed6e4338682a03a8c89d44580316a91","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unit Tests Boilerplate was generated by GPT-4o"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Generated-By: GPT-4o, JayF, adamcarthur"},{"line_number":16,"context_line":"Change-Id: I6f45cc678a5931e3525fb85256c1608e75fe089f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f60d3d0_f7b23db1","line":15,"updated":"2024-11-01 20:33:41.000000000","message":"Looking at the example https://openinfra.dev/legal/ai-policy, I think this should only be GPT-4o. If you want to give me credit as well (I don\u0027t care either way TBH), you can add, above it, \"Co-Authored-By: Jay Faulkner \u003cjay@jvf.cc\u003e\"","commit_id":"e224cab81ba5bd91e8d6140bc9991012837b8042"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"0a4e2c8e80425ca85b35ddae06ae1cac4e147f9a","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unit Tests Boilerplate was generated by GPT-4o"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Generated-By: GPT-4o, JayF, adamcarthur"},{"line_number":16,"context_line":"Change-Id: I6f45cc678a5931e3525fb85256c1608e75fe089f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"857d7a28_d5c2b837","line":15,"in_reply_to":"3f60d3d0_f7b23db1","updated":"2024-11-01 20:38:28.000000000","message":"Done","commit_id":"e224cab81ba5bd91e8d6140bc9991012837b8042"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0050048197c96d0aa16ead86099f882a3bac9466","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"141012bc_c7be5ed5","updated":"2024-11-01 20:35:53.000000000","message":"re-adding -1, please see patchset 3 comments","commit_id":"02ef46d27a3b4b7676a082617b005399280ba537"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"f8119b4aa857a5ec19fb48d29a29f22c66ab35d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3707c94c_c1bf06b4","in_reply_to":"141012bc_c7be5ed5","updated":"2024-11-01 20:39:04.000000000","message":"Done","commit_id":"02ef46d27a3b4b7676a082617b005399280ba537"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a2ae178d1d39cd21d6a154b4029e8fd1d93d516b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ad87cb88_dda8706c","updated":"2024-11-01 20:36:24.000000000","message":"re-adding again :D see patchset 3 comments","commit_id":"63b8b85b0c1cffc2b84ad8e2b3aaac7845bb31fe"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"245f4fa4909915099b43acf50179368c0002c995","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9a7211c7_bd328d24","updated":"2024-11-04 19:49:16.000000000","message":"I Co-Authored this, so not voting +2. LGTM.","commit_id":"266566c331678ba6b7aa72048b25838c9c84e0b2"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"46210a1f8e958057c431c74b820a50606168dd79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c4ea9afa_af3c686e","updated":"2024-11-04 10:20:58.000000000","message":"I think you already covered all of it. I don\u0027t see any microversion bumps though, but CI is passing, maybe you don\u0027t need that ?","commit_id":"266566c331678ba6b7aa72048b25838c9c84e0b2"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"245f4fa4909915099b43acf50179368c0002c995","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4d5ab74a_dfcd6bac","in_reply_to":"c4ea9afa_af3c686e","updated":"2024-11-04 19:49:16.000000000","message":"Yeah, I bumped the microversion to one that supports this for the node.shards change -- they were introduced together.","commit_id":"266566c331678ba6b7aa72048b25838c9c84e0b2"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fe567b16a444c26f95526b6cf0a523421fd500e5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a315829a_5faa1134","updated":"2024-11-05 22:04:49.000000000","message":"Again, no +2 because I\u0027m a co-author","commit_id":"f2bed8f2531ec92b47303346e48fe84cdb92b1ec"}],"ironicclient/osc/v1/baremetal_shard.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5a30f3fc6ed6e4338682a03a8c89d44580316a91","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"550427e7_1cb5a52f","line":37,"updated":"2024-11-01 20:33:41.000000000","message":"one thing I was curious about after thinking about this overnight: do we have a GET /v1/shards/[name] endpoint? if  so we should probably hook it up, too","commit_id":"e224cab81ba5bd91e8d6140bc9991012837b8042"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"ecc7b88ab797f9179f6fb238b52c417d35abc24d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a2f7ed7f_0cf6c0c2","line":37,"in_reply_to":"04a844a9_d74dc676","updated":"2024-11-01 20:52:38.000000000","message":"Done","commit_id":"e224cab81ba5bd91e8d6140bc9991012837b8042"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"0a4e2c8e80425ca85b35ddae06ae1cac4e147f9a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04a844a9_d74dc676","line":37,"in_reply_to":"550427e7_1cb5a52f","updated":"2024-11-01 20:38:28.000000000","message":"To the best of my knowledge, no https://docs.openstack.org/api-ref/baremetal/#shards","commit_id":"e224cab81ba5bd91e8d6140bc9991012837b8042"}],"ironicclient/tests/functional/osc/v1/test_baremetal_shard.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5a30f3fc6ed6e4338682a03a8c89d44580316a91","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        for shard in shard_list:"},{"line_number":32,"context_line":"            self.assertIn(\u0027name\u0027, shard, \"Each shard should have a \u0027name\u0027 field.\")"},{"line_number":33,"context_line":"            self.assertIn(\u0027count\u0027, shard, \"Each shard should have a \u0027count\u0027 field.\")"},{"line_number":34,"context_line":"            self.assertTrue(isinstance(shard[\u0027count\u0027], int), \"Shard \u0027count\u0027 should be an integer.\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_shard_list_invalid_request(self):"},{"line_number":37,"context_line":"        \"\"\"Check for errors on an invalid shard list request."}],"source_content_type":"text/x-python","patch_set":3,"id":"bac7c734_6b60c137","line":34,"updated":"2024-11-01 20:33:41.000000000","message":"This is less review feedback and maybe an indication I\u0027m missing something: What is creating the shards this is looking for at the integration tests level.","commit_id":"53ed97334dc888e832bf01780229479c290cf3be"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"9b87f323c9f15e1fc9bc795eb9b1c73dce937815","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        for shard in shard_list:"},{"line_number":32,"context_line":"            self.assertIn(\u0027name\u0027, shard, \"Each shard should have a \u0027name\u0027 field.\")"},{"line_number":33,"context_line":"            self.assertIn(\u0027count\u0027, shard, \"Each shard should have a \u0027count\u0027 field.\")"},{"line_number":34,"context_line":"            self.assertTrue(isinstance(shard[\u0027count\u0027], int), \"Shard \u0027count\u0027 should be an integer.\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_shard_list_invalid_request(self):"},{"line_number":37,"context_line":"        \"\"\"Check for errors on an invalid shard list request."}],"source_content_type":"text/x-python","patch_set":3,"id":"2eda8802_a39765aa","line":34,"in_reply_to":"1d8d38a3_2bd6bbac","updated":"2024-11-01 20:52:34.000000000","message":"I think I have handled this now","commit_id":"53ed97334dc888e832bf01780229479c290cf3be"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"0a4e2c8e80425ca85b35ddae06ae1cac4e147f9a","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        for shard in shard_list:"},{"line_number":32,"context_line":"            self.assertIn(\u0027name\u0027, shard, \"Each shard should have a \u0027name\u0027 field.\")"},{"line_number":33,"context_line":"            self.assertIn(\u0027count\u0027, shard, \"Each shard should have a \u0027count\u0027 field.\")"},{"line_number":34,"context_line":"            self.assertTrue(isinstance(shard[\u0027count\u0027], int), \"Shard \u0027count\u0027 should be an integer.\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_shard_list_invalid_request(self):"},{"line_number":37,"context_line":"        \"\"\"Check for errors on an invalid shard list request."}],"source_content_type":"text/x-python","patch_set":3,"id":"1d8d38a3_2bd6bbac","line":34,"in_reply_to":"bac7c734_6b60c137","updated":"2024-11-01 20:38:28.000000000","message":"The code in tests/functional/osc/vs/base.py is running the command, and functional runs against a real openstack I think?\n\nhttps://opendev.org/openstack/python-ironicclient/src/branch/master/doc/source/contributor/testing.rst#functional-testing","commit_id":"53ed97334dc888e832bf01780229479c290cf3be"}],"ironicclient/tests/unit/osc/v1/test_baremetal_shard.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5a30f3fc6ed6e4338682a03a8c89d44580316a91","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        # Return a list containing mocked shard data to"},{"line_number":31,"context_line":"        # simulate the expected output"},{"line_number":32,"context_line":"        self.baremetal_mock.shard.list.return_value \u003d ["},{"line_number":33,"context_line":"            baremetal_fakes.FakeBaremetalResource("},{"line_number":34,"context_line":"                None,"},{"line_number":35,"context_line":"                copy.deepcopy(baremetal_fakes.SHARD),"}],"source_content_type":"text/x-python","patch_set":3,"id":"a2ab823a_8b897b29","line":32,"updated":"2024-11-01 20:33:41.000000000","message":"re other comment; Don\u0027t you need something like this in the functional tests level?","commit_id":"53ed97334dc888e832bf01780229479c290cf3be"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"0a4e2c8e80425ca85b35ddae06ae1cac4e147f9a","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        # Return a list containing mocked shard data to"},{"line_number":31,"context_line":"        # simulate the expected output"},{"line_number":32,"context_line":"        self.baremetal_mock.shard.list.return_value \u003d ["},{"line_number":33,"context_line":"            baremetal_fakes.FakeBaremetalResource("},{"line_number":34,"context_line":"                None,"},{"line_number":35,"context_line":"                copy.deepcopy(baremetal_fakes.SHARD),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9697ea3a_e6bd3ffd","line":32,"in_reply_to":"a2ab823a_8b897b29","updated":"2024-11-01 20:38:28.000000000","message":"See comment mentioned for reply","commit_id":"53ed97334dc888e832bf01780229479c290cf3be"}]}