)]}'
{"id":"openstack%2Fpython-ironicclient~95882","triplet_id":"openstack%2Fpython-ironicclient~master~I87a7fd215af3eb92e0ecae2d214449a8e797f351","project":"openstack/python-ironicclient","branch":"master","topic":"emacs-coding-file-variable","hashtags":[],"change_id":"I87a7fd215af3eb92e0ecae2d214449a8e797f351","subject":"Use Emacs-friendly file variable to set file encoding","status":"ABANDONED","created":"2014-05-27 19:59:12.000000000","updated":"2014-05-30 15:59:41.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4916cde4172dfc63411d692c6116d949c4c81825","_number":95882,"virtual_id_number":95882,"owner":{"_account_id":11638,"name":"Martin Geisler","email":"martin@geisler.net","username":"mg"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-05-28 09:39:13.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-05-28 09:04:39.000000000","_account_id":11638,"name":"Martin Geisler","email":"martin@geisler.net","username":"mg"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11638,"name":"Martin Geisler","email":"martin@geisler.net","username":"mg"},{"value":-2,"date":"2014-05-28 09:02:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":11638,"name":"Martin Geisler","email":"martin@geisler.net","username":"mg"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11638,"name":"Martin Geisler","email":"martin@geisler.net","username":"mg"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"_account_id":11638,"name":"Martin Geisler","email":"martin@geisler.net","username":"mg"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-05-28 01:02:39.000000000","updated_by":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"reviewer":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"state":"REVIEWER"},{"updated":"2014-05-28 09:39:13.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"45c5fd8e076b5e6c12568abe6c57e27734737d11","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-27 19:59:12.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"7b9aa409dd72cf1aa422e9f51c8cb20cdd859ce3","author":{"_account_id":11638,"name":"Martin Geisler","email":"martin@geisler.net","username":"mg"},"date":"2014-05-27 19:59:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"92bfc8d607474a961a2a5dc1d33ec474332d837d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-27 22:06:51.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"1615cb179b7df823d57f2bae6df33847ed0a3dc5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-27 23:23:32.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"135c838256daa876abb0a8636c4793e985a03428","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-28 00:11:59.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"4bf3d7939d5aa2ce851c291d4f298962b6c5902c","author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"date":"2014-05-28 01:02:39.000000000","message":"Patch Set 1: Code-Review-2\n\nThanks for pointing out that we still have modelines laying around. We should remove them all. See\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2013-October/017353.html","accounts_in_message":[],"_revision_number":1},{"id":"13fa2484954938eb831a467002d19835243a14e2","author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"date":"2014-05-28 01:20:38.000000000","message":"Patch Set 1:\n\nsuperceded by https://review.openstack.org/95985","accounts_in_message":[],"_revision_number":1},{"id":"220be075917cbfe1ea8c1fe0d459be72348bbc2c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-28 01:32:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-python-ironicclient-pep8 http://logs.openstack.org/82/95882/1/check/gate-python-ironicclient-pep8/1f22411 : SUCCESS in 2m 31s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/82/95882/1/check/gate-python-ironicclient-docs/4cd2500/doc/build/html/ : SUCCESS in 2m 05s\n- gate-python-ironicclient-python26 http://logs.openstack.org/82/95882/1/check/gate-python-ironicclient-python26/f47e0be : SUCCESS in 1m 34s\n- gate-python-ironicclient-python27 http://logs.openstack.org/82/95882/1/check/gate-python-ironicclient-python27/74f68f0 : SUCCESS in 2m 04s\n- gate-python-ironicclient-python33 http://logs.openstack.org/82/95882/1/check/gate-python-ironicclient-python33/db46fc8 : SUCCESS in 6m 53s\n- gate-python-ironicclient-pypy http://logs.openstack.org/82/95882/1/check/gate-python-ironicclient-pypy/04e3dc4 : FAILURE in 2m 13s (non-voting)\n- check-tempest-dsvm-ironic http://logs.openstack.org/82/95882/1/check/check-tempest-dsvm-ironic/9298a01 : SUCCESS in 37m 09s\n- check-tempest-dsvm-virtual-ironic http://logs.openstack.org/82/95882/1/check/check-tempest-dsvm-virtual-ironic/384ebc2 : SUCCESS in 31m 15s","accounts_in_message":[],"_revision_number":1},{"id":"08331be98fb9903a4ac7874c184a834265212491","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-28 09:02:50.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"9f5296182eb48e8fc06f7e303d910bc9f59eb768","author":{"_account_id":11638,"name":"Martin Geisler","email":"martin@geisler.net","username":"mg"},"date":"2014-05-28 09:02:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4b64c07195733ca85c510d1c33d844c87a3c6a51","author":{"_account_id":11638,"name":"Martin Geisler","email":"martin@geisler.net","username":"mg"},"date":"2014-05-28 09:04:39.000000000","message":"Patch Set 2:\n\nThe new version only update the coding line in the files containing non-ASCII characters (where it is necessary per PEP 263).\n\nPlease let me know if this is better.","accounts_in_message":[],"_revision_number":2},{"id":"fba9f4b8ca2b267f5f0451b978c78e402d7c9b39","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-28 09:39:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-python-ironicclient-pep8 http://logs.openstack.org/82/95882/2/check/gate-python-ironicclient-pep8/6553bd8 : SUCCESS in 1m 58s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/82/95882/2/check/gate-python-ironicclient-docs/36b5d98/doc/build/html/ : SUCCESS in 2m 44s\n- gate-python-ironicclient-python26 http://logs.openstack.org/82/95882/2/check/gate-python-ironicclient-python26/dc1d2d8 : SUCCESS in 1m 30s\n- gate-python-ironicclient-python27 http://logs.openstack.org/82/95882/2/check/gate-python-ironicclient-python27/2c84436 : SUCCESS in 2m 08s\n- gate-python-ironicclient-python33 http://logs.openstack.org/82/95882/2/check/gate-python-ironicclient-python33/0a82c50 : SUCCESS in 5m 17s\n- gate-python-ironicclient-pypy http://logs.openstack.org/82/95882/2/check/gate-python-ironicclient-pypy/96a2981 : SUCCESS in 2m 14s (non-voting)\n- check-tempest-dsvm-ironic http://logs.openstack.org/82/95882/2/check/check-tempest-dsvm-ironic/421136e : SUCCESS in 32m 16s\n- check-tempest-dsvm-virtual-ironic http://logs.openstack.org/82/95882/2/check/check-tempest-dsvm-virtual-ironic/06c0d0a : SUCCESS in 25m 08s","accounts_in_message":[],"_revision_number":2},{"id":"a0caaa9ba58e1b8306df1e1b101e25f1ec939f04","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-28 11:33:30.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- check-tripleo-ironic-seed-precise http://logs.openstack.org/82/95882/2/check-tripleo/check-tripleo-ironic-seed-precise/2dd0427 : SUCCESS in 38m 29s\n- check-tripleo-ironic-undercloud-precise http://logs.openstack.org/82/95882/2/check-tripleo/check-tripleo-ironic-undercloud-precise/9dcf9c8 : FAILURE in 1h 18m 29s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"43f94a652543932c20e2d502e24bc6e62359579a","author":{"_account_id":11638,"name":"Martin Geisler","email":"martin@geisler.net","username":"mg"},"date":"2014-05-30 15:59:41.000000000","message":"Abandoned\n\nSuperseded by https://review.openstack.org/96109","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"52ffec8936d3c7947967caa7d2a2055126ea4bff","revisions":{"6289dd55f6bf0e5cea9cdfc7bd491926bca964b5":{"kind":"REWORK","_number":1,"created":"2014-05-27 19:59:12.000000000","uploader":{"_account_id":11638,"name":"Martin Geisler","email":"martin@geisler.net","username":"mg"},"ref":"refs/changes/82/95882/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/82/95882/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/82/95882/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/82/95882/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/82/95882/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/82/95882/1"}}},"commit":{"parents":[{"commit":"951f9a7ad2da1d8c5020318d621013ef96ffc5e6","subject":"removed py3kcompat module","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/951f9a7ad2da1d8c5020318d621013ef96ffc5e6"}]}],"author":{"name":"Martin Geisler","email":"martin@geisler.net","date":"2014-05-27 19:58:41.000000000","tz":120},"committer":{"name":"Martin Geisler","email":"martin@geisler.net","date":"2014-05-27 19:58:41.000000000","tz":120},"subject":"Use Emacs-friendly file variable to set file encoding","message":"Use Emacs-friendly file variable to set file encoding\n\nThe file encoding line serves a dual purpose: it informs both Python\nand Emacs about the file encoding.\n\nPEP 263 explains that a file with non-ASCII characters must specify an\nencoding. Without an encoding line, importing the file will raise a\nSyntaxError.\n\nThe problem is now that while Python will accept a line with\n\n  -*- encoding: \u003csome-encoding\u003e -*-\n\nEmacs only accepts\n\n  -*- coding: \u003csome-encoding\u003e -*-\n\nsince it looks for a file variable named \"coding\", not \"encoding\".\n\nSetting a variable called \"encoding\" has at best no effect, but it can\nresult in Emacs prompting the user with\n\n  The local variable list in __init__.py contains values that may not\n  be safe.\n\nwhen opening the file. This is because the \"encoding\" variable is not\nwhitelisted as a safe variable.\n\nThe command used to update the files were:\n\n  sed -i \u00271,2s/-\\*- encoding:/-*- coding:/\u0027 **/*.py\n\nThis accounts for the case where the file variables is set in the\nsecond line because the first line is used for a \"#!\" line.\n\nChange-Id: I87a7fd215af3eb92e0ecae2d214449a8e797f351\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/6289dd55f6bf0e5cea9cdfc7bd491926bca964b5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/6289dd55f6bf0e5cea9cdfc7bd491926bca964b5"}]},"branch":"refs/heads/master"},"52ffec8936d3c7947967caa7d2a2055126ea4bff":{"kind":"REWORK","_number":2,"created":"2014-05-28 09:02:50.000000000","uploader":{"_account_id":11638,"name":"Martin Geisler","email":"martin@geisler.net","username":"mg"},"ref":"refs/changes/82/95882/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/82/95882/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/82/95882/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/82/95882/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/82/95882/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/82/95882/2"}}},"commit":{"parents":[{"commit":"951f9a7ad2da1d8c5020318d621013ef96ffc5e6","subject":"removed py3kcompat module","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/951f9a7ad2da1d8c5020318d621013ef96ffc5e6"}]}],"author":{"name":"Martin Geisler","email":"martin@geisler.net","date":"2014-05-27 19:58:41.000000000","tz":120},"committer":{"name":"Martin Geisler","email":"martin@geisler.net","date":"2014-05-28 09:00:46.000000000","tz":120},"subject":"Use Emacs-friendly file variable to set file encoding","message":"Use Emacs-friendly file variable to set file encoding\n\nThe file encoding line serves a dual purpose: it informs both Python\nand Emacs about the file encoding.\n\nPEP 263 explains that a file with non-ASCII characters must specify an\nencoding. Without an encoding line, importing the file will raise a\nSyntaxError.\n\nThe problem is now that while Python will both of\n\n  -*- encoding: \u003csome-encoding\u003e -*-\n  -*- coding: \u003csome-encoding\u003e -*-\n\nwhereas Emacs only accepts the latter. Since the Emacs-specific \"-*-\"\nis already used, it seems right to use the correct variable name.\n\nChange-Id: I87a7fd215af3eb92e0ecae2d214449a8e797f351\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/52ffec8936d3c7947967caa7d2a2055126ea4bff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/52ffec8936d3c7947967caa7d2a2055126ea4bff"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
