)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"3ab10de92ec73c3cd0cf6fee79b871d8a2857076","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6f9bbb18_988a7a07","updated":"2026-04-01 06:03:03.000000000","message":"I wonder if we should just import `typing` as `ty` and use it everywhere instead of the individual imports.","commit_id":"533e23b9ca4d1194cd30f23dd1de747b90c3683f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8234f585d8d1c710836db5730a9694cff750bccf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad20d192_9c1bd26a","in_reply_to":"6f9bbb18_988a7a07","updated":"2026-04-04 20:34:52.000000000","message":"I specifically suggested Karan *not* do this (use the `ty` alias) when reviewing earlier patches. Based on rather extensive experience: it\u0027s a bad idea. Types from `typing` and `collections.abc` are not project-specific and will be immediately obvious to anyone that has read any amount typed Python code. Applying the \"import modules\" rules simply makes for more terse, (IMO) harder to read signatures, and brings us no appreciable gain [*]. It also breaks tools like pyupgrade and the ruff equivalent that watch for deprecated (for removal) `typing` objects. I consider it such an anti-pattern now, in fact, that I\u0027ve actually gone back and revisited some modules I typed previously to rework them https://review.opendev.org/c/openstack/cliff/+/982448\n\n[*] To be clear, I otherwise agree with this rule as it prevents namespace pollution. For typing though, it\u0027s an anti-pattern.","commit_id":"533e23b9ca4d1194cd30f23dd1de747b90c3683f"}]}