)]}'
{"id":"openstack%2Fpython-ironicclient~982584","triplet_id":"openstack%2Fpython-ironicclient~master~Ifebbbf5ed5d58e1d5e918ae7b426f1cf0f42f135","project":"openstack/python-ironicclient","branch":"master","attention_set":{},"removed_from_attention_set":{"38828":{"account":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"last_update":"2026-04-01 13:44:43.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ifebbbf5ed5d58e1d5e918ae7b426f1cf0f42f135","subject":"Add typed base command classes for OSC commands","status":"MERGED","created":"2026-03-29 20:23:09.000000000","updated":"2026-04-01 13:45:48.000000000","submitted":"2026-04-01 13:44:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"982584","meta_rev_id":"19205096524b8fef665fa792dc8d007370ea111a","_number":982584,"virtual_id_number":982584,"owner":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-04-01 13:44:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"all":[{"value":2,"date":"2026-04-01 13:34:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},{"value":2,"date":"2026-03-31 20:30:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"all":[{"value":1,"date":"2026-04-01 13:34:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-29 21:39:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-03-31 20:30:07.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2026-04-01 13:34:56.000000000","updated_by":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"reviewer":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"state":"REVIEWER"}],"messages":[{"id":"bde316260e5c364dbcd025df7aa5d83edc42ef9f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"date":"2026-03-29 20:23:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1a26038730354f3724368e43174360e1bc2c8082","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"date":"2026-03-29 20:38:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b43dbfbcb5499875db63efbbc31e80b0f4e6280e","author":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"date":"2026-03-29 20:52:04.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"79af813e32943e7aea400245622f21c8e36d3612","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-29 21:39:37.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0777d076d69e47c1809017e741fbea0c\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2b40459eaf544b3aa97a769d72b6e9b4 : SUCCESS in 5m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/eafcc7d4bcec41a39bc42e273b09db1e : SUCCESS in 1m 54s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/09e2d45e6bb743759d74f2cd3a5cf3e8 : SUCCESS in 2m 30s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/d943683f6a174874b526cf0f1d134243 : SUCCESS in 3m 33s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/07d4ae25ef99481aa316501e0d5a5487 : SUCCESS in 3m 21s (non-voting)\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/7ac7b4d135144cc4bb4ff0966dcf7fbe : SUCCESS in 5m 33s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6515da8ed45545cd846bcf167b03dd6b : SUCCESS in 7m 32s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a6dc8f20bde64bcfaab5f77cea5b8636 : SUCCESS in 3m 12s\n- ironicclient-tempest https://zuul.opendev.org/t/openstack/build/dcfe405692e642848a3b129ff78c3167 : SUCCESS in 58m 18s\n- ironicclient-tox-codespell https://zuul.opendev.org/t/openstack/build/d35ccebbf2e0498bb0737e0721d4a41d : FAILURE in 2m 58s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"898793adbd0475157b671637e789c9cfbb482806","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2026-03-31 20:30:07.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"27c3e8cb8cf6f488985d51fc2ccc4efb3c1b86c9","author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"date":"2026-04-01 13:34:56.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"3aae7edbd6bc1ce4bde3356bd5f8e4d28fc729bc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-01 13:35:33.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"5dba1fe778a50da4ff13cbe34699c6ac4053be61","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-01 13:44:43.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9806823a745e483482cd6fc2e7cbb907\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f8ae5d936cb64dcda4e2177beda51ac8 : SUCCESS in 1m 53s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/1ea66e85967e4c7ea932b8660400384b : SUCCESS in 2m 35s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/3699c4064498431f8aebfe1dd48a8f3f : SUCCESS in 2m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0121a705709348268ea865553fc3f461 : SUCCESS in 7m 52s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/146c2bb66b5040ea99f3c9c8e9bfa1e8 : SUCCESS in 2m 45s","accounts_in_message":[],"_revision_number":2},{"id":"a7dd0715e4884a0088cc1bdfa3f27e98bf357d77","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-01 13:44:43.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"19205096524b8fef665fa792dc8d007370ea111a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-01 13:45:48.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9b3bdc30f229497ba77d06cd2dd6a03b\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/45e4a49076fd490e8a20413af29374d1 : SUCCESS in 53s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ffc36d5a75434f1bab0905da17971c00 : SUCCESS in 51s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"da7711e353b0297bbaeae5d3ce22e72e8942435c","revisions":{"79574d78fa139718f187a8d540081d0011d4d070":{"kind":"REWORK","_number":1,"created":"2026-03-29 20:23:09.000000000","uploader":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"ref":"refs/changes/84/982584/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/84/982584/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/84/982584/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/84/982584/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/84/982584/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/84/982584/1"}}},"commit":{"parents":[{"commit":"5c886f905972bcd76293132a0587bcd9a79a665e","subject":"Add type annotations to `ironicclient/osc/plugin.py`","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/5c886f905972bcd76293132a0587bcd9a79a665e"}]}],"author":{"name":"Karan Anand","email":"anandkarancompsci@gmail.com","date":"2026-03-29 20:16:15.000000000","tz":-240},"committer":{"name":"Karan Anand","email":"anandkarancompsci@gmail.com","date":"2026-03-29 20:21:58.000000000","tz":-240},"subject":"Add typed base command classes for OSC commands","message":"Add typed base command classes for OSC commands\n\nAdd ironicclient/osc/command.py with Command, Lister, and ShowOne\nsubclasses that annotate ``app`` so that\n``self.app.client_manager.baremetal`` is a known attribute, removing\nthe need for ``# type: ignore[attr-defined]`` in command\nimplementations. This follows the same pattern as\npython-openstackclient (see review.opendev.org/970681).\n\nAlso add collections.abc and typing to [hacking] import_exceptions\nin tox.ini, allowing multi-name imports on a single line (matching\nthe Nova convention).\n\nChange-Id: Ifebbbf5ed5d58e1d5e918ae7b426f1cf0f42f135\nSigned-off-by: Karan Anand \u003canandkarancompsci@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/79574d78fa139718f187a8d540081d0011d4d070"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/79574d78fa139718f187a8d540081d0011d4d070"}]},"branch":"refs/heads/master"},"da7711e353b0297bbaeae5d3ce22e72e8942435c":{"kind":"REWORK","_number":2,"created":"2026-03-29 20:38:26.000000000","uploader":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"ref":"refs/changes/84/982584/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/84/982584/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/84/982584/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/84/982584/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/84/982584/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/84/982584/2"}}},"commit":{"parents":[{"commit":"5c886f905972bcd76293132a0587bcd9a79a665e","subject":"Add type annotations to `ironicclient/osc/plugin.py`","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/5c886f905972bcd76293132a0587bcd9a79a665e"}]}],"author":{"name":"Karan Anand","email":"anandkarancompsci@gmail.com","date":"2026-03-29 20:16:15.000000000","tz":-240},"committer":{"name":"Karan Anand","email":"anandkarancompsci@gmail.com","date":"2026-03-29 20:37:49.000000000","tz":-240},"subject":"Add typed base command classes for OSC commands","message":"Add typed base command classes for OSC commands\n\nAdd ironicclient/osc/command.py with Command, Lister, and ShowOne\nsubclasses that annotate ``app`` so that\n``self.app.client_manager.baremetal`` is a known attribute, removing\nthe need for ``# type: ignore[attr-defined]`` in command\nimplementations. This follows the same pattern as\npython-openstackclient (see review.opendev.org/970681).\n\nAlso add collections.abc and typing to [hacking] import_exceptions\nin tox.ini, allowing multi-name imports on a single line (matching\nthe Nova convention).\n\nChange-Id: Ifebbbf5ed5d58e1d5e918ae7b426f1cf0f42f135\nSigned-off-by: Karan Anand \u003canandkarancompsci@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/da7711e353b0297bbaeae5d3ce22e72e8942435c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/da7711e353b0297bbaeae5d3ce22e72e8942435c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}