)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"change_message_id":"f7774199f1fb44fb867f700b5cc9b494548cc4da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"63ae072a_4a96d9b2","updated":"2026-04-21 17:43:09.000000000","message":"recheck","commit_id":"aeb0adfa7acad63f135f6b41b2ead9e571655f2c"}],"ironicclient/tests/unit/common/apiclient/test_base.py":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"f12158518e65b98c4fbc7fae8ee44543b958cbab","unresolved":true,"context_lines":[{"line_number":61,"context_line":"    collection_key \u003d \u0027crud_resources\u0027"},{"line_number":62,"context_line":"    key \u003d \u0027crud_resource\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get(self, **kwargs: Any) -\u003e base.Resource:"},{"line_number":65,"context_line":"        crud_resource \u003d kwargs.pop(\u0027crud_resource\u0027, None)"},{"line_number":66,"context_line":"        if crud_resource is not None:"},{"line_number":67,"context_line":"            return super(CrudResourceManager, self).get("}],"source_content_type":"text/x-python","patch_set":1,"id":"7b10da17_54a7023c","line":64,"updated":"2026-04-24 03:26:02.000000000","message":"Let\u0027s just be explicit here.\n\n```suggestion\n    def get(self, crud_resource: CrudResource, **kwargs: Any) -\u003e base.Resource:\n```","commit_id":"aeb0adfa7acad63f135f6b41b2ead9e571655f2c"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"f12158518e65b98c4fbc7fae8ee44543b958cbab","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    key \u003d \u0027crud_resource\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get(self, **kwargs: Any) -\u003e base.Resource:"},{"line_number":65,"context_line":"        crud_resource \u003d kwargs.pop(\u0027crud_resource\u0027, None)"},{"line_number":66,"context_line":"        if crud_resource is not None:"},{"line_number":67,"context_line":"            return super(CrudResourceManager, self).get("},{"line_number":68,"context_line":"                crud_resource_id\u003dbase.getid(crud_resource), **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"503119c4_3569a513","line":65,"updated":"2026-04-24 03:26:02.000000000","message":"Nuke this line since we get explicit above.","commit_id":"aeb0adfa7acad63f135f6b41b2ead9e571655f2c"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"f12158518e65b98c4fbc7fae8ee44543b958cbab","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    def get(self, **kwargs: Any) -\u003e base.Resource:"},{"line_number":65,"context_line":"        crud_resource \u003d kwargs.pop(\u0027crud_resource\u0027, None)"},{"line_number":66,"context_line":"        if crud_resource is not None:"},{"line_number":67,"context_line":"            return super(CrudResourceManager, self).get("},{"line_number":68,"context_line":"                crud_resource_id\u003dbase.getid(crud_resource), **kwargs)"},{"line_number":69,"context_line":"        return super(CrudResourceManager, self).get(**kwargs)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"de79b333_098f7195","line":67,"updated":"2026-04-24 03:26:02.000000000","message":"```suggestion\n            return super().get(\n```\n\nsince you\u0027re touching it... drop the Python 2 syntax","commit_id":"aeb0adfa7acad63f135f6b41b2ead9e571655f2c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cb86faae473115d7e4de2301826d123f03e6cca9","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    def get(self, **kwargs: Any) -\u003e base.Resource:"},{"line_number":65,"context_line":"        crud_resource \u003d kwargs.pop(\u0027crud_resource\u0027, None)"},{"line_number":66,"context_line":"        if crud_resource is not None:"},{"line_number":67,"context_line":"            return super(CrudResourceManager, self).get("},{"line_number":68,"context_line":"                crud_resource_id\u003dbase.getid(crud_resource), **kwargs)"},{"line_number":69,"context_line":"        return super(CrudResourceManager, self).get(**kwargs)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d679e26b_68c473e2","line":67,"in_reply_to":"8c6aa9a5_9c2e5e71","updated":"2026-04-29 21:15:30.000000000","message":"(you being \"ironic\", not Karan 😀)","commit_id":"aeb0adfa7acad63f135f6b41b2ead9e571655f2c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"213127faa781e926c7f11039b4c26f76329096ab","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    def get(self, **kwargs: Any) -\u003e base.Resource:"},{"line_number":65,"context_line":"        crud_resource \u003d kwargs.pop(\u0027crud_resource\u0027, None)"},{"line_number":66,"context_line":"        if crud_resource is not None:"},{"line_number":67,"context_line":"            return super(CrudResourceManager, self).get("},{"line_number":68,"context_line":"                crud_resource_id\u003dbase.getid(crud_resource), **kwargs)"},{"line_number":69,"context_line":"        return super(CrudResourceManager, self).get(**kwargs)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8c6aa9a5_9c2e5e71","line":67,"in_reply_to":"de79b333_098f7195","updated":"2026-04-29 21:14:21.000000000","message":"Not for this PR, but you should just apply ruff with the `UP` rules, and create a `.git-blame-ignore-revs` file to ignore the errors you see.","commit_id":"aeb0adfa7acad63f135f6b41b2ead9e571655f2c"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"f12158518e65b98c4fbc7fae8ee44543b958cbab","unresolved":true,"context_lines":[{"line_number":66,"context_line":"        if crud_resource is not None:"},{"line_number":67,"context_line":"            return super(CrudResourceManager, self).get("},{"line_number":68,"context_line":"                crud_resource_id\u003dbase.getid(crud_resource), **kwargs)"},{"line_number":69,"context_line":"        return super(CrudResourceManager, self).get(**kwargs)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class ResourceTest(test_base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"20328e44_f13e7b24","line":69,"updated":"2026-04-24 03:26:02.000000000","message":"```suggestion\n        return super().get(**kwargs)\n```","commit_id":"aeb0adfa7acad63f135f6b41b2ead9e571655f2c"}]}